Re: [pgadmin-hackers] Two patches

2010-12-18 Thread Guillaume Lelarge
Le 13/12/2010 18:26, Nail Samatov a écrit : > 1. first patch fixes this ticket: > http://code.pgadmin.org/trac/ticket/291 > > 2. second patch fixes an issue with a focus: > 1) In the the sql box press ctrl+f - appears the find dialog, focus is on it. > 2) Enter a some text, press enter until end o

[pgadmin-hackers] pgAdmin III commit: Add "Number of selected characters" in query tool.

2010-12-18 Thread Guillaume Lelarge
Add "Number of selected characters" in query tool. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=27cd1e7b7a24dda3d315bd6b144b05a4029070d7 Author: Vinicius Santos Modified Files -- CHANGELOG|2 ++ pgadmin/frm/fr

Re: [pgadmin-hackers] Number of selected characters.

2010-12-18 Thread Guillaume Lelarge
Le 16/12/2010 01:25, Vinicius Santos a écrit : > Em 15/12/2010 21:55, Vinicius Santos escreveu: >> >> I'm sending a patch. >> >> Thanks. > > Or Better. > Commited. I replaced the / character with a comma, but nothing else. Thanks for this patch. -- Guillaume http://www.postgresql.fr http://

[pgadmin-hackers] pgAdmin III commit: Fix the permission check for the db restore menu

2010-12-19 Thread Guillaume Lelarge
Fix the permission check for the db restore menu User needs to have the create privilege on the database in order to be able to restore a dump. Report from Konstantin Pelepelin. Branch -- REL-1_12_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=3704c

[pgadmin-hackers] pgAdmin III commit: Fix the permission check for the db restore menu

2010-12-19 Thread Guillaume Lelarge
Fix the permission check for the db restore menu User needs to have the create privilege on the database in order to be able to restore a dump. Report from Konstantin Pelepelin. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=627efa4209a5730c8

Re: [pgadmin-hackers] Graphical Query Builder enhancement

2010-12-19 Thread Guillaume Lelarge
Le 19/12/2010 13:05, Roland Giesler a écrit : > I'd like to know what the immediate plans are for this welcome > addition to pgadmin. > AFAIK, none. > Currently one can only create select queries with it and the query are > in by opinion less correct than they should be. Linking two fields > t

[pgadmin-hackers] pgAdmin III commit: Fix the enabling/disabling of toolbar buttons

2010-12-19 Thread Guillaume Lelarge
Fix the enabling/disabling of toolbar buttons ... in the query tool. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c4a350002d8e7bdb77bf5d8eb1c5eb4efade6aff Author: Vinicius Santos Modified Files -- CHANGELOG|

Re: [pgadmin-hackers] "Clear window" in the SQL Editor

2010-12-19 Thread Guillaume Lelarge
Le 15/12/2010 08:13, Guillaume Lelarge a écrit : > Le 13/12/2010 03:56, Vinicius Santos a écrit : >>> OK, after some thinking, it would be best to disable the "Clear window" >>> items rather than clearing the query. The same needs to be done for Cut, >>> C

[pgadmin-hackers] pgAdmin III commit: Fix wrong release in CHANGELOG

2010-12-21 Thread Guillaume Lelarge
Fix wrong release in CHANGELOG Branch -- REL-1_12_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=df85f553b85dc86a938b0e85b63b55902cb1a3e0 Modified Files -- CHANGELOG |8 1 files changed, 4 insertions(+), 4 deletions(-) -- S

[pgadmin-hackers] pgAdmin III commit: Fix wrong release in CHANGELOG

2010-12-21 Thread Guillaume Lelarge
Fix wrong release in CHANGELOG Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=339ecc2a11fc7fd887119357da82f43c8c8062e3 Modified Files -- CHANGELOG |8 1 files changed, 4 insertions(+), 4 deletions(-) -- Sent via pgad

[pgadmin-hackers] pgAdmin III commit: Fix the invisible column in dlgEditGridOptions

2010-12-21 Thread Guillaume Lelarge
Fix the invisible column in dlgEditGridOptions The fix is rather a workaround. In wxGTK, GetClientSize() doesn't seem appropriately set in the dlgEditGridOptions window. So, we "fix" the right column size if it gets wrong. Branch -- REL-1_12_0_PATCHES Details --- http://git.postgresql.or

[pgadmin-hackers] pgAdmin III commit: Fix the invisible column in dlgEditGridOptions

2010-12-21 Thread Guillaume Lelarge
Fix the invisible column in dlgEditGridOptions The fix is rather a workaround. In wxGTK, GetClientSize() doesn't seem appropriately set in the dlgEditGridOptions window. So, we "fix" the right column size if it gets wrong. Branch -- master Details --- http://git.postgresql.org/gitweb?p=p

Re: [pgadmin-hackers] Fwd: dlgEditGridOptions

2010-12-21 Thread Guillaume Lelarge
Le 23/08/2010 16:44, Dave Page a écrit : > On Mon, Aug 23, 2010 at 3:42 PM, Guillaume Lelarge > wrote: >> Le 23/08/2010 16:33, Dave Page a écrit : >>> Hi Steffen >>> >>> On Sun, Aug 22, 2010 at 3:30 PM, Steffen Kuhn wrote: >>>> Hi, >>

[pgadmin-hackers] pgAdmin III commit: Fix copy bug in the edit grid

2010-12-21 Thread Guillaume Lelarge
Fix copy bug in the edit grid If you select only a part of the text in a cell, and try to copy it, it really copies all the cell. This patch makes sure that only the selected text is copied. Report from Mauro Bertoli. Branch -- REL-1_12_0_PATCHES Details --- http://git.postgresql.org/gi

[pgadmin-hackers] pgAdmin III commit: Fix copy bug in the edit grid

2010-12-21 Thread Guillaume Lelarge
Fix copy bug in the edit grid If you select only a part of the text in a cell, and try to copy it, it really copies all the cell. This patch makes sure that only the selected text is copied. Report from Mauro Bertoli. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadm

Re: [pgadmin-hackers] utffile symbol defined is strange.

2010-12-25 Thread Guillaume Lelarge
Hi Hiroshi-san, Le 24/12/2010 16:52, Hiroshi Saito a écrit : > [...] > I look at this error by VisualStudio2008. > > 1>wxbase28ud.lib(strconv.obj) : error LNK2005: "class wxMBConvUTF32BE > wxConvUTF32BE" (?wxConvUTF32BE@@3VwxMBConvUTF32BE@@A) (snip)... > 1>wxbase28ud.lib(strconv.obj) : error LNK2

[pgadmin-hackers] pgAdmin website commit: 1.12.2 is out since 2010-12-16.

2010-12-25 Thread Guillaume Lelarge
1.12.2 is out since 2010-12-16. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=595301851db26e301d27a5cf716139ce08c2c157 Modified Files -- download/macosx.php |1 + download/source.php |1 + download/windows.php |1 +

[pgadmin-hackers] pgAdmin website commit: Automatic stringmerge using merge script.

2010-12-25 Thread Guillaume Lelarge
Automatic stringmerge using merge script. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=b027ba5e5b8c5d2655723e6bfb6f6153c56c6266 Modified Files -- locale/cs_CZ/LC_MESSAGES/pgadmin3_website.mo | Bin 141398 -> 141398 bytes local

[pgadmin-hackers] pgAdmin website commit: Update website's french translation.

2010-12-25 Thread Guillaume Lelarge
Update website's french translation. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=320b107b967a99a3bd80825511bd0c978566fe72 Modified Files -- locale/fr_FR/LC_MESSAGES/pgadmin3_website.mo | Bin 149481 -> 150164 bytes locale/fr_

[pgadmin-hackers] pgAdmin website commit: Update .pot file.

2010-12-25 Thread Guillaume Lelarge
Update .pot file. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=e1fc2c81254b4dc3012aac62fcddc52e3eafc208 Modified Files -- locale/pgadmin3_website.pot | 100 +-- 1 files changed, 58 inser

[pgadmin-hackers] pgAdmin III commit: Make sure no query more than max size is stored...

2010-12-26 Thread Guillaume Lelarge
Make sure no query more than max size is stored... in the historic file. The issue was that, if pgAdmin was killed, the last query, whatever its size, remained in the histoqueries file. I changed the behabiour so that it can't happen anymore. Old behaviour: When query is launched Save que

[pgadmin-hackers] pgAdmin III commit: Make sure no query more than max size is stored...

2010-12-26 Thread Guillaume Lelarge
Make sure no query more than max size is stored... in the historic file. The issue was that, if pgAdmin was killed, the last query, whatever its size, remained in the histoqueries file. I changed the behabiour so that it can't happen anymore. Old behaviour: When query is launched Save que

[pgadmin-hackers] pgAdmin website commit: Two forgotten items on the roadmap.

2010-12-26 Thread Guillaume Lelarge
Two forgotten items on the roadmap. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=f44ac950558a6ecb3a9fdf5226c61e4afcf5545d Modified Files -- development/roadmap.php |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -

Re: [pgadmin-hackers] Source reindenting

2010-12-29 Thread Guillaume Lelarge
Le 29/12/2010 18:44, Dave Page a écrit : > On Wed, Dec 29, 2010 at 5:30 PM, Magnus Hagander wrote: >> I just did a testrun with astyle to reindent and restyle the code. I >> created a rule in Makefile.am per: >> >> diff --git a/Makefile.am b/Makefile.am >> index be6af45..8266f8d 100644 >> --- a/Ma

Re: [pgadmin-hackers] Source reindenting

2010-12-30 Thread Guillaume Lelarge
Le 30/12/2010 09:52, Magnus Hagander a écrit : > On Thu, Dec 30, 2010 at 00:45, Guillaume Lelarge > wrote: >> Le 29/12/2010 18:44, Dave Page a écrit : >>> On Wed, Dec 29, 2010 at 5:30 PM, Magnus Hagander >>> wrote: >>>> I just did a testrun with

Re: [pgadmin-hackers] code.pgadmin.org

2010-12-30 Thread Guillaume Lelarge
Le 30/12/2010 12:20, Magnus Hagander a écrit : > I've updated code.pgadmin.org so it links to the git repo instead of > the no-longer-updated svn repo. > > I notice it's not being linked from the www.pgadmin.org site at all - > I think that is because we wanted it to nbe a trial and then forgot >

Re: [pgadmin-hackers] Trac tickets

2010-12-30 Thread Guillaume Lelarge
Le 30/12/2010 11:32, Magnus Hagander a écrit : > On Fri, Aug 7, 2009 at 14:09, Guillaume Lelarge > wrote: >> Le vendredi 7 août 2009 à 13:35:51, Magnus Hagander a écrit : >>> On Fri, Aug 7, 2009 at 10:48, Dave Page wrote: >>>> On Thu, Aug 6, 2009 at 12:22 PM,

Re: [pgadmin-hackers] Source reindenting

2010-12-30 Thread Guillaume Lelarge
Le 30/12/2010 11:24, Magnus Hagander a écrit : > On Thu, Dec 30, 2010 at 11:13, Guillaume Lelarge > wrote: >> Le 30/12/2010 09:52, Magnus Hagander a écrit : >>> On Thu, Dec 30, 2010 at 00:45, Guillaume Lelarge >>> wrote: >>>> Le 29/12/2010 18:44, Dave

Re: [pgadmin-hackers] Trac tickets

2010-12-30 Thread Guillaume Lelarge
Le 30/12/2010 18:33, Magnus Hagander a écrit : > On Thu, Dec 30, 2010 at 18:29, Guillaume Lelarge > wrote: >> Le 30/12/2010 11:32, Magnus Hagander a écrit : >>> On Fri, Aug 7, 2009 at 14:09, Guillaume Lelarge >>> wrote: >>>> Le vendredi 7 aoû

Re: [pgadmin-hackers] code.pgadmin.org

2010-12-30 Thread Guillaume Lelarge
Le 30/12/2010 23:28, Magnus Hagander a écrit : > On Thu, Dec 30, 2010 at 18:25, Guillaume Lelarge > wrote: >> Le 30/12/2010 12:20, Magnus Hagander a écrit : >>> I've updated code.pgadmin.org so it links to the git repo instead of >>> the no-longer-updated

[pgadmin-hackers] Support for unlogged tables

2010-12-30 Thread Guillaume Lelarge
Hi, This 9.1 new feature is supported with this patch. It takes care of the table property tab, table dialog, and pg_dump window. Comments? -- Guillaume http://www.postgresql.fr http://dalibo.com diff --git a/pgadmin/dlg/dlgTable.cpp b/pgadmin/dlg/dlgTable.cpp index 322fae0..beced24 100644 -

Re: [pgadmin-hackers] code.pgadmin.org

2010-12-31 Thread Guillaume Lelarge
Le 31/12/2010 10:54, Magnus Hagander a écrit : > On Fri, Dec 31, 2010 at 02:19, Dave Page wrote: >> On Thu, Dec 30, 2010 at 11:20 AM, Magnus Hagander >> wrote: >>> I've updated code.pgadmin.org so it links to the git repo instead of >>> the no-longer-updated svn repo. >>> >>> I notice it's not b

Re: [pgadmin-hackers] Trac tickets

2010-12-31 Thread Guillaume Lelarge
Le 31/12/2010 10:52, Magnus Hagander a écrit : > On Fri, Dec 31, 2010 at 02:30, Dave Page wrote: >> On Thu, Dec 30, 2010 at 5:29 PM, Guillaume Lelarge >> wrote: >>> No to trac reports as they ain't complete now. Dave and I talked about >>> that in Stuttgart,

Re: [pgadmin-hackers] Support for unlogged tables

2010-12-31 Thread Guillaume Lelarge
Le 31/12/2010 12:43, Magnus Hagander a écrit : > On Fri, Dec 31, 2010 at 00:28, Guillaume Lelarge > wrote: >> Hi, >> >> This 9.1 new feature is supported with this patch. It takes care of the >> table property tab, table dialog, and pg_dump window. >> >>

Re: [pgadmin-hackers] Source reindenting - it is done

2011-01-01 Thread Guillaume Lelarge
Le 31/12/2010 15:53, Magnus Hagander a écrit : > I've just pushed reindenting on master and 1.12 to the pgadmin repository. > > Build target "make style" also pushed to both. > Thanks a lot. > This is likely to cause conflicts with any and all patches you have > pending - sorry about that, but

Re: [pgadmin-hackers] Trac tickets

2011-01-01 Thread Guillaume Lelarge
Le 31/12/2010 16:07, Dave Page a écrit : > On Fri, Dec 31, 2010 at 3:03 PM, Magnus Hagander wrote: >> Actually, I take it back. >> >> The CHANGELOG on the REL-1_12_PATCHES has some changes for 1.12.1, >> 1.12.2, 1.12.3. And surprisingly enough also 1.14.0, which certainly >> didn't exist back then

[pgadmin-hackers] pgAdmin III commit: Fix the CHANGELOG, according to Magnus's report :)

2011-01-01 Thread Guillaume Lelarge
Fix the CHANGELOG, according to Magnus's report :) Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=58219d999039679803c4f28b90c0be685b7e03aa Modified Files -- CHANGELOG |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --

[pgadmin-hackers] pgAdmin III commit: Fix the CHANGELOG, according to Magnus's report :)

2011-01-01 Thread Guillaume Lelarge
Fix the CHANGELOG, according to Magnus's report :) Branch -- REL-1_12_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=2ef1acacef27b8b1544aebccd96ddbe7b25dc61e Modified Files -- CHANGELOG |2 +- 1 files changed, 1 insertions(+), 1 deleti

[pgadmin-hackers] pgAdmin III commit: Add support for unlogged table (9.1 new feature)

2011-01-01 Thread Guillaume Lelarge
Add support for unlogged table (9.1 new feature) Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c738dbb772cebfdb4fa486ecdcb216285b38ffaf Modified Files -- CHANGELOG|1 + pgadmin/dlg/dlgTable.cpp |

Re: [pgadmin-hackers] Support for unlogged tables

2011-01-01 Thread Guillaume Lelarge
Le 31/12/2010 15:27, Magnus Hagander a écrit : > On Fri, Dec 31, 2010 at 15:07, Guillaume Lelarge > wrote: >> Le 31/12/2010 12:43, Magnus Hagander a écrit : >>> On Fri, Dec 31, 2010 at 00:28, Guillaume Lelarge >>> wrote: >>>> Hi, >>>> >

[pgadmin-hackers] pgAdmin III commit: Fix the CASCADing option for constraints

2011-01-01 Thread Guillaume Lelarge
Fix the CASCADing option for constraints Per a report from Eric Ongerth, there's no possibility right now to DROP CASCADE a constraint. This patch fixes this issue by checking the cascading option and by reacting accordingly if needed. Branch -- master Details --- http://git.postgresql.o

[pgadmin-hackers] pgAdmin III commit: Fix the CASCADing option for constraints

2011-01-01 Thread Guillaume Lelarge
Fix the CASCADing option for constraints Per a report from Eric Ongerth, there's no possibility right now to DROP CASCADE a constraint. This patch fixes this issue by checking the cascading option and by reacting accordingly if needed. Branch -- REL-1_12_0_PATCHES Details --- http://git.

Re: [pgadmin-hackers] Number of selected characters.

2011-01-04 Thread Guillaume Lelarge
Le 04/01/2011 14:43, Dave Page a écrit : > On Sat, Dec 18, 2010 at 8:14 PM, Guillaume Lelarge > wrote: >> Le 16/12/2010 01:25, Vinicius Santos a écrit : >>> Em 15/12/2010 21:55, Vinicius Santos escreveu: >>>> >>>> I'm sending a patch. >>

Re: [pgadmin-hackers] Number of selected characters.

2011-01-04 Thread Guillaume Lelarge
Le 04/01/2011 16:27, Dave Page a écrit : > On Tue, Jan 4, 2011 at 2:05 PM, Guillaume Lelarge > wrote: >> Ch is not obvious either. But, what about Sel? > > It is obvious when it changes to a new value every time you move the > cursor. Sl (or Sel) isn't - you don

Re: [pgadmin-hackers] Ticket 266: Unable to backup table when quotation marks used in the name

2011-01-06 Thread Guillaume Lelarge
Le 06/01/2011 10:40, Dave Page a écrit : > It looks like as feared, this patch did break the quoting of some > things, as I'm starting to get bugs reported internally here that are > not present in 1.10. Eg. this one, where a database name contains > quotes: > > /opt/PostgresPlus/9.0AS/bin/pg_dump

[pgadmin-hackers] pgAdmin III commit: Fix the quoting of the database in the Dump/Restore

2011-01-09 Thread Guillaume Lelarge
Fix the quoting of the database in the Dump/Restore dialogs The database name should not be quoted as database's objects. Report from Sean Ayres. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=44e69da2ecd684233a7c392368b9cfff5dfa6e91 Modifie

[pgadmin-hackers] pgAdmin III commit: Fix the quoting of the database in the Dump/Restore

2011-01-09 Thread Guillaume Lelarge
Fix the quoting of the database in the Dump/Restore dialogs The database name should not be quoted as database's objects. Report from Sean Ayres. Branch -- REL-1_12_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=5b876443a2216d3a902916e502bb66e726dd2

Re: [pgadmin-hackers] Ticket 266: Unable to backup table when quotation marks used in the name

2011-01-09 Thread Guillaume Lelarge
Le 06/01/2011 15:53, Dave Page a écrit : > On Thu, Jan 6, 2011 at 2:02 PM, Guillaume Lelarge > wrote: >> Le 06/01/2011 10:40, Dave Page a écrit : >>> It looks like as feared, this patch did break the quoting of some >>> things, as I'm starting to get bugs report

[pgadmin-hackers] pgAdmin III commit: Forgot to update the xrcDialogs.cpp file

2011-01-09 Thread Guillaume Lelarge
Forgot to update the xrcDialogs.cpp file Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=8c368f5a514bdfd513b4739d3d5708054c937504 Modified Files -- pgadmin/ui/xrcDialogs.cpp | 9362 +++-- pgadm

[pgadmin-hackers] pgAdmin III commit: Fix the enableing of Unlogged checkbox

2011-01-09 Thread Guillaume Lelarge
Fix the enableing of Unlogged checkbox The Unlogged checkbox should be disabled if the user isn't connected to a 9.1+ PostgreSQL server. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=7558d286095cc5541df08078bfd24936eedf2c15 Modified Files --

Re: [pgadmin-hackers] Support for unlogged tables

2011-01-09 Thread Guillaume Lelarge
Le 06/01/2011 23:38, Jasmin Dizdarevic a écrit : > [...] > I've just build the latest master branch. > I think there is a problem with the unlogged feature. pgAdmin crashes on > pgsql 8.4. The problem (access violation) occurs on line 1224: > > *if (chkUnlogged->GetValue())* > sql += wxT("UNLOGGE

[pgadmin-hackers] pgAdmin III commit: Fix uncalled CREATE OR REPLACE VIEW

2011-01-09 Thread Guillaume Lelarge
Fix uncalled CREATE OR REPLACE VIEW When a user makes a change on an existing view, whatever this change is, there is a CREATE OR REPLACE VIEW statement. Report from Erwin Brandstetter. Fixes #296. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdif

[pgadmin-hackers] pgAdmin III commit: Fix uncalled CREATE OR REPLACE VIEW

2011-01-09 Thread Guillaume Lelarge
Fix uncalled CREATE OR REPLACE VIEW When a user makes a change on an existing view, whatever this change is, there is a CREATE OR REPLACE VIEW statement. Report from Erwin Brandstetter. Fixes #296. Branch -- REL-1_12_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git

Re: [pgadmin-hackers] Uncalled CREATE OR REPLACE VIEW in privileges dialog

2011-01-09 Thread Guillaume Lelarge
Hi Erwin, Le 04/01/2011 21:24, Erwin Brandstetter a écrit : > [...] > My best wishes for 2011 to the pgAdmin team! :) > Best wishes for you too :) > Testing v.1.12.2 (Dec 13 2010) on Windows XP Pro, Server PostgreSQL > 8.4.5 on Debian Lenny. > I found some weirdness in the privileges dialog for

Re: [pgadmin-hackers] pgAdmin III commit: Fix the enableing of Unlogged checkbox

2011-01-09 Thread Guillaume Lelarge
Hi, Le 09/01/2011 22:04, Jasmin Dizdarevic a écrit : > [...] > sorry, but there is still a bug: > > When I click on a table the following statement is shown in the SQL pane: > > CREATE UNLOGGED TABLE berfil.tasks > ( > taskid character varying(32) NOT NULL, > taskyear numeric(4,0), > > and

[pgadmin-hackers] pgAdmin III commit: Another fix on my "unlogged table" patch

2011-01-09 Thread Guillaume Lelarge
Another fix on my "unlogged table" patch Report from Jasmin Dizdarevic. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=a990895ac4687cf79cc0777d7581d59ba08ab9d7 Modified Files -- pgadmin/schema/pgTable.cpp |2 ++ 1 files changed

Re: [pgadmin-hackers] pgAdmin III commit: Fix the enableing of Unlogged checkbox

2011-01-09 Thread Guillaume Lelarge
Le 09/01/2011 22:25, Guillaume Lelarge a écrit : > Hi, > > Le 09/01/2011 22:04, Jasmin Dizdarevic a écrit : >> [...] >> sorry, but there is still a bug: >> >> When I click on a table the following statement is shown in the SQL pane: >> >> CREATE

Re: [pgadmin-hackers] pgAdmin III commit: Another fix on my "unlogged table" patch

2011-01-09 Thread Guillaume Lelarge
Le 09/01/2011 22:43, Jasmin Dizdarevic a écrit : > Great, now everything seems to be ok. > BTW, thanks a lot for checking it. -- Guillaume http://www.postgresql.fr http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscripti

[pgadmin-hackers] New options dialog

2011-01-09 Thread Guillaume Lelarge
Hi, At pgday.eu 2010, Dave and I discussed about the options dialog. We would like to make it look like the Visual Studio options dialog. Something like this one: http://www.timvw.be/wp-content/images/msbuildverbosity.gif So, tonight, I've been thinking about it and how to use the treeview, an

Re: [pgadmin-hackers] Info on non supported Features

2011-01-09 Thread Guillaume Lelarge
Hi, Le 10/01/2011 02:22, Jasmin Dizdarevic a écrit : > [...] > as I started working on email notification Dave told me, that I've to > disable all email notification relevant GUI elements, if the required > pgAgent version is not installed. > I did that of course, but I thought why we should not t

Re: [pgadmin-hackers] Info on non supported Features

2011-01-10 Thread Guillaume Lelarge
Le 10/01/2011 10:53, Dave Page a écrit : > On Mon, Jan 10, 2011 at 1:22 AM, Jasmin Dizdarevic > wrote: >> Hi Guys, >> as I started working on email notification Dave told me, that I've to >> disable all email notification relevant GUI elements, if the required >> pgAgent version is not installed.

Re: [pgadmin-hackers] Info on non supported Features

2011-01-10 Thread Guillaume Lelarge
Le 10/01/2011 11:01, Dave Page a écrit : > On Mon, Jan 10, 2011 at 9:55 AM, Guillaume Lelarge > wrote: > >> I don't see why it couldn't work for radio buttons and checkboxes. They >> also have text. We dont' use that now, but it could be use for this. >

Re: [pgadmin-hackers] Info on non supported Features

2011-01-10 Thread Guillaume Lelarge
Le 10/01/2011 11:07, Jasmin Dizdarevic a écrit : > Sure, it's possible, but then you have take care of each control > individually. Setting a text in a combobx and checkbox is quiet different. > I think this change is acceptable, because the label control is kept. Only > the control, which is also

Re: [pgadmin-hackers] Info on non supported Features

2011-01-10 Thread Guillaume Lelarge
Le 10/01/2011 11:31, Jasmin Dizdarevic a écrit : > 2011/1/10 Guillaume Lelarge > >> Le 10/01/2011 11:07, Jasmin Dizdarevic a écrit : >>> Sure, it's possible, but then you have take care of each control >>> individually. Setting a text in a combobx and checkbox

Re: Fwd: [pgadmin-hackers] Info on non supported Features

2011-01-10 Thread Guillaume Lelarge
Le 10/01/2011 12:21, Jasmin Dizdarevic a écrit : > [...] > you will need this two patches - i hope it works. > I'll take a look. > I'm interested, how you would take a look on a branch of mine. This would > make things a lot easier at all? > It should. You can do that with github for example.

Re: [pgadmin-hackers] Re: [pgadmin-support] pgAdmin Crashes When Opening a *.sql File From Windows Explorer

2011-01-10 Thread Guillaume Lelarge
Le 10/01/2011 16:21, Dhiraj Chawla a écrit : > Hi Dave, > > I was able to reproduce the issue. Please find attached patches for master > and REL_1_12_PATCHES branches. > Oh, clever. If the query tool is opened from a file, there is no browser, meaning mainForm is NULL. Good catch. Thanks, Dhir

[pgadmin-hackers] pgAdmin III commit: Update german translation.

2011-01-15 Thread Guillaume Lelarge
Update german translation. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=d49e13d562ddb02cd78d7471fad9dfa6b2d80b0a Author: Harald Armin Massa Modified Files -- i18n/de_DE/pgadmin3.mo | Bin 192947 -> 206804 bytes i18n/de_DE/pgadmi

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-15 Thread Guillaume Lelarge
Hi, Le 15/01/2011 20:33, Peter Geoghegan a écrit : > I'm having a go at getting pgadmin to build against the development > branch of wxWidgets, 2.9. I intend to first get a clean WxGTK build, > and perhaps move on to other WxWidgets platforms afterwards. I note > that the wxWidgets/contrib directo

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-15 Thread Guillaume Lelarge
Le 15/01/2011 20:52, Dave Page a écrit : > I hope we can support both versions. 2.9 will be a great help on Mac > as we'll be able to use the Cocoa port. > If it is possible, I cannot agree more with you. I'm afraid that the patch will be huge and, as such, won't allow us to support both. -- G

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-17 Thread Guillaume Lelarge
Le 17/01/2011 16:30, Peter Geoghegan a écrit : > On 16 January 2011 22:39, Dave Page wrote: >> On Sun, Jan 16, 2011 at 6:47 PM, Peter Geoghegan > [...] >> How did the OGL port go? I looked at that briefly, and had a rough >> build in 10 minutes or so iirc. Oh, and in answer to your previous >> com

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-17 Thread Guillaume Lelarge
Le 17/01/2011 23:20, Dave Page a écrit : > On Mon, Jan 17, 2011 at 10:13 PM, Guillaume Lelarge > wrote: >> Actually, I don't see us maintaining OGL. We don't have the manpower to >> do that. >> >> I'm wondering if we really need OGL. What do we use it

Re: [pgadmin-hackers] pgAdmin III commit: The new version of astyle seems to want to tweak a

2011-01-18 Thread Guillaume Lelarge
Le 18/01/2011 20:40, Dave Page a écrit : > On Tue, Jan 18, 2011 at 7:29 PM, Magnus Hagander wrote: >> On Tue, Jan 18, 2011 at 20:25, Dave Page wrote: >>> On Tue, Jan 18, 2011 at 7:19 PM, Magnus Hagander >>> wrote: On Tue, Jan 18, 2011 at 18:53, Dave Page wrote: > The new version of as

Re: [pgadmin-hackers] pgAdmin III commit: The new version of astyle seems to want to tweak a

2011-01-18 Thread Guillaume Lelarge
Le 18/01/2011 21:29, Dave Page a écrit : > On Tue, Jan 18, 2011 at 8:15 PM, Guillaume Lelarge > wrote: >> Le 18/01/2011 20:40, Dave Page a écrit : >>> On Tue, Jan 18, 2011 at 7:29 PM, Magnus Hagander >>> wrote: >>>> On Tue, Jan 18, 2011 at 20:25, Dave

[pgadmin-hackers] Patch to support SSL certificate connections

2011-01-18 Thread Guillaume Lelarge
http://www.postgresql.fr http://dalibo.com >From 242e53af104bac7d26d10755003d44af58ccce8f Mon Sep 17 00:00:00 2001 From: Guillaume Lelarge Date: Wed, 19 Jan 2011 00:31:48 +0100 Subject: [PATCH] Support for SSL certificate files This patch adds support to specify SSL certificate files, and to connect w

[pgadmin-hackers] Support for Slony 2.0?

2011-01-19 Thread Guillaume Lelarge
Hi, I want to know if we still want to support Slony. I was working on fixing an issue with our support of Slony till I finally understood we don't have any support of Slony 2.0. I remember that some of us wanted to get rid of our Slony support. I'm all to keep it. I think this is the kind of thi

Re: [pgadmin-hackers] Support for Slony 2.0?

2011-01-19 Thread Guillaume Lelarge
Le 19/01/2011 21:36, Magnus Hagander a écrit : > On Wed, Jan 19, 2011 at 21:19, Guillaume Lelarge > wrote: >> Hi, >> >> I want to know if we still want to support Slony. I was working on >> fixing an issue with our support of Slony till I finally understood we >

Re: [pgadmin-hackers] Support for Slony 2.0?

2011-01-19 Thread Guillaume Lelarge
Le 19/01/2011 22:26, Dave Page a écrit : > On Wed, Jan 19, 2011 at 8:19 PM, Guillaume Lelarge > wrote: >> Hi, >> >> I want to know if we still want to support Slony. I was working on >> fixing an issue with our support of Slony till I finally understood we >>

[pgadmin-hackers] pgAdmin III commit: Display the message only when we're connected

2011-01-19 Thread Guillaume Lelarge
Display the message only when we're connected When we change a server's setting, we always have the usual message "Some changes will not take effect until the next time pgAdmin connects to the server" wether or not we are connected to this server. This patch displays the message only when the use

[pgadmin-hackers] pgAdmin III commit: Display the message only when we're connected

2011-01-19 Thread Guillaume Lelarge
Display the message only when we're connected When we change a server's setting, we always have the usual message "Some changes will not take effect until the next time pgAdmin connects to the server" wether or not we are connected to this server. This patch displays the message only when the use

[pgadmin-hackers] pgAdmin III commit: Disable all widgets in the server dialog...

2011-01-19 Thread Guillaume Lelarge
Disable all widgets in the server dialog... if the user is already connected to it. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=4e1d17d4d1c54721ea496d292857ce1d365de557 Modified Files -- CHANGELOG |2 ++ pgad

Re: [pgadmin-hackers] Support for Slony 2.0?

2011-01-20 Thread Guillaume Lelarge
Le 20/01/2011 19:39, Devrim GÜNDÜZ a écrit : > On Thu, 2011-01-20 at 18:37 +, Peter Geoghegan wrote: >> >>> ...from a PoV of a user or a DBA from field, we need a real GUI that >>> helps people to setup a Slony-I cluster easily -- or say, as easy as >>> possible. >> >> I'm just not sure that Pg

Re: [pgadmin-hackers] Support for Slony 2.0?

2011-01-20 Thread Guillaume Lelarge
Le 20/01/2011 20:15, Peter Geoghegan a écrit : > Why don't we have a wizard-type facility to generate a Slonik script, > rather than calling the "bare-metal" functions ourselves? That could > potentially be much more useful. The reason that the existing > facilities are a bit of a chore to use when

Re: [pgadmin-hackers] Patch to support SSL certificate connections

2011-01-20 Thread Guillaume Lelarge
Le 19/01/2011 00:35, Guillaume Lelarge a écrit : > Hi, > > This patch adds support to specify SSL certificate files and to connect > according to those. > > It's pretty straightforward: four file pickers to handle on dlgServer, > and changes in the connection code to a

Re: [pgadmin-hackers] Support for pg_stat_database_conflicts and pg_stat_replication

2011-01-21 Thread Guillaume Lelarge
Le 21/01/2011 10:16, Magnus Hagander a écrit : > On Thu, Jan 20, 2011 at 23:06, Guillaume Lelarge > wrote: >> Hi, >> >> Two new patchs to add support for these 9.1 features. >> >> Not a lot to say. pg_stat_database_conflicts adds the new statistics >>

Re: [pgadmin-hackers] pgadmin crash on refresh

2011-01-21 Thread Guillaume Lelarge
Le 21/01/2011 19:36, Magnus Hagander a écrit : > On Fri, Jan 21, 2011 at 13:35, Dave Page wrote: >> On Fri, Jan 21, 2011 at 12:20 PM, Magnus Hagander >> wrote: >>> On Wed, Jan 19, 2011 at 14:55, Dave Page wrote: On Wed, Jan 19, 2011 at 12:18 PM, Magnus Hagander wrote: > Opened d

Re: [pgadmin-hackers] Patch to support SSL certificate connections

2011-01-21 Thread Guillaume Lelarge
Le 21/01/2011 10:15, Dave Page a écrit : > On Thu, Jan 20, 2011 at 10:08 PM, Guillaume Lelarge > wrote: >> Le 19/01/2011 00:35, Guillaume Lelarge a écrit : >>> Hi, >>> >>> This patch adds support to specify SSL certificate files and to connect >

Re: [pgadmin-hackers] Patch to support SSL certificate connections

2011-01-21 Thread Guillaume Lelarge
Le 21/01/2011 10:17, Magnus Hagander a écrit : > On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge > wrote: >> Le 19/01/2011 00:35, Guillaume Lelarge a écrit : >>> Hi, >>> >>> This patch adds support to specify SSL certificate files and to connect >

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-23 Thread Guillaume Lelarge
Le 23/01/2011 17:01, Peter Geoghegan a écrit : > On 23 January 2011 14:56, Magnus Hagander wrote: >> >> Hmm. Perhaps the bug is that parser.sh should also update FlexLexer.h? > > Hacking a system header and then shipping it without mentioning > anything seems like a bad idea, an idea that would b

Re: [pgadmin-hackers] Support for Slony 2.0?

2011-01-23 Thread Guillaume Lelarge
Le 22/01/2011 15:46, Peter Geoghegan a écrit : > On 20 January 2011 21:28, Dave Page wrote: >> A wizard as you suggest has been on my "if only i had the time and >> energy" todo list for a few years :-) > > It's something that I'd like to take a look at, once we finish wx 2.9 > support. As I thin

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-24 Thread Guillaume Lelarge
Le 24/01/2011 09:43, Dave Page a écrit : > On Sun, Jan 23, 2011 at 10:21 PM, Guillaume Lelarge > wrote: >> >> Not sure I agree there. This is a huge list of files to be fixed to >> have... nothing more. I'm also all for incremental commits as long as >> they do

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-24 Thread Guillaume Lelarge
Le 24/01/2011 10:49, Dave Page a écrit : > On Mon, Jan 24, 2011 at 9:38 AM, Guillaume Lelarge > wrote: >> Le 24/01/2011 09:43, Dave Page a écrit : >>> On Sun, Jan 23, 2011 at 10:21 PM, Guillaume Lelarge >>> wrote: >>>> >>>> Not sure I ag

Re: [pgadmin-hackers] pgAdmin III commit: Fix copy bug in the edit grid

2011-01-27 Thread Guillaume Lelarge
Le 21/01/2011 15:41, Timon a écrit : > seem that this commit broke ability to copy whole query result from > result grid in query tool. > Sorry for not answering sooner. I just tried and it seems to work right to me. I don't see any issue with copy and paste in the query tool. -- Guillaume ht

Re: [pgadmin-hackers] Patch to support SSL certificate connections

2011-01-27 Thread Guillaume Lelarge
Le 22/01/2011 09:00, Dave Page a écrit : > On Sat, Jan 22, 2011 at 12:33 AM, Guillaume Lelarge > wrote: >> Le 21/01/2011 10:15, Dave Page a écrit : >> Done. >> >>> Also, what's with the inconsistent text/artwork on the buttons? >>> > > The

Re: [pgadmin-hackers] Patch to support SSL certificate connections

2011-01-27 Thread Guillaume Lelarge
Le 22/01/2011 01:34, Guillaume Lelarge a écrit : > Le 21/01/2011 10:17, Magnus Hagander a écrit : >> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge >> wrote: >>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit : >>>> Hi, >>>> >>>> Thi

Re: [pgadmin-hackers] Patch to support SSL certificate connections

2011-01-27 Thread Guillaume Lelarge
Le 28/01/2011 02:11, Dave Page a écrit : > On Thu, Jan 27, 2011 at 9:56 PM, Guillaume Lelarge > wrote: >> Le 22/01/2011 01:34, Guillaume Lelarge a écrit : >>> Le 21/01/2011 10:17, Magnus Hagander a écrit : >>>> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge &

Re: [pgadmin-hackers] Patch to support SSL certificate connections

2011-01-27 Thread Guillaume Lelarge
Hi Ashesh, Le 28/01/2011 04:58, Ashesh Vashi a écrit : > [...] > I think - you've used wxStaticBox here. Actually, it's a wxStaticBoxSizer. Not sure if it matters. > If I am not wrong, please consider this patch for testing on osx. > I've faced an issue in recent past with the wxStaticBox relate

Re: [pgadmin-hackers] Patch to support SSL certificate connections

2011-01-28 Thread Guillaume Lelarge
Le 28/01/2011 09:21, Dave Page a écrit : > On Fri, Jan 28, 2011 at 7:25 AM, Guillaume Lelarge > wrote: >> Le 28/01/2011 02:11, Dave Page a écrit : >>> On Thu, Jan 27, 2011 at 9:56 PM, Guillaume Lelarge >>> wrote: >>>> Le 22/01/2011 01:34, Guillaume L

Re: [pgadmin-hackers] Patch to support SSL certificate connections

2011-01-28 Thread Guillaume Lelarge
Le 28/01/2011 09:37, Guillaume Lelarge a écrit : > Le 28/01/2011 09:21, Dave Page a écrit : >> On Fri, Jan 28, 2011 at 7:25 AM, Guillaume Lelarge >> wrote: >>> Le 28/01/2011 02:11, Dave Page a écrit : >>>> On Thu, Jan 27, 2011 at 9:56 PM, Guillaume Lelarge &g

Re: [pgadmin-hackers] Patch to support SSL certificate connections

2011-01-28 Thread Guillaume Lelarge
Le 28/01/2011 19:39, Dave Page a écrit : > That's better. > > Fyi, the other design did look OK - i just think we need to plan such > changes properly and implement in batches rather than piecemeal. > My issue with my last design is that the two first buttons and the two last buttons were not pr

[pgadmin-hackers] New release?

2011-01-28 Thread Guillaume Lelarge
OK, I'm quite late on this one but shoud we have a new minor release? we've got quite a bunch of fixes in the CHANGELOG file: 2011-01-19 GL 1.12.3 Display the message only when we change the setting of a connected server. Report from Josh Berkus. 201

<    1   2   3   4   5   6   7   8   9   10   >