Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

Thanks, patch applied. On Fri, Jan 20, 2017 at 7:29 AM, Surinder Kumar wrote: > Hi Dave, > > The last patch was for exclusion constraint only. The same issue issue is > reported RM2061 for index. > So, this patch takes care of both issues. > > Added a flag 'is_sort_nulls_applicable' which is set

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

Hi Dave, The last patch was for exclusion constraint only. The same issue issue is reported RM2061 for index. So, this patch takes care of both issues. Added a flag '*is_sort_nulls_applicable*' which is set to true for access method 'btree'. If its is

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

Hi On Tue, Jan 17, 2017 at 9:52 AM, Surinder Kumar wrote: > Hi > On Tue, Jan 17, 2017 at 3:08 PM, Dave Page wrote: >> >> Hi >> >> On Fri, Jan 13, 2017 at 6:50 AM, Surinder Kumar >> wrote: >> > Hi >> > >> > Please find updated patch following changes: >> > 1) Keep field 'opclass' combo box enabl

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

Hi On Tue, Jan 17, 2017 at 3:08 PM, Dave Page wrote: > Hi > > On Fri, Jan 13, 2017 at 6:50 AM, Surinder Kumar > wrote: > > Hi > > > > Please find updated patch following changes: > > 1) Keep field 'opclass' combo box enabled. > > That doesn't seem to be working. ​Is the field 'opclass' is not e

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

Hi On Fri, Jan 13, 2017 at 6:50 AM, Surinder Kumar wrote: > Hi > > Please find updated patch following changes: > 1) Keep field 'opclass' combo box enabled. That doesn't seem to be working. > 2) Keep ASC/DESC and NULLs FIRST/LAST options disable for access methods > other than 'btree'. > 3) Add

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

Hi Please find updated patch following changes: 1) Keep field 'opclass' combo box enabled. 2) Keep ASC/DESC and NULLs FIRST/LAST options disable for access methods other than 'btree'. 3) Add validation for name field. On Fri, Nov 25, 2016 at 5:16 PM, Dave Page wrote: > On Thu, Nov 24, 2016 at

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

On Thu, Nov 24, 2016 at 12:13 PM, Surinder Kumar wrote: > Hi > > Please find updated patch with change. > > On Fri, Oct 21, 2016 at 9:16 PM, Dave Page wrote: >> >> On Fri, Oct 21, 2016 at 4:42 PM, Surinder Kumar >> wrote: >> > On Fri, Oct 21, 2016 at 8:52 PM, Dave Page wrote: >> >> >> >> Hi >>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

Hi Please find updated patch with change. On Fri, Oct 21, 2016 at 9:16 PM, Dave Page wrote: > On Fri, Oct 21, 2016 at 4:42 PM, Surinder Kumar > wrote: > > On Fri, Oct 21, 2016 at 8:52 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar > >> wrote: > >>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

On Fri, Oct 21, 2016 at 4:42 PM, Surinder Kumar wrote: > On Fri, Oct 21, 2016 at 8:52 PM, Dave Page wrote: >> >> Hi >> >> On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar >> wrote: >> > Hi >> > >> > This fix is for exclusion constraint. >> > The options like "order" and "nulls" must be conditiona

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

On Fri, Oct 21, 2016 at 8:52 PM, Dave Page wrote: > Hi > > On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar > wrote: > > Hi > > > > This fix is for exclusion constraint. > > The options like "order" and "nulls" must be conditional. i.e. include > only > > when access method type is other than "gi

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

Hi On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar wrote: > Hi > > This fix is for exclusion constraint. > The options like "order" and "nulls" must be conditional. i.e. include only > when access method type is other than "gist". When creating an index, the asc/desc options are disabled if gist

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

Hi This fix is for exclusion constraint. The options like "order" and "nulls" must be conditional. i.e. include only when access method type is other than "gist". Please find attached patch and review. On Fri, Oct 21, 2016 at 4:38 PM, Dave Page wrote: > Thanks, applied. > > On Thu, Oct 20, 201

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

Thanks, applied. On Thu, Oct 20, 2016 at 7:47 AM, Surinder Kumar wrote: > Hi, > > The options like "sort" and "nulls" must be conditional. i.e. include only > when access method type is other than "gist" or "gin". > > Please find attached patch and review. > > Thanks, > Surinder Kumar > > > > --

[pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

Hi, The options like "sort" and "nulls" must be conditional. i.e. include only when access method type is other than "gist" or "gin". Please find attached patch and review. Thanks, Surinder Kumar RM1840.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@