Hi,
I will open individual threads.
Patch 3 "module.mk" explanation:
pgadmin/include/images/module.mk - new file pastetables.png
pgadmin/include/utils/module.mk - new files pasteTables.h and PgadminScanner.h
pgadmin/ui/module.mk - new file frmCopyTables.xrc
pgadmin/utils/module.mk - new file past
Patch 3 (the only one I've looked at) still modifies at least one
module.mk file, and it's not appropriate to include part of the
unrelated settings flush functionality in it. That makes it very hard
to review the changes individually.
I've also asked a number of times for you to post the patches
Hi,
I must APOLOGIZE for bad patches I've sent to list !
Problem was my wrong handled local GIT repository.
I'm trying to find proper way to handle it ...
Best regards
Vladimir Kokovic
Belgrade, Serbia, 20.September 2012
On 9/19/12, Dave Page wrote:
> On Wed, Sep 19, 2012 at 10:04 AM, Vladimir
On Wed, Sep 19, 2012 at 10:04 AM, Vladimir Koković
wrote:
> Hi,
>
> If you have a build which is configured with "--srcdir=" then
> "pgadmin/ui/module.mk" must be without "$(srcdir)/" !
Well;
- That is a separate issue, and needs to be considered independently
in a different patch.
- The pgAdmi
Hi,
If you have a build which is configured with "--srcdir=" then
"pgadmin/ui/module.mk" must be without "$(srcdir)/" !
Best regards
Vladimir Kokovic
Belgrade, Serbia, 19.September 2012
On Wed, 19 Sep 2012 15:01:36 +0200, Dave Page wrote:
Hi
As I mentioned below, there are issues with
Hi
As I mentioned below, there are issues with the patches that need to
be cleaned up before they can be removed. A sizeable percentage of
patch3 for example changes things that are completely unrelated to
what the patch claims to do, or just changes paths for unrelated files
in the makefiles.
Pl
On Sun, 2012-09-09 at 18:57 +0200, Vladimir Kokovic wrote:
> Hi,
>
> 1.
> ---
> ADDED NEW FUNCTIONALITY FOR SCHEMA:
>
> Right click on schema node provides three new functionalities
> - Copy tables
> - Copy table(s) from the list
> - Paste table(s)
>
> "Copy tables" provides copying all ta
Hi
Sounds interesting, but without public review of the work there's zero
chance of it being committed.
Can you please break it up into individual patches for each feature, and
for the scanner infrastructure, and submit?
Thanks.
On Sunday, September 9, 2012, Vladimir Kokovic wrote:
> Hi,
>
> 1
Hi,
1.
---
ADDED NEW FUNCTIONALITY FOR SCHEMA:
Right click on schema node provides three new functionalities
- Copy tables
- Copy table(s) from the list
- Paste table(s)
"Copy tables" provides copying all tables from the schema.
"Paste table(s)" on target schema will create new table(s) i
