Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-15 Thread Dave Page
Hi On Thu, Jul 14, 2016 at 12:50 PM, Priyanka Shendge wrote: > Hi Dave, > > I have added more debug statements to older patch. New patch attached. > Also, i removed database deletion test case from current patch so that we > can analyse > if database is added or not. OK. One quick note - somewhe

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-14 Thread Priyanka Shendge
Hi Dave, I have added more debug statements to older patch. New patch attached. Also, i removed database deletion test case from current patch so that we can analyse if database is added or not. I have added few more debug statements to database add test case. After running the testsuite can you

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-12 Thread Dave Page
On Tue, Jul 12, 2016 at 5:14 AM, Khushboo Vashi wrote: > > > On Mon, Jul 11, 2016 at 7:15 PM, Priyanka Shendge > wrote: >> >> >> >> On 11 July 2016 at 18:35, Dave Page wrote: >>> >>> On Mon, Jul 11, 2016 at 1:25 PM, Priyanka Shendge >>> wrote: >>> > Sorry, by mistake i copied incomplete query.

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-11 Thread Khushboo Vashi
On Mon, Jul 11, 2016 at 7:15 PM, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote: > > > On 11 July 2016 at 18:35, Dave Page wrote: > >> On Mon, Jul 11, 2016 at 1:25 PM, Priyanka Shendge >> wrote: >> > Sorry, by mistake i copied incomplete query. There is an OID present >> for >> > a

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-11 Thread Priyanka Shendge
On 11 July 2016 at 18:35, Dave Page wrote: > On Mon, Jul 11, 2016 at 1:25 PM, Priyanka Shendge > wrote: > > Sorry, by mistake i copied incomplete query. There is an OID present for > > added database. > > > > SELECT > > db.oid as did, db.datname, db.datallowconn, > > pg_encoding_to_char

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-11 Thread Dave Page
On Mon, Jul 11, 2016 at 1:25 PM, Priyanka Shendge wrote: > Sorry, by mistake i copied incomplete query. There is an OID present for > added database. > > SELECT > db.oid as did, db.datname, db.datallowconn, > pg_encoding_to_char(db.encoding) AS serverencoding, > has_database_privilege

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-11 Thread Priyanka Shendge
Sorry, by mistake i copied incomplete query. There is an OID present for added database. SELECT db.oid as did, db.datname, db.datallowconn, pg_encoding_to_char(db.encoding) AS serverencoding, has_database_privilege(db.oid, 'CREATE') as cancreate, datlastsysoid FROM pg_database db

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-11 Thread Dave Page
Hi, No, sorry I don't have an extra system you can test on. It's pretty clear that query would fail - it's missing a database OID after the = On Fri, Jul 8, 2016 at 10:38 AM, Priyanka Shendge wrote: > Hi Dave, > > I have tried to reproduce the issue by running the test-suite on different > mach

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-08 Thread Priyanka Shendge
Hi Dave, I have tried to reproduce the issue by running the test-suite on different machines (64 and 32 bit) and users on PG9.4/9.5 (Provided different "test_db_username" in test_config.json). It is working fine at my end. The log file (output.log) sent by you shows following query is failing at

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-05 Thread Priyanka Shendge
Hi Dave, I tried running the testsuite against PG9.4 and unable to reproduce the failures. I have added debug statements to previous patch. Patch attached. Could you please re-run the same and send me the logs and output? Thank you. On 4 July 2016 at 17:30, Dave Page wrote: > Hi > > The test d

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-04 Thread Dave Page
Hi The test data was the default, and I ran against PG 9.4. All other logs were attached to my previous email. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 4 Jul 2016, at 12:16, Priyanka She

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-04 Thread Priyanka Shendge
Hi Dave, I am unable to reproduce issue on my side; tried on Python 2.7 and Python 3.4. Could you please provide me DEBUG logs and test data using for database node? Thank you. On 30 June 2016 at 00:51, Dave Page wrote: > Hi, > > That's better. I tweaked a few things and fixed a bug related to

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-06-29 Thread Priyanka Shendge
Hi Dave, As per discussion over mail i have created separate config files for credentials and test data. PFA patch for same. Kindly, review and let me know for modifications. On 27 June 2016 at 15:10, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote: > > > On 27 June 2016 at 13:24, D

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-06-27 Thread Priyanka Shendge
On 27 June 2016 at 13:24, Dave Page wrote: > On Sun, Jun 26, 2016 at 12:05 PM, Priyanka Shendge > wrote: > > > > > > On 24 June 2016 at 16:17, Dave Page wrote: > >> > >> Hi > >> > >> On Thu, Jun 23, 2016 at 2:41 PM, Priyanka Shendge > >> wrote: > >> > > >> > > >> > On 15 June 2016 at 15:05, Pr

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-06-27 Thread Dave Page
On Sun, Jun 26, 2016 at 12:05 PM, Priyanka Shendge wrote: > > > On 24 June 2016 at 16:17, Dave Page wrote: >> >> Hi >> >> On Thu, Jun 23, 2016 at 2:41 PM, Priyanka Shendge >> wrote: >> > >> > >> > On 15 June 2016 at 15:05, Priyanka Shendge >> > wrote: >> >> >> >> Thanks a lot Dave. >> >> >> >>

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-06-26 Thread Priyanka Shendge
On 24 June 2016 at 16:17, Dave Page wrote: > Hi > > On Thu, Jun 23, 2016 at 2:41 PM, Priyanka Shendge > wrote: > > > > > > On 15 June 2016 at 15:05, Priyanka Shendge > > wrote: > >> > >> Thanks a lot Dave. > >> > >> On 15 June 2016 at 14:09, Dave Page wrote: > >>> > >>> Hi > >>> > >>> On Thu,

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-06-24 Thread Dave Page
Hi On Thu, Jun 23, 2016 at 2:41 PM, Priyanka Shendge wrote: > > > On 15 June 2016 at 15:05, Priyanka Shendge > wrote: >> >> Thanks a lot Dave. >> >> On 15 June 2016 at 14:09, Dave Page wrote: >>> >>> Hi >>> >>> On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge >>> wrote: >>> > Hi Dave, >>> > >>

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-06-23 Thread Priyanka Shendge
On 15 June 2016 at 15:05, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote: > Thanks a lot Dave. > > On 15 June 2016 at 14:09, Dave Page wrote: > >> Hi >> >> On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge >> wrote: >> > Hi Dave, >> > >> > PFA updated patch. I have made changes sugge

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-06-15 Thread Priyanka Shendge
Thanks a lot Dave. On 15 June 2016 at 14:09, Dave Page wrote: > Hi > > On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge > wrote: > > Hi Dave, > > > > PFA updated patch. I have made changes suggested by you. > > > > Kindly, review and let me know for more changes. > > OK, I got a bit further thi

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-06-15 Thread Dave Page
Ashesh - can you also look at the patch please (feel free to wait for the update). I want more eyes on this. Thanks. On Wed, Jun 15, 2016 at 9:39 AM, Dave Page wrote: > Hi > > On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge > wrote: >> Hi Dave, >> >> PFA updated patch. I have made changes sugg

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-06-06 Thread Priyanka Shendge
On 6 June 2016 at 14:03, Dave Page wrote: > Hi > > On Sun, Jun 5, 2016 at 6:56 PM, Priyanka Shendge > wrote: > > Hi, > > > > PFA patch for API test cases for tree nodes/modules. This patch does not > > include > > api tests for following modules: > > > > 1. Type > > 2. Table child nodes > > 3. F

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-06-06 Thread Dave Page
Hi On Sun, Jun 5, 2016 at 6:56 PM, Priyanka Shendge wrote: > Hi, > > PFA patch for API test cases for tree nodes/modules. This patch does not > include > api tests for following modules: > > 1. Type > 2. Table child nodes > 3. FTS modules > > Kindly, review the same and let me know for any modifi