Re: pgsql: Handle equality operator in contrib/pg_trgm

2024-09-20 Thread Laurenz Albe
> master > > Details > --- > https://git.postgresql.org/pg/commitdiff/935f502250abde8615bc7805a6e5aa05a066 This causes bad query results with non-deterministic collations, see https://postgr.es/m/8ef4899c4acfebca45cc6c042a6dc611d25ffab1.ca...@cybertec.at Yours, Laurenz Albe

Re: pgsql: Don't enter parallel mode when holding interrupts.

2024-09-18 Thread Laurenz Albe
; > Francesco Degrassi > > Discussion: > https://postgr.es/m/CAC-SaSzHUKT=vzj8mpxydc_urpfax+yoa1hktcf4roz_q6z...@mail.gmail.com Does that warrant mention on this page? https://www.postgresql.org/docs/current/when-can-parallel-query-be-used.html Yours, Laurenz Albe

Re: pgsql: doc: document the need to analyze partitioned tables

2023-10-10 Thread Laurenz Albe
On Tue, 2023-10-10 at 19:14 +, Bruce Momjian wrote: > Reported-by: Justin Pryzby Not very important, but I reported that in https://postgr.es/m/1fd81ddc7710a154834030133c6fea41e55c8efb.camel%40cybertec.at Yours, Laurenz Albe

Re: pgsql: Improve error handling of cryptohash computations

2022-01-13 Thread Laurenz Albe
branches. > > Agreed, that's not worth breaking things in v14, so I'll go and revert > this stuff in it. Thanks! Yours, Laurenz Albe

Re: pgsql: Improve error handling of cryptohash computations

2022-01-13 Thread Laurenz Albe
back branches? Yours, Laurenz Albe

Re: pgsql: Allow a multi-row INSERT to specify DEFAULTs for a generated col

2021-08-18 Thread Laurenz Albe
> -- > master > > Details > --- > https://git.postgresql.org/pg/commitdiff/17958972fe3bb03454a4b53756b29d65dc285efa Shouldn't this be backpatched? That seems like a clear bug to me; see this report on v11: https://stackoverflow.com/q/68834080/6464308 Yours, Laurenz Albe

Re: pgsql: SQL-standard function body

2021-04-16 Thread Laurenz Albe
On Fri, 2021-04-16 at 12:26 +0200, Peter Eisentraut wrote: > committed Thank you! Yours, Laurenz Albe

Re: pgsql: SQL-standard function body

2021-04-12 Thread Laurenz Albe
On Mon, 2021-04-12 at 17:25 +0200, Peter Eisentraut wrote: > On 10.04.21 03:38, Laurenz Albe wrote: > > On Fri, 2021-04-09 at 19:44 +0200, I wrote: > > > > SQL-standard function body > > > > > > > > psql needs some new intelligence to keep track o

Re: pgsql: SQL-standard function body

2021-04-09 Thread Laurenz Albe
a function > body. > > Would it be an option to recognize BEGIN and CASE as starting a > function body only if they are *not* inside parentheses, like in > the attached? Here is an improved patch, which treats END in the same fashion (not properly indented for readability). Your

Re: pgsql: SQL-standard function body

2021-04-09 Thread Laurenz Albe
st on using it as a FDW option, but it is a regression. Would it be an option to recognize BEGIN and CASE as starting a function body only if they are *not* inside parentheses, like in the attached? Yours, Laurenz Albe From 8c95440905c01b8c9ed8b46ef01a24b01f24580d Mon Sep 17 00:00:00 2001 From

Re: pgsql: Drop index behind pg_upgrade test issue.

2021-03-11 Thread Laurenz Albe
l had a point with his complaint[1]. Perhaps it would be better to implement one of his ideas than to remove the test. Yours, Laurenz Albe [1]: https://postgr.es/m/a3ko3nknb...@paquier.xyz

Re: pgsql: Add pg_stat_database counters for sessions and session time

2021-01-18 Thread Laurenz Albe
n a database to pg_stat_database. Should't this update PGSTAT_FILE_FORMAT_ID in include/pgstat.h since "struct PgStat_StatDBEntry" was changed? Yours, Laurenz Albe

Re: pgsql: Add deduplication to nbtree.

2020-02-27 Thread Laurenz Albe
On Wed, 2020-02-26 at 21:06 +, Peter Geoghegan wrote: > Add deduplication to nbtree. This is great! Thanks! Are no changes to the "pageinspect" contrib required? Yours, Laurenz Albe

Re: pgsql: Allow insert and update tuple routing and COPY for foreign table

2019-04-25 Thread Laurenz Albe
t. > > These seem a bit redundant to me [...] > > OK, how about something like the attached? I reworded this a bit, though. I like your patch better than my wording. Thanks for the effort! Yours, Laurenz Albe

Re: pgsql: Allow insert and update tuple routing and COPY for foreign table

2019-04-24 Thread Laurenz Albe
y Multicorn FDW with write support is currently broken. As Andres has argued above, it is too late to do anything more about it than to document this and warn FDW authors as good as we can. Yours, Laurenz Albe

Re: pgsql: Allow insert and update tuple routing and COPY for foreign table

2019-04-24 Thread Laurenz Albe
broken by that API change as well if it hasn't been patched. At the very least, this should have been mentioned in the list of incompatible changes for v11. Yours, Laurenz Albe

Re: pgsql: Allow insert and update tuple routing and COPY for foreign table

2019-04-22 Thread Laurenz Albe
FDWs. I think this > ship simply has sailed. I can accept that (having fixed my own FDW), but I am worried that it will cause problems for FDW users. Well, I guess they can always avoid COPY if they don't want FDWs to crash. Yours, Laurenz Albe

Re: pgsql: Allow insert and update tuple routing and COPY for foreign table

2019-04-22 Thread Laurenz Albe
On Mon, 2019-04-22 at 13:27 -0700, Andres Freund wrote: > On 2019-04-22 21:37:25 +0200, Laurenz Albe wrote: > > Commit 3d956d956a introduced support for foreign tables as partitions > > and COPY FROM on foreign tables. > > > > If a foreign data wrapper supports data mo

Re: pgsql: Allow insert and update tuple routing and COPY for foreign table

2019-04-22 Thread Laurenz Albe
On Mon, 2019-04-22 at 16:24 -0400, Robert Haas wrote: > On Mon, Apr 22, 2019 at 3:37 PM Laurenz Albe wrote: > > Sure, it is not hard to modify a FDW to continue working with v11. > > > > My point is that this should not be necessary. > > I'm not sure whether t

Re: pgsql: Allow insert and update tuple routing and COPY for foreign table

2019-04-22 Thread Laurenz Albe
On Mon, 2019-04-22 at 21:45 +0900, Etsuro Fujita wrote: Thanks for looking into this! > (2019/04/20 20:53), Laurenz Albe wrote: > > On Fri, 2018-04-06 at 23:24 +, Robert Haas wrote: > > > Allow insert and update tuple routing and COPY for foreign tables. > > >

Re: pgsql: Allow insert and update tuple routing and COPY for foreign table

2019-04-20 Thread Laurenz Albe
a foreign table if the FDW implements BeginForeignInsert. The attached patch implements that. I think this should be backpatched to v11. Yours, Laurenz Albe From c4b0e871658c757124dad992578da0b60fccf962 Mon Sep 17 00:00:00 2001 From: Laurenz Albe Date: Sat, 20 Apr 2019 13:36:56 +0200 Subject: [PATCH