pgsql: Fix documentation for pgbench tpcb-like.

2019-07-13 Thread Thomas Munro
Fix documentation for pgbench tpcb-like. We choose a random value for delta, not balance. Back-patch to 9.6 where the mistake arrived. Author: Fabien Coelho Discussion: https://postgr.es/m/alpine.DEB.2.21.1904081752210.5867@lancre Branch -- REL_11_STABLE Details ---

pgsql: Fix documentation for pgbench tpcb-like.

2019-07-13 Thread Thomas Munro
Fix documentation for pgbench tpcb-like. We choose a random value for delta, not balance. Back-patch to 9.6 where the mistake arrived. Author: Fabien Coelho Discussion: https://postgr.es/m/alpine.DEB.2.21.1904081752210.5867@lancre Branch -- master Details ---

pgsql: Fix documentation for pgbench tpcb-like.

2019-07-13 Thread Thomas Munro
Fix documentation for pgbench tpcb-like. We choose a random value for delta, not balance. Back-patch to 9.6 where the mistake arrived. Author: Fabien Coelho Discussion: https://postgr.es/m/alpine.DEB.2.21.1904081752210.5867@lancre Branch -- REL_12_STABLE Details ---

pgsql: Fix tab completion for UPDATE.

2019-07-12 Thread Thomas Munro
Fix tab completion for UPDATE. Previously it suggested an extra "=" after "SET x=". Reported-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/CA%2BhUKGLk%3D0yLDjfviONJLzcHEzygj%3Dx6VbGH43LnXbBUvQb52g%40mail.gmail.com Branch -- master Details ---

pgsql: Tab completion for CREATE TYPE.

2019-07-12 Thread Thomas Munro
Tab completion for CREATE TYPE. Author: Thomas Munro Reviewed-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/CA%2BhUKGLk%3D0yLDjfviONJLzcHEzygj%3Dx6VbGH43LnXbBUvQb52g%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Introduce timed waits for condition variables.

2019-07-12 Thread Thomas Munro
Introduce timed waits for condition variables. Provide ConditionVariableTimedSleep(), like ConditionVariableSleep() but with a timeout argument. Author: Shawn Debnath Reviewed-by: Kyotaro Horiguchi, Thomas Munro Discussion: https://postgr.es/m/eeb06007ccfe46e399df6af18bfcd...@ex13d05uwc002

pgsql: Forward received condition variable signals on cancel.

2019-07-12 Thread Thomas Munro
when there is another process ready to receive it. Author: Thomas Munro Reviewed-by: Shawn Debnath Discussion: https://postgr.es/m/CA%2BhUKGLQ_RW%2BXs8znDn36e-%2Bmq2--zrPemBqTQ8eKT-VO1OF4Q%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Warn if wal_level is too low when creating a publication.

2019-07-12 Thread Thomas Munro
Warn if wal_level is too low when creating a publication. Provide a hint to users that they need to increase wal_level before subscriptions can work. Author: Lucas Viecelli, with some adjustments by Thomas Munro Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CAPjy-57rn5Y9g4e5u--eSOP

pgsql: Pass QueryEnvironment down to EvalPlanQual's EState.

2019-07-09 Thread Thomas Munro
Pass QueryEnvironment down to EvalPlanQual's EState. Otherwise the executor can't see trigger transition tables during EPQ evaluation. Fixes bug #15900 and almost certainly also #15720. Back-patch to 10, where trigger transition tables landed. Author: Alex Aktsipetrov Reviewed-by: Thomas Munro

pgsql: Pass QueryEnvironment down to EvalPlanQual's EState.

2019-07-09 Thread Thomas Munro
Pass QueryEnvironment down to EvalPlanQual's EState. Otherwise the executor can't see trigger transition tables during EPQ evaluation. Fixes bug #15900 and almost certainly also #15720. Back-patch to 10, where trigger transition tables landed. Author: Alex Aktsipetrov Reviewed-by: Thomas Munro

pgsql: Pass QueryEnvironment down to EvalPlanQual's EState.

2019-07-09 Thread Thomas Munro
Pass QueryEnvironment down to EvalPlanQual's EState. Otherwise the executor can't see trigger transition tables during EPQ evaluation. Fixes bug #15900 and almost certainly also #15720. Back-patch to 10, where trigger transition tables landed. Author: Alex Aktsipetrov Reviewed-by: Thomas Munro

pgsql: Pass QueryEnvironment down to EvalPlanQual's EState.

2019-07-09 Thread Thomas Munro
Pass QueryEnvironment down to EvalPlanQual's EState. Otherwise the executor can't see trigger transition tables during EPQ evaluation. Fixes bug #15900 and almost certainly also #15720. Back-patch to 10, where trigger transition tables landed. Author: Alex Aktsipetrov Reviewed-by: Thomas Munro

pgsql: Force hash joins to be enabled in the hash join regression tests

2019-07-09 Thread Thomas Munro
Force hash joins to be enabled in the hash join regression tests. Otherwise the regressplans.sh tests generate extremely slow nested loop joins. Back-patch to 11 where the hash join tests came in. Reported-by: Michael Paquier Discussion: https://postgr.es/m/20190708055256.GB2709%40paquier.xyz

pgsql: Force hash joins to be enabled in the hash join regression tests

2019-07-09 Thread Thomas Munro
Force hash joins to be enabled in the hash join regression tests. Otherwise the regressplans.sh tests generate extremely slow nested loop joins. Back-patch to 11 where the hash join tests came in. Reported-by: Michael Paquier Discussion: https://postgr.es/m/20190708055256.GB2709%40paquier.xyz

pgsql: Improve comment in postgresql.conf.sample.

2019-07-05 Thread Thomas Munro
Improve comment in postgresql.conf.sample. The Unix manual section that "man tcp" appears in varies, so let's just leave it out of the command to run. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e8fdcacc6cbeed7d1a2175c5eddf0b162e0cb7c4 Modified Files

pgsql: Fix misleading comment in nodeIndexonlyscan.c.

2019-06-27 Thread Thomas Munro
Fix misleading comment in nodeIndexonlyscan.c. The stated reason for acquiring predicate locks on heap pages hasn't existed since commit c01262a8, so fix the comment. Perhaps in a later release we'll also be able to change the code to use tuple locks. Back-patch all the way. Reviewed-by:

pgsql: Fix misleading comment in nodeIndexonlyscan.c.

2019-06-27 Thread Thomas Munro
Fix misleading comment in nodeIndexonlyscan.c. The stated reason for acquiring predicate locks on heap pages hasn't existed since commit c01262a8, so fix the comment. Perhaps in a later release we'll also be able to change the code to use tuple locks. Back-patch all the way. Reviewed-by:

pgsql: Fix misleading comment in nodeIndexonlyscan.c.

2019-06-27 Thread Thomas Munro
Fix misleading comment in nodeIndexonlyscan.c. The stated reason for acquiring predicate locks on heap pages hasn't existed since commit c01262a8, so fix the comment. Perhaps in a later release we'll also be able to change the code to use tuple locks. Back-patch all the way. Reviewed-by:

pgsql: Fix misleading comment in nodeIndexonlyscan.c.

2019-06-27 Thread Thomas Munro
Fix misleading comment in nodeIndexonlyscan.c. The stated reason for acquiring predicate locks on heap pages hasn't existed since commit c01262a8, so fix the comment. Perhaps in a later release we'll also be able to change the code to use tuple locks. Back-patch all the way. Reviewed-by:

pgsql: Fix misleading comment in nodeIndexonlyscan.c.

2019-06-27 Thread Thomas Munro
Fix misleading comment in nodeIndexonlyscan.c. The stated reason for acquiring predicate locks on heap pages hasn't existed since commit c01262a8, so fix the comment. Perhaps in a later release we'll also be able to change the code to use tuple locks. Back-patch all the way. Reviewed-by:

pgsql: Fix misleading comment in nodeIndexonlyscan.c.

2019-06-27 Thread Thomas Munro
Fix misleading comment in nodeIndexonlyscan.c. The stated reason for acquiring predicate locks on heap pages hasn't existed since commit c01262a8, so fix the comment. Perhaps in a later release we'll also be able to change the code to use tuple locks. Back-patch all the way. Reviewed-by:

pgsql: Don't unset MAKEFLAGS in non-GNU Makefile.

2019-06-24 Thread Thomas Munro
Don't unset MAKEFLAGS in non-GNU Makefile. It's useful to be able to pass down options like -s and -j. Back-patch to 9.5, like commit a76200de. Discussion: https://postgr.es/m/CA%2BhUKG%2Be1M8-BbL%3DPqhTp6oO6XPO6%2Bs9WGQMLfbuZ%3DG9CtzyXg%40mail.gmail.com Branch -- REL9_5_STABLE Details

pgsql: Don't unset MAKEFLAGS in non-GNU Makefile.

2019-06-24 Thread Thomas Munro
Don't unset MAKEFLAGS in non-GNU Makefile. It's useful to be able to pass down options like -s and -j. Back-patch to 9.5, like commit a76200de. Discussion: https://postgr.es/m/CA%2BhUKG%2Be1M8-BbL%3DPqhTp6oO6XPO6%2Bs9WGQMLfbuZ%3DG9CtzyXg%40mail.gmail.com Branch -- REL_10_STABLE Details

pgsql: Don't unset MAKEFLAGS in non-GNU Makefile.

2019-06-24 Thread Thomas Munro
Don't unset MAKEFLAGS in non-GNU Makefile. It's useful to be able to pass down options like -s and -j. Back-patch to 9.5, like commit a76200de. Discussion: https://postgr.es/m/CA%2BhUKG%2Be1M8-BbL%3DPqhTp6oO6XPO6%2Bs9WGQMLfbuZ%3DG9CtzyXg%40mail.gmail.com Branch -- REL9_6_STABLE Details

pgsql: Don't unset MAKEFLAGS in non-GNU Makefile.

2019-06-24 Thread Thomas Munro
Don't unset MAKEFLAGS in non-GNU Makefile. It's useful to be able to pass down options like -s and -j. Back-patch to 9.5, like commit a76200de. Discussion: https://postgr.es/m/CA%2BhUKG%2Be1M8-BbL%3DPqhTp6oO6XPO6%2Bs9WGQMLfbuZ%3DG9CtzyXg%40mail.gmail.com Branch -- master Details ---

pgsql: Don't unset MAKEFLAGS in non-GNU Makefile.

2019-06-24 Thread Thomas Munro
Don't unset MAKEFLAGS in non-GNU Makefile. It's useful to be able to pass down options like -s and -j. Back-patch to 9.5, like commit a76200de. Discussion: https://postgr.es/m/CA%2BhUKG%2Be1M8-BbL%3DPqhTp6oO6XPO6%2Bs9WGQMLfbuZ%3DG9CtzyXg%40mail.gmail.com Branch -- REL_11_STABLE Details

pgsql: Remove unnecessary comment.

2019-06-23 Thread Thomas Munro
Remove unnecessary comment. Author: Vik Fearing Discussion: https://postgr.es/m/150d3e9f-c7ec-3fb3-4fdb-def47c4144af%402ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/89ff7c08eee355195eba6f544d28584e61200665 Modified Files --

pgsql: Remove obsolete comments about sempahores from proc.c.

2019-06-20 Thread Thomas Munro
Remove obsolete comments about sempahores from proc.c. Commit 675f switched from a semaphore-based wait to a latch-based wait for ProcSleep()/ProcWakeup(), but left behind some stray references to semaphores. Back-patch to 9.5. Reviewed-by: Daniel Gustafsson, Michael Paquier Discussion:

pgsql: Remove obsolete comments about sempahores from proc.c.

2019-06-20 Thread Thomas Munro
Remove obsolete comments about sempahores from proc.c. Commit 675f switched from a semaphore-based wait to a latch-based wait for ProcSleep()/ProcWakeup(), but left behind some stray references to semaphores. Back-patch to 9.5. Reviewed-by: Daniel Gustafsson, Michael Paquier Discussion:

pgsql: Remove obsolete comments about sempahores from proc.c.

2019-06-20 Thread Thomas Munro
Remove obsolete comments about sempahores from proc.c. Commit 675f switched from a semaphore-based wait to a latch-based wait for ProcSleep()/ProcWakeup(), but left behind some stray references to semaphores. Back-patch to 9.5. Reviewed-by: Daniel Gustafsson, Michael Paquier Discussion:

pgsql: Remove obsolete comments about sempahores from proc.c.

2019-06-20 Thread Thomas Munro
Remove obsolete comments about sempahores from proc.c. Commit 675f switched from a semaphore-based wait to a latch-based wait for ProcSleep()/ProcWakeup(), but left behind some stray references to semaphores. Back-patch to 9.5. Reviewed-by: Daniel Gustafsson, Michael Paquier Discussion:

pgsql: Remove obsolete comments about sempahores from proc.c.

2019-06-20 Thread Thomas Munro
Remove obsolete comments about sempahores from proc.c. Commit 675f switched from a semaphore-based wait to a latch-based wait for ProcSleep()/ProcWakeup(), but left behind some stray references to semaphores. Back-patch to 9.5. Reviewed-by: Daniel Gustafsson, Michael Paquier Discussion:

pgsql: Update copyright year.

2019-05-23 Thread Thomas Munro
Update copyright year. Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CA%2BhUKGJFWXmtYo6Frd77RR8YXCHz7hJ2mRy5aHV%3D7fJOqDnBHA%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4c9210f34c621639f896d57cf7bfb5e9be139c91 Modified Files

pgsql: Fix typos.

2019-05-23 Thread Thomas Munro
Fix typos. Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CA%2BhUKGJFWXmtYo6Frd77RR8YXCHz7hJ2mRy5aHV%3D7fJOqDnBHA%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7988cb446d20512ec9d091db66dba6adee3f3d4b Modified Files --

pgsql: Fix SxactGlobalXmin tracking.

2019-05-09 Thread Thomas Munro
are effectively leaked. Revert that hunk of the commit. Also revert another similar hunk that was probably harmless, but unnecessary and unjustified, relating to the DOOMED flag in case of RO_SAFE early release. Author: Thomas Munro Reported-by: Tom Lane Discussion: https://postgr.es/m/16170.1557251214

pgsql: Probe only 127.0.0.1 when looking for ports on Unix.

2019-05-08 Thread Thomas Munro
Probe only 127.0.0.1 when looking for ports on Unix. Commit c0985099, later adjusted by commit 4ab02e81, probed 0.0.0.0 in addition to 127.0.0.1, for the benefit of Windows build farm animals. It isn't really useful on Unix systems, and turned out to be a bit inconvenient to users of some

pgsql: Probe only 127.0.0.1 when looking for ports on Unix.

2019-05-08 Thread Thomas Munro
Probe only 127.0.0.1 when looking for ports on Unix. Commit c0985099, later adjusted by commit 4ab02e81, probed 0.0.0.0 in addition to 127.0.0.1, for the benefit of Windows build farm animals. It isn't really useful on Unix systems, and turned out to be a bit inconvenient to users of some

pgsql: Probe only 127.0.0.1 when looking for ports on Unix.

2019-05-08 Thread Thomas Munro
Probe only 127.0.0.1 when looking for ports on Unix. Commit c0985099, later adjusted by commit 4ab02e81, probed 0.0.0.0 in addition to 127.0.0.1, for the benefit of Windows build farm animals. It isn't really useful on Unix systems, and turned out to be a bit inconvenient to users of some

pgsql: Probe only 127.0.0.1 when looking for ports on Unix.

2019-05-08 Thread Thomas Munro
Probe only 127.0.0.1 when looking for ports on Unix. Commit c0985099, later adjusted by commit 4ab02e81, probed 0.0.0.0 in addition to 127.0.0.1, for the benefit of Windows build farm animals. It isn't really useful on Unix systems, and turned out to be a bit inconvenient to users of some

pgsql: Fix copy-and-paste mistakes in documentation.

2019-05-08 Thread Thomas Munro
Fix copy-and-paste mistakes in documentation. Reported-by: Vik Fearing Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/098344be663f5fc0ad166e7a9e1cd37721ee34d9 Modified Files -- doc/src/sgml/ref/create_table.sgml| 2 +-

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-07 Thread Thomas Munro
On Tue, May 7, 2019 at 11:02 AM Bruce Momjian wrote: > https://git.postgresql.org/pg/commitdiff/bdf595adbca195fa54a909c74a5233ebc30641a1 > +Use pread() and pwrite() for random I/O (Thomas Munro) Hi Bruce, For this one, can we please add Oskari Saarenmaa as first author, and keep me as

pgsql: Fix GetNewTransactionId()'s interaction with xidVacLimit.

2019-04-11 Thread Thomas Munro
that commit, also fix the size computation used by EstimateTransactionStateSize() and switch to the mul_size() macro traditionally used in such expressions. Author: Thomas Munro Reported-by: Roman Zharkov Discussion: https://postgr.es/m/15727-0be246e7d852d229%40postgresql.org Branch -- master

Re: pgsql: Fix declaration after statement

2019-04-10 Thread Thomas Munro
bleeding edge llvm head) and they both seem to ignore -Wdeclaration-after-statement. GCC 8 warns for my test program. [1] https://en.wikipedia.org/wiki/Xcode#Latest_versions -- Thomas Munro https://enterprisedb.com

Re: pgsql: Fix memory leak in pgbench

2019-04-10 Thread Thomas Munro
still obey that rule. > > Ah, thanks I missed that bit from the docs. I should have paid more > attention. I am sure that Álvaro will address your patch in a timely > manner. . o O ( Is it time to run with -Werror on some BF animals yet? ) -- Thomas Munro https://enterprisedb.com

pgsql: Improve comment in sync.h.

2019-04-09 Thread Thomas Munro
Improve comment in sync.h. Per off-list complaint from Andres Freund. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d614aae02e8f878438716b7fd2642b8240b3f2b3 Modified Files -- src/include/storage/sync.h | 4 ++-- 1 file changed, 2 insertions(+), 2

pgsql: Fix typos.

2019-04-09 Thread Thomas Munro
Fix typos. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/255044889d419354b46a2bf8907b83507d695af5 Modified Files -- src/backend/executor/execTuples.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgsql: Wake up interested backends when a checkpoint fails.

2019-04-05 Thread Thomas Munro
Wake up interested backends when a checkpoint fails. Commit c6c9474a switched to condition variables instead of sleep loops to notify backends of checkpoint start and stop, but forgot to broadcast in case of checkpoint failure. Author: Thomas Munro Discussion: https://postgr.es/m/CA%2BhUKGJKbCd

pgsql: Fix bugs in mdsyncfiletag().

2019-04-04 Thread Thomas Munro
(). Author: Thomas Munro Discussion: https://postgr.es/m/CA%2BhUKGL%2BYLUOA0eYiBXBfwW%2BbH5kFgh94%3DgQH0jHEJ-t5Y91wQ%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/794c543b1736f71ff5bc5231eee41cdf460ad8ce Modified Files -- src/backend/storage

pgsql: Refactor the fsync queue for wider use.

2019-04-04 Thread Thomas Munro
). Author: Shawn Debnath and Thomas Munro Reviewed-by: Thomas Munro, Andres Freund Discussion: https://postgr.es/m/CAEepm=2gTANm=e3ARnJT=n0h8hf88wqmazxk0jykxw+b21f...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3eb77eba5a51780d5cf52cd66a9844cd4d26feb0

pgsql: Add wal_recycle and wal_init_zero GUCs.

2019-04-01 Thread Thomas Munro
independently and make only very general statements in the docs. Author: Jerry Jelinek, with some adjustments by Thomas Munro Reviewed-by: Alvaro Herrera, Andres Freund, Tomas Vondra, Robert Haas and others Discussion: https://postgr.es/m/CACPQ5Fo00QR7LNAcd1ZjgoBi4y97%2BK760YABs0vQHH5dLdkkMA

Re: pgsql: Compute XID horizon for page level index vacuum on primary.

2019-04-01 Thread Thomas Munro
On Sat, Mar 30, 2019 at 11:32 PM Thomas Munro wrote: > Here's an attempt to write a suitable comment for the quick fix. And > I suppose effective_io_concurrency is a reasonable default. Pushed. -- Thomas Munro https://enterprisedb.com

pgsql: Fix deadlock in heap_compute_xid_horizon_for_tuples().

2019-04-01 Thread Thomas Munro
Fix deadlock in heap_compute_xid_horizon_for_tuples(). We can't call code that uses syscache while we hold buffer locks on a catalog relation. If passed such a relation, just fall back to the general effective_io_concurrency GUC rather than trying to look up the containing tablespace's IO

Re: pgsql: Compute XID horizon for page level index vacuum on primary.

2019-03-30 Thread Thomas Munro
s a way to narrow this to just GLOBALTABLESPACE_OID since that's where pg_tablespace lives, but that doesn't work, we access other catalog too in that path. Hmm, it seems a bit odd that 0 is supposed to mean "disable issuance of asynchronous I/O requests" according to config

Re: pgsql: Use FullTransactionId for the transaction stack.

2019-03-28 Thread Thomas Munro
ed the patch. Right, thanks. Pushed. -- Thomas Munro https://enterprisedb.com

pgsql: Fix typo.

2019-03-28 Thread Thomas Munro
Fix typo. Author: Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7e69323bf72a924fd1b04a7a91da343a0cda91cf Modified Files -- src/backend/access/transam/xact.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Add basic infrastructure for 64 bit transaction IDs.

2019-03-27 Thread Thomas Munro
transaction IDs in more places. The new type is a struct that we pass by value, as a form of strong typedef. This prevents the sort of accidental confusion between TransactionId and FullTransactionId that would be possible if we were to use a plain old uint64. Author: Thomas Munro Reported-by: Amit

pgsql: Use FullTransactionId for the transaction stack.

2019-03-27 Thread Thomas Munro
time later before the 32 bit xid counter wraps around. Use a new struct to serialize the transaction state for parallel query, because FullTransactionId doesn't fit into the previous serialization scheme very well. Author: Thomas Munro Reviewed-by: Heikki Linnakangas Discussion: https://postgr.es

Re: pgsql: Compute XID horizon for page level index vacuum on primary.

2019-03-27 Thread Thomas Munro
argc=8, argv=0xffbfe608) at main.c:228 frame #57: 0x080bf5eb postgres`_start1(cleanup=0x28b1e540, argc=8, argv=0xffbfe608) at crt1_c.c:73 frame #58: 0x080bf4b8 postgres`_start at crt1_s.S:49 (lldb) print num_held_lwlocks (int) $0 = 1 (lldb) print held_lwlocks[0] (LWLockHandle) $1 = { lock = 0x295365a4 mode = LW_EXCLUSIVE } -- Thomas Munro https://enterprisedb.com

pgsql: Fix off-by-one error in txid_status().

2019-03-27 Thread Thomas Munro
aining the word "last" instead of "next", so fix that too. Back-patch to 10 where the function arrived. Author: Thomas Munro Discussion: https://postgr.es/m/CA%2BhUKG%2Buua_BV5cyfsioKVN2d61Lukg28ECsWTXKvh%3DBtN2DPA%40mail.gmail.com Branch -- REL_10_STABLE Details --- htt

pgsql: Fix off-by-one error in txid_status().

2019-03-27 Thread Thomas Munro
aining the word "last" instead of "next", so fix that too. Back-patch to 10 where the function arrived. Author: Thomas Munro Discussion: https://postgr.es/m/CA%2BhUKG%2Buua_BV5cyfsioKVN2d61Lukg28ECsWTXKvh%3DBtN2DPA%40mail.gmail.com Branch -- master Details --- htt

pgsql: Fix off-by-one error in txid_status().

2019-03-27 Thread Thomas Munro
aining the word "last" instead of "next", so fix that too. Back-patch to 10 where the function arrived. Author: Thomas Munro Discussion: https://postgr.es/m/CA%2BhUKG%2Buua_BV5cyfsioKVN2d61Lukg28ECsWTXKvh%3DBtN2DPA%40mail.gmail.com Branch -- REL_11_STABLE Details --- htt

pgsql: Add MacPorts support to src/test/ldap tests.

2019-03-25 Thread Thomas Munro
Add MacPorts support to src/test/ldap tests. Previously the test knew how to find an OpenLDAP installation at the paths used by Homebrew. Add the MacPorts paths too. Author: Thomas Munro Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CA%2BhUKGKrjGS7sO4jc53gp3qipCtEvThtdP_

pgsql: Add DNS SRV support for LDAP server discovery.

2019-03-20 Thread Thomas Munro
). Author: Thomas Munro Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/CAEepm=2hAnSfhdsd6vXsM6VZVN0br-FbAZ-O+Swk18S5HkCP=a...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0f086f84ad9041888b789af5871c7432f0e19c5b Modified Files

pgsql: Enable parallel query with SERIALIZABLE isolation.

2019-03-14 Thread Thomas Munro
the serializable_okay flag added to CreateParallelContext() by commit 9da0cc35, because it's now redundant. Author: Thomas Munro Reviewed-by: Haribabu Kommi, Robert Haas, Masahiko Sawada, Kevin Grittner Discussion: https://postgr.es/m/CAEepm=0gXGYhtrVDWOTHS8SQQy_=S9xo+8oCxGLWZAOoeJ=y

Re: pgsql: Use condition variables to wait for checkpoints.

2019-03-13 Thread Thomas Munro
On Thu, Mar 14, 2019 at 11:02 AM Thomas Munro wrote: > Use condition variables to wait for checkpoints. BF animal "loach" is blaming a recoveryCheck failure in 016_min_conistency on this commit. I wonder if there some timing dependency in that new test that broke when CHECKPOINT

pgsql: Use condition variables to wait for checkpoints.

2019-03-13 Thread Thomas Munro
Use condition variables to wait for checkpoints. Previously we used a polling/sleeping loop to wait for checkpoints to begin and end, which leads to up to a couple hundred milliseconds of needless thumb-twiddling. Use condition variables instead. Author: Thomas Munro Reviewed-by: Andres Freund

Re: pgsql: Fix minor deficiencies in XMLTABLE, xpath(), xmlexists()

2019-03-08 Thread Thomas Munro
On Fri, Mar 8, 2019 at 9:14 PM Thomas Munro wrote: > On Fri, Mar 8, 2019 at 10:20 AM Alvaro Herrera > wrote: > > Fix minor deficiencies in XMLTABLE, xpath(), xmlexists() > > This seems to have caused lapwing and grison to crash: Oh, sorry for the noise, I see this was

Re: pgsql: Fix minor deficiencies in XMLTABLE, xpath(), xmlexists()

2019-03-08 Thread Thomas Munro
s.c:4256 #18 0x080c52b7 in BackendRun (port=) at postmaster.c:4399 #19 BackendStartup (port=0x9e5a2c0) at postmaster.c:4090 #20 ServerLoop () at postmaster.c:1703 #21 0x083a4dab in PostmasterMain (argc=argc@entry=8, argv=argv@entry=0x9e324d8) at postmaster.c:1376 #22 0x080c6fd2 in main (argc=8, argv=0x9e3

pgsql: Remove useless header inclusion.

2019-03-06 Thread Thomas Munro
Remove useless header inclusion. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/42210524cca3a6d3161bcef9d9e687c7c1f5f6c4 Modified Files -- src/include/storage/smgr.h | 1 - 1 file changed, 1 deletion(-)

pgsql: Drop the vestigial "smgr" type.

2019-03-06 Thread Thomas Munro
Drop the vestigial "smgr" type. Before commit 3fa2bb31 this type appeared in the catalogs to select which of several block storage mechanisms each relation used. New features under development propose to revive the concept of different block storage managers for new kinds of data accessed via

pgsql: Fix inconsistent out-of-memory error reporting in dsa.c.

2019-02-24 Thread Thomas Munro
allocation failure in one code path, but as a FATAL condition in another. Back-patch to 10, where dsa.c landed. Author: Thomas Munro Reported-by: Jakub Glapa Discussion: https://postgr.es/m/CAEepm=2oPqXxyWQ-1o60tpOLrwkw=vpgnxqqf1vn2eyo9zk...@mail.gmail.com Branch -- REL_10_STABLE Details ---

pgsql: Fix inconsistent out-of-memory error reporting in dsa.c.

2019-02-24 Thread Thomas Munro
allocation failure in one code path, but as a FATAL condition in another. Back-patch to 10, where dsa.c landed. Author: Thomas Munro Reported-by: Jakub Glapa Discussion: https://postgr.es/m/CAEepm=2oPqXxyWQ-1o60tpOLrwkw=vpgnxqqf1vn2eyo9zk...@mail.gmail.com Branch -- REL_11_STABLE Details ---

pgsql: Fix inconsistent out-of-memory error reporting in dsa.c.

2019-02-24 Thread Thomas Munro
allocation failure in one code path, but as a FATAL condition in another. Back-patch to 10, where dsa.c landed. Author: Thomas Munro Reported-by: Jakub Glapa Discussion: https://postgr.es/m/CAEepm=2oPqXxyWQ-1o60tpOLrwkw=vpgnxqqf1vn2eyo9zk...@mail.gmail.com Branch -- master Details ---

pgsql: Tolerate EINVAL when calling fsync() on a directory.

2019-02-24 Thread Thomas Munro
Tolerate EINVAL when calling fsync() on a directory. Previously, we tolerated EBADF as a way for the operating system to indicate that it doesn't support fsync() on a directory. Tolerate EINVAL too, for older versions of Linux CIFS. Bug #15636. Back-patch all the way. Reported-by: John Klann

pgsql: Tolerate EINVAL when calling fsync() on a directory.

2019-02-24 Thread Thomas Munro
Tolerate EINVAL when calling fsync() on a directory. Previously, we tolerated EBADF as a way for the operating system to indicate that it doesn't support fsync() on a directory. Tolerate EINVAL too, for older versions of Linux CIFS. Bug #15636. Back-patch all the way. Reported-by: John Klann

pgsql: Tolerate EINVAL when calling fsync() on a directory.

2019-02-24 Thread Thomas Munro
Tolerate EINVAL when calling fsync() on a directory. Previously, we tolerated EBADF as a way for the operating system to indicate that it doesn't support fsync() on a directory. Tolerate EINVAL too, for older versions of Linux CIFS. Bug #15636. Back-patch all the way. Reported-by: John Klann

pgsql: Tolerate EINVAL when calling fsync() on a directory.

2019-02-24 Thread Thomas Munro
Tolerate EINVAL when calling fsync() on a directory. Previously, we tolerated EBADF as a way for the operating system to indicate that it doesn't support fsync() on a directory. Tolerate EINVAL too, for older versions of Linux CIFS. Bug #15636. Back-patch all the way. Reported-by: John Klann

pgsql: Tolerate ENOSYS failure from sync_file_range().

2019-02-24 Thread Thomas Munro
. Back-patch to 9.6 (older branches were not affected in this way by 9ccdd7f6). Author: Thomas Munro and James Sewell Tested-by: James Sewell Reported-by: Bruce Klein Discussion: https://postgr.es/m/ca+mcpegfouph2u4zadtqt16dfbkjjynjl1bstwersazafjq...@mail.gmail.com Branch -- REL_10_STABLE

pgsql: Tolerate ENOSYS failure from sync_file_range().

2019-02-24 Thread Thomas Munro
. Back-patch to 9.6 (older branches were not affected in this way by 9ccdd7f6). Author: Thomas Munro and James Sewell Tested-by: James Sewell Reported-by: Bruce Klein Discussion: https://postgr.es/m/ca+mcpegfouph2u4zadtqt16dfbkjjynjl1bstwersazafjq...@mail.gmail.com Branch -- REL_11_STABLE

pgsql: Tolerate ENOSYS failure from sync_file_range().

2019-02-24 Thread Thomas Munro
. Back-patch to 9.6 (older branches were not affected in this way by 9ccdd7f6). Author: Thomas Munro and James Sewell Tested-by: James Sewell Reported-by: Bruce Klein Discussion: https://postgr.es/m/ca+mcpegfouph2u4zadtqt16dfbkjjynjl1bstwersazafjq...@mail.gmail.com Branch -- REL9_6_STABLE

pgsql: Tolerate ENOSYS failure from sync_file_range().

2019-02-24 Thread Thomas Munro
. Back-patch to 9.6 (older branches were not affected in this way by 9ccdd7f6). Author: Thomas Munro and James Sewell Tested-by: James Sewell Reported-by: Bruce Klein Discussion: https://postgr.es/m/ca+mcpegfouph2u4zadtqt16dfbkjjynjl1bstwersazafjq...@mail.gmail.com Branch -- master Details

pgsql: Fix race in dsm_unpin_segment() when handles are reused.

2019-02-17 Thread Thomas Munro
10, where dsm_unpin_segment() landed. Author: Thomas Munro Reported-by: Justin Pryzby Tested-by: Justin Pryzby (along with other recent DSA/DSM fixes) Discussion: https://postgr.es/m/20190216023854.gf30...@telsasoft.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/

pgsql: Fix race in dsm_unpin_segment() when handles are reused.

2019-02-17 Thread Thomas Munro
10, where dsm_unpin_segment() landed. Author: Thomas Munro Reported-by: Justin Pryzby Tested-by: Justin Pryzby (along with other recent DSA/DSM fixes) Discussion: https://postgr.es/m/20190216023854.gf30...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/

pgsql: Fix race in dsm_unpin_segment() when handles are reused.

2019-02-17 Thread Thomas Munro
10, where dsm_unpin_segment() landed. Author: Thomas Munro Reported-by: Justin Pryzby Tested-by: Justin Pryzby (along with other recent DSA/DSM fixes) Discussion: https://postgr.es/m/20190216023854.gf30...@telsasoft.com Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/

pgsql: Fix race in dsm_attach() when handles are reused.

2019-02-14 Thread Thomas Munro
f-deadlock in the error path. It's not yet clear if further changes are needed to avoid that failure mode. Back-patch to 9.4, where dsm.c arrived. Author: Thomas Munro Reported-by: Justin Pryzby, Sergei Kornilov Discussion: https://postgr.es/m/20190207014719.gj29...@telsasoft.com Discussion: https://postgr.

pgsql: Fix race in dsm_attach() when handles are reused.

2019-02-14 Thread Thomas Munro
f-deadlock in the error path. It's not yet clear if further changes are needed to avoid that failure mode. Back-patch to 9.4, where dsm.c arrived. Author: Thomas Munro Reported-by: Justin Pryzby, Sergei Kornilov Discussion: https://postgr.es/m/20190207014719.gj29...@telsasoft.com Discussion: https://postgr.

pgsql: Fix race in dsm_attach() when handles are reused.

2019-02-14 Thread Thomas Munro
f-deadlock in the error path. It's not yet clear if further changes are needed to avoid that failure mode. Back-patch to 9.4, where dsm.c arrived. Author: Thomas Munro Reported-by: Justin Pryzby, Sergei Kornilov Discussion: https://postgr.es/m/20190207014719.gj29...@telsasoft.com Discussion: https://postgr.

pgsql: Fix race in dsm_attach() when handles are reused.

2019-02-14 Thread Thomas Munro
f-deadlock in the error path. It's not yet clear if further changes are needed to avoid that failure mode. Back-patch to 9.4, where dsm.c arrived. Author: Thomas Munro Reported-by: Justin Pryzby, Sergei Kornilov Discussion: https://postgr.es/m/20190207014719.gj29...@telsasoft.com Discussion: https://postgr.

pgsql: Fix rare dsa_allocate() failures due to freepage.c corruption.

2019-02-12 Thread Thomas Munro
). Author: Robert Haas Diagnosed-by: Thomas Munro and Robert Haas Reported-by: Justin Pryzby, Rick Otten, Sand Stone, Arne Roland and others Discussion: https://postgr.es/m/CAMAYy4%2Bw3NTBM5JLWFi8twhWK4%3Dk_5L4nV5%2BbYDSPu8r4b97Zg%40mail.gmail.com Branch -- REL_10_STABLE Details ---

pgsql: Fix rare dsa_allocate() failures due to freepage.c corruption.

2019-02-12 Thread Thomas Munro
). Author: Robert Haas Diagnosed-by: Thomas Munro and Robert Haas Reported-by: Justin Pryzby, Rick Otten, Sand Stone, Arne Roland and others Discussion: https://postgr.es/m/CAMAYy4%2Bw3NTBM5JLWFi8twhWK4%3Dk_5L4nV5%2BbYDSPu8r4b97Zg%40mail.gmail.com Branch -- master Details --- https://git.post

pgsql: Fix rare dsa_allocate() failures due to freepage.c corruption.

2019-02-12 Thread Thomas Munro
). Author: Robert Haas Diagnosed-by: Thomas Munro and Robert Haas Reported-by: Justin Pryzby, Rick Otten, Sand Stone, Arne Roland and others Discussion: https://postgr.es/m/CAMAYy4%2Bw3NTBM5JLWFi8twhWK4%3Dk_5L4nV5%2BbYDSPu8r4b97Zg%40mail.gmail.com Branch -- REL_11_STABLE Details ---

Re: pgsql: Use Getopt::Long for catalog scripts

2019-02-12 Thread Thomas Munro
.dat] Options: --output Output directory (default '.') --include-path Include path in source tree Does Solution.pm need to be tweaked? -- Thomas Munro http://www.enterprisedb.com

pgsql: Add shared_memory_type GUC.

2019-02-03 Thread Thomas Munro
for AIX, which requires System V shared memory and provided the motivation to revive this possibility. It may also be useful on some BSDs. Author: Andres Freund (revived and documented by Thomas Munro) Discussion: https://postgr.es/m/HE1PR0202MB28126DB4E0B6621CC6A1A91286D90%40HE1PR0202MB2812

pgsql: Add combining characters to unaccent.rules.

2019-02-01 Thread Thomas Munro
Add combining characters to unaccent.rules. Strip certain classes of combining characters, so that accents encoded this way are removed. Author: Hugh Ranalli Discussion: https://postgr.es/m/15548-cef1b3f8de190d4f%40postgresql.org Branch -- master Details ---

pgsql: Fix minor typo in dsa.c.

2018-11-28 Thread Thomas Munro
Fix minor typo in dsa.c. Author: Takeshi Ideriha Discussion: https://postgr.es/m/4E72940DA2BF16479384A86D54D0988A6F3BF22D%40G01JPEXMBKW04 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2e58a73a70d523b9eb426f77155bf206d8966259 Modified Files --

pgsql: Fix minor typo in dsa.c.

2018-11-28 Thread Thomas Munro
Fix minor typo in dsa.c. Author: Takeshi Ideriha Discussion: https://postgr.es/m/4E72940DA2BF16479384A86D54D0988A6F3BF22D%40G01JPEXMBKW04 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f7001b00a08f37bac306a6ae2028afb3dd2c5084 Modified Files --

pgsql: Don't set PAM_RHOST for Unix sockets.

2018-11-27 Thread Thomas Munro
ar that we shouldn't set it to an unresolvable name, so don't do that. Back-patch to 9.6. Bug #15520. Author: Thomas Munro Reviewed-by: Peter Eisentraut Reported-by: Albert Schabhuetl Discussion: https://postgr.es/m/15520-4c266f986998e1c5%40postgresql.org Branch -- REL_10_STABLE Details ---

pgsql: Don't set PAM_RHOST for Unix sockets.

2018-11-27 Thread Thomas Munro
ar that we shouldn't set it to an unresolvable name, so don't do that. Back-patch to 9.6. Bug #15520. Author: Thomas Munro Reviewed-by: Peter Eisentraut Reported-by: Albert Schabhuetl Discussion: https://postgr.es/m/15520-4c266f986998e1c5%40postgresql.org Branch -- REL_11_STABLE Details ---

pgsql: Don't set PAM_RHOST for Unix sockets.

2018-11-27 Thread Thomas Munro
ar that we shouldn't set it to an unresolvable name, so don't do that. Back-patch to 9.6. Bug #15520. Author: Thomas Munro Reviewed-by: Peter Eisentraut Reported-by: Albert Schabhuetl Discussion: https://postgr.es/m/15520-4c266f986998e1c5%40postgresql.org Branch -- master Details ---

pgsql: Don't count zero-filled buffers as 'read' in EXPLAIN.

2018-11-27 Thread Thomas Munro
with a separate counter, if they become more common due to future work. Author: Thomas Munro Reviewed-by: Haribabu Kommi, Kyotaro Horiguchi, David Rowley Discussion: https://postgr.es/m/CAEepm%3D3JytB3KPpvSwXzkY%2Bdwc5zC8P8Lk7Nedkoci81_0E9rA%40mail.gmail.com Branch -- master Details

<    5   6   7   8   9   10   11   12   >