Re: pgsql: Add TIDStore, to store sets of TIDs (ItemPointerData) efficientl

2024-03-25 Thread Masahiko Sawada
On Tue, Mar 26, 2024 at 12:22 PM John Naylor wrote: > > On Tue, Mar 26, 2024 at 9:36 AM Masahiko Sawada wrote: > > > > On Tue, Mar 26, 2024 at 7:16 AM David Rowley wrote: > > > > > > Either "max_bytes" is a bad name for this variable or the * 1024L > > > should be removed. > > > > > > > Right. W

Re: pgsql: Add TIDStore, to store sets of TIDs (ItemPointerData) efficientl

2024-03-25 Thread John Naylor
On Tue, Mar 26, 2024 at 9:36 AM Masahiko Sawada wrote: > > On Tue, Mar 26, 2024 at 7:16 AM David Rowley wrote: > > > > Either "max_bytes" is a bad name for this variable or the * 1024L > > should be removed. > > > > Right. We discussed it on the original thread too[1]. Since we're > going to chan

Re: pgsql: Add TIDStore, to store sets of TIDs (ItemPointerData) efficientl

2024-03-25 Thread Masahiko Sawada
On Tue, Mar 26, 2024 at 7:16 AM David Rowley wrote: > > On Thu, 21 Mar 2024 at 14:10, Masahiko Sawada wrote: > > > > Add TIDStore, to store sets of TIDs (ItemPointerData) efficiently. > > > src/backend/access/common/tidstore.c | 463 > > + > > I was looking at th

Re: pgsql: Add TIDStore, to store sets of TIDs (ItemPointerData) efficientl

2024-03-25 Thread David Rowley
On Thu, 21 Mar 2024 at 14:10, Masahiko Sawada wrote: > > Add TIDStore, to store sets of TIDs (ItemPointerData) efficiently. > src/backend/access/common/tidstore.c | 463 + I was looking at this code and I saw the following: /* choose the maxBlockSize to be no la

pgsql: Add TIDStore, to store sets of TIDs (ItemPointerData) efficientl

2024-03-20 Thread Masahiko Sawada
Add TIDStore, to store sets of TIDs (ItemPointerData) efficiently. TIDStore is a data structure designed to efficiently store large sets of TIDs. For TID storage, it employs a radix tree, where the key is a block number, and the value is a bitmap representing offset numbers. The TIDStore can be cr