Re: pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.

2019-08-27 Thread Michael Paquier
On Tue, Aug 27, 2019 at 11:38:28PM -0400, Tom Lane wrote: > Yeah, it might be a good idea to make a sweep to see what other tests > should be using safe_psql. I found more of these while browsing all the tests, so I am just going to start a new thread with a patch. > Or, more radically, we could

Re: pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.

2019-08-27 Thread Tom Lane
Michael Paquier writes: > On Mon, Aug 26, 2019 at 09:03:08PM +, Tom Lane wrote: >> Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET. > Just for the note. I think that this needs a closer lookup and I am > afraid that there are more issues like this one. Yeah, it might be a good id

Re: pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.

2019-08-27 Thread Michael Paquier
On Mon, Aug 26, 2019 at 09:03:08PM +, Tom Lane wrote: > Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET. > > If a test case tried to set an invalid value of synchronous_standby_names, > the test script didn't detect that, which seems like a bad idea. > Noticed while testing a propos

pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.

2019-08-26 Thread Tom Lane
Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET. If a test case tried to set an invalid value of synchronous_standby_names, the test script didn't detect that, which seems like a bad idea. Noticed while testing a proposed patch that broke some of these test cases. Branch -- master