Am 15.03.2018 um 23:57 schrieb Tom Lane:
> Oh ... duh. We've been assuming that the strtoint change broke it,
> but that's wrong. The test case that is failing is new as of yesterday,
> and the correct answer is that it's never worked on Windows. See
> ...
Correct, thanks for figuring this out
On Fri, Mar 16, 2018 at 1:12 PM, Tom Lane wrote:
> Alvaro Herrera writes:
> > ah, but bowerbird is OK on ecpg, this is only failing on thrips, whelk,
> > woodlouse. It sounds related to 32 vs. 64 bits ...
>
> BTW, the reason why bowerbird was green had nothing to do with 32
> or 64 bits, but ra
On Thu, Mar 15, 2018 at 10:37:06PM -0400, Tom Lane wrote:
> Seems sane AFAICT, so pushed. Thanks!
Thanks, Tom.
--
Michael
signature.asc
Description: PGP signature
Alvaro Herrera writes:
> ah, but bowerbird is OK on ecpg, this is only failing on thrips, whelk,
> woodlouse. It sounds related to 32 vs. 64 bits ...
BTW, the reason why bowerbird was green had nothing to do with 32
or 64 bits, but rather that it isn't running the ecpg tests:
'i
Michael Paquier writes:
> On Thu, Mar 15, 2018 at 06:57:27PM -0400, Tom Lane wrote:
>> I think what's wrong is that src/tools/msvc/ecpg_regression.proj
>> needs to be taught that tests under ecpg/test/compat-oracle need
>> to be run with "-C ORACLE". Neither that directory nor that
>> switch exis
On Thu, Mar 15, 2018 at 06:57:27PM -0400, Tom Lane wrote:
> I think what's wrong is that src/tools/msvc/ecpg_regression.proj
> needs to be taught that tests under ecpg/test/compat-oracle need
> to be run with "-C ORACLE". Neither that directory nor that
> switch existed before yesterday. There's
Oh ... duh. We've been assuming that the strtoint change broke it,
but that's wrong. The test case that is failing is new as of yesterday,
and the correct answer is that it's never worked on Windows. See
https://git.postgresql.org/gitweb/?p=postgresql.git&a=commitdiff&h=3b7ab4380440d7b14ee390fa
Alvaro Herrera writes:
> Tom Lane wrote:
>> build now works, ecpg tests fail.
> I stared at the code for a while, didn't notice anything amiss. I'm
> mystified. Peter?
I'm wondering if the Windows environment is somehow supplying a
"strtoint" that isn't actually ABI-compatible with ours.
A di
ah, but bowerbird is OK on ecpg, this is only failing on thrips, whelk,
woodlouse. It sounds related to 32 vs. 64 bits ...
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Tom Lane wrote:
> Alvaro Herrera writes:
> > Michael Paquier wrote:
> >> Attached is a patch which fixes the compilation failure on Windows for
> >> me. That should put the buildfarm back to green.
>
> > Pushed, thanks -- let's see how that goes.
>
> build now works, ecpg tests fail.
I stared
Alvaro Herrera writes:
> Michael Paquier wrote:
>> Attached is a patch which fixes the compilation failure on Windows for
>> me. That should put the buildfarm back to green.
> Pushed, thanks -- let's see how that goes.
build now works, ecpg tests fail.
regards, tom lane
Michael Paquier wrote:
> Attached is a patch which fixes the compilation failure on Windows for
> me. That should put the buildfarm back to green.
Pushed, thanks -- let's see how that goes.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remo
On Wed, Mar 14, 2018 at 11:23:35AM -0400, Tom Lane wrote:
> Peter Eisentraut writes:
> > I think the problem is rather that we somehow need to tell it to link
> > src/common/string.c into pgtypeslib.
>
> Yeah, that's what I supposed.
>
> Looking at pgtypeslib, there's already infrastructure for
Peter Eisentraut writes:
> I think the problem is rather that we somehow need to tell it to link
> src/common/string.c into pgtypeslib.
Yeah, that's what I supposed.
Looking at pgtypeslib, there's already infrastructure for collecting
stuff from src/port/, and I see you added some for src/common
On 3/13/18 21:10, David Rowley wrote:
> On 14 March 2018 at 08:10, Tom Lane wrote:
>> Peter Eisentraut writes:
>>> Move strtoint() to common
>>
>> Buildfarm seems to think this isn't quite baked for Windows.
>
> Yeah, "restrict" seems to be C99, and the Microsoft compilers don't
> quite know abo
On 14 March 2018 at 08:10, Tom Lane wrote:
> Peter Eisentraut writes:
>> Move strtoint() to common
>
> Buildfarm seems to think this isn't quite baked for Windows.
Yeah, "restrict" seems to be C99, and the Microsoft compilers don't
quite know about that yet. The attached compiles fine for me on
Peter Eisentraut writes:
> Move strtoint() to common
Buildfarm seems to think this isn't quite baked for Windows.
regards, tom lane
Move strtoint() to common
Several places used similar code to convert a string to an int, so take
the function that we already had and make it globally available.
Reviewed-by: Michael Paquier
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/17bb62501787c56e0518e61d
18 matches
Mail list logo
