[COMMITTERS] pgsql: C comment update: relfilenode is only unique with a tablespace

2014-03-05 Thread Bruce Momjian
C comment update: relfilenode is only unique with a tablespace Report from Antonin Houska Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0024a3a3b6cfdca9d5c00f8ac5d5809f2e7ec3a5 Modified Files -- src/include/storage/relfilenode.h |2 +- 1 file change

[COMMITTERS] pgsql: docs: to_timestamp and to_date do minimal range checking

2014-03-05 Thread Bruce Momjian
docs: to_timestamp and to_date do minimal range checking Initial patch from Steve Crawford Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e2224faf17abb6b3cde0af33346835cc013fb1c0 Modified Files -- doc/src/sgml/func.sgml | 14 ++ 1 file cha

[COMMITTERS] pgsql: pg_dump: make argument combination error exit code consistent

2014-03-05 Thread Bruce Momjian
pg_dump: make argument combination error exit code consistent Per report from Pavel Golub Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b44fc39fcecf58c1c93a322d71be2faee525853f Modified Files -- src/bin/pg_dump/pg_dump.c | 10 -- 1 file chang

[COMMITTERS] pgsql: Fix portability issues in recently added make_timestamp/make_int

2014-03-05 Thread Tom Lane
Fix portability issues in recently added make_timestamp/make_interval code. Explicitly reject infinity/NaN inputs, rather than just assuming that something else will do it for us. Per buildfarm. While at it, make some over-parenthesized and under-legible code more readable. Branch -- master

[COMMITTERS] pgsql: Add comment that ec_relids excludes "child" EquivalenceClass mem

2014-03-05 Thread Tom Lane
Add comment that ec_relids excludes "child" EquivalenceClass members. This was already documented a few lines further down, but the comment just beside the field declaration could be misleading. Per gripe from Kyotaro Horiguchi. Branch -- master Details --- http://git.postgresql.org/pg/

[COMMITTERS] pgsql: Fix some typos introduced by the logical decoding patch.

2014-03-05 Thread Robert Haas
Fix some typos introduced by the logical decoding patch. Erik Rijkers Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/406a1a9ef0beb0a7e3f58805ab2d3140e2202deb Modified Files -- src/backend/replication/logical/decode.c|2 +- src/backend/replica

[COMMITTERS] pgsql: Fix test_decoding regression test outputs.

2014-03-05 Thread Robert Haas
Fix test_decoding regression test outputs. Commit 6f37c08057685ee3c6c63222dba0dac012760dde removed whitespace from the SQL file but not the expected-output file, and commit 7e8db2dc420099df3fa73987cf2d2d6d1a609d86 changed the error message without updating the expected outputs. Branch -- mast

Re: [COMMITTERS] pgsql: Fix whitespace

2014-03-05 Thread Robert Haas
On Tue, Mar 4, 2014 at 9:53 PM, Peter Eisentraut wrote: > Fix whitespace If you're going to do this, you need to update the expected file as well. Otherwise, the tests fail. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committe

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-03-05 Thread Thom Brown
On 25 February 2014 16:25, Robert Haas wrote: > Since Fujii Masao doesn't seem to be around, I'll commit this. But > don't we need to update the documentation as well, for those using the > file-copy method of taking a backup? > Yes, that sounds like a sensible idea. -- Thom

[COMMITTERS] pgsql: Remove unused field "evttype".

2014-03-05 Thread Tom Lane
Remove unused field "evttype". Apparent oversight in commit 3855968f. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/114b26c06fb93d74afd6993d4be49b5b3e960979 Modified Files -- src/bin/pg_dump/pg_dump.h |1 - 1 file changed, 1 deletion(-) -- Sent v

[COMMITTERS] pgsql: Remove the correct pgstat file on DROP DATABASE

2014-03-05 Thread Alvaro Herrera
Remove the correct pgstat file on DROP DATABASE We were unlinking the permanent file, not the non-permanent one. But since the stat collector already unlinks all permanent files on startup, there was nothing for it to unlink. The non-permanent file remained in place, and was copied to the perman

[COMMITTERS] pgsql: Remove the correct pgstat file on DROP DATABASE

2014-03-05 Thread Alvaro Herrera
Remove the correct pgstat file on DROP DATABASE We were unlinking the permanent file, not the non-permanent one. But since the stat collector already unlinks all permanent files on startup, there was nothing for it to unlink. The non-permanent file remained in place, and was copied to the perman

[COMMITTERS] pgsql: pg_upgrade: improve C comment about what old/new oids match

2014-03-05 Thread Bruce Momjian
pg_upgrade: improve C comment about what old/new oids match Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/65b96714118d3919195d2dd47e8d2df23718c7ab Modified Files -- contrib/pg_upgrade/pg_upgrade.c | 13 ++--- 1 file changed, 6 insertions(+), 7

[COMMITTERS] pgsql: Allocate fresh memory for post_opts/exec_path

2014-03-05 Thread Stephen Frost
Allocate fresh memory for post_opts/exec_path Instead of having read_post_opts() depend on the memory allocated for the config file (which is now getting free'd), pg_strdup() for post_opts and exec_path (similar to how it's being done elsewhere). Noted by Thom Brown. Branch -- master Detail

Re: [COMMITTERS] pgsql: Fix issues with pg_ctl

2014-03-05 Thread Stephen Frost
* Thom Brown (t...@linux.com) wrote: > On 5 March 2014 06:33, Stephen Frost wrote: > > Fix issues with pg_ctl [...] > thom@swift ~/dbtest $ sh: 1: ���: not found Yeesh. Always with the simple ones it seems. Yeah, I see what the issue here is, will fix. Thanks! Stephen signature.asc

[COMMITTERS] pgsql: Do wal_level and hot standby checks when doing crash-then-archiv

2014-03-05 Thread Heikki Linnakangas
Do wal_level and hot standby checks when doing crash-then-archive recovery. CheckRequiredParameterValues() should perform the checks if archive recovery was requested, even if we are going to perform crash recovery first. Reported by Kyotaro HORIGUCHI. Backpatch to 9.2, like the crash-then-archiv

[COMMITTERS] pgsql: Do wal_level and hot standby checks when doing crash-then-archiv

2014-03-05 Thread Heikki Linnakangas
Do wal_level and hot standby checks when doing crash-then-archive recovery. CheckRequiredParameterValues() should perform the checks if archive recovery was requested, even if we are going to perform crash recovery first. Reported by Kyotaro HORIGUCHI. Backpatch to 9.2, like the crash-then-archiv

[COMMITTERS] pgsql: Do wal_level and hot standby checks when doing crash-then-archiv

2014-03-05 Thread Heikki Linnakangas
Do wal_level and hot standby checks when doing crash-then-archive recovery. CheckRequiredParameterValues() should perform the checks if archive recovery was requested, even if we are going to perform crash recovery first. Reported by Kyotaro HORIGUCHI. Backpatch to 9.2, like the crash-then-archiv

[COMMITTERS] pgsql: Fix lastReplayedEndRecPtr calculation when starting from shutdow

2014-03-05 Thread Heikki Linnakangas
Fix lastReplayedEndRecPtr calculation when starting from shutdown checkpoint. When entering crash recovery followed by archive recovery, and the latest checkpoint is a shutdown checkpoint, and there are no more WAL records to replay before transitioning from crash to archive recovery, we would not

[COMMITTERS] pgsql: Fix lastReplayedEndRecPtr calculation when starting from shutdow

2014-03-05 Thread Heikki Linnakangas
Fix lastReplayedEndRecPtr calculation when starting from shutdown checkpoint. When entering crash recovery followed by archive recovery, and the latest checkpoint is a shutdown checkpoint, and there are no more WAL records to replay before transitioning from crash to archive recovery, we would not

[COMMITTERS] pgsql: Fix lastReplayedEndRecPtr calculation when starting from shutdow

2014-03-05 Thread Heikki Linnakangas
Fix lastReplayedEndRecPtr calculation when starting from shutdown checkpoint. When entering crash recovery followed by archive recovery, and the latest checkpoint is a shutdown checkpoint, and there are no more WAL records to replay before transitioning from crash to archive recovery, we would not

[COMMITTERS] pgsql: Fix lastReplayedEndRecPtr calculation when starting from shutdow

2014-03-05 Thread Heikki Linnakangas
Fix lastReplayedEndRecPtr calculation when starting from shutdown checkpoint. When entering crash recovery followed by archive recovery, and the latest checkpoint is a shutdown checkpoint, and there are no more WAL records to replay before transitioning from crash to archive recovery, we would not

[COMMITTERS] pgsql: Fix lastReplayedEndRecPtr calculation when starting from shutdow

2014-03-05 Thread Heikki Linnakangas
Fix lastReplayedEndRecPtr calculation when starting from shutdown checkpoint. When entering crash recovery followed by archive recovery, and the latest checkpoint is a shutdown checkpoint, and there are no more WAL records to replay before transitioning from crash to archive recovery, we would not

Re: [COMMITTERS] pgsql: Fix issues with pg_ctl

2014-03-05 Thread Thom Brown
On 5 March 2014 06:33, Stephen Frost wrote: > Fix issues with pg_ctl > > The new, small, free_readfile managed to have bug in it which could > cause it to try and free something it shouldn't, and fix the case > where it was being called with an invalid pointer leading to a > segfault. > > Noted b