Re: [COMMITTERS] pgsql: ICU support

2017-03-23 Thread Tom Lane
I wrote: > The buildfarm's mostly happy, but "prion" still isn't, which > suggests there's someplace in the new code that references an > already-closed relcache entry. Ah, scratch that, I was overthinking it. The problem is pretty clear from the error message: + ERROR: collation "en-x-icu" for

[COMMITTERS] pgsql: Avoid syntax error on platforms that have neither LOCALE_T nor I

2017-03-23 Thread Tom Lane
Avoid syntax error on platforms that have neither LOCALE_T nor ICU. Buildfarm member anole sees this union as empty, and doesn't like it. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/457a4448732881b5008f7a3bcca76fc299075ac3 Modified Files -- src/inclu

Re: [COMMITTERS] pgsql: ICU support

2017-03-23 Thread Tom Lane
The buildfarm's mostly happy, but "prion" still isn't, which suggests there's someplace in the new code that references an already-closed relcache entry. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your

[COMMITTERS] pgsql: doc: add missing closing 'sect3' tag for ICU patch

2017-03-23 Thread Bruce Momjian
doc: add missing closing 'sect3' tag for ICU patch Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/218747d2cf3cc1536ff77435e596280e0e739760 Modified Files -- doc/src/sgml/charset.sgml | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers m

[COMMITTERS] pgsql: Add ICU_FLAGS to one more place

2017-03-23 Thread Peter Eisentraut
Add ICU_FLAGS to one more place Reported-by: Thomas Munro Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2e0c17dc7809992e37441a4e39072373f5d99e0d Modified Files -- src/backend/snowball/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -

[COMMITTERS] pgsql: Fix crash in ICU patch

2017-03-23 Thread Peter Eisentraut
Fix crash in ICU patch This only happened with single-byte encodings. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/524e0f7ac8e143e377b8acff24796d7e37b3a9b1 Modified Files -- src/backend/utils/adt/like.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [COMMITTERS] pgsql: ICU support

2017-03-23 Thread Andrew Dunstan
On 03/23/2017 04:07 PM, Peter Eisentraut wrote: > On 3/23/17 15:33, Peter Eisentraut wrote: >> ICU support > Seeing some crashes on the build farm, investigating. If someone can > reproduce locally and get a backtrace, let me know. > The buildfarm actually does that :-) See for example

[COMMITTERS] pgsql: Fix enum definition.

2017-03-23 Thread Robert Haas
Fix enum definition. Commit 249cf070e36721a65be74838c53acf8249faf935 assigned to one of the labels in the middle the value that should have been assigned to the first member of the enum. Rushabh's patch didn't have that defect as submitted, but I managed to mess it up while editing. Repair. Bran

Re: [COMMITTERS] pgsql: ICU support

2017-03-23 Thread Peter Eisentraut
On 3/23/17 15:33, Peter Eisentraut wrote: > ICU support Seeing some crashes on the build farm, investigating. If someone can reproduce locally and get a backtrace, let me know. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Trainin

[COMMITTERS] pgsql: ICU support

2017-03-23 Thread Peter Eisentraut
ICU support Add a column collprovider to pg_collation that determines which library provides the collation data. The existing choices are default and libc, and this adds an icu choice, which uses the ICU4C library. The pg_locale_t type is changed to a union that contains the provider-specific lo

[COMMITTERS] pgsql: Track the oldest XID that can be safely looked up in CLOG.

2017-03-23 Thread Robert Haas
Track the oldest XID that can be safely looked up in CLOG. This provides infrastructure for looking up arbitrary, user-supplied XIDs without a risk of scary-looking failures from within the clog module. Normally, the oldest XID that can be safely looked up in CLOG is the same as the oldest XID th

[COMMITTERS] pgsql: Remove createlang and droplang

2017-03-23 Thread Peter Eisentraut
Remove createlang and droplang They have been deprecated since PostgreSQL 9.1. Reviewed-by: Magnus Hagander Reviewed-by: Daniel Gustafsson Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/50c956add83963d7bbb367dd0b879fccddebd623 Modified Files -- doc/s

[COMMITTERS] pgsql: Allow for parallel execution whenever ExecutorRun() is done only

2017-03-23 Thread Robert Haas
Allow for parallel execution whenever ExecutorRun() is done only once. Previously, it was unsafe to execute a plan in parallel if ExecutorRun() might be called with a non-zero row count. However, it's quite easy to fix things up so that we can support that case, provided that it is known that we

[COMMITTERS] pgsql: Reduce page locking in GIN vacuum

2017-03-23 Thread Teodor Sigaev
Reduce page locking in GIN vacuum GIN vacuum during cleaning posting tree can lock this whole tree for a long time with by holding LockBufferForCleanup() on root. Patch changes it with two ways: first, cleanup lock will be taken only if there is an empty page (which should be deleted) and, second,

Re: [COMMITTERS] pgsql: Logical replication support for initial data copy

2017-03-23 Thread Peter Eisentraut
On 3/23/17 10:25, Petr Jelinek wrote: > On 23/03/17 15:17, Stephen Frost wrote: >> Petr, >> >> * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: >>> On 23/03/17 14:47, Petr Jelinek wrote: I am looking into buildfarm failures. Looks like the clang issue (mylodon, longfin) is becaus

[COMMITTERS] pgsql: Remove trailing comma from enum definition

2017-03-23 Thread Peter Eisentraut
Remove trailing comma from enum definition Author: Petr Jelinek Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/73561013e5aa44a1669b2cb4351f5e2b29485efb Modified Files -- src/include/replication/walreceiver.h | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [COMMITTERS] pgsql: Logical replication support for initial data copy

2017-03-23 Thread Peter Eisentraut
On 3/23/17 10:12, Petr Jelinek wrote: > On 23/03/17 14:47, Petr Jelinek wrote: >> I am looking into buildfarm failures. >> >> Looks like the clang issue (mylodon, longfin) is because we are missing >> extern in include/replication/worker_internal.h for ApplyCacheContext. >> >> Still analyzing the r

[COMMITTERS] pgsql: Assorted compilation and test fixes

2017-03-23 Thread Peter Eisentraut
Assorted compilation and test fixes related to 7c4f52409a8c7d85ed169bbbc1f6092274d03920, per build farm Author: Petr Jelinek Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/128e6ee01dc9a8b7b0d3d3c8edc594ca9e51f993 Modified Files -- src/backend/nodes/co

[COMMITTERS] pgsql: Minor spelling correction in comment

2017-03-23 Thread Simon Riggs
Minor spelling correction in comment Jon Nelson Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/232c532213446701583e015ca55b5afb9c291445 Modified Files -- src/backend/utils/adt/network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

Re: [COMMITTERS] pgsql: Logical replication support for initial data copy

2017-03-23 Thread Petr Jelinek
On 23/03/17 15:17, Stephen Frost wrote: > Petr, > > * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: >> On 23/03/17 14:47, Petr Jelinek wrote: >>> I am looking into buildfarm failures. >>> >>> Looks like the clang issue (mylodon, longfin) is because we are missing >>> extern in include/replica

Re: [COMMITTERS] pgsql: Logical replication support for initial data copy

2017-03-23 Thread Stephen Frost
Petr, * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: > On 23/03/17 14:47, Petr Jelinek wrote: > > I am looking into buildfarm failures. > > > > Looks like the clang issue (mylodon, longfin) is because we are missing > > extern in include/replication/worker_internal.h for ApplyCacheContext.

Re: [COMMITTERS] pgsql: Logical replication support for initial data copy

2017-03-23 Thread Petr Jelinek
On 23/03/17 14:47, Petr Jelinek wrote: > I am looking into buildfarm failures. > > Looks like the clang issue (mylodon, longfin) is because we are missing > extern in include/replication/worker_internal.h for ApplyCacheContext. > > Still analyzing the rest. > Ah missing fields in copy/equal fun

[COMMITTERS] pgsql: Replication lag tracking for walsenders

2017-03-23 Thread Simon Riggs
Replication lag tracking for walsenders Adds write_lag, flush_lag and replay_lag cols to pg_stat_replication. Implements a lag tracker module that reports the lag times based upon measurements of the time taken for recent WAL to be written, flushed and replayed and for the sender to hear about it

Re: [COMMITTERS] pgsql: Logical replication support for initial data copy

2017-03-23 Thread Petr Jelinek
I am looking into buildfarm failures. Looks like the clang issue (mylodon, longfin) is because we are missing extern in include/replication/worker_internal.h for ApplyCacheContext. Still analyzing the rest. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development,

[COMMITTERS] pgsql: Logical replication support for initial data copy

2017-03-23 Thread Peter Eisentraut
Logical replication support for initial data copy Add functionality for a new subscription to copy the initial data in the tables and then sync with the ongoing apply process. For the copying, add a new internal COPY option to have the COPY source data provided by a callback function. The initia

[COMMITTERS] pgsql: Fix grammar in comment

2017-03-23 Thread Magnus Hagander
Fix grammar in comment Author: Emil Iggland Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/707576b571f05ec5b89adb65964d55f3bd1b Modified Files -- src/backend/commands/publicationcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent