Re: [COMMITTERS] pgsql: Fix document bug regarding read only transactions.

2017-06-15 Thread Tatsuo Ishii
> You're right that the statement is irrelevant in the context of what > a standby can or can't do, but what I'm worried about is that someone > will read it and believe that it represents the whole truth about > what read-only master transactions can do. The previous wording was > also irrelevant

[COMMITTERS] pgsql: Make configure check for IPC::Run when --enable-tap-tests is spe

2017-06-15 Thread Tom Lane
Make configure check for IPC::Run when --enable-tap-tests is specified. The TAP tests mostly don't work without IPC::Run, and the reason for the failure is not immediately obvious from the error messages you get. So teach configure to reject --enable-tap-tests unless IPC::Run exists. Mostly this j

[COMMITTERS] pgsql: Fix low-probability leaks of PGresult objects in the backend.

2017-06-15 Thread Tom Lane
Fix low-probability leaks of PGresult objects in the backend. We had three occurrences of essentially the same coding pattern wherein we tried to retrieve a query result from a libpq connection without blocking. In the case where PQconsumeInput failed (typically indicating a lost connection), all

[COMMITTERS] pgsql: Fix low-probability leaks of PGresult objects in the backend.

2017-06-15 Thread Tom Lane
Fix low-probability leaks of PGresult objects in the backend. We had three occurrences of essentially the same coding pattern wherein we tried to retrieve a query result from a libpq connection without blocking. In the case where PQconsumeInput failed (typically indicating a lost connection), all

[COMMITTERS] pgsql: Fix low-probability leaks of PGresult objects in the backend.

2017-06-15 Thread Tom Lane
Fix low-probability leaks of PGresult objects in the backend. We had three occurrences of essentially the same coding pattern wherein we tried to retrieve a query result from a libpq connection without blocking. In the case where PQconsumeInput failed (typically indicating a lost connection), all

[COMMITTERS] pgsql: Fix low-probability leaks of PGresult objects in the backend.

2017-06-15 Thread Tom Lane
Fix low-probability leaks of PGresult objects in the backend. We had three occurrences of essentially the same coding pattern wherein we tried to retrieve a query result from a libpq connection without blocking. In the case where PQconsumeInput failed (typically indicating a lost connection), all

[COMMITTERS] pgsql: Fix low-probability leaks of PGresult objects in the backend.

2017-06-15 Thread Tom Lane
Fix low-probability leaks of PGresult objects in the backend. We had three occurrences of essentially the same coding pattern wherein we tried to retrieve a query result from a libpq connection without blocking. In the case where PQconsumeInput failed (typically indicating a lost connection), all

[COMMITTERS] pgsql: Fix low-probability leaks of PGresult objects in the backend.

2017-06-15 Thread Tom Lane
Fix low-probability leaks of PGresult objects in the backend. We had three occurrences of essentially the same coding pattern wherein we tried to retrieve a query result from a libpq connection without blocking. In the case where PQconsumeInput failed (typically indicating a lost connection), all

[COMMITTERS] pgsql: doc: remove mention of Windows junction points by pg_upgrade

2017-06-15 Thread Bruce Momjian
doc: remove mention of Windows junction points by pg_upgrade pg_upgrade never used Windows junction points but instead always used Windows hard links. Reported-by: Adrian Klaver Discussion: https://postgr.es/m/6a638c60-90bb-4921-8ee4-5fdad68f8...@aklaver.com Backpatch-through: 9.3, where the m

[COMMITTERS] pgsql: doc: remove mention of Windows junction points by pg_upgrade

2017-06-15 Thread Bruce Momjian
doc: remove mention of Windows junction points by pg_upgrade pg_upgrade never used Windows junction points but instead always used Windows hard links. Reported-by: Adrian Klaver Discussion: https://postgr.es/m/6a638c60-90bb-4921-8ee4-5fdad68f8...@aklaver.com Backpatch-through: 9.3, where the m

[COMMITTERS] pgsql: doc: remove mention of Windows junction points by pg_upgrade

2017-06-15 Thread Bruce Momjian
doc: remove mention of Windows junction points by pg_upgrade pg_upgrade never used Windows junction points but instead always used Windows hard links. Reported-by: Adrian Klaver Discussion: https://postgr.es/m/6a638c60-90bb-4921-8ee4-5fdad68f8...@aklaver.com Backpatch-through: 9.3, where the m

[COMMITTERS] pgsql: doc: remove mention of Windows junction points by pg_upgrade

2017-06-15 Thread Bruce Momjian
doc: remove mention of Windows junction points by pg_upgrade pg_upgrade never used Windows junction points but instead always used Windows hard links. Reported-by: Adrian Klaver Discussion: https://postgr.es/m/6a638c60-90bb-4921-8ee4-5fdad68f8...@aklaver.com Backpatch-through: 9.3, where the m

[COMMITTERS] pgsql: doc: remove mention of Windows junction points by pg_upgrade

2017-06-15 Thread Bruce Momjian
doc: remove mention of Windows junction points by pg_upgrade pg_upgrade never used Windows junction points but instead always used Windows hard links. Reported-by: Adrian Klaver Discussion: https://postgr.es/m/6a638c60-90bb-4921-8ee4-5fdad68f8...@aklaver.com Backpatch-through: 9.3, where the m

[COMMITTERS] pgsql: docs: Fix pg_upgrade standby server upgrade docs

2017-06-15 Thread Bruce Momjian
docs: Fix pg_upgrade standby server upgrade docs It was unsafe to instruct users to start/stop the server after pg_upgrade was run but before the standby servers were rsync'ed. The new instructions avoid this. RELEASE NOTES: This fix should be mentioned in the minor release notes. Reported-by

[COMMITTERS] pgsql: docs: Fix pg_upgrade standby server upgrade docs

2017-06-15 Thread Bruce Momjian
docs: Fix pg_upgrade standby server upgrade docs It was unsafe to instruct users to start/stop the server after pg_upgrade was run but before the standby servers were rsync'ed. The new instructions avoid this. RELEASE NOTES: This fix should be mentioned in the minor release notes. Reported-by

[COMMITTERS] pgsql: docs: Fix pg_upgrade standby server upgrade docs

2017-06-15 Thread Bruce Momjian
docs: Fix pg_upgrade standby server upgrade docs It was unsafe to instruct users to start/stop the server after pg_upgrade was run but before the standby servers were rsync'ed. The new instructions avoid this. RELEASE NOTES: This fix should be mentioned in the minor release notes. Reported-by

[COMMITTERS] pgsql: Rename function for consistency

2017-06-15 Thread Alvaro Herrera
Rename function for consistency Avoid using prefix "staext" when everything else uses "statext". Author: Kyotaro HORIGUCHI Discussion: https://postgr.es/m/20170615.140041.165731947.horiguchi.kyot...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3ab

[COMMITTERS] pgsql: psql: Improve display of "for all tables" publications

2017-06-15 Thread Peter Eisentraut
psql: Improve display of "for all tables" publications Show "All tables" property in \dRp and \dRp+. Don't list tables for such publications in \dRp+, since it's redundant and the list could be very long. Author: Masahiko Sawada Author: Jeff Janes Branch -- master Details --- https:/

Re: [COMMITTERS] pgsql: Fix problems related to RangeTblEntry members enrname and enrtup

2017-06-15 Thread Robert Haas
On Thu, Jun 15, 2017 at 10:17 AM, Tom Lane wrote: > Robert Haas writes: >> On Wed, Jun 14, 2017 at 4:30 PM, Tom Lane wrote: >>> This really should have involved a catversion bump. But we just >>> had one earlier today, so in practice it might not matter. > >> Oh, because of stored rules using t

Re: [COMMITTERS] pgsql: Fix problems related to RangeTblEntry members enrname and enrtup

2017-06-15 Thread Tom Lane
Robert Haas writes: > On Wed, Jun 14, 2017 at 4:30 PM, Tom Lane wrote: >> This really should have involved a catversion bump. But we just >> had one earlier today, so in practice it might not matter. > Oh, because of stored rules using the old RangeTblEntry serialization > format? Sorry, I tot

Re: [COMMITTERS] pgsql: Fix document bug regarding read only transactions.

2017-06-15 Thread Tom Lane
Tatsuo Ishii writes: >> Right, but what I think it is comparing is a read-only transaction >> on the master and a transaction on the standby. The former can do >> nextval() on temp sequences, the latter can't. > But we cannot create temp sequences on stanbys in the first place. > Still do you th

Re: [COMMITTERS] pgsql: Fix problems related to RangeTblEntry members enrname and enrtup

2017-06-15 Thread Robert Haas
On Wed, Jun 14, 2017 at 4:30 PM, Tom Lane wrote: > Robert Haas writes: >> Fix problems related to RangeTblEntry members enrname and enrtuples. >> Commit 18ce3a4ab22d2984f8540ab480979c851dae5338 failed to update >> the comments in parsenodes.h for the new members, and made only >> incomplete updat

[COMMITTERS] pgsql: Fix typo in code comment

2017-06-15 Thread Peter Eisentraut
Fix typo in code comment Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6c6a1149b5662f685ddbb0c6dc83eb110992044a Modified Files -- src/interfaces/ecpg/pgtypeslib/datetime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[COMMITTERS] pgsql: Remove unnecessary IPC::Run inclusion

2017-06-15 Thread Peter Eisentraut
Remove unnecessary IPC::Run inclusion This is no longer needed because the tests use PostgresNode. Reported-by: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/878b7d9eaa9cbf5f121f9ee8676d82b22decedf0 Modified Files -- src/test/ssl/t/0