Re: [HACKERS] PartitionSchemaData & partcollation (Re: [COMMITTERS] pgsql: Associate partitioning information with each RelOptInfo.)

2017-09-28 Thread Amit Langote
On 2017/09/28 16:13, Ashutosh Bapat wrote: > On Thu, Sep 28, 2017 at 11:47 AM, Amit Langote wrote: >> On 2017/09/21 12:42, Robert Haas wrote: >>> Associate partitioning information with each RelOptInfo. >>> >>> This is not used for anything yet, but it is necess

Re: [HACKERS] PartitionSchemaData & partcollation (Re: [COMMITTERS] pgsql: Associate partitioning information with each RelOptInfo.)

2017-09-27 Thread Amit Langote
Sorry, I meant to say PartitionSchem"e"Data in subject. Thanks, Amit -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

PartitionSchemaData & partcollation (Re: [COMMITTERS] pgsql: Associate partitioning information with each RelOptInfo.)

2017-09-27 Thread Amit Langote
On 2017/09/21 12:42, Robert Haas wrote: > Associate partitioning information with each RelOptInfo. > > This is not used for anything yet, but it is necessary infrastructure > for partition-wise join and for partition pruning without constraint > exclusion. > > Ashutosh Ba

Re: [COMMITTERS] pgsql: Doc: desultory copy-editing for v10 release notes.

2017-07-09 Thread Amit Langote
On 2017/07/10 12:36, Tom Lane wrote: > Amit Langote writes: >> On 2017/07/10 9:11, Tom Lane wrote: >>> Doc: desultory copy-editing for v10 release notes. > >> I see you updated text for the partitioning item: > >> syntax that automatical

Re: [COMMITTERS] pgsql: Doc: desultory copy-editing for v10 release notes.

2017-07-09 Thread Amit Langote
- > https://git.postgresql.org/pg/commitdiff/749eceff4a1f9740391b126c81af9fd4bf3b1eaa I see you updated text for the partitioning item: @@ -1574,7 +1553,7 @@ Add table partitioning syntax that automatically creates partition constraints and - INSERT routing (Amit Lango

Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables.

2017-06-12 Thread Amit Langote
On 2017/06/12 22:46, Tom Lane wrote: > Amit Langote writes: >> How about something like the attached? The patch makes >> mtstate->mt_plans[0] to be passed for all invocations of ExecInitQual() on >> WithCheckOption.qual that is being initialized for each partition. > &

Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables.

2017-06-11 Thread Amit Langote
On 2017/06/12 11:51, Tom Lane wrote: > Amit Langote writes: >> On 2017/06/12 11:09, Joe Conway wrote: >>> On 06/11/2017 05:35 PM, Tom Lane wrote: >>>> First guess is that map_partition_varattnos has forgotten to handle >>>> WithCheckOption.qual. &

Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables.

2017-06-11 Thread Amit Langote
On 2017/06/12 11:09, Joe Conway wrote: > On 06/11/2017 05:35 PM, Tom Lane wrote: >> Joe Conway writes: >>> Apply RLS policies to partitioned tables. >> >> Buildfarm member skink has grown a "make check" failure with this commit. >> >> ==28150== VALGRINDERROR-BEGIN >> ==28150== Invalid read of size

Re: [COMMITTERS] pgsql: Logical replication

2017-01-20 Thread Amit Langote
On Sat, Jan 21, 2017 at 1:19 PM, Amit Kapila wrote: > On Fri, Jan 20, 2017 at 7:36 PM, Peter Eisentraut wrote: >> Logical replication >> >> - Add PUBLICATION catalogs and DDL >> - Add SUBSCRIPTION catalog and DDL >> - Define logical replication protocol and output plugin >> - Add logical replicat

Re: [COMMITTERS] pgsql: Fix some more regression test row-order-instability issues.

2017-01-13 Thread Amit Langote
On Sat, Jan 14, 2017 at 7:32 AM, Tom Lane wrote: > Fix some more regression test row-order-instability issues. > > Commit 0563a3a8b just introduced another instance of the same unsafe > testing methodology that appeared in 2ac3ef7a0, which I corrected in > 257d81572. Robert/Amit, please stop doin

Re: [COMMITTERS] pgsql: Fix bugs in RelationGetPartitionDispatchInfo.

2016-12-13 Thread Amit Langote
Hi Alexander, On 2016/12/14 15:18, Alexander Korotkov wrote: > Hmm, Dmitry Ivanov spotted this bug [1]. And he posted this patch with > only difference of variables naming and comments [2]. But he is not > mentioned in commit message. That doesn't look fine. I apologize for my part in failing

Re: [COMMITTERS] pgsql: Fix creative, but unportable, spelling of "ptr != NULL".

2016-12-12 Thread Amit Langote
On 2016/12/13 1:23, Tom Lane wrote: > Fix creative, but unportable, spelling of "ptr != NULL". > > Or at least I suppose that's what was really meant here. But even > aside from the not-per-project-style use of "0" to mean "NULL", > I doubt it's safe to assume that all valid pointers are > NULL.

Re: [COMMITTERS] pgsql: Don't vacuum all-frozen pages.

2016-03-10 Thread Amit Langote
On 2016/03/11 8:19, Peter Geoghegan wrote: > On Thu, Mar 10, 2016 at 1:22 PM, Andres Freund wrote: >> Yeha! > > Fantastic effort, particularly from Masahiko. Well done. +1! - Amit -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscripti

Re: [COMMITTERS] pgsql: BRIN: Block Range Indexes

2014-11-09 Thread Amit Langote
On Sat, Nov 8, 2014 at 4:43 AM, Alvaro Herrera wrote: > src/backend/access/brin/README| 189 A minor typo: +Summarization +- + +Wehn VACUUM is run on the table, all unsummarized page ranges are s/Wehn/When/ Thanks, Amit -- Sent via pgsql-committers mailin

Re: [COMMITTERS] pgsql: Update 9.4 release notes for queryid control

2014-05-05 Thread Amit Langote
Perhaps a typo/copy-pasto in this commit, ;-) This allows monitoring tools to only fetch query texts for newly observe entries, as determined by queryid. s/observe/observed -- Amit

Re: [COMMITTERS] pgsql: Add missing 9.4 release file.

2014-05-05 Thread Amit Langote
Spotted a typo: + +worker_spi_launch() in worker_spi shows an example if its use. + + s/example if/example of -- Amit -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpre