Re: [COMMITTERS] pgsql: Improve performance of timezone loading, especially pg_timezone_

On 7 May 2017 at 21:33, David Rowley <david.row...@2ndquadrant.com> wrote: > I've attached a patch for review. My perl skills are at "trial and > error" level, so please review carefully. Actually, my Perl code contained a superfluous line to trim the whitespace from $pos

Re: [COMMITTERS] pgsql: Improve performance of timezone loading, especially pg_timezone_

On 7 May 2017 at 21:03, David Rowley <david.row...@2ndquadrant.com> wrote: > Perhaps we just need to put the NUL char back, to trim off the filename again: > > /* If that didn't work, fall through to do it the hard way */ > fullname[fullnamelen] = '\0'; > > but I've

Re: [COMMITTERS] pgsql: Improve performance of timezone loading, especially pg_timezone_

, On 7 May 2017 at 17:19, Tom Lane wrote: > Amit Kapila writes: >> On Wed, May 3, 2017 at 7:21 AM, Tom Lane wrote: >>> Improve performance of timezone loading, especially pg_timezone_names view. > >> I am consistently getting

Re: [COMMITTERS] pgsql: Faster expression evaluation and targetlist projection.

ssions easier. > > This is a huge achievement. Congratulations! Agreed. Congratulations! -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgr

Re: [COMMITTERS] pgsql: ICU support

f + } info; +}; but forgot to update varstr_cmp() completely. result = wcscoll_l((LPWSTR) a1p, (LPWSTR) a2p, mylocale); should be: result = wcscoll_l((LPWSTR) a1p, (LPWSTR) a2p, mylocale->info.lt); Patch attached. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Developmen

Re: [COMMITTERS] pgsql: dblink: Replace some macros by static functions

contrib/dblink/dblink.h | 39 --- > 2 files changed, 137 insertions(+), 192 deletions(-) > Hi Peter, Please accept a small patch which fixes a new compiler warning which started as a result of this commit. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Deve

Re: [COMMITTERS] pgsql: Suppress compiler warnings in ecpg test on newer Windows toolcha

hrips=2017-03-07%2022%3A37%3A28=make [2] https://msdn.microsoft.com/en-us/library/tzthab44(v=vs.110).aspx -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services isnan_msvc_warning_fixes.patch Description: Binary data -- Sen

Re: [COMMITTERS] pgsql: Provide errno-translation wrappers around bind() and listen() on

On 13 April 2016 at 11:52, Tom Lane wrote: > Provide errno-translation wrappers around bind() and listen() on Windows. > > I've seen one too many "could not bind IPv4 socket: No error" log entries > from the Windows buildfarm members. Per previous discussion, this is > likely

Re: [COMMITTERS] pgsql: Copyedit comments and documentation.

On 4 April 2016 at 12:11, Noah Misch <n...@leadboat.com> wrote: > On Mon, Apr 04, 2016 at 10:55:03AM +1200, David Rowley wrote: >> On 2 April 2016 at 14:56, Noah Misch <n...@leadboat.com> wrote: >> > Copyedit comments and documentation. >> >> ... >>

Re: [COMMITTERS] pgsql: Copyedit comments and documentation.

On 4 April 2016 at 10:55, David Rowley <david.row...@2ndquadrant.com> wrote: > It appears that the tender is still open on "a SQL" vs "an SQL", but > that'll likely be down to people pronouncing SQL as either > "es-que-el", or "sque

Re: [COMMITTERS] pgsql: Copyedit comments and documentation.

appears that the tender is still open on "a SQL" vs "an SQL", but that'll likely be down to people pronouncing SQL as either "es-que-el", or "squeal" -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Train

Re: [COMMITTERS] pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

lthough that's most likely only because psql compiled first, and created psqlscan.c. So I think both changes are required, we just end up running flex on psqlscan.l twice. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: [COMMITTERS] pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

before, but it seems that the parsing of the Makefile just assumes that psqlscan.c is in the same path as the rest of the stuff. The patch just uses some already defined file replace functions to switch the wrong filename out for the correct one before the Visual Studios project file is create

Re: [COMMITTERS] pgsql: Improve index AMs' opclass validation procedures.

rnings with this change which mention about 32-bit bit shifting then bitwise anding to a 64-bit variable. The attached fixes the warnings -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services amvalidate_64bit_bitshift.patch D