Re: [COMMITTERS] pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

2016-03-21 Thread Michael Paquier
On Tue, Mar 22, 2016 at 10:20 AM, Andrew Dunstan wrote: > > > On 03/21/2016 09:25 AM, Tom Lane wrote: >> >> Andres Freund writes: >>> >>> On 2016-03-21 22:38:50 +1300, David Rowley wrote: Perl is not my native tongue, but after a little study and some testing on a windows machine,

Re: [COMMITTERS] pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

2016-03-21 Thread Andrew Dunstan
On 03/21/2016 09:25 AM, Tom Lane wrote: Andres Freund writes: On 2016-03-21 22:38:50 +1300, David Rowley wrote: Perl is not my native tongue, but after a little study and some testing on a windows machine, the attached seems to fix the problem. I've pushed this, as I would like the buildfar

Re: [COMMITTERS] pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

2016-03-21 Thread David Rowley
On 22 March 2016 at 02:33, Andres Freund wrote: > On 2016-03-21 09:25:18 -0400, Tom Lane wrote: >> Shouldn't we revert 6f1f34c92b11593e? AFAICS this patch isn't depending >> on that, but maybe I miss something. > > Hm. I'd guess that at least part of it is still required. AddSimpleFrontend() > af

Re: [COMMITTERS] pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

2016-03-21 Thread Andres Freund
On 2016-03-21 09:25:18 -0400, Tom Lane wrote: > Shouldn't we revert 6f1f34c92b11593e? AFAICS this patch isn't depending > on that, but maybe I miss something. Hm. I'd guess that at least part of it is still required. AddSimpleFrontend() afaics processes these variables, and I don't think the msvc

Re: [COMMITTERS] pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

2016-03-21 Thread Tom Lane
Andres Freund writes: > On 2016-03-21 22:38:50 +1300, David Rowley wrote: >> Perl is not my native tongue, but after a little study and some >> testing on a windows machine, the attached seems to fix the problem. > I've pushed this, as I would like the buildfarm to be green before > pushing the l

Re: [COMMITTERS] pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

2016-03-21 Thread Andres Freund
On 2016-03-21 22:38:50 +1300, David Rowley wrote: > On 21 March 2016 at 10:52, Tom Lane wrote: > > Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9. > > > > pgbench now needs to use src/bin/psql/psqlscan.l, but it's not very clear > > how to fit that into the MSVC build system. If thi

Re: [COMMITTERS] pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

2016-03-21 Thread David Rowley
On 21 March 2016 at 10:52, Tom Lane wrote: > Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9. > > pgbench now needs to use src/bin/psql/psqlscan.l, but it's not very clear > how to fit that into the MSVC build system. If this doesn't work I'm going > to need some help from somebody w

[COMMITTERS] pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

2016-03-20 Thread Tom Lane
Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9. pgbench now needs to use src/bin/psql/psqlscan.l, but it's not very clear how to fit that into the MSVC build system. If this doesn't work I'm going to need some help from somebody who actually understands those scripts ... Branch ---