Re: [COMMITTERS] pgsql: Fix integer-overflow problems in interval comparison.

2017-04-17 Thread Andres Freund
On 2017-04-17 13:04:31 -0400, Tom Lane wrote: > Peter Eisentraut writes: > > On 4/5/17 23:51, Tom Lane wrote: > >> Fix integer-overflow problems in interval comparison. > > > This is failing cpluspluscheck now because C++ does not have > > _Static_assert, which is used in int128.h. > > Hmm. We

Re: [COMMITTERS] pgsql: Fix integer-overflow problems in interval comparison.

2017-04-17 Thread Tom Lane
Peter Eisentraut writes: > On 4/5/17 23:51, Tom Lane wrote: >> Fix integer-overflow problems in interval comparison. > This is failing cpluspluscheck now because C++ does not have > _Static_assert, which is used in int128.h. Hmm. We could drop that assert, or move it to some .c file, or wrap it

Re: [COMMITTERS] pgsql: Fix integer-overflow problems in interval comparison.

2017-04-17 Thread Peter Eisentraut
On 4/5/17 23:51, Tom Lane wrote: > Fix integer-overflow problems in interval comparison. > Branch > -- > REL9_4_STABLE > > Details > --- > http://git.postgresql.org/pg/commitdiff/8851bcf8813baa0ea393ef9d2894d15b3f13f957 > > Modified Files > -- > src/backend/utils/adt/timestam

[COMMITTERS] pgsql: Fix integer-overflow problems in interval comparison.

2017-04-05 Thread Tom Lane
Fix integer-overflow problems in interval comparison. When using integer timestamps, the interval-comparison functions tried to compute the overall magnitude of an interval as an int64 number of microseconds. As reported by Frazer McLean, this overflows for intervals exceeding about 296000 years,

[COMMITTERS] pgsql: Fix integer-overflow problems in interval comparison.

2017-04-05 Thread Tom Lane
Fix integer-overflow problems in interval comparison. When using integer timestamps, the interval-comparison functions tried to compute the overall magnitude of an interval as an int64 number of microseconds. As reported by Frazer McLean, this overflows for intervals exceeding about 296000 years,

[COMMITTERS] pgsql: Fix integer-overflow problems in interval comparison.

2017-04-05 Thread Tom Lane
Fix integer-overflow problems in interval comparison. When using integer timestamps, the interval-comparison functions tried to compute the overall magnitude of an interval as an int64 number of microseconds. As reported by Frazer McLean, this overflows for intervals exceeding about 296000 years,

[COMMITTERS] pgsql: Fix integer-overflow problems in interval comparison.

2017-04-05 Thread Tom Lane
Fix integer-overflow problems in interval comparison. When using integer timestamps, the interval-comparison functions tried to compute the overall magnitude of an interval as an int64 number of microseconds. As reported by Frazer McLean, this overflows for intervals exceeding about 296000 years,