Re: [COMMITTERS] pgsql: Fix problems related to RangeTblEntry members enrname and enrtup

2017-06-15 Thread Robert Haas
On Thu, Jun 15, 2017 at 10:17 AM, Tom Lane wrote: > Robert Haas writes: >> On Wed, Jun 14, 2017 at 4:30 PM, Tom Lane wrote: >>> This really should have involved a catversion bump. But we just >>> had one earlier today, so in practice it might not matter. > >> Oh, because of stored rules using t

Re: [COMMITTERS] pgsql: Fix problems related to RangeTblEntry members enrname and enrtup

2017-06-15 Thread Tom Lane
Robert Haas writes: > On Wed, Jun 14, 2017 at 4:30 PM, Tom Lane wrote: >> This really should have involved a catversion bump. But we just >> had one earlier today, so in practice it might not matter. > Oh, because of stored rules using the old RangeTblEntry serialization > format? Sorry, I tot

Re: [COMMITTERS] pgsql: Fix problems related to RangeTblEntry members enrname and enrtup

2017-06-15 Thread Robert Haas
On Wed, Jun 14, 2017 at 4:30 PM, Tom Lane wrote: > Robert Haas writes: >> Fix problems related to RangeTblEntry members enrname and enrtuples. >> Commit 18ce3a4ab22d2984f8540ab480979c851dae5338 failed to update >> the comments in parsenodes.h for the new members, and made only >> incomplete updat

Re: [COMMITTERS] pgsql: Fix problems related to RangeTblEntry members enrname and enrtup

2017-06-14 Thread Tom Lane
Robert Haas writes: > Fix problems related to RangeTblEntry members enrname and enrtuples. > Commit 18ce3a4ab22d2984f8540ab480979c851dae5338 failed to update > the comments in parsenodes.h for the new members, and made only > incomplete updates to src/backend/nodes This really should have involve

[COMMITTERS] pgsql: Fix problems related to RangeTblEntry members enrname and enrtup

2017-06-14 Thread Robert Haas
Fix problems related to RangeTblEntry members enrname and enrtuples. Commit 18ce3a4ab22d2984f8540ab480979c851dae5338 failed to update the comments in parsenodes.h for the new members, and made only incomplete updates to src/backend/nodes Thomas Munro, per a report from Noah Misch. Discussion: ht