Re: [COMMITTERS] pgsql: Improve index AMs' opclass validation procedures.

2016-01-21 Thread David Rowley
change which mention about 32-bit bit shifting then bitwise anding to a 64-bit variable. The attached fixes the warnings -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services amvalidate_64bit_bitshift.patch Description: Bi

Re: [COMMITTERS] pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

2016-03-21 Thread David Rowley
re, but it seems that the parsing of the Makefile just assumes that psqlscan.c is in the same path as the rest of the stuff. The patch just uses some already defined file replace functions to switch the wrong filename out for the correct one before the Visual Studios project file is created. -- D

Re: [COMMITTERS] pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

2016-03-21 Thread David Rowley
extrasource, although that's most likely only because psql compiled first, and created psqlscan.c. So I think both changes are required, we just end up running flex on psqlscan.l twice. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Trai

Re: [COMMITTERS] pgsql: Copyedit comments and documentation.

2016-04-03 Thread David Rowley
or it. It appears that the tender is still open on "a SQL" vs "an SQL", but that'll likely be down to people pronouncing SQL as either "es-que-el", or "squeal" -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Su

Re: [COMMITTERS] pgsql: Copyedit comments and documentation.

2016-04-03 Thread David Rowley
On 4 April 2016 at 10:55, David Rowley wrote: > It appears that the tender is still open on "a SQL" vs "an SQL", but > that'll likely be down to people pronouncing SQL as either > "es-que-el", or "squeal" Of course I mean "sequel".

Re: [COMMITTERS] pgsql: Copyedit comments and documentation.

2016-04-03 Thread David Rowley
On 4 April 2016 at 12:11, Noah Misch wrote: > On Mon, Apr 04, 2016 at 10:55:03AM +1200, David Rowley wrote: >> On 2 April 2016 at 14:56, Noah Misch wrote: >> > Copyedit comments and documentation. >> >> ... >> > src/backend/storage/freespace/freespace.c |

Re: [COMMITTERS] pgsql: Provide errno-translation wrappers around bind() and listen() on

2016-04-13 Thread David Rowley
On 13 April 2016 at 11:52, Tom Lane wrote: > Provide errno-translation wrappers around bind() and listen() on Windows. > > I've seen one too many "could not bind IPv4 socket: No error" log entries > from the Windows buildfarm members. Per previous discussion, this is > likely caused by the fact t

Re: [COMMITTERS] pgsql: Suppress compiler warnings in ecpg test on newer Windows toolcha

2017-03-07 Thread David Rowley
l?nm=thrips&dt=2017-03-07%2022%3A37%3A28&stg=make [2] https://msdn.microsoft.com/en-us/library/tzthab44(v=vs.110).aspx -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services isnan_msvc_warning_fixes.patch Descripti

Re: [COMMITTERS] pgsql: dblink: Replace some macros by static functions

2017-03-12 Thread David Rowley
7 insertions(+), 192 deletions(-) > Hi Peter, Please accept a small patch which fixes a new compiler warning which started as a result of this commit. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services dblink_c

Re: [COMMITTERS] pgsql: ICU support

2017-03-24 Thread David Rowley
update varstr_cmp() completely. result = wcscoll_l((LPWSTR) a1p, (LPWSTR) a2p, mylocale); should be: result = wcscoll_l((LPWSTR) a1p, (LPWSTR) a2p, mylocale->info.lt); Patch attached. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &

Re: [COMMITTERS] pgsql: Faster expression evaluation and targetlist projection.

2017-03-25 Thread David Rowley
dispatch based, expression evaluation. >> Projection is now implemented as part of expression evaluation. >> >> This both leads to significant performance improvements, and makes >> future just-in-time compilation of expressions easier. > > This is a huge achievement. Congr

Re: [COMMITTERS] pgsql: Identity columns

2017-04-06 Thread David Rowley
s not smart enough to know the elog(ERROR) does not return. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services identity_columns_warning_fix.patch Description: Binary data -- Sent via pgsql-committers mailing list (p

Re: [COMMITTERS] pgsql: Improve performance of timezone loading, especially pg_timezone_

2017-05-07 Thread David Rowley
, On 7 May 2017 at 17:19, Tom Lane wrote: > Amit Kapila writes: >> On Wed, May 3, 2017 at 7:21 AM, Tom Lane wrote: >>> Improve performance of timezone loading, especially pg_timezone_names view. > >> I am consistently getting below error after this commit in my Win7 machine: >> running bootstrap

Re: [COMMITTERS] pgsql: Improve performance of timezone loading, especially pg_timezone_

2017-05-07 Thread David Rowley
On 7 May 2017 at 21:03, David Rowley wrote: > Perhaps we just need to put the NUL char back, to trim off the filename again: > > /* If that didn't work, fall through to do it the hard way */ > fullname[fullnamelen] = '\0'; > > but I've not yet looked int

Re: [COMMITTERS] pgsql: Improve performance of timezone loading, especially pg_timezone_

2017-05-07 Thread David Rowley
On 7 May 2017 at 21:33, David Rowley wrote: > I've attached a patch for review. My perl skills are at "trial and > error" level, so please review carefully. Actually, my Perl code contained a superfluous line to trim the whitespace from $posixrules. The attached is a vers

Re: [COMMITTERS] pgsql: Improve performance of timezone loading, especially pg_timezone_

2017-05-07 Thread David Rowley
On 8 May 2017 at 02:57, Tom Lane wrote: > David Rowley writes: >> OK, so it looks like GenerateTimezoneFiles in Install.pm for the MSVC >> build does not quite do what make install does for src/timezone. >> Nothing seems to pass the -p parameter as the following is doing: &g