Re: Additional Chapter for Tutorial

2021-05-20 Thread Erik Rijkers
Hi Jürgen, What's going to happen with this work? If you intend to have it eventually committed, I think it will be necessary to make the patches smaller, and bring them into the commitfest app, so that others can follow progress. I for one, cannot see/remember/understand what has been

Re: pg_monitor role description

2021-05-20 Thread Pavel Luzanov
On 20.05.2021 21:10, Tom Lane wrote: Pavel Luzanov writes: So, is it correct to change description of pg_monitor role from: "Read/execute various monitoring views and functions. This role is a member of|pg_read_all_settings|,|pg_read_all_stats| and|pg_stat_scan_tables|." to "Read/execute

Re: pg_monitor role description

2021-05-20 Thread Tom Lane
Pavel Luzanov writes: > So, is it correct to change description of pg_monitor role from: > "Read/execute various monitoring views and functions. This role is a member > of|pg_read_all_settings|,|pg_read_all_stats| and|pg_stat_scan_tables|." > to > "Read/execute various monitoring views and

Re: pg_monitor role description

2021-05-20 Thread Pavel Luzanov
Hello, On 20.05.2021 20:27, Pavel Luzanov wrote: So, is it correct to change description of pg_monitor role from: "Read/execute various monitoring views and functions. This role is a member of|pg_read_all_settings|,|pg_read_all_stats| and|pg_stat_scan_tables|." to "Read/execute various

Re: pg_monitor role description

2021-05-20 Thread Pavel Luzanov
Hello, On 20.05.2021 19:03, Tom Lane wrote: Pavel Luzanov writes: Let me try one more time. What is correct from the English language point of view: 1. Julien Rouhaud is a member of PostgreSQL Community. or 2. PostgreSQL Community is a member of Julien Rouhaud, Michael Paquier. Or both forms

Re: pg_monitor role description

2021-05-20 Thread Laurenz Albe
On Thu, 2021-05-20 at 12:03 -0400, Tom Lane wrote: > List of roles > Role name | Attributes | Member of > ---+--+- > bob | | {sysadmins} > joe | | {sysadmins} > sysadmins | Cannot login | {} > > and I

Re: pg_monitor role description

2021-05-20 Thread Tom Lane
Pavel Luzanov writes: > Let me try one more time. > What is correct from the English language point of view: > 1. Julien Rouhaud is a member of PostgreSQL Community. > or > 2. PostgreSQL Community is a member of Julien Rouhaud, Michael Paquier. > Or both forms are correct? > I think that 1 is

Re: pg_monitor role description

2021-05-20 Thread Pavel Luzanov
On 20.05.2021 11:54, Julien Rouhaud wrote: On Thu, May 20, 2021 at 3:01 PM Michael Paquier wrote: On Thu, May 20, 2021 at 06:11:40AM +, PG Doc comments form wrote: "This role is a member of pg_read_all_settings, pg_read_all_stats and pg_stat_scan_tables." Is it correct sentence? It seems

Re: pg_monitor role description

2021-05-20 Thread Julien Rouhaud
On Thu, May 20, 2021 at 3:01 PM Michael Paquier wrote: > > On Thu, May 20, 2021 at 06:11:40AM +, PG Doc comments form wrote: > > "This role is a member of pg_read_all_settings, pg_read_all_stats and > > pg_stat_scan_tables." > > Is it correct sentence? > > It seems for me that

Re: more detailed description of tup_returned and tup_fetched

2021-05-20 Thread Masahiro Ikeda
On 2021/05/20 17:00, Fujii Masao wrote: > On 2021/05/20 9:46, Masahiro Ikeda wrote: >> On 2021/05/18 20:10, Fujii Masao wrote: > pg_stat_database.tup_fetched: > Number of index entries returned by scans on indexes in this database Is this the sum of pg_stat_all_indexes.idx_tup_read?

Re: more detailed description of tup_returned and tup_fetched

2021-05-20 Thread Fujii Masao
On 2021/05/20 9:46, Masahiro Ikeda wrote: On 2021/05/18 20:10, Fujii Masao wrote: On 2021/05/18 18:23, Masahiro Ikeda wrote: On 2021/05/18 16:01, Fujii Masao wrote: On 2021/05/18 13:20, Masahiro Ikeda wrote: Tid Range Scan increments the tup_returned, and

Re: pg_monitor role description

2021-05-20 Thread Michael Paquier
On Thu, May 20, 2021 at 06:11:40AM +, PG Doc comments form wrote: > "This role is a member of pg_read_all_settings, pg_read_all_stats and > pg_stat_scan_tables." > Is it correct sentence? > It seems for me that pg_read_all_stats is a member of pg_monitor. But not > vice versa. Here is what I

pg_monitor role description

2021-05-20 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/13/default-roles.html Description: "This role is a member of pg_read_all_settings, pg_read_all_stats and pg_stat_scan_tables." Is it correct sentence? It seems for me that pg_read_all_stats

pg_type_d.h location incorrect

2021-05-20 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/libpq-exec.html Description: >The OIDs of the built-in data types are defined in the file include/server/catalog/pg_type_d.h in the install directory. The location of "pg_type_d.h" is