Re: Ambiguous description on new columns

2024-06-11 Thread Amit Kapila
On Fri, Jun 7, 2024 at 3:23 PM Koen De Groote wrote: > > Yes, this change is clear to me that the "columns added" applies to the table > on the publisher. > Thanks for the confirmation. I have pushed and backpatched the fix. -- With Regards, Amit Kapila.

Re: Ambiguous description on new columns

2024-06-07 Thread Koen De Groote
Yes, this change is clear to me that the "columns added" applies to the table on the publisher. Regards, Koen De Groote On Tue, Jun 4, 2024 at 7:57 AM Amit Kapila wrote: > On Fri, May 31, 2024 at 10:54 PM Peter Smith > wrote: > > > > On Wed, May 29, 2024 at 8:04 PM vignesh C wrote: > > > > >

Re: Ambiguous description on new columns

2024-06-07 Thread Amit Kapila
On Tue, Jun 4, 2024 at 11:26 AM Amit Kapila wrote: > > > > > IIUC you're saying my v1 patch *content* and rendering is OK, but you > > only wanted the SGML text to have better wrapping for < 80 chars > > lines. So I have attached a patch v2 with improved wrapping. If you > > meant something differ

Re: Ambiguous description on new columns

2024-06-03 Thread Amit Kapila
On Fri, May 31, 2024 at 10:54 PM Peter Smith wrote: > > On Wed, May 29, 2024 at 8:04 PM vignesh C wrote: > > > > > > > > > > The following documentation comment has been logged on the website: > > > > > > > > Page: > > > > https://www.postgresql.org/docs/16/logical-replication-col-lists.html > >

Re: Ambiguous description on new columns

2024-06-03 Thread vignesh C
On Fri, 31 May 2024 at 08:58, vignesh C wrote: > > On Thu, 30 May 2024 at 06:21, Peter Smith wrote: > > > > On Wed, May 29, 2024 at 8:04 PM vignesh C wrote: > > > > > > On Wed, 22 May 2024 at 14:26, Peter Smith wrote: > > > > > > > > On Tue, May 21, 2024 at 8:40 PM PG Doc comments form > > > >

Re: Ambiguous description on new columns

2024-05-31 Thread Peter Smith
On Wed, May 29, 2024 at 8:04 PM vignesh C wrote: > > On Wed, 22 May 2024 at 14:26, Peter Smith wrote: > > > > On Tue, May 21, 2024 at 8:40 PM PG Doc comments form > > wrote: > > > > > > The following documentation comment has been logged on the website: > > > > > > Page: > > > https://www.postg

Re: Ambiguous description on new columns

2024-05-30 Thread vignesh C
On Thu, 30 May 2024 at 06:21, Peter Smith wrote: > > On Wed, May 29, 2024 at 8:04 PM vignesh C wrote: > > > > On Wed, 22 May 2024 at 14:26, Peter Smith wrote: > > > > > > On Tue, May 21, 2024 at 8:40 PM PG Doc comments form > > > wrote: > > > > > > > > The following documentation comment has be

Re: Ambiguous description on new columns

2024-05-29 Thread vignesh C
On Wed, 22 May 2024 at 08:18, Peter Smith wrote: > > On Tue, May 21, 2024 at 8:40 PM PG Doc comments form > wrote: > > > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/16/logical-replication-col-lists.html > > Description: > > >

Re: Ambiguous description on new columns

2024-05-22 Thread Peter Smith
On Tue, May 21, 2024 at 8:40 PM PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/logical-replication-col-lists.html > Description: > > The documentation on this page mentions: > > "If no column list is

Re: Ambiguous description on new columns

2024-05-22 Thread Laurenz Albe
On Wed, 2024-05-22 at 12:47 +1000, Peter Smith wrote: > I think the following small change will remove any ambiguity: > > BEFORE > If no column list is specified, any columns added later are > automatically replicated. > > SUGGESTION > If no column list is specified, any columns added to the tabl

Re: Ambiguous description on new columns

2024-05-21 Thread David G. Johnston
On Tuesday, May 21, 2024, Peter Smith wrote: > > > > > Each publication can optionally specify which columns of each table are > replicated to subscribers. The table on the subscriber side must have at > least all the columns that are published. If no column list is specified, > then all columns

Re: Ambiguous description on new columns

2024-05-21 Thread Peter Smith
On Wed, May 22, 2024 at 1:22 PM David G. Johnston wrote: > > On Tue, May 21, 2024 at 7:48 PM Peter Smith wrote: >> >> >> I think the following small change will remove any ambiguity: >> >> BEFORE >> If no column list is specified, any columns added later are >> automatically replicated. >> >> SUG

Re: Ambiguous description on new columns

2024-05-21 Thread David G. Johnston
On Tue, May 21, 2024 at 7:48 PM Peter Smith wrote: > > I think the following small change will remove any ambiguity: > > BEFORE > If no column list is specified, any columns added later are > automatically replicated. > > SUGGESTION > If no column list is specified, any columns added to the table

Re: Ambiguous description on new columns

2024-05-21 Thread David G. Johnston
On Tue, May 21, 2024 at 3:40 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: > https://www.postgresql.org/docs/16/logical-replication-col-lists.html > Description: > > The documentation on this page mentions: > > "If no column list is

Re: Ambiguous description on new columns

2024-05-21 Thread Peter Smith
On Tue, May 21, 2024 at 8:40 PM PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/logical-replication-col-lists.html > Description: > > The documentation on this page mentions: > > "If no column list is

Re: Ambiguous description on new columns

2024-05-21 Thread Guillaume Lelarge
Hi, Le mar. 21 mai 2024 à 12:40, PG Doc comments form a écrit : > The following documentation comment has been logged on the website: > > Page: > https://www.postgresql.org/docs/16/logical-replication-col-lists.html > Description: > > The documentation on this page mentions: > > "If no column li

Ambiguous description on new columns

2024-05-21 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/logical-replication-col-lists.html Description: The documentation on this page mentions: "If no column list is specified, any columns added later are automatically replicated." It feels