Re: CREATE ROLE inheritance details

2024-04-13 Thread Noah Misch
On Wed, Apr 03, 2024 at 06:11:47PM -0700, David G. Johnston wrote: > On Sat, Mar 30, 2024 at 11:16 PM Noah Misch wrote: > > On Tue, Jan 30, 2024 at 01:49:42PM -0700, David G. Johnston wrote: > > > + The membership grants created by the > > > + IN ROLE, ROLE, and > > ADMIN > > > + clauses hav

Re: CREATE ROLE inheritance details

2024-04-03 Thread David G. Johnston
On Sat, Mar 30, 2024 at 11:16 PM Noah Misch wrote: > On Tue, Jan 30, 2024 at 01:49:42PM -0700, David G. Johnston wrote: > > + The membership grants created by the > > + IN ROLE, ROLE, and > ADMIN > > + clauses have the role executing this command as the grantee. > > This should be s/grantee

Re: CREATE ROLE inheritance details

2024-03-30 Thread Noah Misch
On Tue, Jan 30, 2024 at 01:49:42PM -0700, David G. Johnston wrote: > + The membership grants created by the > + IN ROLE, ROLE, and > ADMIN > + clauses have the role executing this command as the grantee. This should be s/grantee/grantor/, right? > + If unspecified when create a new role

Re: CREATE ROLE

2024-03-27 Thread Bruce Momjian
On Wed, Mar 27, 2024 at 12:52:55AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/sql-createrole.html > Description: > > https://www.postgresql.org/docs/16/sql-createrole.html > > ROLE role_nam

CREATE ROLE

2024-03-27 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/sql-createrole.html Description: https://www.postgresql.org/docs/16/sql-createrole.html ROLE role_name The ROLE clause causes one or more specified existing roles to be automatically adde

Re: CREATE ROLE inheritance details

2024-02-01 Thread Bruce Momjian
and GRANT work > together part of the description of create role.  So I moved that commentary > to > a new description paragraph. I liked all your changes so applied your composite patch. You can see the results here: https://momjian.us/pgsql_docs/ These improvements will appear

Re: CREATE ROLE inheritance details

2024-01-30 Thread David G. Johnston
Almost there I think. The comment regarding seeing GRANT really applies to IN ROLE, ROLE, and ADMIN. Repeating it seemed a poor choice and upon thinking further it really makes sense to consider how this command and GRANT work together part of the description of create role. So I moved that

Re: CREATE ROLE inheritance details

2024-01-29 Thread Bruce Momjian
gt; refers to the option.  I dislike burying this description about how the option > works within create role like this.  It is already in chapter 22 and this > attribute description should point the reader there, not repeat the > information. Okay, I made these changes in the attach

Re: CREATE ROLE inheritance details

2024-01-28 Thread David G. Johnston
learer if we consistently call the property attached to the membership an "option" (the grant command calls them options) and restrict the word attribute to only when talking about the role property. The following refers to the option. I dislike burying this description about how the option wo

Re: CREATE ROLE inheritance details

2024-01-26 Thread Bruce Momjian
on" works, as opposed to > the attribute, seems out of place where it was and the material is already > covered in the GRANT page.  We should either improve that page or extract this > level of detail somewhere else, not try to clutter up the CREATE ROLE page > with > it. Because the

Re: CREATE ROLE inheritance details

2024-01-17 Thread David G. Johnston
On Wed, Jan 17, 2024 at 9:38 AM Bruce Momjian wrote: > On Wed, Jan 17, 2024 at 09:28:38AM +0100, Laurenz Albe wrote: > > On Tue, 2024-01-16 at 17:03 -0500, Bruce Momjian wrote: > > > I am unhappy with the documentation adjustments made to CREATE ROLE in > > >

Re: CREATE ROLE inheritance details

2024-01-17 Thread Bruce Momjian
On Wed, Jan 17, 2024 at 09:28:38AM +0100, Laurenz Albe wrote: > On Tue, 2024-01-16 at 17:03 -0500, Bruce Momjian wrote: > > I am unhappy with the documentation adjustments made to CREATE ROLE in > > Postgres 16 by this commit: > > > > commit e3ce2de09d > >

Re: CREATE ROLE inheritance details

2024-01-17 Thread Laurenz Albe
On Tue, 2024-01-16 at 17:03 -0500, Bruce Momjian wrote: > I am unhappy with the documentation adjustments made to CREATE ROLE in > Postgres 16 by this commit: > > commit e3ce2de09d > > I have attached a patch to re-add this information, and clarify it. I > would lik

CREATE ROLE inheritance details

2024-01-16 Thread Bruce Momjian
I am unhappy with the documentation adjustments made to CREATE ROLE in Postgres 16 by this commit: commit e3ce2de09d Author: Robert Haas Date: Thu Aug 25 10:06:02 2022 -0400 Allow grant-level control of role inheritance behavior

Re: Create Role Documentation - Not Clear for new users

2023-08-22 Thread David G. Johnston
about PostgreSQL, I'm totally new, and I think that > for > people like me, the documentation is not clear, for example, you are > stating > that we need to run the ` CREATE ROLE name; `, but you are not specifying > if > that is directly on the terminal? > > In my c

Create Role Documentation - Not Clear for new users

2023-08-22 Thread PG Doc comments form
not clear, for example, you are stating that we need to run the ` CREATE ROLE name; `, but you are not specifying if that is directly on the terminal? In my case, I'm trying to run that on my terminal and I'm getting: `CREATE: not found`, I think would be great if that part could be im

Re: Difference options with the CREATE ROLE docs

2020-04-10 Thread Tom Lane
Euler Taveira writes: > It seems an oversight. I'm attaching patches to fix it in all supported > branches. v11 can be applied cleanly to v12/master. Ah, I'd already done this before seeing your response :-( regards, tom lane

Re: Difference options with the CREATE ROLE docs

2020-04-10 Thread Tom Lane
PG Doc comments form writes: > This page says that "CREATE GROUP is now an alias for CREATE ROLE.", > But when u check the CREATE ROLE, u see they have different options, The implementations are the same, as you could easily find by experiment. Looks like people have been slopp

Re: Difference options with the CREATE ROLE docs

2020-04-10 Thread Euler Taveira
On Fri, 10 Apr 2020 at 08:19, PG Doc comments form wrote: > > This page says that "CREATE GROUP is now an alias for CREATE ROLE.", > But when u check the CREATE ROLE, u see they have different options, > I don't know if this is on purpose or not, But if it's j

Difference options with the CREATE ROLE docs

2020-04-10 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/sql-creategroup.html Description: Hello, This page says that "CREATE GROUP is now an alias for CREATE ROLE.", But when u check the CREATE ROLE, u see they have different option