he
TOC (because that was the default behavior for whatever toolchain we
were then using) and later took them out precisely because they were
useless. Not sure how a list of figures would be any more useful.
regards, tom lane
Isn't it the other way around, that the partition key column(s) must be
included in the primary key? Maybe I'm confused, but it seems like
we couldn't enforce PK uniqueness otherwise.
regards, tom lane
nobody's complained before that it was ambiguous.
But, if we're going to change it, let's just s/midnight/00:00:00/
and be done. Making up fancy terminology doesn't improve matters.
regards, tom lane
[1] git blame dates the text to commit 1b342df00 of 2002-11-11, and
apparently it was
ist of them. It's not like it will be any harder to make that change
in a year or two than it is today.
regards, tom lane
t surely
4.1.2.7 makes it plain that the discussed syntax is for constants.
You might need to read 4.2.9 "Type Casts" instead.)
regards, tom lane
e browsers
but others (at least Safari) cut off the image.
regards, tom lane
since there's no actual functional change here.
regards, tom lane
move the
set of failure conditions around, so I'm unconvinced that it'd
be an improvement.
regards, tom lane
e second formulation is
pedantically correct, but also unintelligible.
Maybe we could make it say "run in parallel with non-DDL activity" ?
regards, tom lane
ough the cracks if you
add them to the commitfest page.)
regards, tom lane
dentifiers have to be double-quoted anywhere
in SQL. See
https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS
particularly the last para in 4.1.1.
regards, tom lane
that.
There's no definitive right answer on the pronunciation.
It might be best to try to cast your sentences so that the issue
doesn't come up ;-)
regards, tom lane
're just ordered differently, and there is more text
around them. I did yield to temptation in some small ways
though.
Comments?
regards, tom lane
diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml
index 4493862..cdc743c 100644
--- a/doc/src/
-by-blow discussions of decades-old
AIX or HPUX bugs either; nor recommendations to use gcc 2.95.3 ;-).
The HPUX section actually seems totally unnecessary after removing
info that is obsolete or duplicative.
Proposed patch attached.
regards, tom lane
diff --git a/doc/src/sgml
e symbols with special meaning of
> the URI parts, e.g. "&" and "?".
Hm, I agree that the options part doesn't accept "&", but I don't see
anything preventing use of a "?" there.
regards, tom lane
https://www.postgresql.org/docs/11/contrib.html
might clarify it for you.
regards, tom lane
n't necessarily remove the inheritance section;
it's talking about OOP-style inheritance, which you can't get
with partitioning.
regards, tom lane
Of course, that was me fat-fingering. Fixed in the attached v3. Thanks for
> reviewing!
Pushed with some marginal additional fiddling with the comments.
regards, tom lane
entirely, because the rendering is completely disproportional to the
meaning.
(Or, maybe, somebody could tinker with the stylesheets?)
regards, tom lane
f whoever is making the
list-of-contributors at the end of a release cycle. So far that's
been Peter.
regards, tom lane
ill fix, thanks for the report!
regards, tom lane
Alexander Lakhin writes:
> While translating Release Notes for version 12 I found some
> inconsistencies with contributor names.
Proposed changes seem reasonable from here. Pushed, thanks!
regards, tom lane
first reference to a program or function, when there are
several close together.
Thanks for the fixes!
regards, tom lane
in new entries.
Directories recorded in the hints file by previous runs of
ldconfig are also rescanned for new shared libraries.
I'm hardly a FreeBSD power user, but that does sound like what
is wanted here.
regards, tom lane
ity), but it needs to be documented as behaving that way on that
> page.
Done now.
regards, tom lane
recursion.
Another way to look at this is that control of whether the repetition
is finished is external to the function/query. If the stop condition
were part of the query logic, it'd be more sensible to think of it as
recursion, IMO.
regards, tom lane
no mention that PG 12's plan_cache_mode can modify this
> behavior. I think this needs a doc patch.
Yeah, agreed. I can do it, or do you want to?
regards, tom lane
Bruce Momjian writes:
> On Mon, Sep 30, 2019 at 12:05:07PM -0400, Tom Lane wrote:
>> Yeah, agreed. I can do it, or do you want to?
> Uh, I am feeling I can't do anything with the tree until Friday because
> of the PG 12 packaging, right?
There's not a freeze on docs, as far a
> key)" right after "a unique constraint". Thoughts?
I'd leave that alone. I don't think the parenthetical comment about
primary keys in your new text is adding much either.
regards, tom lane
Alvaro Herrera writes:
> On 2019-Nov-08, Tom Lane wrote:
>> So the patch becomes s/virgin/pristine/g plus add a parenthetical
>> definition for the first use? Works for me.
> Well, there are three uses of the word "virgin". The first is for
> "virgin user&
By instructing CREATE DATABASE to copy template0 instead of
template1, you can create a pristine user database, that is one where
no user-defined objects exist and where system objects have not been
altered. This is particularly handy ...
regards, tom lane
ou're making some other nearby change.
(There are actually instances of this in quite a few places in
our docs, if memory serves. I think somebody uses, or used,
an editor that tended to remove newlines in that context.)
regards, tom lane
pect it won't be the only entry that needs
cross-references to other terminology.
regards, tom lane
[1] https://commitfest.postgresql.org/25/2305/
eed not be ordered" and phrase it more like
If there are multiple queries in the WITH clause, RECURSIVE can
be written only once, immediately after WITH. It applies to all
queries in the WITH clause (but has no effect on queries that do
not use either of these features).
regards, tom lane
Laurenz Albe writes:
> On Wed, 2019-11-13 at 17:17 -0500, Tom Lane wrote:
>> It might be worth clarifying this point in section 5.7,
>> https://www.postgresql.org/docs/devel/ddl-priv.html
>> but let's not duplicate that in every ref/ page.
> I have attached a proposed p
"David G. Johnston" writes:
> On Fri, Nov 15, 2019 at 12:05 PM Tom Lane wrote:
>> I'm not clear why we should duplicate that information here, especially
>> when we're not duplicating any of the other essential information about
>> how to use IMPORT FOREIGN SCHEMA.
becomes s/virgin/pristine/g plus add a parenthetical
definition for the first use? Works for me.
regards, tom lane
Now that we explicitly support
things like altering the ACLs of system-defined objects, I do not
think it's okay to take that part for granted.
regards, tom lane
As long as there's more than one
column expression; the need for that special case is another reason
why omitting ROW isn't really a nice thing to do.)
regards, tom lane
it only works
in cases where the aggregate function can accept a composite
argument type. Most don't.
Moreover, the very same thing holds in *any* expression context,
not only aggregate arguments. So if we took this seriously there
would have to be a lot of other places plastered with equally
confusing/unhelpful addenda.
regards, tom lane
"These node types will discard subnodes when they detect that a
particular subnode won't produce any records required by the query."
Actually, that whole para could do with a rewrite; whoever wrote
it was obviously not familiar with Strunk & White's dictum
"Omit needless words".
regards, tom lane
f "records" rather than "rows",
and different markup choices. I propose the attached ... it's
actually a bit longer than the original, but that's because it
offers more details.
regards, tom lane
diff --git a/doc/src/sgml/perform.sgml b/doc/src/sgml
s to this code
I agree this code could have better style, but maybe that is just more
evidence that a well-written example would be helpful?
regards, tom lane
t quite sure whether the ending "by default" is worth writing
or not.)
Barring objections, I'll run around and make them all look like that.
regards, tom lane
t
(1 row)
The most likely explanation is that you have some non-built-in
"jsonb @@ something" operator in your installation. But you
did not say what "does not work" means, so I'm just guessing.
regards, tom lane
ould be "UNIX domain sockets".)
FWIW, I think we've used the first spelling in most places.
Which is more "correct", I don't know, but I'm pretty sure
that spelling Unix in all-caps has been out of fashion for
a very long time.
regards, tom lane
gt;> But if we want to cater for clueless beginners, we cannot omit Windows.
I have to agree with this point ... fortunately, there's probably only
one packaging that's of great interest there, and that's EDB's.
regards, tom lane
Laurenz Albe writes:
> On Fri, 2019-11-15 at 13:41 -0500, Tom Lane wrote:
>> Laurenz Albe writes:
>>> On Wed, 2019-11-13 at 17:17 -0500, Tom Lane wrote:
>>>> It might be worth clarifying this point in section 5.7,
>>>> https://www.postgresql.org/docs
tax;
so it doesn't seem like it's a huge problem that requires multiple
explanations.
I've pushed a patch for the SELECT reference page.
regards, tom lane
hink should be undone.
I have noted that many of our Japanese contributors show a different name
order in their From: line than in their signature/footer, so it's not
entirely clear which preference they're expressing.
regards, tom lane
Peter Eisentraut writes:
> PostgreSQL 12 requires C99, so those guidelines should probably be
> rephrased from "because old compilers don't accept it" to "because we
> like it that way".
Yeah, or more formally "to encourage consistent coding style".
regards, tom lane
needs
to be moved to the pg_statistic_ext_data section (and then
reworded a bit). Will fix, thanks for the report!
regards, tom lane
pect that it was supposed to read: "will be".
You'd need to report this to the JDBC project --- this list is just
for documentation issues in core Postgres.
regards, tom lane
ee
https://wiki.postgresql.org/wiki/Guide_to_reporting_problems
(In any case, I think this is off-topic for pgsql-docs.)
regards, tom lane
I wrote:
> Concretely, I propose the attached. Anybody want to editorialize on
> my short descriptions of the auth methods?
Pushed after a bit more fiddling with the wording.
regards, tom lane
ok
for a README-type file installed by the package.
regards, tom lane
OPY FROM will match each listed column in the table
to a file column by position (so the number of columns listed must match
the number of columns in the file).
regards, tom lane
me: you've run two nearly independent
observations into one sentence. But s/; any/. Any/ might be enough
to fix it.
regards, tom lane
Bruce Momjian writes:
> OK, this wording is obviously harder than I thought. Updated patch
> attached.
That one works for me.
regards, tom lane
Julien Rouhaud writes:
> On Sun, Dec 8, 2019 at 3:51 AM Tatsuo Ishii wrote:
>> Thanks for looking into this. The patch looks much cleaner than
>> before.
> I agree this is way better!
Pushed like that, then.
regards, tom lane
is is the
draconian space constraints imposed by the tabular format, which is
hurting us on a lot of these pages, not just this one. Alvaro did
some preliminary investigation towards finding a better way [1],
but nobody's tried to push that forward.
regards, tom lane
[1]
https://w
[ GRANTED BY ]
so I suppose whoever added the implementation just forgot about
fixing the docs.
regards, tom lane
.fc30.x86_64
Anybody seen this, or have an idea what to poke at?
regards, tom lane
PG Doc comments form writes:
> https://www.postgresql.org/docs/12/sql-keywords-appendix.html
> BYTEA missing from Keyword list.
> Is this intentional?
It's not a keyword, just a name that happens to be predefined.
regards, tom lane
future release.
It's Sunday afternoon, and nothing has happened, so I took it on
myself to revert this.
regards, tom lane
n.
So far as I can tell, that RFC's requirement for line breaks has not
been removed by any later RFC. So you're complaining to the wrong
people.
regards, tom lane
could get behind changing
them to use, say, a path as LHS. But I don't think there's room to
explain how to do rotation if you don't know that already, any more
than (say) our explanation of aggregate functions tries to explain
statistics.
regards, tom lane
duplicating the website's style isn't the default.
Doesn't seem like having authors optimize for some other style is
what we really want.
regards, tom lane
"Jonathan S. Katz" writes:
> On 2/11/20 1:37 PM, Tom Lane wrote:
>> I also wonder why duplicating the website's style isn't the default.
>> Doesn't seem like having authors optimize for some other style is
>> what we really want.
> Oh, and specifically for thi
It's
tough enough to keep one instance of the info up-to-date. So I'd
want to see some structure for this that respects that existing
set of information.
regards, tom lane
as a constant, to see
if it can get a better (but less general) plan that way. I think that's
probably what happened in your experiment, but you didn't provide enough
details to be sure.
regards, tom lane
ke they'd be subject to translation. I'm really not eager to
turn loose an automatic-zwsp-inserter for a problem that might be mostly
hypothetical once we have a more forgiving table layout in place.
regards, tom lane
Alvaro Herrera writes:
> On 2020-Feb-12, Tom Lane wrote:
>> I also attached a screenshot of a segment of Table 9-31, to show
>> what that layout proposal looks like. It's a little busier, but
>> it does have the advantage that it's clearer how to apply that
>>
L format the trouble threshold is a good deal
higher. I wonder if we could improve matters by switching to some
narrower font for text in PDF?
regards, tom lane
[1]
https://www.postgresql.org/message-id/2020011618.GA25792%40alvherre.pgsql
diff --git a/doc/src/sgml/func
st sentence uses "graph" as a verb, while the next one uses
"graph" as a noun. Both are correct English, but I can understand that
the inconsistency might confuse non-native speakers. Not sure if it's
worth changing.
regards, tom lane
ybe not. But we have to have a redirect,
else external links pointing at this page will be broken.
We have done page renames with redirects in the past, if memory serves,
so it's possible. But I don't know details.
regards, tom lane
t the WINDOW keyword.
If that wasn't the issue, you need to show more specifically what
you tried.
I agree that the syntax definition isn't terribly precise, but
people don't seem to have trouble with the very comparable
rules for, say, FROM or GROUP BY.
regards, tom lane
le.) This value will
>> It does actually mean "even and odd". This kind of rounding is also
>> called "Banker's Rounding".
>> https://en.wikipedia.org/wiki/Rounding#Round_half_to_even
> Oh, Thanks! The link is very helpful.
I think actually the standard terminology is "round-to-nearest-even".
regards, tom lane
y about updating the manual page for
CREATE GROUP though :-(. Will fix, thanks for the report!
regards, tom lane
s
> also allow control over..."
> as it appears to pertain to the previous example block.
Yeah, I agree, somebody was sloppy about inserting a new paragraph.
Will fix, thanks for the report!
regards, tom lane
Euler Taveira writes:
> It seems an oversight. I'm attaching patches to fix it in all supported
> branches. v11 can be applied cleanly to v12/master.
Ah, I'd already done this before seeing your response :-(
regards, tom lane
ven though or links will take you right to the exact
table entry, the index entries generated from the indexterms only
point to the page. That seems pretty sad, why isn't it better?
regards, tom lane
arrow and switch the
font to match 's choice, this would work more or less decently, and
it's probably cleaner than the bare-entity-reference approach I posted
before. I don't have the XSL skills to get that to work though.
Anyone want to help out?
regards, tom lane
[1] https://www.postgresql.org/message-id/23574.1581555393%40sss.pgh.pa.us
rticularly wondering how an would render.)
regards, tom lane
the arrow ends up
adjacent to the type name.)
So I'm pretty happy with this implementation and will push forward.
regards, tom lane
diff --git a/doc/src/sgml/stylesheet-common.xsl b/doc/src/sgml/stylesheet-common.xsl
index e148c90..5936d9a 100644
--- a/doc/src/sgml/styles
Corey Huinker writes:
> On Sat, Apr 11, 2020 at 6:41 PM Tom Lane wrote:
>> Don't have a strong opinion about that, but it'd sure be a lot of new
>> anchors.
> So I can't speak to any scalability issues for adding a bunch of refs,
I did a quick check by adding id tags
markup and others not.
regards, tom lane
HERE clauses of a
SELECT.
IOW, Query.jointree->quals.
regards, tom lane
Corey Huinker writes:
> On Sat, Apr 11, 2020 at 6:41 PM Tom Lane wrote:
>> Is that going to be a problem for the docs toolchain? If
>> the anchors are attached to individual function names rather than
>> sections or paragraphs, do they actually work well as link references?
Alexander Lakhin writes:
> 12.04.2020 20:33, Tom Lane wrote:
>> I educated myself a teensy bit about XSL, and unless I'm missing
>> something, this is really pretty darn trivial; the attached seems
>> to do the trick.
> I've come to almost the same solution simultaneousl
t's just PG_ARGISNULL without any type-specific
decoration. Will push in a moment.
regards, tom lane
be secondary examples rather than the only one. There's some work
afoot to restructure this chapter's function tables in a way that would
make that a bit less painful vertical-space-wise, so maybe it'll get
done soon.
regards, tom lane
appens here is that text between quotes is considered
quoted (so that, for example, commas within it are not field separators),
but that does not exclude there being other unquoted text within the
same field value.
regards, tom lane
t;The contents of a string value must be
validly encoded according to the database's encoding, and cannot include
the character with code zero". I'd sort of thought we said that there
already, but I don't see it.
regards, tom lane
ng nul rejection in some code
path, then we're probably not doing encoding validation at all.
regards, tom lane
Alexander Lakhin writes:
> 26.04.2020 22:13, Tom Lane wrote:
>> Use of a new processing-instruction might not be the most elegant
>> way to do this ... anyone have a better suggestion?
> I would use the phrase tag, which is intended for such uses: [1] [2].
Good i
Alexander Lakhin writes:
> 27.04.2020 18:04, Tom Lane wrote:
>> BTW, I tried to also use this markup inside the template for
>> , so we'd only need one font-switching special case not two.
>> Didn't work though --- apparently templates don't get applied recursively?
&
ity isn't loaded yet.)
regards, tom lane
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index b0afaeb..fdbd4a0 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -1365,7 +1365,7 @@ repeat('Pg', 4) PgPgPgPg
pi ( )
Pavel Borisov writes:
> This patch little bit clarifies parsing of operators websearch_to_tqsuery()
> function
I pushed a version of this. Thanks for noticing the omission.
regards, tom lane
not very happy with that approach. Surely Lockhart[1] got this
definition from someplace, though, and didn't invent it out of thin air.
regards, tom lane
[1] I'd supposed we could blame this stuff on Berkeley, but excavation
in our git history shows it c
101 - 200 of 603 matches
Mail list logo
