PG Doc comments form writes:
> The table on information_schema.tables documentation page is broken after
> version 12.
> Instead of three columns in header and body all text is packed inside one.
That's an intentional change.
regards, tom lane
just this one mistake.
regards, tom lane
sed in the docs, and with markup).
Pushed, thanks for preparing the patch.
regards, tom lane
Bruce Momjian writes:
> On Thu, Jul 15, 2021 at 11:12:38PM -0400, Tom Lane wrote:
>> At least two of these changes are flat out wrong. The places
>> that explicitly mention "substring(s)" are not doing so because
>> we failed to think about what that meant.
>
postgresql-version under the current ...
Admittedly, someone who doesn't grok that
version is a variable might be confused
initially, but I think they'd soon figure it out after seeing the
file names on the server.
regards, tom lane
On the whole though,
I'm having qualms about recommending this in this particular spot,
rather than back in Appendix I. Seems like the wrong audience is
going to be reading this chapter.
regards, tom lane
close
enough to universal that we don't need to be pedantic about it.
regards, tom lane
Alvaro Herrera writes:
> On 2021-Jul-21, Tom Lane wrote:
>> I'm having qualms about recommending this in this particular spot,
>> rather than back in Appendix I. Seems like the wrong audience is
>> going to be reading this chapter.
> Well, we can remove that first parag
hat you chose the .bz2 file instead of the .gz one.
regards, tom lane
t thought about it.
Of the options we provide in the core distro, plpython is less suitable
because it only comes in an untrusted form (for lack of any workable
sandboxing feature in Python). So plperl or pltcl is what there is.
regards, tom lane
oposal though. In the
meantime I'm not much on board with sprinkling cross-references into
random places, if only because those references will be pointing to
the wrong place when/if this refactoring does happen.
regards, tom lane
what that meant.
regards, tom lane
t; is the patch to add "(process)" to them.
> - Auxiliary process
> - Startup process
> - WAL receiver
I think "Auxiliary process (process)" is redundant to the point
of being silly. +1 for addiing it to "WAL receiver", though,
since that's not obviously a process.
regards, tom lane
me page are also
rendered with less-than-usual spacing around them (to my eye
anyway); though this is the only one that looks like it has no
space at all.
regards, tom lane
larger issue is that blind "mkdir -p" may not produce the ownerships
and permissions you want for the parent directories. That's not a
topic to get into in a one-line summary, though.
regards, tom lane
bout just inserting a parenthetical remark at the first usage?
... leader process requests shared locks (ACCESS SHARE) on the ...
Possibly we could make the "ACCESS SHARE" be a without causing
problems in man format.
regards, tom lane
Schemas don't enter into it.
regards, tom lane
here, because it's not the inverse of "whatever IS NULL".)
regards, tom lane
nly function that acts that way.
regards, tom lane
"Daniel Westermann (DWE)" writes:
> which rules do we follow for writing hot standby?
The original author liked to capitalize it, but that's since been
followed only intermittently. Personally I'd just as soon lose
the caps.
regards, tom lane
l_indexes.idx_scan instead the second
> time. I.e. bitmap scans do not increment idx_scan.
Um ... you did notice that the mentions of idx_tup_fetch apply to two
different views, pg_stat_all_tables vs pg_stat_all_indexes?
regards, tom lane
/systemd/man/systemd.service.html#TimeoutStartSec=,
> this should be set to "infinity" to disable the timeout.
Hmm ... maybe zero works too, or worked when this was written?
But you're right that "infinity" is now the documented way
to do it. Will fix, thanks for the report.
regards, tom lane
Justin Pryzby writes:
> On Sun, Mar 20, 2022 at 12:11:19PM -0400, Tom Lane wrote:
>> Hmm ... maybe zero works too, or worked when this was written?
>> But you're right that "infinity" is now the documented way
>> to do it. Will fix, thanks for the report.
quot; useful enough to
include in the report?
regards, tom lane
from reading it, and that could
> be made a lot more clear.
I dunno, the section already makes it perfectly clear that there
are two functions. I could get behind documenting the more modern
one first, though.
I wonder if it's time to remove the references to PG 8.1?
regards, tom lane
Daniel Gustafsson writes:
>> On 30 Jan 2022, at 16:52, Tom Lane wrote:
>> I could get behind documenting the more modern
>> one first, though.
> +1
Proposed patch attached.
>> I wonder if it's time to remove the references to PG 8.1?
> I think it's time to re
" code that fails to
conform to the JSON RFC, so I'm disinclined to work harder than that.
regards, tom lane
d idea, done.
regards, tom lane
Bruce Momjian writes:
> OK, updated patch attached. I don't think we even show TCL syntax
> anywhere anymore, so I removed that text, rather than moving it.
WFM.
regards, tom lane
ackets, to indicate an optional element in a
syntax synopsis.
regards, tom lane
ations (not only output) that can distinguish
them, so the index can't lump them together.
There are similar issues in some other datatypes, for example
zero and minus zero in the float types.
regards, tom lane
to zero, and they are likely to be familiar enough to not
> need our preface to enlighten them.
Maybe time to drop the Tcl reference altogether? I like that language,
but I fear it's next door to dead, so it certainly doesn't need to be
mentioned outside the pltcl docs.
regards, tom lane
Bruce Momjian writes:
> How is this patch?
I'd still drop the Tcl bit, or if you must have it, move it to
pltcl.sgml. Otherwise OK by me.
regards, tom lane
continuing to find that 9.1 page when the search terms
include GIN and GIST. I suspect it's keying off those terms appearing
in the page title :-(
After the recent changes discussed on the -www list, it's possible
that Google will eventually stop indexing the 9.1 page altogether,
but I'm not holding my breath.
regards, tom lane
Peter Geoghegan writes:
> On Tue, Apr 12, 2022 at 12:49 PM Tom Lane wrote:
>> I think we should take the index type names out of the section title
>> entirely, and name it something generic like "Preferred Index Types for
>> Full Text Search".
> Agreed.
Prop
es.html
role-attributes.html is not intended to be a substitute for that.
regards, tom lane
Peter Geoghegan writes:
> On Tue, Apr 12, 2022 at 1:28 PM Tom Lane wrote:
>> Proposed patch attached. The existing text already says "GIN indexes are
>> the preferred text search index type", so I'm not sure we need to go
>> further than that about
expressions, however." Not sure if we
cover that explicitly anywhere else.
regards, tom lane
to document this?
Section 8.5.1.2. Times already says "The appropriate time zone offset
is recorded in the time with time zone value." Maybe that could be
made a little more precise, say "The resolved numeric offset from UTC
is recorded in the time with time zone value."
regards, tom lane
t a good fix.
regards, tom lane
Laurenz Albe writes:
> On Mon, 2023-10-16 at 12:29 -0400, Tom Lane wrote:
>> So that feels like a bug: we should not allow ALTER SYSTEM to execute
>> against a placeholder GUC definition, because the placeholder can't
>> tell us whether the value is valid. I wonder
feels like a bug: we should not allow ALTER SYSTEM to execute
against a placeholder GUC definition, because the placeholder can't
tell us whether the value is valid. I wonder though if forbidding
this would break any legitimate usage patterns.
regards, tom lane
e limitation to 1-microsecond precision is spelled out in the
table just above the para you quote.
regards, tom lane
n to have some such feature but it never got done?
Anyway, I don't see anything indicating that there's actually
such a concept as "the default connection". I suggest we just
remove those paragraphs.
What *is* treated specially is CURRENT --- but EXEC SQL SET
CONNECTION = CURRENT is effectively a no-op, so it's not very
exciting.
regards, tom lane
tamptz value?
regards, tom lane
DATABASE does not copy
+ database-level GRANT permissions attached to the
+ source database. The new database has default permissions.
+
+
There is a second standard system database named
regards, tom lane
Bruce Momjian writes:
> On Wed, Nov 1, 2023 at 06:32:37PM -0400, Tom Lane wrote:
>> But it *is* permissible, unless we add code to reject it during
>> SET as Bruce mentioned. Which seems fairly pointless to me. It's not
>> like there is anything unclear about the CREAT
there is anything unclear about the CREATE TABLE error message.
regards, tom lane
Bruce Momjian writes:
> I found a cleaner improvement, attached.
OK by me. Maybe that doesn't make the point strongly enough,
but we can hope it's enough.
regards, tom lane
"Daniel Westermann (DWE)" writes:
> Creating a table with 1600 bigint columns does work with a 8k blocksize:
Yeah, but populating it would not (unless many of the columns were
NULL).
regards, tom lane
mpact of NULLs, and the fact that usually tables have some
variable-width columns, I doubt that a creation-time warning could be
accurate enough to be useful.
regards, tom lane
about PL/pgSQL features into command
reference pages that have nothing to do with PL/pgSQL.
regards, tom lane
ion that mentions partial indexes at all. Somebody
reading the chapter in order would have no idea what we were
talking about.
regards, tom lane
so, that para already mentions that the input can be a
comma-separated list when appropriate, so your add-on para seems
partially repetitive. I think you could just drop the first
sentence of it.
regards, tom lane
Daniel Gustafsson writes:
>> On 22 Sep 2023, at 19:04, Tom Lane wrote:
>> I propose the attached. (I also modified the para's last sentence to
>> speak of "kind" not "type", for consistency with the relkind field name
>> and the rest of the
"type", for consistency with the relkind field name
and the rest of the para.)
regards, tom lane
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index d17ff51e28..e09adb45e4 100644
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -1893,8
relkind for that anymore.
What probably does deserve to be called out in place of those is
composite types, since their appearance in pg_class might be pretty
surprising to newbies.
regards, tom lane
unless --if-exists is also specified.
--if-exists
Use DROP ... IF EXISTS commands to drop objects in --clean mode.
This suppresses "does not exist" errors that might otherwise be
reported. This option is not valid unless --clean is also specified.
regards, tom lane
ut that
doesn't result in an automatic kill of the server process.
> Do you want to propose a patch?
There are enough environmental dependencies involved here that
any simple description is likely to contain lies. So I'm
hesitant to try to put anything about it into the docs.
regards, tom lane
gitweb/?p=postgresql.git;a=commitdiff;h=75af0f401f905b947ea14401e8a51f1bae4ac265
regards, tom lane
OW-FUNCTIONS
> but I think it would be helpful to put some examples in
> https://www.postgresql.org/docs/16/functions-window.html
That page starts out with a link to section 3.5 which is
full of examples. Seems a bit repetitive to put more here.
regards, tom lane
cs/current/rangetypes.html#RANGETYPES-DISCRETE
regards, tom lane
gt; complete.
Perhaps a parenthetical remark like "(pg_basebackup refers to this as
'spread' mode)" would help?
regards, tom lane
reservation VALUES
> (1108, '[2010-01-01 14:30, 2010-01-01 15:30)');
> there should be ] after 15:30
No, it looks correct as given: that end of the range is open not closed.
regards, tom lane
for some other
feature identifiers?
regards, tom lane
der though if there's really just one place claiming that
that's how it works. A trawl through the code comments might
be advisable.
regards, tom lane
Daniel Gustafsson writes:
>> On 7 Oct 2023, at 22:22, Tom Lane wrote:
>> Yeah, either way has the same result. However, I wonder if we should
>> change this example to use current_user for clarity. It does look
>> more like it's intended to be a variable or column r
, either way has the same result. However, I wonder if we should
change this example to use current_user for clarity. It does look
more like it's intended to be a variable or column reference than
a built-in function.
regards, tom lane
sers can't see
umoptions.
regards, tom lane
potting it.
I wonder whether we should update this or just remove it --- it's
clearly something that's likely to get missed again.
regards, tom lane
dered to be within any
schema: extensions have unqualified names that must be unique
database-wide. But objects belonging to the extension can be within
schemas."
I hardly see how we could make this any plainer.
regards, tom lane
"Jonathan S. Katz" writes:
> On 5/31/22 10:55 AM, Tom Lane wrote:
>> I wonder whether we should update this or just remove it --- it's
>> clearly something that's likely to get missed again.
> While burdensome, +1 for updating. We don't want users to get caught by
&
ls of keyword reserved-ness in Postgres,
and a simple highlighted-or-not scheme is not going to capture any of
that nuance.
regards, tom lane
he same page.
Hmm, this was fixed recently in HEAD, but it should have been
back-patched to v14 and was not.
Will fix, thanks for noticing!
regards, tom lane
rd.
Use the index.
regards, tom lane
y belong there.
The NOTE you mention is gone altogether as of v15.
regards, tom lane
'::integer[])
+{1,2,3,1}
uniq(sort('{1,2,3,2,1}'::integer[]))
regards, tom lane
Daniel Gustafsson writes:
>> On 3 Jun 2022, at 17:34, Tom Lane wrote:
>> .. there's no longer any reason we have
>> to limit ourselves to one example. I propose this:
> +1
Done like that, then.
regards, tom lane
:
https://www.postgresql.org/docs/current/plpgsql-statements.html#PLPGSQL-STATEMENTS-SQL-ONEROW
regards, tom lane
Bruce Momjian writes:
> +not occur at certain isolation levels; higher
The docs toolchain is not gonna like that.
regards, tom lane
ime: 1830.390 ms
(13 rows)
The parentheses are actually optional here, if memory serves --- to get
the ORDER BY to be applied inside the second sub-select, you'd have to
use parens as Shay had it.
regards, tom lane
s not correct. I tried creating a PK or unique
> key index on a CITEXT column. It checks uniqueness in case-insensitivity.
That paragraph is talking about what happens when you *don't* use citext.
regards, tom lane
omparisons yield
> true (including the case where the array has zero elements)."
I don't see any conflict there.
regards, tom lane
em to recall some discussion of letting the commit info pop up
as a tooltip. Not sure that that counts as "unobtrusive", though.
regards, tom lane
imilar statement on every single
one of our program man pages?
>> The page could use a hyperlink/cross-reference to the pg_hba.conf
>> documentation.
> That's easily fixed. How about the attached patch?
That part's OK, but personally I'd only have cited the link once.
regards, tom lane
np[FLEXIBLE_ARRAY_MEMBER]; /* line pointer array */
...
regards, tom lane
didn't realize that.
This is a job for the glossary, perhaps?
regards, tom lane
rusted source, you must ...
Or maybe even better, just drop "shell command" from that phrase
altogether.
Probably also s/passing/including/ in the next sentence.
regards, tom lane
opping "specifying" works fine with fewer words.
> The attached includes all the above suggestions.
LGTM.
regards, tom lane
ost
common Values' Frequencies". (Summing the MCVs themselves isn't
sensible; they might not even be numeric.)
I'd vote for replacing mvf in both places with something a bit more
spelled-out, perhaps "mcv_freqs".
regards, tom lane
going effort to create a respectable substitute,
but it still hasn't gotten across the finish line [1].
regards, tom lane
[1] https://commitfest.postgresql.org/39/1608/
urn 20 bolts.
> I agree, based on the attached test.
> ...
> Doc patch attached.
Pushed, thanks.
regards, tom lane
palatable. If the conversion is sufficiently automated,
that might not be a big lift. (If it's *not* automated, I think
the change would never get off the ground even for HEAD, because
the docs are too much of a moving target.)
regards, tom lane
Laurenz Albe writes:
>> I think that adding "bpchar(n)" in table 8.4 would be a good thing.
> Here is a patch for that.
There would need to be some mention of it in the paras below, too.
regards, tom lane
Laurenz Albe writes:
> On Wed, 2022-09-28 at 10:48 -0400, Tom Lane wrote:
>> There would need to be some mention of it in the paras below, too.
> True. I think the attached should be sufficient.
Pushed. I failed to resist the temptation to do some further cleanup
in t
-CONFIG-LOGGING-JSONLOG-KEYS-VALUES
> Yeah, that's a typo. Patch attached.
Shouldn't it be "integer"?
regards, tom lane
parately for each affected extension.
regards, tom lane
so a single column, which is more relevant to the point being
made. Compare this to the immediately preceding example.
regards, tom lane
orrect because they *are* standard
regular expression notations. So I think being consistent with that
is more useful than writing something else. Also, we have five
cross-references to Patterns on that page already, so I don't think
a sixth would add much.
regards, tom lane
ND on
Linux, as suggested at [1] ... although that hobbles error
detection, so I'm not really sold that it's such a great idea.)
regards, tom lane
[1] https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
401 - 500 of 616 matches
Mail list logo
