Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-16 Thread Radosław Smogura
Craig Ringer Thursday 16 of June 2011 06:14:13 > On 16/06/11 04:49, Josh Berkus wrote: > > We especially need folks who are able to build PostgreSQL on Windows, as > > we have several Windows-specific patches and no reviewers for them. > > Urrrggh. Does that mean I have to volunteer myself? ;

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-16 Thread Josh Berkus
Radoslaw, > https://commitfest.postgresql.org/action/patch_view?id=565 > https://commitfest.postgresql.org/action/patch_view?id=579 Actually, I assigned you to 580 instead of 579, because supposedly Noah is reviewing 579. -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-16 Thread Bill Moran
In response to Joshua Berkus : > > > I have no knowledge on the subject one way or the other, that's why > > I'm asking.. If the answer is "no, there would be no benefit" then > > that's the answer.. However, it seems like generating UUIDs in Win64 > > has been broken, perhaps, forever which is w

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-16 Thread Joshua Berkus
> I have no knowledge on the subject one way or the other, that's why > I'm asking.. If the answer is "no, there would be no benefit" then > that's the answer.. However, it seems like generating UUIDs in Win64 > has been broken, perhaps, forever which is why I question if there's a > better librar

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-16 Thread Joshua Berkus
Craig, > Well, a quick look through > https://commitfest.postgresql.org/action/commitfest_view/inprogress > suggests that these could use attention: Let me know which one of these you want to take first. I'll put your name by it. -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com San

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-16 Thread Torsten Zühlsdorff
Josh Berkus schrieb: You do not have to be a C coder to be a patch reviewer. Pretty much all you need to know is: - how to checkout PostgreSQL from Git - how to build PostgreSQL from source - how to apply a patch If you know those three things, you can help with patch review. Of course, if yo

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-16 Thread Greg Smith
On 06/15/2011 04:49 PM, Josh Berkus wrote: You do not have to be a C coder to be a patch reviewer. Pretty much all you need to know is: - how to checkout PostgreSQL from Git - how to build PostgreSQL from source - how to apply a patch And you don't even really need to know these things wel

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-15 Thread Mike Christensen
On Wed, Jun 15, 2011 at 10:34 PM, Tom Lane wrote: > Mike Christensen writes: >> Wouldn't it be faster/better/easier if Postgres just had its own built >> in UUID generator? > > Why would it be?  If you think you can easily improve on uuid-ossp, > you should go help them. I have no knowledge on t

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-15 Thread Tom Lane
Mike Christensen writes: > Wouldn't it be faster/better/easier if Postgres just had its own built > in UUID generator? Why would it be? If you think you can easily improve on uuid-ossp, you should go help them. regards, tom lane -- Sent via pgsql-general mailing list (

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-15 Thread Mike Christensen
Wouldn't it be faster/better/easier if Postgres just had its own built in UUID generator? Last I tested generating a bunch of UUIDs, it was quite slow (well compared to MS SQL anyway).. On Wed, Jun 15, 2011 at 10:23 PM, Tom Lane wrote: > Mike Christensen writes: >> Did anyone ever fix the annoy

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-15 Thread Tom Lane
Mike Christensen writes: > Did anyone ever fix the annoying thing where uuid_generate_v4() > doesn't work on Windows 64bit? AFAIR that was an issue with the uuid-ossp library, so it would be a matter for that upstream group to deal with. regards, tom lane -- Sent via pg

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-15 Thread Mike Christensen
Did anyone ever fix the annoying thing where uuid_generate_v4() doesn't work on Windows 64bit? On Wed, Jun 15, 2011 at 9:46 PM, Tom Lane wrote: > Craig Ringer writes: >> Any chance of flagging patches on the commitfest when they're platform >> specific? I'm hurting for time but will check out Wi

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-15 Thread Tom Lane
Craig Ringer writes: > Any chance of flagging patches on the commitfest when they're platform > specific? I'm hurting for time but will check out Windows-specific stuff > if it's an area the project particularly needs help with. Well, a quick look through https://commitfest.postgresql.org/action/

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-15 Thread Craig Ringer
On 16/06/11 04:49, Josh Berkus wrote: > We especially need folks who are able to build PostgreSQL on Windows, as > we have several Windows-specific patches and no reviewers for them. Urrrggh. Does that mean I have to volunteer myself? ;-) I kind of regret learning to develop on Windows, beca

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-15 Thread sunpeng
Cool, I hope I could be a member of patch reviewers. peng sun On Thu, Jun 16, 2011 at 4:58 AM, Merlin Moncure wrote: > On Wed, Jun 15, 2011 at 3:49 PM, Josh Berkus wrote: > > PostgreSQL community members: > > > > Do you love the PostgreSQL project? Do you want to contribute to it? > > Do you w

Re: [GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-15 Thread Merlin Moncure
On Wed, Jun 15, 2011 at 3:49 PM, Josh Berkus wrote: > PostgreSQL community members: > > Do you love the PostgreSQL project?  Do you want to contribute to it? > Do you want to help produce the next version of PostgreSQL? (9.2) > > Well, you *can*.  You can be a patch reviewer -- one of the single m

[GENERAL] You could be a PostgreSQL Patch Reviewer!

2011-06-15 Thread Josh Berkus
PostgreSQL community members: Do you love the PostgreSQL project? Do you want to contribute to it? Do you want to help produce the next version of PostgreSQL? (9.2) Well, you *can*. You can be a patch reviewer -- one of the single most valuable things you can contribute to the project. You do