Re: Covering GiST indexes

Thanks, Thomas! > 30 июля 2018 г., в 3:58, Thomas Munro > написал(а): > > On Sun, Jul 29, 2018 at 10:50 PM, Andrey Borodin wrote: >> Thanks! The problem appeared with commit 701fd0b [0] which dropped >> validation rules checked in failed test. Here's the patch with fixed tests. > > Thanks.

Re: Usability fail with psql's \dp command

Hello. At Sun, 29 Jul 2018 21:34:29 -0400 (EDT), Fabien COELHO wrote in > > >> My 0.02¤: this creates an exception for anyone trying to parse the > >> output. > >> I would have preferred empty logically meaning no rights, and the > >> default > >> being spelled out explicitely. > > > > Uh,

RE: Recovery performance of standby for multiple concurrent truncates on large tables

Hi Andres, > I think this is a case where the potential work arounds are complex enough to > use significant resources to get right, and are likely to make properly > fixing the issue harder. I'm willing to comment on proposals that claim not > to be problmatic in those regards, but I have

Re: Making "COPY partitioned_table FROM" faster

On Sat, Jul 28, 2018 at 6:00 PM, David Rowley wrote: > Oops. Must've fallen off in transit :) Hopefully, it's more firmly > attached this time. > LGTM. Status changed to "ready for committer"

Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

On Thu, May 17, 2018 at 8:20 PM, Paul Guo wrote: > Thanks. I tentatively submitted a patch (See the attachment). Hi Paul, It looks like you missed a couple of changes in the contrib/btree_gist bit and varbit tests, so make check-world fails: - Index Cond: ((a >= B'100'::"bit") AND (a <=

Re: Usability fail with psql's \dp command

My 0.02¤: this creates an exception for anyone trying to parse the output. I would have preferred empty logically meaning no rights, and the default being spelled out explicitely. Uh, who'd be trying to parse the output of \dp? Ok. Maybe humans? Note that 'No privileges' could be somehow

Re: adding tab completions

Sorry for the delay..this got lost while catching up after being out of town.. On Thu, Jun 28, 2018 at 02:20:39PM +0300, Arthur Zakirov wrote: > Thank you for the new version. > > On Wed, Jun 27, 2018 at 03:10:51PM -0500, Justin Pryzby wrote: > > Thanks - I've done this in the attached. It

Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack

On Sun, Jul 29, 2018 at 04:11:38PM +, Bossart, Nathan wrote: > On 7/27/18, 7:10 PM, "Michael Paquier" wrote: > > No problem. If there are no objections, I am going to fix the REINDEX > > issue first and back-patch. Its patch is the least invasive of the > > set. > > This seems like a

Re: Would like to help with documentation for Postgres 11

> Justin Pryzby writes: >> On Sun, Jul 29, 2018 at 11:50:40AM -0500, Michael Goldshteyn wrote: >>> I would like to offer some help writing and improving the English >>> documentation for some of the new features and changes in Postgres 11. If I >>> can get an email of where such help would be

Adding a note to protocol.sgml regarding CopyData

In libpq.sgml following is stated: Before PostgreSQL protocol 3.0, it was necessary for the application to explicitly send the two characters \. as a final line to indicate to the server that it had finished sending COPY data. While this still works, it is

Re: Covering GiST indexes

On Sun, Jul 29, 2018 at 10:50 PM, Andrey Borodin wrote: > Thanks! The problem appeared with commit 701fd0b [0] which dropped > validation rules checked in failed test. Here's the patch with fixed tests. Thanks. I received the attachment. Just as an FYI, something about the way your mail

Re: [HACKERS] Parallel Append implementation

On Thu, May 10, 2018 at 7:08 AM, Robert Haas wrote: > [parallel-append-doc-v2.patch] +plans just as they can in any other plan. However, in a parallel plan, +it is also possible that the planner may choose to substitute a +Parallel Append node. Maybe drop "it is also possible that

Re: Bizarre behavior in libpq's searching of ~/.pgpass

On 07/29/2018 11:15 PM, Tom Lane wrote: > Here's a proposed patch to adopt that behavior. I'm still of mixed > mind whether to push this into v10 ... but we definitely need some > change in v10, because it's not acting as per its docs. Is there actually a useful use case working in v10 and

Re: Fwd: Would like to help with documentation for Postgres 11

Justin Pryzby writes: > On Sun, Jul 29, 2018 at 11:50:40AM -0500, Michael Goldshteyn wrote: >> I would like to offer some help writing and improving the English >> documentation for some of the new features and changes in Postgres 11. If I >> can get an email of where such help would be

Re: Fwd: Would like to help with documentation for Postgres 11

On Sun, Jul 29, 2018 at 11:50:40AM -0500, Michael Goldshteyn wrote: > I would like to offer some help writing and improving the English > documentation for some of the new features and changes in Postgres 11. If I > can get an email of where such help would be appreciated, so I can choose a >

Re: Bizarre behavior in libpq's searching of ~/.pgpass

I wrote > I noticed that there's some strange coding in libpq's choice of > what hostname to use for searching ~/.pgpass for a password. > ... > So my first thought was that we should go back to the pre-v10 behavior > of considering only the host parameter, which it looks like would only >

Re: [PATCH] Improve geometric types

On 07/29/2018 10:57 PM, Tom Lane wrote: > Tomas Vondra writes: >> This should fix it I guess, and it's how we deal with unused return >> values elsewhere. I've considered using USE_ASSERT_CHECKING here, but it >> seems rather ugly with that. I'll wait for Emre's opinion ... > > I think what you

Re: [PATCH] Improve geometric types

Tomas Vondra writes: > This should fix it I guess, and it's how we deal with unused return > values elsewhere. I've considered using USE_ASSERT_CHECKING here, but it > seems rather ugly with that. I'll wait for Emre's opinion ... I think what you want is to mark the variable with

Re: [PATCH] Improve geometric types

On 07/29/2018 08:02 PM, Tom Lane wrote: > I wrote: >> Tomas Vondra writes: >>> On 07/29/2018 05:14 PM, Tomas Vondra wrote: FWIW I think this should fix it. Can someone with access to an affected machine confirm? > >>> Gah, shouldn't have posted before trying to compile it. Here is a

Re: [PATCH] Improve geometric types

I wrote: > Tomas Vondra writes: >> On 07/29/2018 05:14 PM, Tomas Vondra wrote: >>> FWIW I think this should fix it. Can someone with access to an affected >>> machine confirm? >> Gah, shouldn't have posted before trying to compile it. Here is a fixed >> version of the fix. > Sure, I'll try this

Fwd: Would like to help with documentation for Postgres 11

I sent the below email to pgsql-committers, but I suppose that pgsql-hackers list might have been the more appropriate mailing list. -- Forwarded message - From: Michael Goldshteyn Date: Sun, Jul 29, 2018 at 11:49 AM Subject: Would like to help with documentation for Postgres 11

Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack

On 7/27/18, 7:10 PM, "Michael Paquier" wrote: > No problem. If there are no objections, I am going to fix the REINDEX > issue first and back-patch. Its patch is the least invasive of the > set. This seems like a reasonable place to start. I took a closer look at 0003. + /* +

Re: [PATCH] Improve geometric types

On 07/29/2018 05:14 PM, Tomas Vondra wrote: > On 07/29/2018 02:03 PM, Tomas Vondra wrote: >> >> ... >> >> Hmm, I see. I think adding it to the else branch should do the trick, >> then, I guess. But I'd be much happier if I could test it somewhere >> before the commit. >> > > FWIW I think this

Re: [PATCH] Improve geometric types

On 07/29/2018 02:03 PM, Tomas Vondra wrote: > > > On 07/29/2018 01:28 PM, Thomas Munro wrote: >> On Sun, Jul 29, 2018 at 10:57 PM, Thomas Munro >> wrote: >>> On Sun, Jul 29, 2018 at 10:35 PM, Tomas Vondra >>> wrote: It's always 0/-0 difference, and it's limited to power machines. I'll

Re: [PATCH] Improve geometric types

On 07/29/2018 04:31 PM, Jeff Janes wrote: > > > On Sat, Jul 28, 2018 at 9:54 PM, Tomas Vondra > mailto:tomas.von...@2ndquadrant.com>> wrote: > > > > I've committed the first two parts, after a review and testing. > > > I'm getting a compiler warning now: > > geo_ops.c: In function

Re: add verbosity to pg_basebackup for sync

On Sun, Jul 29, 2018 at 10:45:10AM -0400, Jeff Janes wrote: > Thanks for committing it. It is probably safer not to backpatch, as > someone might have scripts that look at the output of -v so it shouldn't > change between minor releases. I don't think looking at those would be a > good idea, but

Re: Inconsistent error message in bt_page_items_bytea().

On Fri, Jul 27, 2018 at 05:13:37PM +0530, Ashutosh Sharma wrote: > All the pageinspect functions dealing with raw page has the error > message as "must be superuser to use raw page function" however, > that's not true for bt_page_items_bytea() which has "must be > superuser to use pageinspect

Re: add verbosity to pg_basebackup for sync

On Fri, Jul 27, 2018 at 7:10 PM, Michael Paquier wrote: > On Fri, Jul 27, 2018 at 11:58:42AM -0400, Jeff Janes wrote: > > But it was really waiting for the syncs of the new -D dir to finish. The > > attached patch adds a -v notice that it is starting to do the sync, with > > the wording taken

Re: [PATCH] Improve geometric types

On Sat, Jul 28, 2018 at 9:54 PM, Tomas Vondra wrote: > > > I've committed the first two parts, after a review and testing. > > I'm getting a compiler warning now: geo_ops.c: In function 'line_closept_point': geo_ops.c:2528:7: warning: variable 'retval' set but not used

Re: [PATCH] Improve geometric types

On 07/29/2018 01:28 PM, Thomas Munro wrote: > On Sun, Jul 29, 2018 at 10:57 PM, Thomas Munro > wrote: >> On Sun, Jul 29, 2018 at 10:35 PM, Tomas Vondra >> wrote: >>> It's always 0/-0 difference, and it's limited to power machines. I'll >>> try to get access to such system and see what's

Re: GiST VACUUM

Hi! Thank you! > 29 июля 2018 г., в 14:04, Thomas Munro > написал(а): > > On Tue, Jul 24, 2018 at 6:04 AM, Andrey Borodin wrote: >>> 21 июля 2018 г., в 17:11, Andrey Borodin написал(а): >>> <0001-Physical-GiST-scan-in-VACUUM-v13.patch> >> >> Just in case, here's second part of patch series

Re: [PATCH] Improve geometric types

On Sun, Jul 29, 2018 at 10:57 PM, Thomas Munro wrote: > On Sun, Jul 29, 2018 at 10:35 PM, Tomas Vondra > wrote: >> It's always 0/-0 difference, and it's limited to power machines. I'll >> try to get access to such system and see what's wrong. > > This is suspicious: > > /* on some

Re: [PATCH] Improve geometric types

On Sun, Jul 29, 2018 at 10:35 PM, Tomas Vondra wrote: > It's always 0/-0 difference, and it's limited to power machines. I'll > try to get access to such system and see what's wrong. This is suspicious: /* on some platforms, the preceding expression tends to produce -0 */ if

Re: Covering GiST indexes

Hi, Thomas!29 июля 2018 г., в 14:28, Thomas Munro написал(а):On Fri, Jul 6, 2018 at 5:27 AM, Andrey Borodin wrote:Here is v3 version of the patch. I've fixed some comments and added some words to docs.Hi again Andrey,Cfbot reported the

Re: Removing unneeded self joins

On Sat, Jul 28, 2018 at 12:26 AM, Alexander Kuzmenkov wrote: > Here is a current version of the patch, still rather experimental. Hi Alexander, The eval-qual-plan isolation test is failing: - checking 1050 checking 600 + checking 600checking 600

Re: [PATCH] Improve geometric types

On 07/29/2018 03:54 AM, Tomas Vondra wrote: > > > On 07/27/2018 10:20 AM, Kyotaro HORIGUCHI wrote: >> Thank you for taking this. >> >> At Thu, 26 Jul 2018 17:12:50 +0200, Tomas Vondra >> wrote in >> <672f4c42-6742-c1ec-e9a4-1994b815a...@2ndquadrant.com> >>> On 07/11/2018 07:13 PM, Emre

Re: [HACKERS] WIP: long transactions on hot standby feedback replica / proof of concept

On Thu, Mar 1, 2018 at 3:24 AM, Ivan Kartyshov wrote: > Could you give me your ideas over these patches. Hi Ivan, Not sure if this is expected at this stage or not, but just in case you didn't know... the tests under src/test/subscription seem to be broken:

Re: Covering GiST indexes

On Fri, Jul 6, 2018 at 5:27 AM, Andrey Borodin wrote: > Here is v3 version of the patch. I've fixed some comments and added some > words to docs. Hi again Andrey, Cfbot reported the following difference (twice) in the index_including_gist test: - ERROR: included columns must not intersect

Re: GiST VACUUM

On Tue, Jul 24, 2018 at 6:04 AM, Andrey Borodin wrote: >> 21 июля 2018 г., в 17:11, Andrey Borodin написал(а): >> <0001-Physical-GiST-scan-in-VACUUM-v13.patch> > > Just in case, here's second part of patch series with actual page deletion. Hi Andrey, Cfbot says:

Re: Postgres, fsync, and OSs (specifically linux)

On Thu, Jun 14, 2018 at 5:30 PM, Thomas Munro wrote: > On Wed, May 23, 2018 at 8:02 AM, Andres Freund wrote: >> [patches] > > A more interesting question is: how will you cap the number file > handles you send through that pipe? On that OS you call > DuplicateHandle() to fling handles into