Re: New GUC to sample log queries

On 11/26/18 12:40 AM, Thomas Munro wrote: > On Wed, Nov 21, 2018 at 9:06 PM Adrien Nayrat > wrote: >> Thanks for your comments. Here is the updated patch. I fixed a warning for >> missing parentheses in this expression: >> if ((exceeded && in_sample) || log_duration) > > Hi Adrien, > > GCC 4.8

Re: Add extension options to control TAP and isolation tests

В письме от 26 ноября 2018 08:53:20 Вы написали: > > I've carefully read this documentation. And did not get clear explanation > > of what is the true purpose of PGXS environment variable. Only > > > > "The last three lines should always be the same. Earlier in the file, you > > assign variables

Re: Handling of REGRESS_OPTS in MSVC for regression tests

On Mon, Nov 26, 2018 at 02:43:02PM +0900, Michael Paquier wrote: > Another option could also be to switch contribcheck and modulescheck > so as they use a temporary installation, but that's a can of worms > waiting to explode as MSVC makes more complicated the search for > initdb and such (see the

Re: tab-completion debug print

On Mon, Nov 26, 2018 at 12:23:16PM +0900, Kyotaro HORIGUCHI wrote: > Thank you for the comments. > > At Sun, 25 Nov 2018 01:17:27 +0100, David Fetter wrote in > <20181125001727.gm...@fetter.org> > > On Fri, Nov 23, 2018 at 04:32:31PM -0500, Tom Lane wrote: > > > Hm. I can see the value of

Re: tab-completion debug print

On Sun, Nov 25, 2018 at 11:21:51PM -0500, Tom Lane wrote: > Kyotaro HORIGUCHI writes: > >> On Fri, Nov 23, 2018 at 04:32:31PM -0500, Tom Lane wrote: > >>> Hm. I can see the value of instrumenting tab-complete when you're trying > >>> to debug why it did something, but this output format seems

Re: Inadequate executor locking of indexes

On 2018/11/26 14:25, David Rowley wrote: > On Mon, 26 Nov 2018 at 17:37, Amit Langote > wrote: >> On 2018/11/24 1:25, Tom Lane wrote: >>> I'm beginning to think that postponing target-index locking to >>> ExecInitModifyTable was a damfool idea and we should undo it. >> >> +1 >> >> Also as already

RE: [Todo item] Add entry creation timestamp column to pg_stat_replication

On Thu, Nov 15, 2018 at 5:27 PM Michael Paquier wrote: >> Good point. 'last_reply_send_time' is better. >> How about just 'reply_time'? > >Please note that the original thread has mentioned reply_timestamp as a >consensus: So I selected 'reply_time' because 'timestamp' was not used in stat

Re: Updated backup APIs for non-exclusive backups

On Sun, 2018-11-25 at 22:01 +0100, Magnus Hagander wrote: [about managing backups from pre- and post-file-system-backup scrips] > I agree with your point that it's not an uncommon thing to need. If a good > solution > for it can be proposed that requires the exclusive backup interface, then I >

Handling of REGRESS_OPTS in MSVC for regression tests

Hi all, As mentioned on this thread, I have been fighting a bit with the buildfarm when trying to introduce new PGXS options for isolation and TAP tests: https://www.postgresql.org/message-id/e1gr4d0-0002yj...@gemulon.postgresql.org However it happens that we have more issues than the buildfarm

Re: Updated backup APIs for non-exclusive backups

On Sun, 2018-11-25 at 16:04 -0500, Stephen Frost wrote: > > > There isn’t any need to write the backup label before you restore the > > > database, > > > just as you write recovery.conf then. > > > > Granted. > > But it is pretty convenient, and writing it to the data directory right away > > is

Re: Inadequate executor locking of indexes

On Mon, 26 Nov 2018 at 17:37, Amit Langote wrote: > On 2018/11/24 1:25, Tom Lane wrote: > > I'm beginning to think that postponing target-index locking to > > ExecInitModifyTable was a damfool idea and we should undo it. > > +1 > > Also as already proposed, InitPlan should lock result relation

RE: Too many logs are written on Windows (LOG: could not reserve shared memory region (addr=%p) for child %p:)

Hi, Thank you for replying. > You might be right, but maybe we should first try to understand why > this is happening so frequently. Maybe it's not that normal. I found past threads [1] and [2]. In thread [1], the error is mentioned as an ASLR problem. In thread [2], the patch is provided

Re: using expression syntax for partition bounds

On 2018/11/09 14:38, Amit Langote wrote: > Rebased due to change in addRangeTableEntryForRelation's API. Rebased again due to changes in psql's describe output for partitioned tables. Thanks, Amit >From 999aa53b459a6fc0fe899e613406f0e0035aca94 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi

Re: csv format for psql

On Sun, Nov 25, 2018 at 11:23 PM Tom Lane wrote: > Corey Huinker writes: > > Could we have another output type called "separated" that uses the > existing > > --fieldsep / --recordsep? > > Uh, what's the difference from the existing unaligned format? > No footer and I guess we'd want to escape

Re: csv format for psql

po 26. 11. 2018 v 5:36 odesílatel Andrew Gierth napsal: > > "Tom" == Tom Lane writes: > > Tom> Or we could kill both issues by hard-wiring the separator as ','. > > Using ';' for the delimiter isn't all that rare. > ; is default for CSV produced by MS Excel in Czech mutation - so for some

Re: 64-bit hash function for hstore and citext data type

Thanks Tom for enhancing & committing these patches. Regards, Amul On Sat, Nov 24, 2018 at 12:15 AM Tom Lane wrote: > > Andrew Gierth writes: > > "Tomas" == Tomas Vondra writes: > > Tomas> The important question is - can there be two different encodings > > Tomas> for the same hstore value?

Re: Inadequate executor locking of indexes

Sorry for jumping in late on this. On 2018/11/24 1:25, Tom Lane wrote: > David Rowley writes: > Thinking more about this, the problem I noted previously about two of > these solutions not working if the index scan node is not physically > underneath the ModifyTable node actually applies to all

Re: csv format for psql

> "Tom" == Tom Lane writes: Tom> Or we could kill both issues by hard-wiring the separator as ','. Using ';' for the delimiter isn't all that rare. But I don't see any reason to allow multibyte or non-ascii characters or arbitrary strings. -- Andrew (irc:RhodiumToad)

Re: csv format for psql

Corey Huinker writes: > Could we have another output type called "separated" that uses the existing > --fieldsep / --recordsep? Uh, what's the difference from the existing unaligned format? regards, tom lane

Re: tab-completion debug print

Kyotaro HORIGUCHI writes: >> On Fri, Nov 23, 2018 at 04:32:31PM -0500, Tom Lane wrote: >>> Hm. I can see the value of instrumenting tab-complete when you're trying >>> to debug why it did something, but this output format seems pretty terse >>> and unreadable. > The reason for the minimal

Re: csv format for psql

> > > Or we could kill both issues by hard-wiring the separator as ','. +1 I've never encountered a situation where a customer wanted a custom delimiter AND quoted strings. So either they wanted pure CSV or a customed TSV. Could we have another output type called "separated" that uses the

Broken and rotten TAP tests in contrib/bloom/

Hi Alexander & Teodor, It happens that the buildfarm machines do not like much the set of TAP tests present in contrib/bloom/: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=longfin=2018-11-25%2023%3A59%3A03 Here is an extract of the failure: # Failed test 'initial: query result

Re: pgsql: Add PGXS options to control TAP and isolation tests

On Mon, Nov 26, 2018 at 09:33:51AM +0900, Michael Paquier wrote: > Several buildfarm members complain about this commit, including dory and > longfin: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dory=2018-11-26%2000%3A00%3A26 >

Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS

Hi, Attached patches are following: * tab_completion_alter_index_set_statistics.patch - Add column name completion after ALTER COLUMN - Avoid schema completion after SET STATISTICS * fix_manual_of_alter_index.patch - ALTER INDEX ALTER COLUMN syntax is able to use not only

Re: shared-memory based stats collector

Hi, Unfortunately, the patch does not apply anymore - it seems it got broken by the changes to signal handling and/or removal of magic OIDs :-( I've done a review and testing when applied on top of 10074651e335. Firstly, the testing - I was wondering if the patch has some performance impact, so

Re: Regarding performance regression on specific query

Thanks for the comment. We also have several performance regression cases that we found from TPC-C benchmark. Since those queries were not executed on empty relation, they will be more interesting. We will report to pgsql-performance mailing list next time. Jinho Jung

Re: csv format for psql

Fabien COELHO writes: > Basically the proposed patch addresses a simple and convenient use case > which are neither addressed by \copy nor COPY. The fact that more options > are available with these commands does it precludes its usefulness as is. Yeah, I agree that this option is useful

Re: SSL tests failing with "ee key too small" error on Debian SID

On Mon, Nov 26, 2018 at 01:17:24PM +1300, Thomas Munro wrote: > On Wed, Oct 3, 2018 at 1:32 PM Michael Paquier wrote: >> I find your suggestion quite tempting at the end instead of having to >> tweak the global system's configuration. That should normally work with >> any configuration. This

Re: Copy function for logical replication slots

On Sun, Nov 25, 2018 at 12:27 AM Petr Jelinek wrote: > > Hi, > > On 31/08/2018 07:03, Masahiko Sawada wrote: > > > > Attached a new version patch incorporated the all comments I got. > > > > This looks pretty reasonable. Thank you for looking at this patch. > > I am personally not big fan of

Re: pgsql: Add PGXS options to control TAP and isolation tests

On Sun, Nov 25, 2018 at 11:53:02PM +, Michael Paquier wrote: > Add PGXS options to control TAP and isolation tests > > The following options are added for extensions: > - TAP_TESTS, to allow an extention to run TAP tests which are the ones > present in t/*.pl. A subset of tests can always be

Re: pgsql: Integrate recovery.conf into postgresql.conf

On Sun, Nov 25, 2018 at 03:49:23PM +, Peter Eisentraut wrote: > Integrate recovery.conf into postgresql.conf > > recovery.conf settings are now set in postgresql.conf (or other GUC > sources). Currently, all the affected settings are PGC_POSTMASTER; > this could be refined in the future case

Re: SSL tests failing with "ee key too small" error on Debian SID

On Wed, Oct 3, 2018 at 1:32 PM Michael Paquier wrote: > On Mon, Oct 01, 2018 at 09:18:01PM +0900, Kyotaro HORIGUCHI wrote: > > The attached second patch just changes key size to 2048 bits and > > "ee key too small" are eliminated in 001_ssltests_master, but > > instead I got "ca md too weak"

Re: allow online change primary_conninfo

On Sun, Nov 25, 2018 at 01:43:13PM -0800, Andres Freund wrote: > On 2018-11-26 00:25:43 +0300, Sergei Kornilov wrote: >> I think we have no futher reason to have a copy of conninfo and slot >> name in WalRcvData, so i propose remove these fields from >> pg_stat_get_wal_receiver() (and

Re: pgsql: Add WL_EXIT_ON_PM_DEATH pseudo-event.

On Mon, Nov 26, 2018 at 09:53:19AM +1300, Thomas Munro wrote: > I see now that Michael already wrote about this recently[1], but that > thread hasn't yet reached a conclusion. > > [1] > https://www.postgresql.org/message-id/flat/20180917131340.GE31460%40paquier.xyz Yes, I heard nothing but

Re: Add extension options to control TAP and isolation tests

On Sun, Nov 25, 2018 at 05:49:42PM +0300, Nikolay Shaplov wrote: > I've carefully read this documentation. And did not get clear explanation of > what is the true purpose of PGXS environment variable. Only > > "The last three lines should always be the same. Earlier in the file, you > assign

Re: Constraint documentation

On Thu, Nov 22, 2018 at 03:16:11PM +0100, Patrick Francelle wrote: > On 11/15/18 00:02, Tom Lane wrote: > > I think this could be improved some more. Perhaps something like this > > (I've not bothered with markup...) > > > > This is a little verbose maybe, but as the text stands, it sounds like

Re: New GUC to sample log queries

On Wed, Nov 21, 2018 at 9:06 PM Adrien Nayrat wrote: > Thanks for your comments. Here is the updated patch. I fixed a warning for > missing parentheses in this expression: > if ((exceeded && in_sample) || log_duration) Hi Adrien, GCC 4.8 says: guc.c:3328:3: error: initialization makes integer

Re: [HACKERS] Time to change pg_regress diffs to unified by default?

On Thu, Nov 22, 2018 at 02:10:59PM +0100, Christoph Berg wrote: > Re: Noah Misch 2017-04-07 <20170407021431.gb2658...@tornado.leadboat.com> > > > > I personally, and I know of a bunch of other regular contributors, find > > > > context diffs very hard to read. Besides general dislike, for things

Re: Doc patch on psql output formats

"Daniel Verite" writes: > Tom Lane wrote: >> Pushed. (I simplified the code a bit by using just one state variable, >> and also made the error message more verbose.) > Thanks! I noticed while poking at the csv patch that we'd outsmarted ourselves with this one. As of HEAD, it's impossible to

Re: Continue work on changes to recovery.conf API

Greetings, * Sergei Kornilov (s...@zsrv.org) wrote: > > Why don't we put recovery entries into postgresql.recovery.conf or such? > > And overwrite rather than append? > Appending to postgressql.auto.conf instead of writing new hardcoded file was > proposed here: >

Python versions (was Re: RHEL 8.0 build)

Andres Freund writes: > On 2018-11-24 15:49:25 -0500, Tom Lane wrote: >> There's been some preliminary discussion about starting to default to >> python3, but given this project's inherent conservatism, I don't expect >> that to happen for some years yet. In any case, whenever we do pull >> that

Re: Continue work on changes to recovery.conf API

Hi, On 25/11/2018 21:48, Stephen Frost wrote: > Greetings, > > On Sun, Nov 25, 2018 at 15:39 Andres Freund > wrote: > > Hi, > > On 2018-11-25 13:24:15 -0500, Stephen Frost wrote: > > - User performs a backup with pg_basebackup -R > > - Replica is

Re: RHEL 8.0 build

Hi, On 2018-11-24 15:49:25 -0500, Tom Lane wrote: > Jeremy Harris writes: > > Trying to set up a buildfarm animal on a RHEL 8.0 (beta) system, > > the build fails early: > > ... > > It appears to be a "configure" script looking for python; and there is > > no such. You can have python3 or

Re: allow online change primary_conninfo

Hi, On 2018-11-26 00:25:43 +0300, Sergei Kornilov wrote: > Now we integrate recovery.conf into GUC system. So i would like to start > discussion to make primary_conninfo and primary_slot_name PGC_SIGHUP. > My work-in-progress patch attached. Cool! > I think we have no futher reason to have a

allow online change primary_conninfo

Hello all Now we integrate recovery.conf into GUC system. So i would like to start discussion to make primary_conninfo and primary_slot_name PGC_SIGHUP. My work-in-progress patch attached. I think we have no futher reason to have a copy of conninfo and slot name in WalRcvData, so i propose

Re: [HACKERS] advanced partition matching algorithm for partition-wise join

On Mon, Nov 26, 2018 at 9:03 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: > I've noticed, that this patch set is outdated, so here is the rebased version. This turned red on cfbot because I turned on -Werror: partbounds.c: In function ‘partition_bounds_merge’: partbounds.c:3619:43: error:

Re: Updated backup APIs for non-exclusive backups

Greetings, On Sun, Nov 25, 2018 at 15:45 Laurenz Albe wrote: > Stephen Frost wrote: > > > > On restore, you're > > > > going to need to create a recovery.conf (at least in released > versions) > > > > which provides a restore command (needed even in HEAD today) to get > the > > > > old WAL, so

Re: Updated backup APIs for non-exclusive backups

On Sun, Nov 25, 2018 at 9:45 PM Laurenz Albe wrote: > Stephen Frost wrote: > > > > Lastly, if you really want, you can extract out the data from > > > > pg_stop_backup in whatever your post-backup script is. > > > > > > Come on, now. > > > You usually use backup techniques like that because you

Re: pgsql: Add WL_EXIT_ON_PM_DEATH pseudo-event.

On Mon, Nov 26, 2018 at 6:56 AM Tom Lane wrote: > Thomas Munro writes: > > Fix pushed. > > By way of penance, I have now configured PG_TEST_EXTRA="ssl ldap > > kerberos" for my build farm animals elver and eelpout. elver should > > pass at the next build, as I just tested it with --nosend, but

Re: Continue work on changes to recovery.conf API

Hi > Why don't we put recovery entries into postgresql.recovery.conf or such? > And overwrite rather than append? Appending to postgressql.auto.conf instead of writing new hardcoded file was proposed here:

Re: Continue work on changes to recovery.conf API

Greetings, On Sun, Nov 25, 2018 at 15:39 Andres Freund wrote: > Hi, > > On 2018-11-25 13:24:15 -0500, Stephen Frost wrote: > > - User performs a backup with pg_basebackup -R > > - Replica is then promoted to be a primary > > - User performs a backup with pg_basebackup -R on the new primary > >

Re: Updated backup APIs for non-exclusive backups

Stephen Frost wrote: > > > Seeing it often doesn't make it a good solution. Running just > > > pre-backup and post-backup scripts and copying the filesystem isn't > > > enough to perform an online PostgreSQL backup- the WAL needs to be > > > collected as well, and you need to make sure that you

Re: Continue work on changes to recovery.conf API

On 2018-11-25 16:56:13 +0100, Peter Eisentraut wrote: > On 21/11/2018 07:00, Michael Paquier wrote: > >> Author: Simon Riggs > >> Author: Abhijit Menon-Sen > >> Author: Sergei Kornilov > > I think that Fujii Masao should also be listed as an author, or at least > > get a mention. He was one of

Re: Continue work on changes to recovery.conf API

Hi, On 2018-11-25 13:24:15 -0500, Stephen Frost wrote: > - User performs a backup with pg_basebackup -R > - Replica is then promoted to be a primary > - User performs a backup with pg_basebackup -R on the new primary > - Duplicate entries end up in postgresql.auto.conf. Ew. Why don't we put

Re: [HACKERS] [PATCH] Generic type subscripting

On Mon, Nov 26, 2018 at 6:07 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > On Fri, Nov 9, 2018 at 1:55 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > > I've noticed, that patch has some conflicts, so here is the rebased version. > > Also, since people are concern about performance

Re: Updated backup APIs for non-exclusive backups

Greetings, On Sun, Nov 25, 2018 at 14:17 Laurenz Albe wrote: > On Sun, 2018-11-25 at 13:50 -0500, Stephen Frost wrote: > > I don't see any compelling argument for trying to do something half-way > > any more today than I did two years ago when this was being discussed. > > That may well be so.

Re: Support custom socket directory in pg_upgrade

Daniel Gustafsson writes: > [ pg_upgrade_sockdir-v3.patch ] BTW, I notice that cfbot doesn't like this now that Thomas is running it with -Werror: option.c: In function ‘parseCommandLine’: option.c:265:8: error: ignoring return value of ‘getcwd’, declared with attribute warn_unused_result

Re: Updated backup APIs for non-exclusive backups

On Sun, 2018-11-25 at 13:50 -0500, Stephen Frost wrote: > I don't see any compelling argument for trying to do something half-way > any more today than I did two years ago when this was being discussed. That may well be so. It may be better to make users unhappy than to make them very unhappy...

Re: Continue work on changes to recovery.conf API

Peter Eisentraut writes: > Committed with that addition. Some of the buildfarm doesn't like this. I realized that the common denominator was EXEC_BACKEND: if you build with -DEXEC_BACKEND the failure is completely reproducible. Presumably something is thinking that it will inherit some

Re: Updated backup APIs for non-exclusive backups

Greetings, * Laurenz Albe (laurenz.a...@cybertec.at) wrote: > On Sun, 2016-04-24 at 11:49 -0400, Stephen Frost wrote: > > * Magnus Hagander (mag...@hagander.net) wrote: > > > On Sun, Apr 24, 2016 at 5:37 AM, Bruce Momjian wrote: > > > > On Fri, Apr 22, 2016 at 11:53:46AM -0400, Robert Haas

Re: FETCH FIRST clause PERCENT option

Tomas Vondra writes: > On 11/25/18 1:05 PM, Vik Fearing wrote: >> I don't see how this behavior is justified by reading the SQL standard. >> Obviously only an integer number of rows is going to be returned, but >> the percentage should be calculated correctly. > Right. My draft of SQL standard

Re: FETCH FIRST clause PERCENT option

On 11/25/18 1:05 PM, Vik Fearing wrote: > On 25/11/2018 12:49, Surafel Temesgen wrote: >> >> >> On Sun, Nov 25, 2018 at 1:24 PM Vik Fearing > > wrote: >> >> >> Also, this query returns 210 rows instead of the expected 208: >> >>     select * >>    

Re: Continue work on changes to recovery.conf API

Greetings, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > Committed with that addition. I'm concerned that this hasn't been entirely thought through regarding pretty common use-cases, consider a pretty typical pg_basebackup -R usage case: - User performs a backup with

Re: Centralize use of PG_INTXX_MIN/MAX for integer limits

Peter Eisentraut writes: > On 24/11/2018 13:15, Michael Paquier wrote: >> A couple of years ago, 62e2a8dc has introduced in c.h a set of limits >> (to fix some portability issues from 83ff1618) to make the code more >> system-independent. Those are for example PG_INT32_MIN, etc. The core >>

Re: Updated backup APIs for non-exclusive backups

I'm a bit late to the party, but I only recently noticed that the exclusive backup API is deprecated. On Sun, 2016-04-24 at 11:49 -0400, Stephen Frost wrote: > * Magnus Hagander (mag...@hagander.net) wrote: > > On Sun, Apr 24, 2016 at 5:37 AM, Bruce Momjian wrote: > > > On Fri, Apr 22, 2016 at

Re: Don't wake up to check trigger file if none is configured

On Sat, Nov 24, 2018 at 11:29 AM Jeff Janes wrote: > A streaming replica waiting on WAL from the master will wake up every 5 > seconds to check for a trigger file. This is pointless if no trigger file > has been configured. > > The attached patch suppresses the timeout when there is no trigger

Re: pgsql: Add WL_EXIT_ON_PM_DEATH pseudo-event.

Thomas Munro writes: > Fix pushed. > By way of penance, I have now configured PG_TEST_EXTRA="ssl ldap > kerberos" for my build farm animals elver and eelpout. elver should > pass at the next build, as I just tested it with --nosend, but eelpout > is so slow I'll just take my chances see if that

Re: Desirability of client-side expressions in psql?

so 24. 11. 2018 v 22:03 odesílatel Corey Huinker napsal: > > >> >>psql> \if :i >= 5 >> >> >> > I think we're ok with that so long as none of the operators or values >> has a >> > \ in it. >> > What barriers do you see to re-using the pgbench grammar? >> >> The pgbench expression grammar

Re: Continue work on changes to recovery.conf API

HelloThank you! Regards, Sergei

Re: Continue work on changes to recovery.conf API

On 21/11/2018 07:00, Michael Paquier wrote: >> Author: Simon Riggs >> Author: Abhijit Menon-Sen >> Author: Sergei Kornilov > I think that Fujii Masao should also be listed as an author, or at least > get a mention. He was one of the first to work on this stuff. Committed with that addition.

Re: Centralize use of PG_INTXX_MIN/MAX for integer limits

On 24/11/2018 13:15, Michael Paquier wrote: > A couple of years ago, 62e2a8dc has introduced in c.h a set of limits > (to fix some portability issues from 83ff1618) to make the code more > system-independent. Those are for example PG_INT32_MIN, etc. The core > code now mixes the internal PG_

Re: Add extension options to control TAP and isolation tests

В письме от 23 ноября 2018 09:43:45 пользователь Michael Paquier написал: > > So, I continued exploring your patch. First I carefully read changes in > > pgxs.mk. The only part of it I did not understand is > > > > .PHONY: submake > > > > -submake: > > ifndef PGXS > > > > +submake: > >

Re: FETCH FIRST clause PERCENT option

> "Surafel" == Surafel Temesgen writes: Surafel> this is because fetch first values work with integer and it Surafel> change fractional number to nearest integer number like select Surafel> * from generate_series(1, 1000) fetch first 20.3 rows only; is Surafel> not an error rather it

Re: RHEL 8.0 build

On 11/24/18 3:49 PM, Tom Lane wrote: Jeremy Harris writes: Trying to set up a buildfarm animal on a RHEL 8.0 (beta) system, the build fails early: ... It appears to be a "configure" script looking for python; and there is no such. You can have python3 or python2 - but neither package

Re: FETCH FIRST clause PERCENT option

On 25/11/2018 12:49, Surafel Temesgen wrote: > > > On Sun, Nov 25, 2018 at 1:24 PM Vik Fearing > wrote: > > > Also, this query returns 210 rows instead of the expected 208: > >     select * >     from generate_series(1, 1000) >     fetch

Re: FETCH FIRST clause PERCENT option

On Sun, Nov 25, 2018 at 1:24 PM Vik Fearing wrote: > > Also, this query returns 210 rows instead of the expected 208: > > select * > from generate_series(1, 1000) > fetch first 20.8 percent rows only > > this is because fetch first values work with integer and it change fractional

Re: FETCH FIRST clause PERCENT option

On 25/11/2018 10:00, Surafel Temesgen wrote: > > > > > I messed around with your changes to the grammar and it seems you don't > need to add PERCENT as a reserved keyword.  Moving this to the > unreserved > keyword section does not cause any shift/reduce errors, and the >

Re: FETCH FIRST clause PERCENT option

> I messed around with your changes to the grammar and it seems you don't > need to add PERCENT as a reserved keyword. Moving this to the unreserved > keyword section does not cause any shift/reduce errors, and the regression > tests still pass. Relative to your patch v4, these changes help: > >

Re: pgsql: Add WL_EXIT_ON_PM_DEATH pseudo-event.

On Sun, Nov 25, 2018 at 12:59 PM Thomas Munro wrote: > On Sun, Nov 25, 2018 at 3:38 AM Christoph Berg wrote: > > TRAP: FailedAssertion(»!(!IsUnderPostmaster || (wakeEvents & (1 << 5)) || > > (wakeEvents & (1 << 4)))«, Datei: > >