Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance

I really appreciate the addition of tanh into core postgres. If someone doubts it is useful: it is used as a part of math in geographical calculations. Say you have your cars in planar Mercator projection and want to move them "1 second forward by this heading with this speed". sin/cos and the

Re: Add exclusive backup deprecation notes to documentation

On 3/18/19 4:33 PM, Peter Eisentraut wrote: On 2019-03-07 10:33, David Steele wrote: On 3/1/19 3:14 PM, Laurenz Albe wrote: Magnus Hagander wrote: Maybe have the first note say "This method is deprecated bceause it has serious risks (see bellow)" and then list the actual risks at the end?

Re: What to name the current heap after pluggable storage / what to rename?

Hi, On 2019-03-19 15:25:44 +1100, Haribabu Kommi wrote: > On Tue, Mar 19, 2019 at 2:32 PM Andres Freund wrote: > > I'm kinda wondering about replacing the TableTuple prefix with TableMod, > > seems less confusing to me. > One more way, how about just TupleUpdated and etc. Removing of Table? >

Re: extensions are hitting the ceiling

On 03/19/19 00:56, Chapman Flack wrote: > Nobody ever chimed in to say how numerous they did or didn't think the > problems would be. I was actually thinking recently about sitting down > and trying to write that patch, as no one had exactly stood up to say > "oh heavens no, don't write that." Of

Re: extensions are hitting the ceiling

On 03/18/19 22:38, Eric Hanson wrote: > rows are really second class citizens: They aren't tracked with > pg_catalog.pg_depend, they aren't deleted when the extension is dropped, > etc. This. You have other interests as well, but this is the one I was thinking about a few years ago in [1]

Re: [HACKERS] Block level parallel vacuum

On Mon, Mar 18, 2019 at 7:06 PM Kyotaro HORIGUCHI wrote: > > Hello. > > At Mon, 18 Mar 2019 11:54:42 +0900, Masahiko Sawada > wrote in > > Here is the performance test results. I've setup a 500MB table with > > several indexes and made 10% of table dirty before each vacuum. > > Compared

Re: What to name the current heap after pluggable storage / what to rename?

On Tue, Mar 19, 2019 at 2:32 PM Andres Freund wrote: > On 2019-03-18 16:24:40 -0700, Andres Freund wrote: > > Hi, > > > > On 2019-03-13 08:29:47 -0400, Robert Haas wrote: > > > On Tue, Mar 12, 2019 at 8:39 PM Andres Freund > wrote: > > > > > I like that option. > > > > > > > > In that vein,

RE: Timeout parameters

From: Robert Haas [mailto:robertmh...@gmail.com] > I don't think so. I think it's just a weirdly-design parameter > without a really compelling use case. Enforcing limits on the value > of the parameter doesn't fix that. Most of the reviewers who have > opined so far have been somewhere between

Re: Add exclusive backup deprecation notes to documentation

Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-03-18 23:35:07 -0400, Stephen Frost wrote: > > * Robert Haas (robertmh...@gmail.com) wrote: > > > On Mon, Mar 18, 2019 at 11:13 PM Stephen Frost wrote: > > > > I don't view it as up for much debate. > > > > > > In other words,

Re: Add exclusive backup deprecation notes to documentation

Hi, On 2019-03-18 23:35:07 -0400, Stephen Frost wrote: > * Robert Haas (robertmh...@gmail.com) wrote: > > On Mon, Mar 18, 2019 at 11:13 PM Stephen Frost wrote: > > > I don't view it as up for much debate. > > > > In other words, you're not willing to listen to what other people > > think about

Re: Add exclusive backup deprecation notes to documentation

Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Mar 18, 2019 at 11:13 PM Stephen Frost wrote: > > I don't view it as up for much debate. > > In other words, you're not willing to listen to what other people > think about this issue. I have listened, but unfortunately the

Re: What to name the current heap after pluggable storage / what to rename?

On 2019-03-18 16:24:40 -0700, Andres Freund wrote: > Hi, > > On 2019-03-13 08:29:47 -0400, Robert Haas wrote: > > On Tue, Mar 12, 2019 at 8:39 PM Andres Freund wrote: > > > > I like that option. > > > > > > In that vein, does anybody have an opinion about the naming of > > > a)

Re: Add exclusive backup deprecation notes to documentation

On Mon, Mar 18, 2019 at 11:13 PM Stephen Frost wrote: > I don't view it as up for much debate. In other words, you're not willing to listen to what other people think about this issue. I can't say I haven't noticed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: Add exclusive backup deprecation notes to documentation

Greetings, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 2019-03-07 10:33, David Steele wrote: > > On 3/1/19 3:14 PM, Laurenz Albe wrote: > >> Magnus Hagander wrote: > >>> Maybe have the first note say "This method is deprecated bceause it has > >>> serious > >>> risks (see

RE: Libpq support to connect to standby server as priority

From: Haribabu Kommi [mailto:kommi.harib...@gmail.com] > Target_session_attrs Target_server_type > > read-write prefer-slave, slave > > prefer-read master, slave > read-onlymaster, prefer-slave > > I know that some of the

RE: [HACKERS] Cached plans and statement generalization

On Tue, Jan 29, 2019 at 10:46 AM, Konstantin Knizhnik wrote: > Rebased version of the patch is attached. I'm sorry for the late review. I confirmed behavior of autoprepare-12.patch. It is summarized below. ・parameter Expected behavior was shown according to the set value. However, I think that

Re: Problem with default partition pruning

Hello. At Fri, 15 Mar 2019 17:30:07 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20190315.173007.147577546.horiguchi.kyot...@lab.ntt.co.jp> > The patch relies on the fact(?) that the lowest index is always > -1 in range partition and uses it as pseudo default > partition. I'm not

extensions are hitting the ceiling

Hi folks, After months and years of really trying to make EXTENSIONs meet the requirements of my machinations, I have come to the conclusion that either a) I am missing something or b) they are architecturally flawed. Or possibly both. Admittedly, I might be trying to push extensions beyond

Re: [HACKERS] CLUSTER command progress monitor

On 2019/03/19 10:43, Tatsuro Yamada wrote: Hi Rafia! On 2019/03/18 20:42, Rafia Sabih wrote: On Fri, 8 Mar 2019 at 09:14, Tatsuro Yamada wrote: Attached file is rebased patch on current HEAD. I changed a status. :) Looks like the patch needs a rebase. I was on the commit

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

On Mon, Mar 18, 2019 at 5:12 PM Peter Geoghegan wrote: > Smarter choices on page splits pay off with higher client counts > because they reduce contention at likely hot points. It's kind of > crazy that the code in _bt_check_unique() sometimes has to move right, > while holding an exclusive

Re: [HACKERS] CLUSTER command progress monitor

Hi Rafia! On 2019/03/18 20:42, Rafia Sabih wrote: On Fri, 8 Mar 2019 at 09:14, Tatsuro Yamada wrote: Attached file is rebased patch on current HEAD. I changed a status. :) Looks like the patch needs a rebase. I was on the commit fb5806533f9fe0433290d84c9b019399cd69e9c2 PFA reject file in

Re: [HACKERS] Block level parallel vacuum

On Mon, Mar 18, 2019 at 1:58 PM Masahiko Sawada wrote: > On Tue, Feb 26, 2019 at 7:20 PM Masahiko Sawada > wrote: > > > > On Tue, Feb 26, 2019 at 1:35 PM Haribabu Kommi > wrote: > > > > > > On Thu, Feb 14, 2019 at 9:17 PM Masahiko Sawada > wrote: > > >> > > >> Thank you. Attached the rebased

Re: Libpq support to connect to standby server as priority

On Thu, Feb 28, 2019 at 1:00 PM Tsunakawa, Takayuki < tsunakawa.ta...@jp.fujitsu.com> wrote: > From: Haribabu Kommi [mailto:kommi.harib...@gmail.com] > > Attached are the updated patches. > > Thanks, all look fixed. > > > > The target_server_type option yet to be implemented. > > Please let me

RE: speeding up planning with partitions

Amit-san, On Mon, Mar 18, 2019 at 9:56 AM, Amit Langote wrote: > On 2019/03/15 14:40, Imai, Yoshikazu wrote: > > Amit-san, > > > > I have another little comments about v31-patches. > > > > * We don't need is_first_child in inheritance_planner(). > > > > On Fri, Mar 8, 2019 at 9:18 AM, Amit

Re: Rare SSL failures on eelpout

Thomas Munro writes: > Yeah, now that we understand this properly I agree this is unlikely to > bother anyone in real life. I just want to make the build farm green. > I wondered about ssl_max_protocol_version = 'TLSv1.2', but that GUC's > too new. Yeah; also, forcing that would reduce our test

Re: [HACKERS] Block level parallel vacuum

On Tue, Mar 19, 2019 at 3:05 AM Robert Haas wrote: > > On Thu, Mar 14, 2019 at 3:37 AM Masahiko Sawada wrote: > > BTW your patch seems to not apply to the current HEAD cleanly and to > > need to update the comment of vacuum(). > > Yeah, I omitted some hunks by being stupid with 'git'. > > Since

Re: Rare SSL failures on eelpout

On Tue, Mar 19, 2019 at 12:44 PM Tom Lane wrote: > Thomas Munro writes: > > Shouldn't we also back-patch the one-line change adding > > pqHandleSendFailure()? > > As I said before, I don't like that patch: at best it's an abuse of > pqHandleSendFailure, because that function is only meant to be

Re: Rare SSL failures on eelpout

On Tue, Mar 19, 2019 at 12:25 PM Thomas Munro wrote: > 2. Linux, FreeBSD and Darwin gave slightly different error sequences > when writing after the remote connection was closed (though I suspect > they'd behave much the same way for a connection to a remote host), > but all allowed the

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

On Mon, Mar 18, 2019 at 5:00 PM Robert Haas wrote: > Blech. I think the patch has enough other advantages that it's worth > accepting that, but it's not great. We seem to keep finding reasons > to reduce single client performance in the name of scalability, which > is often reasonable not but

Re: Progress reporting for pg_verify_checksums

Hello. At Mon, 18 Mar 2019 23:14:01 +0100 (CET), Fabien COELHO wrote in > > > I have rebased it now. > > Thanks. Will look at it. > > >> If the all of aboves are involved, the line would look as the > >> follows. > >> > >> [=== ] ( 63% of 12.53 GB, 179 MB/s,

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On Sun, Feb 3, 2019 at 8:28 AM Andres Freund wrote: > > > > > It compiled, worked as expected, but some tests broke executing make > check: > > > > test create_table ... FAILED > > constraints ... FAILED > > inherit ... FAILED > >

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

On Mon, Mar 18, 2019 at 7:34 PM Peter Geoghegan wrote: > With pgbench scale factor 20, here are results for patch and master > with a Gaussian distribution on my 8 thread/4 core home server, with > each run reported lasting 10 minutes, repeating twice for client > counts 1, 2, 8, 16, and 64,

Re: Rare SSL failures on eelpout

Thomas Munro writes: > On Tue, Mar 19, 2019 at 9:11 AM Tom Lane wrote: >> My current feeling is that this is OK to put in HEAD but I think the >> risk-reward ratio isn't very good for the back branches. Even with >> an OpenSSL version where this makes a difference, the problematic >> behavior

pg_upgrade version checking questions

While poking around trying to find an explanation for the pg_upgrade failure described here: https://www.postgresql.org/message-id/flat/CACmJi2JUhGo2ZxqDkh-EPHNjEN1ZA1S64uHLJFWHBhUuV4492w%40mail.gmail.com I noticed a few things that seem a bit fishy about pg_upgrade. I can't (yet) connect any of

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

On Tue, Mar 12, 2019 at 11:40 AM Robert Haas wrote: > I think it's pretty clear that we have to view that as acceptable. I > mean, we could reduce contention even further by finding a way to make > indexes 40% larger, but I think it's clear that nobody wants that. > Now, maybe in the future

Re: Rare SSL failures on eelpout

On Tue, Mar 19, 2019 at 9:11 AM Tom Lane wrote: > I wrote: > > ... I don't like pqHandleSendFailure all that much: it has strong > > constraints on what state libpq has to be in, as a consequence of which > > it's called from a bunch of ad-hoc places, and can't be called from > > some others.

Re: What to name the current heap after pluggable storage / what to rename?

Hi, On 2019-03-13 08:29:47 -0400, Robert Haas wrote: > On Tue, Mar 12, 2019 at 8:39 PM Andres Freund wrote: > > > I like that option. > > > > In that vein, does anybody have an opinion about the naming of > > a) HeapUpdateFailureData, which will be used for different AMs > > b) HTSU_Result

Re: Progress reporting for pg_verify_checksums

I have rebased it now. Thanks. Will look at it. If the all of aboves are involved, the line would look as the follows. [=== ] ( 63% of 12.53 GB, 179 MB/s, ETC 26s) # Note that this is just an opinion. (pg_checksum runs fast at the beginning so ETC behaves

Re: [HACKERS] Custom compression methods

On 3/15/19 12:52 PM, Ildus Kurbangaliev wrote: > On Fri, 15 Mar 2019 14:07:14 +0400 > David Steele wrote: > >> On 3/7/19 11:50 AM, Alexander Korotkov wrote: >>> On Thu, Mar 7, 2019 at 10:43 AM David Steele >> > wrote: >>> >>> On 2/28/19 5:44 PM, Ildus

Re: partitioned tables referenced by FKs

On 2019-Feb-28, Amit Langote wrote: > I'd like to hear your thoughts on some suggestions to alter the structure > of the reorganized code around foreign key addition/cloning. With this > patch adding support for foreign keys to reference partitioned tables, the > code now has to consider various

Re: Online verification of checksums

Greetings, On Tue, Mar 19, 2019 at 04:15 Michael Banck wrote: > Am Montag, den 18.03.2019, 16:11 +0800 schrieb Stephen Frost: > > On Mon, Mar 18, 2019 at 15:52 Michael Banck > wrote: > > > Am Montag, den 18.03.2019, 03:34 -0400 schrieb Stephen Frost: > > > > Thanks for that. Reading through

Re: Progress reporting for pg_verify_checksums

Hi, thanks for the additional review! Am Donnerstag, den 14.03.2019, 11:54 +0900 schrieb Kyotaro HORIGUCHI: > At Wed, 13 Mar 2019 16:25:15 +0900, Michael Paquier > wrote in <20190313072515.gb2...@paquier.xyz> > > On Wed, Mar 13, 2019 at 07:22:28AM +0100, Fabien COELHO wrote: > > > Does not

Re: partitioned tables referenced by FKs

Hi Jesper On 2019-Mar-01, Jesper Pedersen wrote: > I'm getting a failure in the pg_upgrade test: > > -- > +-- Name: pk5 pk5_pkey; Type: CONSTRAINT; Schema: regress_fk; Owner: > jpedersen > +-- > + > +ALTER TABLE ONLY regress_fk.pk5 > +ADD CONSTRAINT pk5_pkey PRIMARY KEY (a); > + > + > +--

Re: [PATCH] remove repetitive characters in fdwhandler.sgml

On 2019-03-12 23:19:23 -0700, Andres Freund wrote: > On 2019-03-13 14:55:59 +0900, Etsuro Fujita wrote: > > (2019/03/13 14:02), Michael Paquier wrote: > > > On Tue, Mar 12, 2019 at 01:37:04AM +, Zhang, Jie wrote: > > > > Here is a tiny patch removing repetitive characters [if] in > > > >

Re: jsonpath

po 18. 3. 2019 v 21:23 odesílatel Tom Lane napsal: > Alexander Korotkov writes: > > On Mon, Mar 18, 2019 at 10:08 PM Tom Lane wrote: > >> Just another minor bitch about this patch: jsonpath_scan.l has > introduced > >> a typedef called "keyword". This is causing pgindent to produce >

Re: jsonpath

Alexander Korotkov writes: > On Mon, Mar 18, 2019 at 10:08 PM Tom Lane wrote: >> Just another minor bitch about this patch: jsonpath_scan.l has introduced >> a typedef called "keyword". This is causing pgindent to produce seriously >> ugly results in libpq, and probably in other places where

Re: chained transactions

Hallo Peter, Updated patch. I have squashed the two previously separate patches together in this one. Ok. I do not understand the value of the SAVEPOINT in the tests. The purpose of the SAVEPOINT in the test is because it exercises different switch cases in CommitTransactionCommand()

Re: outdated reference to tuple header OIDs

Hi, On 2019-03-14 15:49:40 +0800, John Naylor wrote: > It seems this is a leftover from commit 578b229718e8. Patch attached. Thanks for noticing. Pushed. Greetings, Andres Freund

Re: Online verification of checksums

Hi, Am Montag, den 18.03.2019, 16:11 +0800 schrieb Stephen Frost: > On Mon, Mar 18, 2019 at 15:52 Michael Banck wrote: > > Am Montag, den 18.03.2019, 03:34 -0400 schrieb Stephen Frost: > > > Thanks for that.  Reading through the code though, I don't entirely > > > understand why we're making

Re: Row Level Security − leakproof-ness and performance implications

On 3/18/19 3:52 PM, Peter Eisentraut wrote: > On 2019-02-28 00:03, Joe Conway wrote: >> What if we provided an option to redact all client messages (leaving >> logged messages as-is). Separately we could provide a GUC to force all >> functions to be resolved as leakproof. Depending on your

Re: Rare SSL failures on eelpout

I wrote: > ... I don't like pqHandleSendFailure all that much: it has strong > constraints on what state libpq has to be in, as a consequence of which > it's called from a bunch of ad-hoc places, and can't be called from > some others. It's kind of accidental that it will work here. > I was

Re: Online verification of checksums

On Mon, Mar 18, 2019 at 2:06 AM Michael Paquier wrote: > The mentions on this thread that the server has all the facility in > place to properly lock a buffer and make sure that a partial read > *never* happens and that we *never* have any kind of false positives, > directly preventing the set of

Re: [PATCH][PROPOSAL] Add enum releation option type

В письме от среда, 20 февраля 2019 г. 15:08:32 MSK пользователь Michael Paquier написал: > > 2.5 May be this src/test/modules dummy index is subject to another patch. > > So I will start working on it right now, but we will do this work not > > dependent to any other patches. And just add there

Re: Row Level Security − leakproof-ness and performance implications

On 2019-02-28 00:03, Joe Conway wrote: > What if we provided an option to redact all client messages (leaving > logged messages as-is). Separately we could provide a GUC to force all > functions to be resolved as leakproof. Depending on your requirements, > having both options turned on could be

Re: jsonpath

On Mon, Mar 18, 2019 at 10:08 PM Tom Lane wrote: > Just another minor bitch about this patch: jsonpath_scan.l has introduced > a typedef called "keyword". This is causing pgindent to produce seriously > ugly results in libpq, and probably in other places where that is used as > a field or

Re: Speed up transaction completion faster after many relations are accessed in a transaction

On 2019-02-20 07:20, Tsunakawa, Takayuki wrote: > From: Tom Lane [mailto:t...@sss.pgh.pa.us] >> Hm. Putting a list header for a purely-local data structure into shared >> memory seems quite ugly. Isn't there a better place to keep that? > > Agreed. I put it in the global variable. I think

[PATCH] src/test/modules/dummy_index -- way to test reloptions from inside of access method

Hi! This patch introduce a dummy_index access method module, that does not do any indexing at all, but allow to test reloptions from inside of access method extension. This patch is part of my bigger work on reloptions refactoring. It came from

Re: BUG #15641: Autoprewarm worker fails to start on Windows with huge pages in use Old PostgreSQL community/pgsql-bugs x

On Mon, Mar 18, 2019 at 1:43 PM Mithun Cy wrote: >> Does that sound right? > > -- Yes I Agree. Committed with a little more tweaking of the commit message, and back-patched to v11. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [HACKERS] Block level parallel vacuum

On Thu, Mar 14, 2019 at 3:37 AM Masahiko Sawada wrote: > Attached the updated patch you proposed and the patch that converts > the grammer productions for the VACUUM option on top of the former > patch. The latter patch moves VacuumOption to vacuum.h since the > parser no longer needs such

Re: Row Level Security − leakproof-ness and performance implications

On 2019-02-21 15:56, Pierre Ducroquet wrote: > I undestand these decisions, but it makes RLS quite fragile, with numerous un- > documented side-effects. In order to save difficulties from future users, I > wrote this patch to the documentation, listing the biggest restrictions I hit > with RLS

Re: jsonpath

Just another minor bitch about this patch: jsonpath_scan.l has introduced a typedef called "keyword". This is causing pgindent to produce seriously ugly results in libpq, and probably in other places where that is used as a field or variable name. Please rename that typedef to something less

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

On Mon, Mar 18, 2019 at 6:23 PM Yun Li wrote: > > Let's take one step back. Since queryId is stored in core as Julien pointed > out, can we just add that global to the pg_stat_get_activity and ultimately > exposed in pg_stat_activity view? Then no matter whether PGSS is on or off, > or

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

Hello On Sat, Mar 16, 2019 at 7:32 AM Robert Haas wrote: > Also, I think this is now the third independent request to expose > query ID in pg_stat_statements. I think we should give the people > what they want. > Count me as the 4th. This would be a very important feature for automated query

Re: [HACKERS] Block level parallel vacuum

On Thu, Mar 14, 2019 at 3:37 AM Masahiko Sawada wrote: > BTW your patch seems to not apply to the current HEAD cleanly and to > need to update the comment of vacuum(). Yeah, I omitted some hunks by being stupid with 'git'. Since you seem to like the approach, I put back the hunks I intended to

Re: BUG #15641: Autoprewarm worker fails to start on Windows with huge pages in use Old PostgreSQL community/pgsql-bugs x

Thanks Robert, On Mon, Mar 18, 2019 at 9:01 PM Robert Haas wrote: > On Mon, Mar 18, 2019 at 3:04 AM Mithun Cy wrote: > > autoprewarm waorker should not be restarted. As per the code > @apw_start_database_worker@ master starts a worker per database and wait > until it exit by calling

Re: Fix XML handling with DOCTYPE

There might be too many different email threads on this with patches, but in case it went under the radar, xml-content-2006-3.patch appeared in my previous message on this thread[1]. It is based on a simple pre-check of the prefix of the input, determining which form of parse to apply. That may

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

Thanks a lot for really good points!! I did not expected I will get this many points of view. :P I have identical experience with Robert when other extension calculate the id different as PGSS, PGSS will overwritten that id when it is on. But Tom got a point that if we centralize the logic that

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

On Mon, Mar 18, 2019 at 4:59 AM Heikki Linnakangas wrote: > I'm getting a regression failure from the 'create_table' test with this: > Are you seeing that? Yes -- though the bug is in your revised v18, not the original v18, which passed CFTester. Your revision fails on Travis/Linux, which is

Re: Fix optimization of foreign-key on update actions

On 2019-03-11 12:57, Peter Eisentraut wrote: > On 2019-02-06 23:15, Peter Eisentraut wrote: >> On 05/02/2019 17:20, Tom Lane wrote: >>> What I *don't* like about the proposed patch is that it installs a >>> new, different comparison rule for the ON UPDATE CASCADE case only. >>> If we were to go in

Concurrency bug with vacuum full (cluster) and toast

Hi all, I've discovered bug, when vacuum full fails with error, because it couldn't find toast chunks deleted by itself. That happens because cluster_rel() sets OldestXmin, but toast accesses gets snapshot later and independently. That causes heap_page_prune_opt() to clean chunks, which

Re: Add exclusive backup deprecation notes to documentation

On Mon, Mar 18, 2019 at 8:33 AM Peter Eisentraut wrote: > The documentation changes appear to continue the theme from the other > thread that the exclusive backup mode is terrible and everyone should > feel bad about it. I don't think there is consensus about that. +1. -- Robert Haas

Re: pg_basebackup ignores the existing data directory permissions

On Mon, Mar 18, 2019 at 11:36 AM Peter Eisentraut wrote: > On 2019-03-18 14:47, Robert Haas wrote: > >> Based on the feedback gathered, having a separate option to enforce > >> the default and not touching the behavior implemented until now, > >> sounds fine to me. > > That's not what I'm

Re: pg_basebackup ignores the existing data directory permissions

On 2019-03-18 14:47, Robert Haas wrote: >> Based on the feedback gathered, having a separate option to enforce >> the default and not touching the behavior implemented until now, >> sounds fine to me. > That's not what I'm proposing. I think the behavior implemented until > now is not best,

Re: BUG #15641: Autoprewarm worker fails to start on Windows with huge pages in use Old PostgreSQL community/pgsql-bugs x

On Mon, Mar 18, 2019 at 3:04 AM Mithun Cy wrote: > autoprewarm waorker should not be restarted. As per the code > @apw_start_database_worker@ master starts a worker per database and wait > until it exit by calling WaitForBackgroundWorkerShutdown. The call > WaitForBackgroundWorkerShutdown

Re: Compressed TOAST Slicing

> On Mar 18, 2019, at 7:34 AM, Robert Haas wrote: > > On Mon, Mar 18, 2019 at 10:14 AM Tom Lane wrote: >> Stephen Frost writes: >>> * Andres Freund (and...@anarazel.de) wrote: I don't think that should stop us from breaking the API. You've got to do quite low level stuff to need

Re: Unduly short fuse in RequestCheckpoint

On Sun, Mar 17, 2019 at 3:41 PM Tom Lane wrote: > So I think we should just blow off that > hypothetical possibility and do it like this. Makes sense to me. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Compressed TOAST Slicing

On Mon, Mar 18, 2019 at 10:14 AM Tom Lane wrote: > Stephen Frost writes: > > * Andres Freund (and...@anarazel.de) wrote: > >> I don't think that should stop us from breaking the API. You've got to > >> do quite low level stuff to need pglz directly, in which case such an > >> API change should

Re: [HACKERS] generated columns

Hi po 18. 3. 2019 v 8:35 odesílatel Peter Eisentraut < peter.eisentr...@2ndquadrant.com> napsal: > Here is an updated patch with just the "stored" functionality, as > discussed. > > The actual functionality is much smaller now, contained in the executor. > Everything else is mostly DDL support,

Re: Compressed TOAST Slicing

Stephen Frost writes: > * Andres Freund (and...@anarazel.de) wrote: >> I don't think that should stop us from breaking the API. You've got to >> do quite low level stuff to need pglz directly, in which case such an >> API change should be the least of your problems between major versions. >

Re: Timeout parameters

On Sun, Mar 17, 2019 at 9:08 PM Jamison, Kirk wrote: > The main argument here is about the security risk of allowing socket timeout > to cancel valid connections, right? I don't think so. I think it's just a weirdly-design parameter without a really compelling use case. Enforcing limits on the

Re: Possible to modify query language in an extension?

On Sun, Mar 17, 2019 at 12:21 AM Tom Lane wrote: > Chris Cleveland writes: > > I'd like to add some keywords/clauses to the SELECT statement. > > Yeah, you'll have to modify gram.y (and a pile of other places) > if you want to do that. That's certainly something we do all > the time, but bison

Re: partitioned tables referenced by FKs

Hi Amit On 2019-Mar-18, Amit Langote wrote: > On 2019/03/15 2:31, Alvaro Herrera wrote: > > Once I was finished, fixed bugs and tested it, I realized that that was > > a stupid thing to have done -- because THOSE ARE DIFFERENT CONSTRAINTS. > > When you say "fk (a) references pk1" you're saying

Re: pg_basebackup ignores the existing data directory permissions

On Mon, Mar 18, 2019 at 4:16 AM Michael Paquier wrote: > On Mon, Mar 18, 2019 at 08:32:44AM +0100, Magnus Hagander wrote: > > On Mon, Mar 18, 2019 at 7:08 AM Stephen Frost wrote: > >> I definitely think that we should add an option to allow the user to > >> tell us explicitly what they want

Re: Unaccent extension python script Issue in Windows

On Mon, 18 Mar 2019 at 01:14, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > This patch contains irrelevant changes. The minimal required > change would be the attached. If you want refacotor the > UnicodeData reader or rearrange import sutff, it should be > separate patches. > I'm

Re: pg_basebackup ignores the existing data directory permissions

On 2019-03-16 15:29, Robert Haas wrote: > Another option would be to provide a pg_basebackup option to allow the > user to specify what they intended i.e. --[no-]group-read. (Tying it > to -R doesn't sound like a good decision to me.) I was actually surprised to learn how it works right now. I

Re: Add exclusive backup deprecation notes to documentation

On 2019-03-07 10:33, David Steele wrote: > On 3/1/19 3:14 PM, Laurenz Albe wrote: >> Magnus Hagander wrote: >>> Maybe have the first note say "This method is deprecated bceause it has >>> serious >>> risks (see bellow)" and then list the actual risks at the end? >> >> Good idea. That may attract

Re: [HACKERS] CLUSTER command progress monitor

On Fri, 8 Mar 2019 at 09:14, Tatsuro Yamada wrote: > > On 2019/03/06 15:38, Tatsuro Yamada wrote: > > On 2019/03/05 17:56, Tatsuro Yamada wrote: > >> On 2019/03/05 11:35, Robert Haas wrote: > >>> On Mon, Mar 4, 2019 at 5:38 AM Tatsuro Yamada > >>> wrote: > === Current design === > >

Re: explain plans with information about (modified) gucs

On Sun, 24 Feb 2019 at 00:06, Tomas Vondra wrote: > > Hi, > > attached is an updated patch, fixing and slightly tweaking the docs. > > > Barring objections, I'll get this committed later next week. > I was having a look at this patch, and this kept me wondering, +static void

Re: chained transactions

On 2019-02-16 06:22, Andres Freund wrote: >> +static int save_XactIsoLevel; >> +static bool save_XactReadOnly; >> +static bool save_XactDeferrable; > > We normally don't define variables in the middle of a file? Also, why > do these need to be global vars rather than defined where we do >

Re: chained transactions

Updated patch. I have squashed the two previously separate patches together in this one. On 2019-01-06 15:14, Fabien COELHO wrote: > I do not understand the value of the SAVEPOINT in the tests. The purpose of the SAVEPOINT in the test is because it exercises different switch cases in

Re: pg_basebackup ignores the existing data directory permissions

At Mon, 18 Mar 2019 17:16:01 +0900, Michael Paquier wrote in <20190318081601.gi1...@paquier.xyz> > On Mon, Mar 18, 2019 at 08:32:44AM +0100, Magnus Hagander wrote: > > On Mon, Mar 18, 2019 at 7:08 AM Stephen Frost wrote: > >> I definitely think that we should add an option to allow the user to

Re: [HACKERS] Block level parallel vacuum

Hello. At Mon, 18 Mar 2019 11:54:42 +0900, Masahiko Sawada wrote in > Here is the performance test results. I've setup a 500MB table with > several indexes and made 10% of table dirty before each vacuum. > Compared execution time of the patched postgrse with the current HEAD > (at 'speed_up'

Re: speeding up planning with partitions

Imai-san, On 2019/03/15 14:40, Imai, Yoshikazu wrote: > Amit-san, > > I have another little comments about v31-patches. > > * We don't need is_first_child in inheritance_planner(). > > On Fri, Mar 8, 2019 at 9:18 AM, Amit Langote wrote: >> On 2019/03/08 16:16, Imai, Yoshikazu wrote: >>> I

Re: Problem with default partition pruning

Hosoya-san, On 2019/03/15 15:05, Yuzuko Hosoya wrote: > Indeed, it's problematic. I also did test and I found that > this problem was occurred when any partition didn't match > WHERE clauses. So following query didn't work correctly. > > # explain select * from test1_3 where (id > 0 and id <

Re: Tid scan improvements

On Fri, 15 Mar 2019 at 18:42, Edmund Horner wrote: > I've had to adapt it to use the table scan API. I've got it compiling > and passing tests, but I'm uneasy about some things that still use the > heapam API. > > 1. I call heap_setscanlimits as I'm not sure there is a tableam equivalent. > 2.

Re: Parallel query vs smart shutdown and Postmaster death

Thomas Munro writes: > Just a thought: instead of the new hand-coded loop you added in > pmdie(), do you think it would make sense to have a new argument > "exclude_class_mask" for SignalSomeChildren()? If we did that, I > would consider renaming the existing parameter "target" to >

Re: partitioned tables referenced by FKs

Hi, On 2019/03/15 2:31, Alvaro Herrera wrote: > Once I was finished, fixed bugs and tested it, I realized that that was > a stupid thing to have done -- because THOSE ARE DIFFERENT CONSTRAINTS. > When you say "fk (a) references pk1" you're saying that all the values > in fk(a) must appear in pk1.

Re: pg_basebackup ignores the existing data directory permissions

On Mon, Mar 18, 2019 at 08:32:44AM +0100, Magnus Hagander wrote: > On Mon, Mar 18, 2019 at 7:08 AM Stephen Frost wrote: >> I definitely think that we should add an option to allow the user to >> tell us explicitly what they want here, even if we also go based on what >> the created directory has

Re: Offline enabling/disabling of data checksums

On Fri, Mar 15, 2019 at 01:37:27PM +0100, Michael Banck wrote: > Am Freitag, den 15.03.2019, 21:23 +0900 schrieb Michael Paquier: >> Perhaps having them under --verbose makes more sense? > > Well if we think it is essential in order to tell the user what happened > in the case of an error, it

Re: Online verification of checksums

Greetings, On Mon, Mar 18, 2019 at 15:52 Michael Banck wrote: > Hi. > > Am Montag, den 18.03.2019, 03:34 -0400 schrieb Stephen Frost: > > * Michael Banck (michael.ba...@credativ.de) wrote: > > > Am Montag, den 18.03.2019, 02:38 -0400 schrieb Stephen Frost: > > > > * Michael Paquier

  1   2   >