Re: [HACKERS] Block level parallel vacuum

2019-10-27 Thread Amit Kapila
On Sun, Oct 27, 2019 at 12:52 PM Dilip Kumar wrote: > > On Fri, Oct 25, 2019 at 9:19 PM Masahiko Sawada wrote: > > > > > I haven't yet read the new set of the patch. But, I have noticed one > thing. That we are getting the size of the statistics using the AM > routine. But, we are copying thos

Re: WIP: expression evaluation improvements

2019-10-27 Thread Soumyadeep Chakraborty
Hi Andres, Apologies, I realize my understanding of symbol resolution and the referenced_functions mechanism wasn't correct. Thank you for your very helpful explanations. > There's also a related edge-case where are unable to figure out a symbol > name in llvm_function_reference(), and then resor

Re: [DOC] Fix for the missing pg_stat_progress_cluster view phase column value

2019-10-27 Thread Michael Paquier
On Mon, Oct 28, 2019 at 02:26:39PM +0900, Kyotaro Horiguchi wrote: > By the way the table mentions the phases common to CLUSTER and > VACUUM FULL. I wonder why some of them are described as "CLUSTER is" > and others are "The command is".. Because VACUUM FULL does not use the sort-and-scan mode, n

Re: Duplicate entries in pg_depend after REINDEX CONCURRENTLY

2019-10-27 Thread Michael Paquier
On Fri, Oct 25, 2019 at 03:43:18PM +0900, Michael Paquier wrote: > Attached is a patch to fix the issue. As we know that the old index > will have a definition and dependencies that match with the old one, I > think that we should just remove any dependency records on the new > index before moving

Re: define bool in pgtypeslib_extern.h

2019-10-27 Thread Amit Kapila
On Sat, Oct 26, 2019 at 10:49 PM Tom Lane wrote: > > I'm inclined to think that we need to make ecpglib.h's bool-related > definitions exactly match c.h, which will mean that it has to pull in > on most platforms, which will mean adding a control symbol > for that to ecpg_config.h. I do not thin

Re: [DOC] Fix for the missing pg_stat_progress_cluster view phase column value

2019-10-27 Thread Michael Paquier
On Sat, Oct 26, 2019 at 05:13:49AM +, Shinoda, Noriyoshi (PN Japan A&PS Delivery) wrote: > The attached patch adds a description of the 'writing new heap' > value output in the 'phase' column. Indeed, fixed. Thanks for the patch. -- Michael signature.asc Description: PGP signature

Re: [HACKERS] Block level parallel vacuum

2019-10-27 Thread Dilip Kumar
On Thu, Oct 24, 2019 at 4:33 PM Dilip Kumar wrote: > > On Thu, Oct 24, 2019 at 4:21 PM Amit Kapila wrote: > > > > On Thu, Oct 24, 2019 at 11:51 AM Dilip Kumar wrote: > > > > > > On Fri, Oct 18, 2019 at 12:18 PM Dilip Kumar > > > wrote: > > > > > > > > On Fri, Oct 18, 2019 at 11:25 AM Amit Kapi

RE: Avoiding deadlock errors in CREATE INDEX CONCURRENTLY

2019-10-27 Thread imai.yoshik...@fujitsu.com
Hi Dhruv, On Sun, June 30, 2019 at 7:30 AM, Goel, Dhruv wrote: > > On Jun 10, 2019, at 1:20 PM, Goel, Dhruv wrote: > >> On Jun 9, 2019, at 5:33 PM, Tom Lane wrote: > >> Andres Freund writes: > >>> On June 9, 2019 8:36:37 AM PDT, Tom Lane wrote: > I think you are mistaken that doing transa

Re: [DOC] Fix for the missing pg_stat_progress_cluster view phase column value

2019-10-27 Thread Kyotaro Horiguchi
At Sat, 26 Oct 2019 05:13:49 +, "Shinoda, Noriyoshi (PN Japan A&PS Delivery)" wrote in > I found a missing column value in the pg_stat_progress_cluster view document. > I read the src/backend/catalog/system_views.sql file, there seems to be a > possibility that 'writing new heap' is output

Re: Remove one use of IDENT_USERNAME_MAX

2019-10-27 Thread Kyotaro Horiguchi
Hello. At Sat, 26 Oct 2019 08:55:03 +0200, Peter Eisentraut wrote in > IDENT_USERNAME_MAX is the maximum length of the information returned > by an ident server, per RFC 1413. Using it as the buffer size in peer > authentication is inappropriate. It was done here because of the > historical r

Re: Restore replication settings when modifying a field type

2019-10-27 Thread Kyotaro Horiguchi
Hello. # The patch no longer applies on the current master. Needs a rebasing. At Sat, 26 Oct 2019 16:50:48 +0800, Quan Zongliang wrote in > In fact, the replication property of the table has not been modified, > and it is still 'i'(REPLICA_IDENTITY_INDEX). But the previously > specified index

Allow cluster_name in log_line_prefix

2019-10-27 Thread Craig Ringer
Hi folks I was recently surprised to notice that log_line_prefix doesn't support a cluster_name placeholder. I suggest adding one. If I don't hear objections I'll send a patch. Before anyone asks "but why?!": * A constant (short) string in log_line_prefix is immensely useful when working with lo

RE: Proposal: Add more compile-time asserts to expose inconsistencies.

2019-10-27 Thread Smith, Peter
From: Kyotaro Horiguchi Sent: Monday, 28 October 2019 1:26 PM > It is missing the __cplusplus case? My use cases for the macro are only in C code, so that's all I was interested in at this time. If somebody else wants to extend the patch for C++ also (and test it) they can do. Kind Regards,

Re: CREATE TEXT SEARCH DICTIONARY segfaulting on 9.6+

2019-10-27 Thread Arthur Zakirov
Hello Tomas, On 2019/10/13 10:26, Tomas Vondra wrote: over in pgsql-bugs [1] we got a report about CREATE TEXT SEARCH DICTIONARY causing segfaults on 12.0. Simply running    CREATE TEXT SEARCH DICTIONARY hunspell_num (Template=ispell,    DictFile=hunspell_sample_num, AffFile=hunspell_sample_l

Re: PL/Python fails on new NetBSD/PPC 8.0 install

2019-10-27 Thread Benjamin Scherrey
None of the output provides any clue to me but I do know that Python 3.7 has some issues with a lot of versions of openssl that is based on a disagreement between devs in both projects. This was a problem for me when trying to build python 3.7 on my Kubuntu 14.04 system. I've seen this issue report

Re: PL/Python fails on new NetBSD/PPC 8.0 install

2019-10-27 Thread Tom Lane
Awhile back I wrote: > I noticed that the old NetBSD 5.1.5 installation I had on my G4 Mac > was no longer passing our regression tests, because it has a strtof() > that is sloppy about underflow. Rather than fight with that I decided > to update it to something shinier (well, as shiny as you can

RE: Proposal: Add more compile-time asserts to expose inconsistencies.

2019-10-27 Thread Smith, Peter
From: Andres Freund Sent: Sunday, 27 October 2019 12:03 PM > My proposal for this really was just to use this as a fallback for when > static assert isn't available. Which in turn I was just suggesting because > Tom wanted a fallback. The patch is updated to use "extern" technique only when "_

update ALTER TABLE with ATTACH PARTITION lock mode

2019-10-27 Thread Justin Pryzby
commit #898e5e32 (Allow ATTACH PARTITION with only ShareUpdateExclusiveLock) updates ddl.sgml but not alter_table.sgml, which only says: https://www.postgresql.org/docs/12/release-12.html |An ACCESS EXCLUSIVE lock is held unless explicitly noted. Find attached patch, which also improve language i

Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock(PG10.7)

2019-10-27 Thread Alexander Korotkov
Hi, Peter! On Fri, Oct 4, 2019 at 12:05 AM Alexander Korotkov wrote: > I'm planning to continue work on README, comments and commit messages. It tool me a lot of efforts to revise a concurrency section in README. I can't judge the result, but I probably did my best. I'd like to commit this patc

Re: Selecting fields from a RowExpr

2019-10-27 Thread Pavel Stehule
Hi ne 27. 10. 2019 v 19:47 odesílatel Tom Lane napsal: > At pgconf.eu, someone whose name I've forgotten pointed out to me > that this doesn't work: > > regression=# select (row(1, 2.0)).f1; > ERROR: could not identify column "f1" in record data type > LINE 1: select (row(1, 2.0)).f1; >

Selecting fields from a RowExpr

2019-10-27 Thread Tom Lane
At pgconf.eu, someone whose name I've forgotten pointed out to me that this doesn't work: regression=# select (row(1, 2.0)).f1; ERROR: could not identify column "f1" in record data type LINE 1: select (row(1, 2.0)).f1; ^ The fields of an anonymous rowtype are certainly named f1,

Re: [Proposal] Arbitrary queries in postgres_fdw

2019-10-27 Thread David Fetter
On Fri, Oct 25, 2019 at 05:17:18PM +0200, rto...@carto.com wrote: > Dear all, > > We stumbled upon a few cases in which retrieving information from the > foreign server may turn pretty useful before creating any foreign > table, especially info related to the catalog. E.g: a list of schemas > or t

Re: Proposition to use '==' as synonym for 'IS NOT DISTINCT FROM'

2019-10-27 Thread Tom Lane
I wrote: > To clarify, what I have in mind here doesn't have any effect whatever > on the parse tree or the execution semantics, it's just about offering > an alternative SQL textual representation. Continuing this thread ... if we were just trying to fix the dump/restore issue without regard for

Re: Binary support for pgoutput plugin

2019-10-27 Thread Dmitry Dolgov
> On Mon, Jun 17, 2019 at 10:29:26AM -0400, Dave Cramer wrote: > > Which is what I have done. Thanks > > > > I've attached both patches for comments. > > I still have to add documentation. > > Additional patch for documentation. Thank you for the patch! Unfortunately 0002 has some conflicts, could

Re: Proposal: Add more compile-time asserts to expose inconsistencies.

2019-10-27 Thread Andres Freund
On 2019-10-27 11:44:54 +, Smith, Peter wrote: > From: Andres Freund Sent: Sunday, 27 October 2019 12:03 > PM > > I think it should work everywhere that has static assert. So we should need > > a separate configure check. > > Er, that's a typo right? I think you meant: "So we *shouldn't* nee

RE: Proposal: Add more compile-time asserts to expose inconsistencies.

2019-10-27 Thread Smith, Peter
From: Andres Freund Sent: Sunday, 27 October 2019 12:03 PM >>Ideally, the implementation should end up calling _Static_assert() >>somehow, so that we get the compiler's native error message. OK. I can work on that. >>We could do a configure check for whether _Static_assert() works at >>file s

Re: [HACKERS] Block level parallel vacuum

2019-10-27 Thread Dilip Kumar
On Fri, Oct 25, 2019 at 9:19 PM Masahiko Sawada wrote: > > On Fri, Oct 25, 2019 at 2:06 PM Dilip Kumar wrote: > > > > On Fri, Oct 25, 2019 at 10:22 AM Masahiko Sawada > > wrote: > > > > > > For more detail of my idea it is that the first worker who entered to > > > vacuum_delay_point adds its l