Re: more backtraces

2019-12-14 Thread Robert Haas
On Fri, Dec 13, 2019 at 7:26 AM Peter Eisentraut wrote: > On 2019-12-04 22:34, Tom Lane wrote: > > Andres Freund writes: > >> It'd be bad if the addition of backtraces for SEGV/BUS suddenly made it > >> harder to attach a debugger and getting useful results. > > > > Yeah. TBH, I'm not sure I wan

Re: allowing broader use of simplehash

2019-12-14 Thread Robert Haas
On Thu, Dec 12, 2019 at 2:33 PM Andres Freund wrote: > I was basically just thinking that we could pass the context to use via > CurrentMemoryContext, instead of explicitly passing it in. I thought about that, but as a general rule, replacing a function parameter with a global variable is the wro

Re: Wrong assert in TransactionGroupUpdateXidStatus

2019-12-14 Thread Robert Haas
On Thu, Dec 12, 2019 at 9:23 PM Amit Kapila wrote: > Do you think we need such an Assert after having StaticAssert for > (THRESHOLD_SUBTRANS_CLOG_OPT <= PGPROC_MAX_CACHED_SUBXIDS) and then > an if statement containing (nsubxids <= THRESHOLD_SUBTRANS_CLOG_OPT) > just before this Assert? Sure, we

Re: pg_ls_tmpdir to show shared filesets

2019-12-14 Thread Justin Pryzby
On Thu, Dec 12, 2019 at 11:39:31PM -0600, Justin Pryzby wrote: > I suggested that pg_ls_tmpdir should show shared filesets like > > 169347 5492 -rw-r- 1 postgres postgres 5619712 Dec 7 01:35 > > /var/lib/pgsql/12/data/base/pgsql_tmp/pgsql_tmp11025.0.sharedfileset/0.0 .. > Actually, my sugg

Re: [HACKERS] proposal: schema variables

2019-12-14 Thread Pavel Stehule
t; minor change - replace heap_tuple_fetch_attr by detoast_external_attr. >>> >>> >> similar update - heap_open, heap_close was replaced by table_open, >> table_close >> > > fresh rebase > only rebase Regards Pavel > Regards > > Pavel > > >> Regards >> >> Pavel >> > schema-variables-20191214.patch.gz Description: application/gzip

Re: tuplesort test coverage

2019-12-14 Thread Tom Lane
Andres Freund writes: > On 2019-12-12 09:27:04 -0500, Tom Lane wrote: >> What seems like a simpler and more reliable fix is to make >> test_mark_restore a temp table, thus keeping autovac away from it. >> Is there a reason in terms of the test's goals not to do that? > I can't see any reason. The

Re: Memory-Bounded Hash Aggregation

2019-12-14 Thread Tomas Vondra
On Wed, Nov 27, 2019 at 02:58:04PM -0800, Jeff Davis wrote: On Wed, 2019-08-28 at 12:52 -0700, Taylor Vesely wrote: Right now the patch always initializes 32 spill partitions. Have you given any thought into how to intelligently pick an optimal number of partitions yet? Attached a new patch th

Re: psql's \watch is broken

2019-12-14 Thread Fabien COELHO
I've not dug into code itself, I just bisected it. Thanks for the report. I'll look into it. Looked at it already. Ah, the magic of timezones! And yes, I can see the difference. This comes from the switch from cancel_pressed to CancelRequested in psql, especially PSQLexecWatch() in th

Re: [WIP] UNNEST(REFCURSOR): allowing SELECT to consume data from a REFCURSOR

2019-12-14 Thread Dent John
Hi folks,I’ve made a revision of this patch. The significant change is to access the Portal using Portal APIs rather than through SPI. It seems the persisted state necessary to survive being used to retrieve a row at a time inside an SRF just isn’t a good fit for SPI. It turned out there was upstre