Re: Error message inconsistency

2020-01-09 Thread MBeena Emerson
Hi Mahendra, Thanks for the patch. I am not sure but maybe the relation name should also be added to the following test case? create table t4 (id int); insert into t4 values (1); ALTER TABLE t4 ADD CONSTRAINT c1 CHECK (id > 10) NOT VALID; -- succeeds ALTER TABLE t4 VALIDATE CONSTRAINT c1; *ERROR:

Re: [HACKERS] Block level parallel vacuum

2020-01-09 Thread Sergei Kornilov
Hello I noticed that parallel vacuum uses min_parallel_index_scan_size GUC to skip small indexes but this is not mentioned in documentation for both vacuum command and GUC itself. + /* Determine the number of parallel workers to launch */ + if (lps->lvshared->for_cleanup) + {

Re: [Proposal] Global temporary tables

2020-01-09 Thread Konstantin Knizhnik
On 06.01.2020 8:04, 曾文旌(义从) wrote: In the previous communication 1 we agreed on the general direction 1.1 gtt use local (private) buffer 1.2 no replica access in first version 2 We feel that gtt needs to maintain statistics, but there is no agreement on what it will be done. 3 Still no one

Re: Questions/Observations related to Gist vacuum

2020-01-09 Thread Mahendra Singh Thalor
On Mon, 9 Dec 2019 at 14:37, Amit Kapila wrote: > > On Mon, Dec 9, 2019 at 2:27 PM Amit Kapila wrote: > > > > I have modified the patch for the above points and additionally ran > > pgindent. Let me know what you think about the attached patch? > > > > A new version with a slightly modified comm

Re: base backup client as auxiliary backend process

2020-01-09 Thread Alexandra Wang
Hi Peter, On Fri, Nov 22, 2019 at 6:22 PM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > Here is another patch set that implements the temporary slot use on the > walreceiver side, essentially mirroring what pg_basebackup already does. > > I think this patch set might be useful on

Re: logical decoding : exceeded maxAllocatedDescs for .spill files

2020-01-09 Thread Amit Kapila
On Thu, Jan 9, 2020 at 11:15 AM Tom Lane wrote: > > Noah Misch writes: > > Even so, a web search for "extend_brk" led to the answer. By default, > > 32-bit > > AIX binaries get only 256M of RAM for stack and sbrk. The new regression > > test > > used more than that, hence this crash. > > Hm,

Re: Allow 'sslkey' and 'sslcert' in postgres_fdw user mappings

2020-01-09 Thread Christoph Berg
Re: To Andrew Dunstan 2020-01-09 <20200109103014.ga4...@msg.df7cb.de> > sslcert/sslkey options can only be set/modified by superusers when > "password_required" is set. But when password_required is not set, any > user and create user mappings that reference arbitrary files on the > server filesyst

Re: Allow 'sslkey' and 'sslcert' in postgres_fdw user mappings

2020-01-09 Thread Christoph Berg
Re: Andrew Dunstan 2019-11-01 > {"password_required", UserMappingRelationId, false}, > + /* > + * Extra room for the user mapping copies of sslcert and > sslkey. These > + * are really libpq options but we repeat them here to allow > them to >

Re: [Logical Replication] TRAP: FailedAssertion("rel->rd_rel->relreplident == REPLICA_IDENTITY_DEFAULT || rel->rd_rel->relreplident == REPLICA_IDENTITY_FULL || rel->rd_rel->relreplident == REPLICA_IDE

2020-01-09 Thread Rafia Sabih
On Thu, 9 Jan 2020 at 08:48, Dilip Kumar wrote: > > On Thu, Jan 9, 2020 at 12:50 PM Neha Sharma > wrote: > > > > Hi Michael, > > Thanks for looking into the issue. Sorry by mistake I had mentioned the > > incorrect DML query,please use the query as mentioned below. > > > > On Thu, Jan 9, 2020 at

Re: adding partitioned tables to publications

2020-01-09 Thread Amit Langote
On Wed, Jan 8, 2020 at 7:57 PM Peter Eisentraut wrote: > On 2020-01-07 15:18, Rafia Sabih wrote: > > On Tue, 7 Jan 2020 at 06:02, Amit Langote wrote: > > > >> Rebased and updated to address your comments. > >> > > + > > + Partitioned tables are not considered when FOR ALL > > TABLES > > +

Re: remove some STATUS_* symbols

2020-01-09 Thread Peter Eisentraut
On 2020-01-06 07:31, Michael Paquier wrote: On Sun, Dec 29, 2019 at 11:33:34AM +0100, Peter Eisentraut wrote: Attached are two patches to remove these two symbols. STATUS_FOUND can be replaced by a simple bool. STATUS_WAITING is replaced by a separate enum. Patch 0001 looks good to me, but I

Re: [PATCH] Resolve Parallel Hash Join Performance Issue

2020-01-09 Thread Thomas Munro
On Thu, Jan 9, 2020 at 10:04 PM Deng, Gang wrote: > Attached is a patch to resolve parallel hash join performance issue. This is > my first time to contribute patch to PostgreSQL community, I referred one of > previous thread as template to report the issue and patch. Please let me know > if ne

Re: Remove libpq.rc, use win32ver.rc for libpq

2020-01-09 Thread Peter Eisentraut
On 2020-01-06 09:02, Michael Paquier wrote: - FILEFLAGSMASK 0x17L + FILEFLAGSMASK VS_FFI_FILEFLAGSMASK Are you sure with the mapping here? I would have thought that VS_FF_DEBUG is not necessary when using release-quality builds, which is something that can be configured with build.pl, and that

Re: Change atoi to strtol in same place

2020-01-09 Thread Peter Eisentraut
On 2019-12-06 18:43, Joe Nelson wrote: I see this patch has been moved to the next commitfest. What's the next step, does it need another review? I think you need to promote your patch better. The thread subject and the commit fest entry title are somewhat nonsensical and no longer match wha

Re: pgbench - use pg logging capabilities

2020-01-09 Thread Fabien COELHO
Bonjour Michaël, I don't follow what you mean by that. The first versions of the patch did not change syntax_error(), and the version committed has switched to use PQExpBufferData there. I think that we should just do the same for the debug logs executing the meta commands. This way, we get

Re: Unicode normalization SQL functions

2020-01-09 Thread Peter Eisentraut
On 2020-01-06 17:00, Daniel Verite wrote: Peter Eisentraut wrote: Also, there is a way to optimize the "is normalized" test for common cases, described in UTR #15. For that we'll need an additional data file from Unicode. In order to simplify that, I would like my patch "Add support f

Re: Add support for automatically updating Unicode derived files

2020-01-09 Thread Peter Eisentraut
On 2020-01-03 15:13, John Naylor wrote: On Thu, Dec 26, 2019 at 12:39 PM Peter Eisentraut wrote: On 2019-12-19 23:48, John Naylor wrote: I would print out the full boilerplate like for other generated headers. Hmm, you are probably comparing with src/common/unicode/generate-unicode_norm_tab

Re: Recognizing superuser in pg_hba.conf

2020-01-09 Thread Simon Riggs
On Wed, 8 Jan 2020 at 23:55, Vik Fearing wrote: > On 08/01/2020 23:13, Peter Eisentraut wrote: > > On 2020-01-06 17:03, Tom Lane wrote: > >> So it's not clear to me whether we have any meeting of the minds > >> on wanting this patch. > > > > This fairly far-ranging syntax reorganization of pg_hba

Verify true root on replicas with amcheck

2020-01-09 Thread godjan •
Hi, we have trouble to detect true root corruptions on replicas. I made a patch for resolving it with the locking meta page and potential root page. I heard that amcheck has an invariant about locking no more than 1 page at a moment for avoiding deadlocks. Is there possible a deadlock situation?

Re: Allow 'sslkey' and 'sslcert' in postgres_fdw user mappings

2020-01-09 Thread Andrew Dunstan
On Wed, Jan 8, 2020 at 7:36 PM Peter Eisentraut wrote: > > On 2019-12-02 00:12, Andrew Dunstan wrote: > > On 11/30/19 8:48 PM, Michael Paquier wrote: > >> On Thu, Oct 31, 2019 at 07:54:41PM -0400, Andrew Dunstan wrote: > >>> This patch achieves $SUBJECT and also provides some testing of the > >>>

<    1   2