Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

On Wed, Mar 11, 2020 at 2:23 PM Amit Kapila wrote: > > On Tue, Mar 10, 2020 at 8:53 AM Dilip Kumar wrote: > > > > Please find the updated patch (summary of the changes) > > - Instead of searching the lock hash table for assert, it maintains a > > counter. > > - Also, handled the case where we

Re: Berserk Autovacuum (let's save next Mandrill)

On Thu, 2020-03-12 at 17:47 +1300, David Rowley wrote: > I'm starting to think that we should set the scale_factor to something > like 0.3 and the threshold to 50. Is anyone strongly against that? Or > Laurenz, are you really set on the 10 million threshold? These values are almost the same as

RE: Planning counters in pg_stat_statements (using pgss_store)

Hi Julien, On Mon, Mar 9, 2020 at 10:32 AM, Julien Rouhaud wrote: > On Thu, Mar 05, 2020 at 01:26:19PM -0700, legrand legrand wrote: > > Please consider PG13 shortest path ;o) > > > > My one is parse->queryId != UINT64CONST(0) in pgss_planner_hook(). > > It fixes IVM problem (verified), > > and

Re: [PATCH] Replica sends an incorrect epoch in its hot standby feedback to the Master

On Wed, Mar 11, 2020 at 7:47 PM Thomas Munro wrote: > On Sat, Feb 22, 2020 at 6:10 AM Palamadai, Eka wrote: > > Thanks a lot for the feedback. Please let me know if you have any further > > comments. Meanwhile, I have also added this patch to "Commitfest 2020-03" > > at

Re: Berserk Autovacuum (let's save next Mandrill)

On Wed, 11 Mar 2020 at 19:00, Masahiko Sawada wrote: > > On Wed, 11 Mar 2020 at 13:24, Laurenz Albe wrote: > > If you have an insert-only table that has 10 entries, it will get > > vacuumed roughly every 2 new entries. The impact is probably too > > little to care, but it will increase

Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

On Wed, Mar 11, 2020 at 12:27:03PM +0900, Michael Paquier wrote: >> Also, I think the function comment could stand some more detailing. > > What kind of additional information would you like to add on top of > what the updated version attached does? I have been working more on that, and attached

Re: Refactor compile-time assertion checks for C/C++

Michael Paquier writes: > Indeed the bot is happy now. By looking at the patch, one would note > that what it just does is unifying the fallback "hack-ish" > implementations so as C and C++ use the same thing, which is the > fallback implementation for C of HEAD. I would prefer hear first from

Re: [PATCH] Fix for slow GIN index queries when "gin_fuzzy_search_limit" setting is relatively small for large tables

Hi, Tom. Thanks for taking a look. > It seems like what you're actually trying > to accomplish is to ensure that entryLoadMoreItems's "stepright" path > is taken, instead of re-descending the index from the root. What I was primarily trying to do is make sure that when entryLoadMoreItems is

Re: BEFORE ROW triggers for partitioned tables

On Wed, Mar 11, 2020 at 8:53 PM Ashutosh Bapat wrote: > > On Thu, Feb 27, 2020 at 10:22 PM Alvaro Herrera > wrote: > > > > * The "root" is not necessarily the root partitioned table, but instead > > it's the table that was named in the command. Because of this, we don't > > need to acquire

Re: Berserk Autovacuum (let's save next Mandrill)

On Wed, 11 Mar 2020 at 17:24, Laurenz Albe wrote: > > On Wed, 2020-03-11 at 12:00 +0900, Masahiko Sawada wrote: > > I might be missing your point but could you elaborate on that in what > > kind of case you think this lead to unnecessary vacuums? > > If you have an insert-only table that has

A bug when use get_bit() function for a long bytea string

Hello hackers, I found an issue about get_bit() and set_bit() function,here it is: postgres=# select get_bit(pg_read_binary_file('/home/movead/temp/file_seek/f_512M'), 0); 2020-03-12 10:05:23.296 CST [10549] ERROR: index 0 out of valid range, 0..-1 2020-03-12

Re: v13 latest snapshot build error

Artur Zakirov writes: > I'm not familiar with the patch itself. But I think there is just a lack > of the comma here, after ", /tmp" :-) [ blink... ] There definitely is a comma there in the version of the patch that's in the Fedora repo. regards, tom lane

Re: v13 latest snapshot build error

Hello, On 3/12/2020 4:44 AM, Tom Lane wrote: Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= writes: I'm getting build error while building latest snapshot. Any idea why? Please note that I'm adding this patch to the tarball:

Re: GSOC 2020 - Develop Performance Farm Benchmarks and Website (2020)

Hi, On Mon, Mar 09, 2020 at 08:35:10PM +, do w.r. (wrd1e16) wrote: > I am very interested in the Develop Performance Farm Benchmarks and Website > (2020) project as one of the GSOC project. Is it possible to link me up with > Andreas Scherbaum to discuss more and further understand the

Re: Index Skip Scan

On Wed, 11 Mar 2020 at 16:44, Andy Fan wrote: >> >> >> I think the UniqueKeys may need to be changed from using >> EquivalenceClasses to use Exprs instead. > > > When I try to understand why UniqueKeys needs EquivalenceClasses, > see your comments here. I feel that FuncExpr can't be > used to

Re: v13 latest snapshot build error

Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= writes: > On Wed, 2020-03-11 at 21:07 +, Devrim Gunduz wrote: >> This happens on RHEL 8. I don't think it's that bleeding edge. > Morever, my RHEL 7 build are broken as well: Hm. We have various RHEL and CentOS 7.x machines in the buildfarm, and they

Re: v13 latest snapshot build error

Hi Tom, [Adding Christoph] On Wed, 2020-03-11 at 21:07 +, Devrim Gunduz wrote: > This happens on RHEL 8. I don't think it's that bleeding edge. Morever, my RHEL 7 build are broken as well: + MAKELEVEL=0 + /usr/bin/make -j4 all In file included from /usr/include/time.h:37:0,

Re: Refactor compile-time assertion checks for C/C++

On Wed, Mar 11, 2020 at 12:31:19PM +, Georgios Kokolatos wrote: > For whatever is worth, my previous comment that the patch improves > readability also applies to the updated version of the patch. v2 has actually less diffs for the C++ part. > The CF bot seems happy now, which means that

Re: Use compiler intrinsics for bit ops in hash

On Sat, 29 Feb 2020 at 04:13, David Fetter wrote: > > On Thu, Feb 27, 2020 at 02:41:49PM +0800, John Naylor wrote: > > In 0002, the pg_bitutils functions have a test (input > 0), and the > > new callers ceil_log2_* and next_power_of_2_* have asserts. That seems > > backward to me. > > To me, too,

Re: range_agg

Thanks everyone for offering some thoughts on this! Tom Lane wrote: > have you given any thought to just deciding that ranges and > multiranges are the same type? I can see how it might be nice to have just one type to think about. Still I think keeping them separate makes sense. Other folks

Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library

Hugh McMaster writes: > The question is really whether we want to maintain a fallback to > xml2-config. To give more context, I gave a more detailed assessment of the > situation in an earlier email to this list. (Personally, I don’t think we > should.) I think that that is not optional. We try

Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library

On Thu, 12 Mar 2020 at 03:39, Tom Lane wrote: > Daniel Gustafsson writes: > > For me, the duplication aspect is the most troubling, since we'd still > need the > > xml2-config fallback and thus won't be able to simplify the code. > > Yeah, but at least it's concentrated in a few lines in

Re: control max length of parameter values logged

Alvaro Herrera writes: > Maybe it would make sense to always log complete parameters for error > cases when that feature is enabled, and have the GUC only control the > lengths logged for non-error cases? I could get behind that. It's a bit different from the original idea here, but I think

Re: control max length of parameter values logged

On 2020-Mar-10, Tom Lane wrote: > I agree that something ought to be done here, but I'm not sure that > this is exactly what. It appears to me that there are three related > but distinct behaviors under discussion: > > 1. Truncation of bind parameters returned to clients in error message >

Re: v13 latest snapshot build error

Hi, (Sorry for top posting) This happens on RHEL 8. I don't think it's that bleeding edge. Regards, Devrim On 11 March 2020 19:44:55 GMT, Tom Lane wrote: >Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= writes: >> I'm getting build error while building latest snapshot. Any idea why? >Please >> note that

Re: Add an optional timeout clause to isolationtester step.

On 2020-Mar-11, Tom Lane wrote: > We could re-use Julien's ideas about the isolation spec syntax by > making it be, roughly, > > step "" { } [ blocked if "" "" ] > > and then those items would need to be passed as parameters of the prepared > query. I think for test readability's sake, it'd

Re: Add an optional timeout clause to isolationtester step.

Michael Paquier writes: > On Tue, Mar 10, 2020 at 02:53:36PM +0100, Julien Rouhaud wrote: >> So basically we could just change pg_isolation_test_session_is_blocked() to >> also return the wait_event_type and wait_event, and adding something like > Hmm. I think that Tom has in mind the reasons

Re: [Proposal] Global temporary tables

On Wed, Mar 11, 2020 at 9:07 AM 曾文旌(义从) wrote: > reindex need change relfilenode, but GTT is not currently supported. In my view that'd have to be fixed somehow. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: backup manifests

On Fri, Mar 6, 2020 at 3:58 AM Suraj Kharage wrote: > 1: Getting below error while compiling 0002 patch. > 2: > > Few macros defined in 0003 patch not used anywhere in 0005 patch. Either we > can replace these with hard-coded values or remove them. Thanks. I hope that I have straightened those

Re: more ALTER .. DEPENDS ON EXTENSION fixes

Thanks for the reviews; I pushed 0001 now, again to all branches since 9.6. Because of the previous commit, the fact that multiple statements are emitted is not important anymore: the server will only restore the first one, and silently ignore subsequent ones. And once you're using a system in

Re: v13 latest snapshot build error

Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= writes: > I'm getting build error while building latest snapshot. Any idea why? Please > note that I'm adding this patch to the tarball: >

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

Hi, On 2020-03-11 11:25:28 +0800, Craig Ringer wrote: > I propose that per the attached patch PGXS should simply skip adding > the automatic dependency for .bc files if clang cannot be found. > Extensions may still choose to explicitly declare the rule in their > own Makefile if they want to

Re: Improve handling of parameter differences in physical replication

Here is an updated patch that incorporates some of the suggestions. In particular, some of the warning messages have been rephrased to more accurate (but also less specific), the warning message at recovery pause repeats every 1 minute, and the documentation has been updated. -- Peter

Re: pg11+: pg_ls_*dir LIMIT 1: temporary files .. not closed at end-of-transaction

Justin Pryzby writes: >>> On Sun, Mar 08, 2020 at 02:37:49PM -0400, Tom Lane wrote: I guess we ought to change that function to use returns-a-tuplestore protocol instead of thinking it can hold a directory open across calls. > I patched this one to see what it looks like and to allow

Re: backend type in log_line_prefix?

On Tue, Mar 10, 2020 at 02:01:42PM -0500, Justin Pryzby wrote: > On Thu, Feb 13, 2020 at 06:43:32PM +0900, Fujii Masao wrote: > > If we do this, backend type should be also included in csvlog? > > +1, I've been missing that > > Note, this patch seems to correspond to: > b025f32e0b Add leader_pid

Re: User and Logical Replication

On 2020-03-11 17:18, Tobias Stadler wrote: Would it be possible to include the user (who changed the row) in the logical replication data? Not without major re-engineering. If you need this information, maybe a BEFORE INSERT OR UPDATE trigger could be used to write this information into a

Re: Add A Glossary

> > > * Transaction - yes, all those things could be "visible" or they could be > "side effects". It may be best to leave the over-simplified definition in > place, and add a "For more information see < tutorial-transactions>> > transaction-iso would be a better linkref in this case

Re: Add A Glossary

> > It will be helpful for diff-ing to restrict the length of lines in the > SGML files to 71 characters (as usual). I did it that way for the following reasons 1. It aids grep-ability 2. The committers seem to be moving towards that for SQL strings, mostly for reason #1 3. I recall that the

Re: Add A Glossary

On Wed, Mar 11, 2020 at 12:50 PM Jürgen Purtz wrote: > I made changes on top of 0001-add-glossary-page.patch which was supplied > by C. Huinker. This affects not only terms proposed by me but also his > original terms. If my changes are not obvious, please let me know and I > will describe my

v13 latest snapshot build error

Hi,? I'm getting build error while building latest snapshot. Any idea why? Please note that I'm adding this patch to the tarball:

Re: Add A Glossary

I made changes on top of 0001-add-glossary-page.patch which was supplied by C. Huinker. This affects not only terms proposed by me but also his original terms. If my changes are not obvious, please let me know and I will describe my motivation. Please note especially lines marked with

Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library

Daniel Gustafsson writes: > On 10 Mar 2020, at 18:38, Peter Eisentraut > wrote: >> Btw., here is an older thread for the same issue >> . >> Might be worth reflecting on the issues discussed there. >

User and Logical Replication

Hi, Would it be possible to include the user (who changed the row) in the logical replication data? Best Reagrds Tobias

Re: [PATCH] Erase the distinctClause if the result is unique by definition

On Wed, Mar 11, 2020 at 4:19 AM David Rowley wrote: > > On Wed, 11 Mar 2020 at 02:50, Ashutosh Bapat > wrote: > > > > On Tue, Mar 10, 2020 at 1:49 PM Andy Fan wrote: > > > In my current implementation, it calculates the uniqueness for each > > > BaseRel only, but in your way, looks we need to

Re: [PATCH] Erase the distinctClause if the result is unique by definition

On Tue, Mar 10, 2020 at 9:12 PM Andy Fan wrote: > > > Hi Tom & David & Bapat: > > Thanks for your review so far. I want to summarize the current issues to help > our following discussion. > > 1. Shall we bypass the AggNode as well with the same logic. > > I think yes, since the rules to bypass a

Re: Improve search for missing parent downlinks in amcheck

On Wed, Mar 11, 2020 at 2:02 AM Alexander Korotkov wrote: > Thank you! Pushed with this comment revised! Thanks! -- Peter Geoghegan

Re: BEFORE ROW triggers for partitioned tables

On Thu, Feb 27, 2020 at 10:22 PM Alvaro Herrera wrote: > > * The "root" is not necessarily the root partitioned table, but instead > it's the table that was named in the command. Because of this, we don't > need to acquire locks on the tables, since the executor already has the > tables open and

Re: [PATCH] Add schema and table names to partition error

Amit, On 3/11/20 6:29 AM, Amit Kapila wrote: > On Tue, Mar 3, 2020 at 10:05 AM Chris Bandy wrote: >> >> On 3/1/20 10:09 PM, Amit Langote wrote: >>> Hi Chris, >>> >>> On Mon, Mar 2, 2020 at 8:51 AM Chris Bandy wrote: On 3/1/20 5:14 AM, Amit Kapila wrote: > On Sun, Mar 1, 2020 at 10:10

Re: SERIAL datatype column skipping values.

Andreas Karlsson writes: > On 3/11/20 11:15 AM, Prabhat Sahu wrote: >> Is this an expected behavior? > Curious, it seems like DEFAULT expressions of a table are executed an > extra time if a set returning function is used like in your example. And > the SERIAL type is implemented using

Re: more ALTER .. DEPENDS ON EXTENSION fixes

Alvaro Herrera writes: > I'm still not sure whether to apply 0003 (+ your tab-completion patch, > thanks for it) to backbranches or just to master. It seems legitimate > to see it as a feature addition, but OTOH the overall feature is not > complete without it ... 0003 is the command addition

Re: Additional improvements to extended statistics

On Mon, 9 Mar 2020 at 18:19, Tomas Vondra wrote:> > On Mon, Mar 09, 2020 at 08:35:48AM +, Dean Rasheed wrote: > > > > P(a,b) = P(a) * [f + (1-f)*P(b)] > > > >because it might return a value that is larger that P(b), which > >obviously should not be possible. > > Hmmm, yeah. It took me a

Re: more ALTER .. DEPENDS ON EXTENSION fixes

On 2020-Mar-05, Alvaro Herrera wrote: > On 2020-Mar-05, Ibrar Ahmed wrote: > > > Is this intentional that there is no error when removing a non-existing > > dependency? > > Hmm, I think we can do nothing silently if nothing is called for. > So, yes, that seems to be the way it should work. I

Re: SERIAL datatype column skipping values.

On 3/11/20 11:15 AM, Prabhat Sahu wrote: Hi all, Please check the below behavior for the "SERIAL" datatype. [...] In this above case, the serial column "c2" is skipping the value "4" in select output. Is this an expected behavior? Curious, it seems like DEFAULT expressions of a table are

Re: Add A Glossary

Hello, everyone, I'm Roger, the tech writer who worked with Corey on the glossary file. I just thought I'd announce that I am also on the list, and I'm looking forward to any questions or comments people may have. Thanks! On Tue, Mar 10, 2020 at 11:37 AM Corey Huinker wrote: > This latest

Re: Refactor compile-time assertion checks for C/C++

Thank you for updating the status of the issue. I have to admit that I completely missed the CF bot. Lesson learned. For whatever is worth, my previous comment that the patch improves readability also applies to the updated version of the patch. The CF bot seems happy now, which means that your

Re: [PATCH] Add schema and table names to partition error

On Tue, Mar 3, 2020 at 10:05 AM Chris Bandy wrote: > > On 3/1/20 10:09 PM, Amit Langote wrote: > > Hi Chris, > > > > On Mon, Mar 2, 2020 at 8:51 AM Chris Bandy wrote: > >> On 3/1/20 5:14 AM, Amit Kapila wrote: > >>> On Sun, Mar 1, 2020 at 10:10 AM Amit Langote > >>> wrote: > > There

Re: pg11+: pg_ls_*dir LIMIT 1: temporary files .. not closed at end-of-transaction

On Sun, Mar 08, 2020 at 03:40:09PM -0400, Tom Lane wrote: > Justin Pryzby writes: > > On Sun, Mar 08, 2020 at 02:37:49PM -0400, Tom Lane wrote: > >> I guess we ought to change that function to use returns-a-tuplestore > >> protocol instead of thinking it can hold a directory open across calls. >

Re: Index Skip Scan

On Tue, Mar 10, 2020 at 4:32 AM James Coleman wrote: > On Mon, Mar 9, 2020 at 3:56 PM Dmitry Dolgov <9erthali...@gmail.com> > wrote: > > > > Assuming we'll implement it in a way that we do not know about what kind > > of path type is that in create_distinct_path, then it can also work for > >

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

On Tue, Mar 10, 2020 at 4:11 PM Amit Kapila wrote: > > On Mon, Feb 24, 2020 at 3:38 PM Amit Kapila wrote: > > > > On Thu, Feb 20, 2020 at 8:06 AM Andres Freund wrote: > > > What I'm advocating is that extension locks should continue to go > > > through lock.c. And yes, that requires some

Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library

On Wed, 11 Mar 2020 at 07:49, Daniel Gustafsson wrote: > > On 10 Mar 2020, at 18:38, Peter Eisentraut wrote: > > Btw., here is an older thread for the same issue > > . > > Might be worth reflecting on the

Re: HAVE_WORKING_LINK still needed?

On 2020-03-04 17:37, Peter Eisentraut wrote: Here is the third patch again, we renaming durable_link_or_rename() to durable_rename_excl(). This seems to match existing Unix system call naming best (see open() flag O_EXCL, and macOS has a renamex_np() flag RENAME_EXCL). committed like that --

Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library

On Tue, 10 Mar 2020 at 22:41, Daniel Gustafsson wrote: > > > On 10 Mar 2020, at 11:53, Hugh McMaster wrote: > > This patch uses pkg-config's PKG_CHECK_MODULES macro to detect libxml2 > > or, if pkg-config is not available, falls back to xml2-confg. > > This was previously discussed in

SERIAL datatype column skipping values.

Hi all, Please check the below behavior for the "SERIAL" datatype. postgres=# CREATE TABLE t1(c1 int, c2 serial); CREATE TABLE postgres=# insert into t1 values (generate_series(1,3)); INSERT 0 3 postgres=# insert into t1 values (generate_series(4,6)); INSERT 0 3 postgres=# select * from t1; c1 |

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

On Wed, Mar 11, 2020 at 2:23 PM Amit Kapila wrote: > > On Tue, Mar 10, 2020 at 8:53 AM Dilip Kumar wrote: > > > > Please find the updated patch (summary of the changes) > > - Instead of searching the lock hash table for assert, it maintains a > > counter. > > - Also, handled the case where we

Re: WIP/PoC for parallel backup

Hi Asif I have started testing this feature. I have applied v6 patch on commit a069218163704c44a8996e7e98e765c56e2b9c8e (30 Jan). I got few observations, please take a look. *--if backup failed, backup directory is not getting removed.* [edb@localhost bin]$ ./pg_basebackup -p 5432 --jobs=9 -D

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

On Tue, Mar 10, 2020 at 6:39 PM Robert Haas wrote: > > On Fri, Mar 6, 2020 at 11:27 PM Dilip Kumar wrote: > > I think instead of the flag we need to keep the counter because we can > > acquire the same relation extension lock multiple times. So > > basically, every time we acquire the lock we

Re: Improve search for missing parent downlinks in amcheck

On Wed, Mar 11, 2020 at 7:19 AM Peter Geoghegan wrote: > This looks committable. I only noticed one thing: The comments above > bt_target_page_check() need to be updated to reflect the new check, > which no longer has anything to do with "heapallindexed = true". Thank you! Pushed with this

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

On Tue, Mar 10, 2020 at 8:53 AM Dilip Kumar wrote: > > Please find the updated patch (summary of the changes) > - Instead of searching the lock hash table for assert, it maintains a counter. > - Also, handled the case where we can acquire the relation extension > lock while holding the relation

Re: [Proposal] Global temporary tables

On Mon, Mar 9, 2020 at 10:02 PM 曾文旌(义从) wrote: > > > Fixed in global_temporary_table_v18-pg13.patch. > Hi Wenjing, Thanks for the patch. I have verified the previous issues with "gtt_v18_pg13.patch" and those are resolved. Please find below case: postgres=# create sequence seq; CREATE SEQUENCE

Re: Refactor compile-time assertion checks for C/C++

On Sat, Mar 07, 2020 at 04:44:48PM -0500, Tom Lane wrote: > cfbot reports this doesn't work with MSVC. Not sure why --- maybe > it defines __cpp_static_assert differently than you're expecting? I don't think that's the issue. The CF bot uses MSVC 12.0 which refers to the 2013.

Re: Some problems of recovery conflict wait events

On 2020/03/10 13:54, Masahiko Sawada wrote: On Tue, 10 Mar 2020 at 00:57, Fujii Masao wrote: On 2020/03/09 14:10, Masahiko Sawada wrote: On Mon, 9 Mar 2020 at 13:24, Fujii Masao wrote: On 2020/03/08 13:52, Masahiko Sawada wrote: On Thu, 5 Mar 2020 at 20:16, Fujii Masao wrote:

Re: Online checksums verification in the backend

On Tue, Dec 10, 2019 at 11:12:34AM +0100, Julien Rouhaud wrote: > On Tue, Dec 10, 2019 at 3:26 AM Michael Paquier wrote: > > > > On Mon, Dec 09, 2019 at 07:02:43PM +0100, Julien Rouhaud wrote: > > > On Mon, Dec 9, 2019 at 5:21 PM Robert Haas wrote: > > >> Some people might prefer notices,

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

On Wed, 11 Mar 2020 at 13:47, Pavel Stehule wrote: > > st 11. 3. 2020 v 6:43 odesílatel Julien Rouhaud napsal: >> >> Le mer. 11 mars 2020 à 05:28, Laurenz Albe a >> écrit : >>> >>> On Wed, 2020-03-11 at 11:25 +0800, Craig Ringer wrote: >>> > Short version: Currently if the server is built with

Re: [PATCH] Replica sends an incorrect epoch in its hot standby feedback to the Master

On Sat, Feb 22, 2020 at 6:10 AM Palamadai, Eka wrote: > Thanks a lot for the feedback. Please let me know if you have any further > comments. Meanwhile, I have also added this patch to "Commitfest 2020-03" at > https://commitfest.postgresql.org/27/2464. Thanks for the excellent reproducer for

Re: custom postgres launcher for tests

On Fri, 21 Feb 2020 at 17:05, Ivan N. Taranov wrote: > > On Fri, Feb 21, 2020 at 4:49 AM Craig Ringer wrote: > > > I thought I saw a related patch to this that proposed to add a pg_ctl > > argument. Was that you too? I can't find it at the moment. I've had it on my TODO forever but I don't

Re: Berserk Autovacuum (let's save next Mandrill)

On Wed, 11 Mar 2020 at 13:24, Laurenz Albe wrote: > > On Wed, 2020-03-11 at 12:00 +0900, Masahiko Sawada wrote: > > > > I have one question about this patch from architectural perspective: > > > > have you considered to use autovacuum_vacuum_threshold and > > > > autovacuum_vacuum_scale_factor