Re: pglz compression performance, take two

2020-12-25 Thread Andrey Borodin
> 12 дек. 2020 г., в 22:47, Andrey Borodin написал(а): > > I've cleaned up comments, checked that memory alignment stuff actually make sense for 32-bit ARM (according to Godbolt) and did some more code cleanup. PFA v2 patch. I'm still in doubt should I register this patch on CF or not. I'm

Re: On login trigger: take three

2020-12-25 Thread Pavel Stehule
so 26. 12. 2020 v 8:00 odesílatel Pavel Stehule napsal: > Hi > > > Thank you. >> I have applied all your fixes in on_connect_event_trigger-12.patch. >> >> Concerning enable_client_connection_trigger GUC, I think that it is >> really useful: it is the fastest and simplest way to disable login trig

Re: On login trigger: take three

2020-12-25 Thread Pavel Stehule
Hi Thank you. > I have applied all your fixes in on_connect_event_trigger-12.patch. > > Concerning enable_client_connection_trigger GUC, I think that it is really > useful: it is the fastest and simplest way to disable login triggers in case > of some problems with them (not only for superuser it

Re: Better client reporting for "immediate stop" shutdowns

2020-12-25 Thread Bharath Rupireddy
On Sat, Dec 26, 2020 at 4:33 AM Andres Freund wrote: > On 2020-12-21 16:43:33 -0500, Tom Lane wrote: > > * I chose to report the same message for immediate shutdown as we > > already use for SIGTERM (fast shutdown or pg_terminate_backend()). > > Should it be different, and if so what? > > To do be

Re: proposal: schema variables

2020-12-25 Thread Pavel Stehule
so 26. 12. 2020 v 7:18 odesílatel Erik Rijkers napsal: > On 2020-12-26 05:52, Pavel Stehule wrote: > > so 19. 12. 2020 v 7:57 odesílatel Pavel Stehule > > > > napsal: > > [schema-variables-20201222.patch.gz (~] > > > >> Hi > >> > >> only rebase > >> > > > > rebase and comments fixes > > > > Hi P

Re: proposal: schema variables

2020-12-25 Thread Erik Rijkers
On 2020-12-26 05:52, Pavel Stehule wrote: so 19. 12. 2020 v 7:57 odesílatel Pavel Stehule napsal: [schema-variables-20201222.patch.gz (~] Hi only rebase rebase and comments fixes Hi Pavel, This file is the exact same as the file you sent Tuesday. Is it a mistake?

Re: Parallel Inserts in CREATE TABLE AS

2020-12-25 Thread Dilip Kumar
On Thu, Dec 24, 2020 at 1:07 PM Bharath Rupireddy wrote: > > On Thu, Dec 24, 2020 at 10:25 AM vignesh C wrote: > > You could change intoclause_len = strlen(intoclausestr) to > > strlen(intoclausestr) + 1 and use intoclause_len in the remaining > > places. We can avoid the +1 in the other places.

Re: proposal: schema variables

2020-12-25 Thread Pavel Stehule
so 19. 12. 2020 v 7:57 odesílatel Pavel Stehule napsal: > Hi > > only rebase > rebase and comments fixes Regards Pavel > Regards > > Pavel > schema-variables-20201222.patch.gz Description: application/gzip

RE: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently

2020-12-25 Thread tsunakawa.ta...@fujitsu.com
From: Michael Paquier > On Wed, Dec 09, 2020 at 09:52:17AM -0300, Alvaro Herrera wrote: > > Well, that definition seems unfriendly to me. I prefer the stance > > that if you change the value for the parent, then future partitions > > inherit that value. > > That's indeed more interesting from th

Re: SQL/JSON: functions

2020-12-25 Thread Zhihong Yu
For 0001-Common-SQL-JSON-clauses-v51.patch : + /* | implementation_defined_JSON_representation_option (BSON, AVRO etc) */ I don't find implementation_defined_JSON_representation_option in the patchset. Maybe rephrase the above as a comment without implementation_defined_JSON_representation

Re: Better client reporting for "immediate stop" shutdowns

2020-12-25 Thread Andres Freund
Hi, On 2020-12-21 16:43:33 -0500, Tom Lane wrote: > Up to now, if you shut down the database with "pg_ctl stop -m immediate" > then clients get a scary message claiming that something has crashed, > because backends can't tell whether the SIGQUIT they got was sent for > a crash-and-restart situati

Re: Logical decoding without slots: decoding in lockstep with recovery

2020-12-25 Thread Andres Freund
Hi, On 2020-12-23 14:56:07 +0800, Craig Ringer wrote: > I want to share an idea I've looked at a few times where I've run into > situations where logical slots were inadvertently dropped, or where it > became necessary to decode changes in the past on a slot. > > As most of you will know you can'

Re: [HACKERS] [PATCH] Generic type subscripting

2020-12-25 Thread Dmitry Dolgov
> On Tue, Dec 22, 2020 at 02:21:22PM -0500, Tom Lane wrote: > Pavel Stehule writes: > > But maybe we try to design some that are designed already. Is there some > > info about index specification in SQL/JSON? > > We do have precedent for this, it's the rules about resolving argument > types for ov

Pre-allocating WAL files

2020-12-25 Thread Andres Freund
Hi, When running write heavy transactional workloads I've many times observed that one needs to run the benchmarks for quite a while till they get to their steady state performance. The most significant reason for that is that initially WAL files will not get recycled, but need to be freshly initi

Re: Temporary tables versus wraparound... again

2020-12-25 Thread Noah Misch
On Tue, Nov 10, 2020 at 04:10:57PM +0900, Masahiko Sawada wrote: > On Mon, Nov 9, 2020 at 3:23 PM Greg Stark wrote: > > On Mon, 9 Nov 2020 at 00:17, Noah Misch wrote: > > > > @@ -3340,6 +3383,7 @@ heap_truncate_one_rel(Relation rel) > > > > > > > > /* Truncate the underlying relation */ >

Re: pgsql: Add key management system

2020-12-25 Thread Bruce Momjian
On Fri, Dec 25, 2020 at 07:30:01PM +0100, Erik Rijkers wrote: > On 2020-12-25 16:19, Bruce Momjian wrote: > > > Add key management system > > doc/src/sgml/database-encryption.sgml | 97 + > > Attached are a few typos. > > I also noticed that this option does not occur in the initdb -

Re: pgsql: Add key management system

2020-12-25 Thread Erik Rijkers
On 2020-12-25 16:19, Bruce Momjian wrote: Add key management system doc/src/sgml/database-encryption.sgml | 97 + Attached are a few typos. I also noticed that this option does not occur in the initdb --help: -u --copy-encryption-keys Was that deliberate? Thanks, Erik Rijk

Re: A failure of standby to follow timeline switch

2020-12-25 Thread Fujii Masao
On 2020/12/25 12:03, Kyotaro Horiguchi wrote: Thank you for looking this. At Thu, 24 Dec 2020 15:33:04 +0900, Fujii Masao wrote in When I applied two patches in the master branch and ran "make check-world", I got the following error. == creating database "contrib_regression" =

Re: Commit fest manager for 2021-01

2020-12-25 Thread Masahiko Sawada
On Fri, Dec 25, 2020 at 8:20 PM Magnus Hagander wrote: > > > On Fri, Dec 25, 2020 at 8:48 AM Michael Paquier wrote: >> >> On Fri, Dec 25, 2020 at 04:35:30PM +0900, Masahiko Sawada wrote: >> > Hmm, on the left of the logout button, I can see only the 'edit >> > profile' button and 'Activity log' b

Re: Logical decoding without slots: decoding in lockstep with recovery

2020-12-25 Thread Craig Ringer
On Wed, 23 Dec 2020, 18:57 Amit Kapila, wrote: > On Wed, Dec 23, 2020 at 12:26 PM Craig Ringer > wrote: > > > > Hi all > > > > I want to share an idea I've looked at a few times where I've run into > situations where logical slots were inadvertently dropped, or where it > became necessary to dec

Re: Add session statistics to pg_stat_database

2020-12-25 Thread Masahiro Ikeda
Hi, As a user, I want this feature to know whether clients' session activities are as expected. I have some comments about the patch. 1. pg_proc.dat The unit of "session time" and so on says "in seconds". But, is "in milliseconds" right? 2. monitoring.sgml IIUC, "active_time" includes the

RE: Disable WAL logging to speed up data loading

2020-12-25 Thread osumi.takami...@fujitsu.com
Hi, Michael Thank you for your attention to this thread. On Friday, December 25, 2020 4:09 PM Michael Paquier wrote: > On Thu, Dec 03, 2020 at 03:52:47AM +, tsunakawa.ta...@fujitsu.com > wrote: > > The code looks good, and the performance seems to be nice, so I marked > > this ready for co

Re: Commit fest manager for 2021-01

2020-12-25 Thread Magnus Hagander
On Fri, Dec 25, 2020 at 8:48 AM Michael Paquier wrote: > On Fri, Dec 25, 2020 at 04:35:30PM +0900, Masahiko Sawada wrote: > > Hmm, on the left of the logout button, I can see only the 'edit > > profile' button and 'Activity log' button. > > Maybe that's a cache issue with your browser? Magnus, a

Re: About to add WAL write/fsync statistics to pg_stat_wal view

2020-12-25 Thread Masahiro Ikeda
Hi, I rebased the patch to the master branch. Regards, -- Masahiro Ikeda NTT DATA CORPORATIONdiff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index 4b60382778..45d54cd394 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -7388,6 +7388,27 @@ COPY postgres_log

Re: Get memory contexts of an arbitrary backend process

2020-12-25 Thread Kasahara Tatsuhito
Hi, On Thu, Dec 10, 2020 at 10:48 AM torikoshia wrote: > > On 2020-12-04 19:16, torikoshia wrote: > > On 2020-12-03 10:36, Tom Lane wrote: > >> Fujii Masao writes: > >>> I'm starting to study how this feature behaves. At first, when I > >>> executed > >>> the following query, the function never

pg_waldump: Limit the number of lines shown at the start

2020-12-25 Thread Kyotaro Horiguchi
Hello. I'm occasionally annoyed by the behavior of pg_waldump that it shows all records in the specified segment before entering waiting state. tail -f shows only the last few dozen lines at the start. This behavior I think is useful also for pg_waldump -f. It was as simple than expected as att

Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY

2020-12-25 Thread Andy Fan
On Tue, Aug 4, 2020 at 7:49 AM Alvaro Herrera wrote: > I've been working on the ability to detach a partition from a > partitioned table, without causing blockages to concurrent activity. > I think this operation is critical for some use cases. > > This would be a very great feature. When we can