On Sat, Jan 23, 2021 at 11:26 PM Amit Kapila wrote:
>
> On Sat, Jan 23, 2021 at 4:55 AM Peter Smith wrote:
> >
> > PSA the v18 patch for the Tablesync Solution1.
> >
>
> Few comments:
> =
> 1.
> - * So the state progression is always: INIT -> DATASYNC -> SYNCWAIT ->
> - * CATCHUP
On Sun, Jan 24, 2021 at 11:29 AM Dilip Kumar wrote:
> > Some comments on the v6 patch:
> > [2] Typo - it's "requested" + * 'paused requested' - if pause is
> > reqested but recovery is not yet paused
Here I meant the typo "reqested" in "if pause is reqested but recovery
is not yet paused" statem
On Sun, Jan 24, 2021 at 7:17 AM Dilip Kumar wrote:
> On Sat, 23 Jan 2021 at 4:40 PM, Bharath Rupireddy
> wrote:
>>
>> On Sat, Jan 23, 2021 at 1:36 PM Dilip Kumar wrote:
>> > Please find the patch for the same. I haven't added a test case for
>> > this yet. I mean we can write a test case to p
Hi,
While working on pg14 compatibility for an extension relying on an apparently
uncommon combination of FOR UPDATE and stored function calls, I hit some new
Asserts introduced in 866e24d47db (Extend amcheck to check heap pages):
+ /*
+* Do not allow tuples with invalid combination
On Sat, Jan 23, 2021 at 4:40 PM Bharath Rupireddy
wrote:
>
> On Sat, Jan 23, 2021 at 1:36 PM Dilip Kumar wrote:
> > Please find the patch for the same. I haven't added a test case for
> > this yet. I mean we can write a test case to pause the recovery and
> > get the status. But I am not sure
On Sat, Jan 23, 2021 at 12:52 PM Zhihong Yu wrote:
> Hi,
>
> + for (i = 0; i < riinfo->nkeys; i++)
> + {
> + Oid eq_opr = eq_oprs[i];
> + Oid typeid = RIAttType(fk_rel, riinfo->fk_attnums[i]);
> + RI_CompareHashEntry *entry = ri_HashCompareOp(eq_o
On Sat, 23 Jan 2021 at 4:40 PM, Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
> On Sat, Jan 23, 2021 at 1:36 PM Dilip Kumar wrote:
> > Please find the patch for the same. I haven't added a test case for
> > this yet. I mean we can write a test case to pause the recovery and
Hi,
On 2021-01-19 14:16:07 +0800, Craig Ringer wrote:
> AFAICS it'd be necessary to expand PROCLOG to expose this in shmem.
> Probably by adding a small bitfield where bit 0 is set if there's a txn
> level lock and bit 1 is set if there's a session level lock. But I'm not
> convinced that expandin
Hi,
I've pushed the fix, after a a couple extra rounds of careful testing.
I noticed that the existing pg_visibility regression tests don't check
if we freeze the TOAST rows too (failing to do that was one of the
symptoms). It'd be good to add that, because that would fail even
without CLOBBE
On Sun, Jan 10, 2021 at 9:21 AM Thomas Munro wrote:
> I left the fsync-after-closing and non-sync'd tests using write(),
> because they weren't using lseek(). The latter case is arguably a bit
> odd because it's not overwriting pre-allocated blocks, unlike the
> earlier tests.
On closer inspecti
Hi,
On 2021-01-21 16:23:58 +0100, Denis Laxalde wrote:
> We found an issue in pg_upgrade on a cluster with a third-party
> background worker. The upgrade goes fine, but the new cluster is then in
> an inconsistent state. The background worker comes from the PoWA
> extension but the issue does not
FYI - I have done some long-running testing using the current patch [v18].
1. The src/test/subscription TAP tests:
- Subscription TAP tests were executed in a loop X 150 iterations.
- Duration 5 hrs.
- All iterations report "Result: PASS"
2. The postgres "make check" tests:
- make check was execu
I got annoyed about the lack of $SUBJECT. The attached patch
adds a simple test case, bringing the module's coverage to 84%
according to my results. (The uncovered lines mostly are in
_PG_fini(), which is unreachable, or else to do with chaining
to additional occupiers of the same hooks.)
Any ob
On Fri, Jan 15, 2021 at 01:39:49PM -0500, Bruce Momjian wrote:
> I learned a few things when working on the key management patch that I
> want to share here in case it helps anyone:
...
> Maybe everyone else knew these things, but I didn't. I can provide more
> details if desired.
One more learni
so 23. 1. 2021 v 19:21 odesílatel Stephen Frost napsal:
> Greetings,
>
> * Pavel Stehule (pavel.steh...@gmail.com) wrote:
> > jsonb with subscripting support can be used as a dictionary object in
> > plpgsql.
> >
> > Can be nice to have support for iteration over a set of tuples (key,
> > value).
Greetings,
* Pavel Stehule (pavel.steh...@gmail.com) wrote:
> jsonb with subscripting support can be used as a dictionary object in
> plpgsql.
>
> Can be nice to have support for iteration over a set of tuples (key,
> value).
Yes, I agree that this would be useful.
> FOREACH fieldvar [ KEY keyv
Greetings,
On Fri, Jan 22, 2021 at 2:33 PM Tom Lane wrote:
> Tommy Li writes:
> > Additionally, is there any interest in exposing more vacuum options to be
> > run by autovac? Right now it runs FREEZE and ANALYZE, which leaves the
> > VERBOSE, SKIP_LOCKED, INDEX_CLEANUP, and TRUNCATE unconfigura
Hi,
+ for (i = 0; i < riinfo->nkeys; i++)
+ {
+ Oid eq_opr = eq_oprs[i];
+ Oid typeid = RIAttType(fk_rel, riinfo->fk_attnums[i]);
+ RI_CompareHashEntry *entry = ri_HashCompareOp(eq_opr, typeid);
+
+ if (pk_nulls[i] != 'n' &&
OidIsValid(en
On 1/23/21 9:31 AM, Amit Langote wrote:
On Thu, Jan 21, 2021 at 11:36 AM Tomas Vondra
wrote:
On 1/21/21 3:09 AM, tsunakawa.ta...@fujitsu.com wrote:
From: Tomas Vondra
Right, that's pretty much what I ended up doing (without the CMD_INSERT
check it'd add batching info to explain for update
Hi, Mark:
+ CREATE TABLE races (
Maybe 'racings' is a better name for the table (signifying the activities).
+ if (ARR_NDIM(arr) != 1 ||
+ ARR_DIMS(arr)[0] != numkeys ||
+ ARR_HASNULL(arr) ||
+ ARR_ELEMTYPE(arr) != CHAROID)
+ elog(ERROR, "confref
Amit:
Good catch.
bq. ExecInitRoutingInfo() that is in the charge of initialing
Should be 'ExecInitRoutingInfo() that is in charge of initializing'
Cheers
On Sat, Jan 23, 2021 at 12:31 AM Amit Langote
wrote:
> On Thu, Jan 21, 2021 at 11:36 AM Tomas Vondra
> wrote:
> > On 1/21/21 3:09 AM, tsu
Greetings,
I am trying to revive this patch, Foreign Key Arrays. The original proposal
from my GSoC 2017 days can be found here:
https://www.postgresql.org/message-id/CAJvoCut7zELHnBSC8HrM6p-R6q-NiBN1STKhqnK5fPE-9%3DGq3g%40mail.gmail.com
Disclaimer, I am not the original author of this patch, I p
On Sat, Jan 23, 2021 at 4:55 AM Peter Smith wrote:
>
> PSA the v18 patch for the Tablesync Solution1.
>
Few comments:
=
1.
- * So the state progression is always: INIT -> DATASYNC -> SYNCWAIT ->
- * CATCHUP -> SYNCDONE -> READY.
+ * So the state progression is always: INIT -> DA
On Sat, Jan 23, 2021 at 1:36 PM Dilip Kumar wrote:
> Please find the patch for the same. I haven't added a test case for
> this yet. I mean we can write a test case to pause the recovery and
> get the status. But I am not sure that we can really write a reliable
> test case for 'pause requested
On 2021-01-20 03:49, Nikita Glukhov wrote:
[0001-Add-common-SQL-JSON-clauses-v52.patch.gz]
[0002-SQL-JSON-constructors-v52.patch.gz]
[0003-IS-JSON-predicate-v52.patch.gz]
[0004-SQL-JSON-query-functions-v52.patch.gz]
[0005-SQL-JSON-functions-for-json-type-v52.patch.gz]
[0006-GUC-sql_json-v52.patc
Hi Justin,
On Sun, Dec 27, 2020 at 02:26:05PM -0600, Justin Pryzby wrote:
> Thank you.
I have been looking at 0005, the patch dealing with the docs of the
replication stats, and have some comments.
Number of times transactions were spilled to disk while decoding
changes
-
Hi
only rebase
Regards
Pavel
schema-variables-20200123.patch.gz
Description: application/gzip
On Sat, Jan 23, 2021 at 1:27 AM Sergey Shinderuk
wrote:
>
> On 23.01.2021 08:02, Sergey Shinderuk wrote:
> >> On the whole it looks like we should recommend installing the CLT
> >> and not bothering with Xcode, which is about 10X the size:
> >>
> >> $ du -hs /Library/Developer/CommandLineTools
> >
On Thu, Jan 21, 2021 at 11:36 AM Tomas Vondra
wrote:
> On 1/21/21 3:09 AM, tsunakawa.ta...@fujitsu.com wrote:
> > From: Tomas Vondra
> >> Right, that's pretty much what I ended up doing (without the CMD_INSERT
> >> check it'd add batching info to explain for updates too, for example).
> >> I'll d
On 23.01.2021 08:02, Sergey Shinderuk wrote:
On the whole it looks like we should recommend installing the CLT
and not bothering with Xcode, which is about 10X the size:
$ du -hs /Library/Developer/CommandLineTools
1.1G /Library/Developer/CommandLineTools
$ du -hs /Applications/Xcode.app
15
On Sat, Jan 23, 2021 at 11:50 AM Amit Kapila wrote:
>
> On Fri, Jan 22, 2021 at 2:59 PM Bharath Rupireddy
> wrote:
> >
> > On Fri, Jan 22, 2021 at 2:00 PM Amit Kapila wrote:
> >
> > Yes you are right. Looks like the above commit is causing the issue. I
> > reverted that commit and did not see th
On Sat, Jan 23, 2021 at 9:56 AM Dilip Kumar wrote:
>
> On Fri, Jan 22, 2021 at 2:18 AM Robert Haas wrote:
> >
> > On Mon, Jan 18, 2021 at 9:42 PM Yugo NAGATA wrote:
> > > If it is acceptable that pg_is_wal_replay_paused() makes users wait,
> > > I'm ok for the current interface. I don't feel the
32 matches
Mail list logo
