Re: Added schema level support for publication.

2021-09-21 Thread Amit Kapila
On Tue, Sep 21, 2021 at 11:39 PM vignesh C wrote: > > On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow wrote: > > > > On Fri, Sep 17, 2021 at 10:09 PM vignesh C wrote: > > > > > > Attached v29 patch has the fixes for the same. > > > > > > > Some minor comments on the v29-0002 patch: > > > > (1) >

RE: Added schema level support for publication.

2021-09-21 Thread tanghy.f...@fujitsu.com
On Wednesday, September 22, 2021 11:22 AM Masahiko Sawada wrote: > > --- > + if (!IsA(node, String)) > + ereport(ERROR, > + errcode(ERRCODE_SYNTAX_ERROR), > +

Re: row filtering for logical replication

2021-09-21 Thread Dilip Kumar
On Wed, Sep 22, 2021 at 9:20 AM Amit Kapila wrote: > > On Wed, Sep 22, 2021 at 6:42 AM Ajin Cherian wrote: > > > > On Tue, Sep 21, 2021 at 9:42 PM Dilip Kumar wrote: > > > > > > On Tue, Sep 21, 2021 at 4:29 PM Dilip Kumar wrote: > > > > > > I have one more question, while looking into the > > >

Re: windows build slow due to windows.h includes

2021-09-21 Thread Noah Misch
On Tue, Sep 21, 2021 at 12:30:35PM -0700, Andres Freund wrote: > solution to windows.h being just so damn big, the delightfully named > WIN32_LEAN_AND_MEAN. > > This reduces the non-incremental buildtime in my 8 core windows VM from 187s > to > 140s. Cross compiling from linux it's > master: > re

Re: Added schema level support for publication.

2021-09-21 Thread Amit Kapila
On Wed, Sep 22, 2021 at 8:02 AM houzj.f...@fujitsu.com wrote: > > On Wednesday, September 22, 2021 2:02 AM vignesh C > wrote: > > Attached v30 patch has the fixes for the same. > > Thanks for updating the patches. > > I have one comment. > @@ -474,7 +707,75 @@ AlterPublication(ParseState *pstate

RE: Failed transaction statistics to measure the logical replication progress

2021-09-21 Thread osumi.takami...@fujitsu.com
Hello Just conducted some cosmetic changes and rebased my patch, using v14 patch-set in [1]. [1] - https://www.postgresql.org/message-id/CAD21AoCO_ZYWZEBw7ziiYoX7Zm1P0L9%3Dd7Jj9YsGEGsT9o6wmw%40mail.gmail.com Best Regards, Takamichi Osumi extend_subscription_stats_of_transaction_v05

Re: logical replication restrictions

2021-09-21 Thread Amit Kapila
On Tue, Sep 21, 2021 at 4:21 PM Marcos Pegoraro wrote: > No, I´m talking about that configuration you can have on standby servers > recovery_min_apply_delay = '8h' > > oh okay, I think this can be useful in some cases where we want to avoid data loss similar to its use for physical standby. For e

Re: row filtering for logical replication

2021-09-21 Thread Ajin Cherian
On Wed, Sep 22, 2021 at 1:50 PM Amit Kapila wrote: > > On Wed, Sep 22, 2021 at 6:42 AM Ajin Cherian wrote: > > > > Why do you think that the second assumption (if there is an old tuple > it will contain all RI key fields.) is broken? It seems to me even > when we are planning to include unchanged

Re: relation OID in ReorderBufferToastReplace error message

2021-09-21 Thread Amit Kapila
On Wed, Sep 22, 2021 at 2:17 AM Jeremy Schneider wrote: > > On 9/20/21 22:14, Amit Kapila wrote: > > On Fri, Sep 17, 2021 at 10:53 AM Amit Kapila > > wrote: > >> > >> I don't think it is a bad idea to print additional information as you > >> are suggesting but why only for this error? It could b

Re: Estimating HugePages Requirements?

2021-09-21 Thread Michael Paquier
On Tue, Sep 21, 2021 at 04:06:38PM +, Bossart, Nathan wrote: > I was looking at this from the standpoint of keeping the startup steps > consistent between the modes. Looking again, I can't think of > a strong reason to add it to bootstrap mode. I think the case for > adding it to single-user

Re: 回复:Queries that should be canceled will get stuck on secure_write function

2021-09-21 Thread Fujii Masao
On 2021/09/22 1:14, 蔡梦娟(玊于) wrote: Hi all, I want to know your opinion on this patch, or in what way do you think we should solve this problem? I agree that something like the patch (i.e., introduction of promotion from cancel request to terminate one) is necessary for the fix. One concern

Re: row filtering for logical replication

2021-09-21 Thread Amit Kapila
On Wed, Sep 22, 2021 at 6:42 AM Ajin Cherian wrote: > > On Tue, Sep 21, 2021 at 9:42 PM Dilip Kumar wrote: > > > > On Tue, Sep 21, 2021 at 4:29 PM Dilip Kumar wrote: > > > > I have one more question, while looking into the > > ExtractReplicaIdentity() function, it seems that if any of the "rep >

Re: Added schema level support for publication.

2021-09-21 Thread Masahiko Sawada
On Wed, Sep 22, 2021 at 3:02 AM vignesh C wrote: > > > Attached v30 patch has the fixes for the same. > Thank you for updating the patches. Here are random comments on v30-0002 patch: + + if (stmt->action == DEFELEM_SET && !list_length(schemaidlist)) +

RE: Added schema level support for publication.

2021-09-21 Thread houzj.f...@fujitsu.com
On Wednesday, September 22, 2021 2:02 AM vignesh C wrote: > Attached v30 patch has the fixes for the same. Thanks for updating the patches. I have one comment. @@ -474,7 +707,75 @@ AlterPublication(ParseState *pstate, AlterPublicationStmt *stmt) ... + if (list_length(relations)) +

Re: Unintended interaction between bottom-up deletion and deduplication's single value strategy

2021-09-21 Thread Peter Geoghegan
On Sun, Sep 19, 2021 at 7:47 PM Peter Geoghegan wrote: > Attached patch fixes the bug by slightly narrowing the conditions > under which we'll consider if we should apply deduplication's single > value strategy. Pushed this fix a moment ago. -- Peter Geoghegan

Re: Added schema level support for publication.

2021-09-21 Thread Greg Nancarrow
On Wed, Sep 22, 2021 at 4:02 AM vignesh C wrote: > > Attached v30 patch has the fixes for the same. > Thanks for all the patch updates. I have some suggested updates to the v30-0005 documentation patch: doc/src/sgml/ref/alter_publication.sgml (1) I'm thinking it might be better to simplify the d

Re: row filtering for logical replication

2021-09-21 Thread Ajin Cherian
On Tue, Sep 21, 2021 at 9:42 PM Dilip Kumar wrote: > > On Tue, Sep 21, 2021 at 4:29 PM Dilip Kumar wrote: > > Some more comments, > > > > In pgoutput_row_filter_update(), first, we are deforming the tuple in > > local datum, then modifying the tuple, and then reforming the tuple. > > I think we c

Re: Improve logging when using Huge Pages

2021-09-21 Thread Justin Pryzby
On Wed, Sep 22, 2021 at 02:03:11AM +0900, Fujii Masao wrote: > Another idea is to output "Anonymous shared memory was allocated with > huge pages" when it's successfully allocated with huge pages, and to output > "Anonymous shared memory was allocated without huge pages" > when it's successfully

Re: windows build slow due to windows.h includes

2021-09-21 Thread Andres Freund
Hi, On 2021-09-21 20:26:36 -0300, Ranier Vilela wrote: > Em ter., 21 de set. de 2021 às 16:30, Andres Freund > escreveu: > > But that's too much work for my taste. As it turns out there's a partial > > solution to windows.h being just so damn big, the delightfully named > > WIN32_LEAN_AND_MEAN. >

Re: [PATCH] Implement INSERT SET syntax

2021-09-21 Thread Rachel Heaton
> On 4/23/20 8:04 PM, Gareth Palmer wrote: > > > > Thank you for the review, attached is v7 of the patch which should > > apply correcly to HEAD. > > Hello Gareth, This patch no longer applies to HEAD, can you please submit a rebased version? Thanks, Rachel

Re: windows build slow due to windows.h includes

2021-09-21 Thread Ranier Vilela
Em ter., 21 de set. de 2021 às 16:30, Andres Freund escreveu: > Hi, > > For the AIO stuff I needed to build postgres for windows. And I was a bit > horrified by the long compile times. At first I was ready to blame the MS > compiler for being slow, until I noticed that using mingw gcc from linux

Re: Eval expression R/O once time (src/backend/executor/execExpr.c)

2021-09-21 Thread Ranier Vilela
Em ter., 21 de set. de 2021 às 20:00, Andres Freund escreveu: > Hi, > > On 2021-09-21 18:21:24 -0400, Tom Lane wrote: > > Andres Freund writes: > > > On 2021-09-21 15:09:11 -0300, Ranier Vilela wrote: > > >> Currently when determining where CoerceToDomainValue can be read, > > >> it evaluates ev

Re: Eval expression R/O once time (src/backend/executor/execExpr.c)

2021-09-21 Thread Ranier Vilela
Em ter., 21 de set. de 2021 às 19:21, Tom Lane escreveu: > Andres Freund writes: > > On 2021-09-21 15:09:11 -0300, Ranier Vilela wrote: > >> Currently when determining where CoerceToDomainValue can be read, > >> it evaluates every step in a loop. > >> But, I think that the expression is immutabl

Re: Eval expression R/O once time (src/backend/executor/execExpr.c)

2021-09-21 Thread Andres Freund
Hi, On 2021-09-21 18:21:24 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2021-09-21 15:09:11 -0300, Ranier Vilela wrote: > >> Currently when determining where CoerceToDomainValue can be read, > >> it evaluates every step in a loop. > >> But, I think that the expression is immutable and sh

Re: windows build slow due to windows.h includes

2021-09-21 Thread Andres Freund
Hi, On 2021-09-21 16:13:55 -0400, Andrew Dunstan wrote: > I also see references to VC_EXTRALEAN which defines this and some other > stuff that might make things even faster. I don't think that's relevant to "us", just mfc apps (which we gladly aren't). From what I can see we'd have to actually cl

Re: PostgreSQL High Precision Support Extension.

2021-09-21 Thread Jan Wieck
On 9/21/21 6:20 PM, Thomas Munro wrote: On Tue, Sep 21, 2021 at 2:58 PM Thomas Munro wrote: On Tue, Sep 21, 2021 at 1:30 PM A Z wrote: > -A library like GMP, written in C, is an appropriate basis to start from and to include, for all OS platforms involved. Are you aware of Daniele Varrazzo's

Re: PostgreSQL High Precision Support Extension.

2021-09-21 Thread Thomas Munro
On Tue, Sep 21, 2021 at 2:58 PM Thomas Munro wrote: > On Tue, Sep 21, 2021 at 1:30 PM A Z wrote: > > -A library like GMP, written in C, is an appropriate basis to start from > > and to include, for all OS platforms involved. > > Are you aware of Daniele Varrazzo's extension > https://github.com/

Re: Eval expression R/O once time (src/backend/executor/execExpr.c)

2021-09-21 Thread Tom Lane
Andres Freund writes: > On 2021-09-21 15:09:11 -0300, Ranier Vilela wrote: >> Currently when determining where CoerceToDomainValue can be read, >> it evaluates every step in a loop. >> But, I think that the expression is immutable and should be solved only >> once. > What is immutable here? I th

Re: prevent immature WAL streaming

2021-09-21 Thread Alvaro Herrera
I made one final pass over the whole thing to be sure it's all commented as thoroughly as possible, and changed the names of things to make them all consistent. So here's the last version which I intend to push to all branches soon. (The only difference in back-branches is that the xlogreader str

Re: Eval expression R/O once time (src/backend/executor/execExpr.c)

2021-09-21 Thread Andres Freund
Hi, On 2021-09-21 15:09:11 -0300, Ranier Vilela wrote: > Currently when determining where CoerceToDomainValue can be read, > it evaluates every step in a loop. > But, I think that the expression is immutable and should be solved only > once. What is immutable here? > Otherwise the logic is wron

Re: windows build slow due to windows.h includes

2021-09-21 Thread Andrew Dunstan
On 9/21/21 3:30 PM, Andres Freund wrote: > Hi, > > For the AIO stuff I needed to build postgres for windows. And I was a bit > horrified by the long compile times. At first I was ready to blame the MS > compiler for being slow, until I noticed that using mingw gcc from linux to > cross compile to

Re: Delegating superuser tasks to new security roles (Was: Granting control of SUSET gucs to non-superusers)

2021-09-21 Thread Andrew Dunstan
On 9/15/21 10:38 AM, Mark Dilger wrote: >> On Aug 31, 2021, at 6:41 PM, Mark Dilger >> wrote: >> >> > Synopsis: > > The major change in version 7 is a reworking of role ownership and the > CREATEROLE attribute to make it no longer a near-superuser privilege. This > new functionality is in v

windows build slow due to windows.h includes

2021-09-21 Thread Andres Freund
Hi, For the AIO stuff I needed to build postgres for windows. And I was a bit horrified by the long compile times. At first I was ready to blame the MS compiler for being slow, until I noticed that using mingw gcc from linux to cross compile to windows is also a *lot* slower than building for linu

Eval expression R/O once time (src/backend/executor/execExpr.c)

2021-09-21 Thread Ranier Vilela
Hi, Currently when determining where CoerceToDomainValue can be read, it evaluates every step in a loop. But, I think that the expression is immutable and should be solved only once. Otherwise the logic is wrong since by the rules of C, even though the variable is being initialized in the declara

Re: Added schema level support for publication.

2021-09-21 Thread vignesh C
On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow wrote: > > On Fri, Sep 17, 2021 at 10:09 PM vignesh C wrote: > > > > Attached v29 patch has the fixes for the same. > > > > Some minor comments on the v29-0002 patch: > > (1) > In get_object_address_publication_schema(), the error message: > > + errm

Re: Added schema level support for publication.

2021-09-21 Thread vignesh C
On Mon, Sep 20, 2021 at 4:20 PM vignesh C wrote: > > On Mon, Sep 20, 2021 at 3:57 PM Amit Kapila wrote: > > > > On Fri, Sep 17, 2021 at 5:40 PM vignesh C wrote: > > > > > > On Thu, Sep 16, 2021 at 9:54 AM Amit Kapila > > > wrote: > > > > > > > > I think there is one more similar locking proble

Re: Re: [PATCH] regexp_positions ( string text, pattern text, flags text ) → setof int4range[]

2021-09-21 Thread Tom Lane
"Joel Jacobson" writes: > [ 0005-regexp-positions.patch ] I took a quick look at this patch. I am on board now with the general idea of returning match positions, but I think there are still definitional issues to be discussed. 1. The main idea we might perhaps want to adopt from the Oracle-ish

Re: .ready and .done files considered harmful

2021-09-21 Thread Robert Haas
On Mon, Sep 20, 2021 at 4:42 PM Alvaro Herrera wrote: > I was going to say that perhaps we can avoid repeated scans by having a > bitmap of future files that were found by a scan; so if we need to do > one scan, we keep track of the presence of the next (say) 64 files in > our timeline, and then w

Re: refactoring basebackup.c

2021-09-21 Thread Robert Haas
On Tue, Sep 21, 2021 at 9:35 AM Jeevan Ladhe wrote: > Here is a patch for lz4 based on the v5 set of patches. The patch adapts with > the > bbsink changes, and is now able to make the provision for the required length > for the output buffer using the new callback function > bbsink_lz4_begin_bac

Re: Improve logging when using Huge Pages

2021-09-21 Thread Fujii Masao
On 2021/09/20 17:55, Shinoda, Noriyoshi (PN Japan FSIP) wrote: I was worried about the same thing as you. So the attached patch gets the value of the kernel parameter vm.nr_hugepages, and if it is the default value of zero, the log level is the same as before. On the other hand, if any value i

Re: refactoring basebackup.c

2021-09-21 Thread Robert Haas
On Tue, Sep 21, 2021 at 9:08 AM Jeevan Ladhe wrote: > Yes, you are right here, and I could verify this fact with an experiment. > When autoflush is 1, the file gets less compressed i.e. the compressed file > is of more size than the one generated when autoflush is set to 0. > But, as of now, I cou

Re: extensible options syntax for replication parser?

2021-09-21 Thread Robert Haas
On Fri, Sep 10, 2021 at 3:44 PM Robert Haas wrote: > Last call for complaints about either the overall direction or the > specific implementation choices... A complaint showed up over at http://postgr.es/m/979131631633...@mail.yandex.ru and pursuant to that complaint I have made the new syntax fo

Re: proposal: possibility to read dumped table's name from file

2021-09-21 Thread Pavel Stehule
Hi > The above comments are fixed in the attached, as well as a pass over the > docs > and extended tests to actually test matching a foreign server. What do > think > about this version? I'm still not convinced that there aren't more quoting > bugs in the parser, but I've left that intact for

回复:Queries that should be canceled will get stuck on secure_write function

2021-09-21 Thread 蔡梦娟(玊于)
Hi all, I want to know your opinion on this patch, or in what way do you think we should solve this problem? -- 发件人:蔡梦娟(玊于) 发送时间:2021年9月9日(星期四) 17:38 收件人:Robert Haas ; Andres Freund ; alvherre ; masao.fujii 抄 送:pgsql-hackers 主 题:回

Re: Deduplicate code updating ControleFile's DBState.

2021-09-21 Thread Bossart, Nathan
On 9/20/21, 10:07 PM, "Amul Sul" wrote: > On Tue, Sep 21, 2021 at 4:44 AM Bossart, Nathan wrote: >> On 9/19/21, 11:07 PM, "Amul Sul" wrote: >> > I have one additional concern about the way we update the control >> > file, at every place where doing the update, we need to set control >> > file up

Re: proposal: possibility to read dumped table's name from file

2021-09-21 Thread Tomas Vondra
On 9/21/21 3:28 PM, Alvaro Herrera wrote: > I definitely agree that we should have two files, one for config and > another one for filter, since their purposes are orthogonal and their > formats are likely different; trying to cram the filter specification in > the config file seems unfriendly beca

Re: Estimating HugePages Requirements?

2021-09-21 Thread Bossart, Nathan
On 9/20/21, 7:29 PM, "Michael Paquier" wrote: > On Tue, Sep 21, 2021 at 12:08:22AM +, Bossart, Nathan wrote: >> Should we also initialize the shared memory GUCs in bootstrap and >> single-user mode? I think I missed this in bd17880. > > Why would we need that for the bootstrap mode? > > While

Re: Estimating HugePages Requirements?

2021-09-21 Thread Bossart, Nathan
On 9/20/21, 6:48 PM, "Michael Paquier" wrote: > Thanks. I have gone through the last patch this morning, did some > tests on all the platforms I have at hand (including Linux) and > finished by applying it after doing some small tweaks. First, I have > finished by extending GetHugePageSize() to

Re: Logical replication timeout problem

2021-09-21 Thread Fabrice Chapuis
> IIUC, these are called after processing each WAL record so not sure how is it possible in your case that these are not reached? I don't know, as you say, to highlight the problem we would have to debug the WalSndKeepaliveIfNecessary function > I was curious to know if the walsender has exited b

Re: refactoring basebackup.c

2021-09-21 Thread Robert Haas
On Tue, Sep 14, 2021 at 11:30 AM Sergei Kornilov wrote: > I found that in 0001 you propose to rename few options. Probably we could > rename another option for clarify? I think FAST (it's about some bw limits?) > and WAIT (wait for what? checkpoint?) option names are confusing. > Could we replac

Re: Refactoring postgres_fdw code to rollback remote transaction

2021-09-21 Thread Fujii Masao
On 2021/09/17 15:33, Bharath Rupireddy wrote: On Fri, Sep 17, 2021 at 8:28 AM Fujii Masao wrote: On 2021/09/17 11:40, Zhihong Yu wrote: + goto fail; /* Trouble clearing prepared statements */ The label fail can be removed. Under the above condition, entry->changing_xa

Re: refactoring basebackup.c

2021-09-21 Thread Jeevan Ladhe
Hi Robert, Here is a patch for lz4 based on the v5 set of patches. The patch adapts with the bbsink changes, and is now able to make the provision for the required length for the output buffer using the new callback function bbsink_lz4_begin_backup(). Sample command to take backup: pg_basebackup

Re: PostgreSQL High Precision Support Extension.

2021-09-21 Thread Andrew Dunstan
On 9/20/21 9:29 PM, A Z wrote: > I have been trying to get a reply or interest in either updating > PostgreSQL to support the following, > or for there to be a public, free for any use Extension put out there, > that will support the following. > Can someone able and interested please respond to

Re: proposal: possibility to read dumped table's name from file

2021-09-21 Thread Alvaro Herrera
I definitely agree that we should have two files, one for config and another one for filter, since their purposes are orthogonal and their formats are likely different; trying to cram the filter specification in the config file seems unfriendly because it'd force users to write the filter in whatev

Re: refactoring basebackup.c

2021-09-21 Thread Jeevan Ladhe
> > >> + /* > >> + * LZ4F_compressUpdate() returns the number of bytes written into > output > >> + * buffer. We need to keep track of how many bytes have been > cumulatively > >> + * written into the output buffer(bytes_written). But, > >> + * LZ4F_compressUpdate() returns 0 in case the data is bu

Re: proposal: possibility to read dumped table's name from file

2021-09-21 Thread Pavel Stehule
út 21. 9. 2021 v 14:37 odesílatel Daniel Gustafsson napsal: > > On 21 Sep 2021, at 08:50, Pavel Stehule wrote: > > po 20. 9. 2021 v 14:10 odesílatel Daniel Gustafsson > napsal: > > > + printf(_(" --filter=FILENAMEdump objects and data > based on the fi

Re: EXPLAIN(VERBOSE) to CTE with SEARCH BREADTH FIRST fails

2021-09-21 Thread torikoshia
On 2021-09-16 08:40, Tom Lane wrote: I wrote: I do not think that patch is a proper solution, but we do need to do something about this. I poked into this and decided it's an ancient omission within ruleutils.c. The reason we've not seen it before is probably that you can't get to the case t

Re: proposal: possibility to read dumped table's name from file

2021-09-21 Thread Daniel Gustafsson
> On 21 Sep 2021, at 08:50, Pavel Stehule wrote: > po 20. 9. 2021 v 14:10 odesílatel Daniel Gustafsson > napsal: > + printf(_(" --filter=FILENAMEdump objects and data based > on the filter expressions\n" > +"

Re: Added schema level support for publication.

2021-09-21 Thread Greg Nancarrow
On Tue, Sep 21, 2021 at 4:12 PM vignesh C wrote: > > > (1) > > In get_object_address_publication_schema(), the error message: > > > > + errmsg("publication tables of schema \"%s\" in publication \"%s\" > > does not exist", > > > > isn't grammatically correct. It should probably be: > > > > + errms

Re: refactoring basebackup.c

2021-09-21 Thread Jeevan Ladhe
Thanks for the newer set of the patches Robert! I was wondering if we should change the bbs_buffer_length in bbsink to be size_t instead of int, because that's what most of the compression libraries have their length variables defined as. Regards, Jeevan Ladhe On Mon, Sep 13, 2021 at 9:42 PM Rob

Re: row filtering for logical replication

2021-09-21 Thread Dilip Kumar
On Tue, Sep 21, 2021 at 4:29 PM Dilip Kumar wrote: > Some more comments, > > In pgoutput_row_filter_update(), first, we are deforming the tuple in > local datum, then modifying the tuple, and then reforming the tuple. > I think we can surely do better here. Currently, you are reforming > the tupl

Re: [PATCH] Allow multiple recursive self-references

2021-09-21 Thread Denis Hirn
> I studied up on the theory and terminology being discussed here. I conclude > that what the latest version of this patch is doing (allowing multiple > recursive references, but only in a linear-recursion way) is sound and useful. That's great to hear! > I haven't looked closely at the implem

Re: mem context is not reset between extended stats

2021-09-21 Thread Tomas Vondra
On 9/21/21 3:37 AM, Justin Pryzby wrote: > On Tue, Sep 21, 2021 at 02:15:45AM +0200, Tomas Vondra wrote: >> On 9/15/21 10:09 PM, Justin Pryzby wrote: >>> Memory allocation appeared be O(1) WRT the number of statistics objects, >>> which >>> was not expected to me. This is true in v13 (and probabl

Re: row filtering for logical replication

2021-09-21 Thread Dilip Kumar
On Tue, Sep 21, 2021 at 2:34 PM Amit Kapila wrote: > > On Tue, Sep 21, 2021 at 11:16 AM Dilip Kumar wrote: > > > > On Tue, Sep 21, 2021 at 10:41 AM Amit Kapila > > wrote: > > > > > I think the point is if for some expression some > > > values are in old tuple and others are in new then the idea

Re: logical replication restrictions

2021-09-21 Thread Marcos Pegoraro
No, I´m talking about that configuration you can have on standby servers recovery_min_apply_delay = '8h' Atenciosamente, Em seg., 20 de set. de 2021 às 23:44, Amit Kapila escreveu: > On Mon, Sep 20, 2021 at 9:47 PM Marcos Pegoraro wrote: > > > > One thing is needed and is not solved yet is

Re: psql: tab completion differs on semicolon placement

2021-09-21 Thread Dagfinn Ilmari Mannsåker
David Fetter writes: > On Mon, Sep 20, 2021 at 08:26:51PM +0100, Dagfinn Ilmari Mannsåker wrote: > >> The same applies to any completion after a MatchAny that ends in a any >> of the WORD_BREAKS characters (except whitespace and () which are >> handled specially). >> >> #define WORD_BREAKS

Re: POC: Cleaning up orphaned files using undo logs

2021-09-21 Thread Amit Kapila
On Mon, Sep 20, 2021 at 10:24 AM Antonin Houska wrote: > > Amit Kapila wrote: > > > On Fri, Sep 17, 2021 at 9:50 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > > > > > On Tue, Sep 14, 2021 at 10:51:42AM +0200, Antonin Houska wrote: > > > > > > * What happened with the idea of abandoning di

Re: Logical replication timeout problem

2021-09-21 Thread Amit Kapila
On Tue, Sep 21, 2021 at 1:52 PM Fabrice Chapuis wrote: > > If I understand, the instruction to send keep alive by the wal sender has not > been reached in the for loop, for what reason? > ... > * Check for replication timeout. */ > WalSndCheckTimeOut(); > > /* Send keepalive if the time has com

Re: row filtering for logical replication

2021-09-21 Thread Amit Kapila
On Tue, Sep 21, 2021 at 11:16 AM Dilip Kumar wrote: > > On Tue, Sep 21, 2021 at 10:41 AM Amit Kapila wrote: > > > I think the point is if for some expression some > > values are in old tuple and others are in new then the idea proposed > > in the patch seems sane. Moreover, I think in your idea f

Re: Logical replication timeout problem

2021-09-21 Thread Fabrice Chapuis
If I understand, the instruction to send keep alive by the wal sender has not been reached in the for loop, for what reason? ... * Check for replication timeout. */ WalSndCheckTimeOut(); /* Send keepalive if the time has come */ WalSndKeepaliveIfNecessary(); ... The data load is performed on

Re: POC: Cleaning up orphaned files using undo logs

2021-09-21 Thread Dmitry Dolgov
On Tue, 21 Sep 2021 09:00 Antonin Houska, wrote: > Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > Yep, makes sense, thanks. I have few more questions: > > > > * The use case with orphaned files is working somewhat differently after > > the rebase on the latest master, do you observe it as w

Re: POC: Cleaning up orphaned files using undo logs

2021-09-21 Thread Antonin Houska
Dmitry Dolgov <9erthali...@gmail.com> wrote: > > On Tue, Sep 14, 2021 at 10:51:42AM +0200, Antonin Houska wrote: > > Antonin Houska wrote: > > > > > Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > > > > * By throwing at the patchset `make installcheck` I'm getting from time > > > > to time >