Re: Proposal: adding a better description in psql command about large objects

2022-06-05 Thread Guillaume Lelarge
Le ven. 3 juin 2022 à 19:29, Nathan Bossart a écrit : > On Fri, Jun 03, 2022 at 12:56:20PM -0400, Tom Lane wrote: > > Nathan Bossart writes: > >> Another option could be to move it after the "Input/Output" section so > that > >> it's closer to some other commands that involve files. I can't say

Re: [v15 beta] pg_upgrade failed if earlier executed with -c switch

2022-06-05 Thread Michael Paquier
On Sun, Jun 05, 2022 at 09:24:25AM +0900, Michael Paquier wrote: > Well, another error that could happen in the early code paths is > EACCES on a custom socket directory specified, and we'd still face the > same problem on a follow-up restart. Using a sub-directory structure > as Daniel and Tom me

Re: pgcon unconference / impact of block size on performance

2022-06-05 Thread Tomas Vondra
On 6/5/22 02:21, Roberto Mello wrote: > On Sat, Jun 4, 2022 at 5:23 PM Tomas Vondra > mailto:tomas.von...@enterprisedb.com>> > wrote: > > Hi, > > At on of the pgcon unconference sessions a couple days ago, I presented > a bunch of benchmark results comparing performance with differ

Re: [PATCH] Fix pg_upgrade test from v10

2022-06-05 Thread Anton A. Melnikov
Hello! On 02.06.2022 23:57, Andrew Dunstan wrote: 1. There is no mention of why there's a change w.r.t. Cygwin and permissions checks. Maybe it's ok, but it seems off topic and is certainly not referred to in the patch submission. Thanks for the comments! It was my error to change w.r.t. Cyg

Reducing Memory Consumption (aset and generation)

2022-06-05 Thread Ranier Vilela
HI hackers, I thought it would be better to start a new thread to discuss. While working with sorting patch, and read others threads, I have some ideas to reduces memory consumption by aset and generation memory modules. I have done basic benchmarks, and it seems to improve performance. I think i

Re: [PATCH] Compression dictionaries for JSONB

2022-06-05 Thread Matthias van de Meent
On Fri, 13 May 2022 at 10:09, Aleksander Alekseev wrote: > > Hi hackers, > > > Here it the 2nd version of the patch: > > > > - Includes changes named above > > - Fixes a warning reported by cfbot > > - Fixes some FIXME's > > - The path includes some simple tests now > > - A proper commit message w

Re: [v15 beta] pg_upgrade failed if earlier executed with -c switch

2022-06-05 Thread Daniel Gustafsson
> On 5 Jun 2022, at 11:19, Michael Paquier wrote: > > On Sun, Jun 05, 2022 at 09:24:25AM +0900, Michael Paquier wrote: >> Well, another error that could happen in the early code paths is >> EACCES on a custom socket directory specified, and we'd still face the >> same problem on a follow-up resta

Re: [v15 beta] pg_upgrade failed if earlier executed with -c switch

2022-06-05 Thread Michael Paquier
On Mon, Jun 06, 2022 at 02:38:03AM +0200, Daniel Gustafsson wrote: > On 5 Jun 2022, at 11:19, Michael Paquier wrote: >> On Sun, Jun 05, 2022 at 09:24:25AM +0900, Michael Paquier wrote: >>> Well, another error that could happen in the early code paths is >>> EACCES on a custom socket directory spec

Allow placeholders in ALTER ROLE w/o superuser

2022-06-05 Thread Steve Chavez
Hello hackers, Using placeholders for application variables allows the use of RLS for application users as shown in this blog post https://www.2ndquadrant.com/en/blog/application-users-vs-row-level-security/ . SET my.username = 'tomas' CREATE POLICY chat_policy ON chat USING (current_s

Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set

2022-06-05 Thread Michael Paquier
On Sat, Jun 04, 2022 at 12:35:45PM +0900, Michael Paquier wrote: > Something like 80~85% of the bloat comes from the diffs in your case. > Well, it is always possible to limit that to an arbitrary amount of > characters (say 50k~100k?) to still give some context, and dump the > whole in a different

Re: Handle infinite recursion in logical replication setup

2022-06-05 Thread vignesh C
On Fri, Jun 3, 2022 at 11:01 AM Peter Smith wrote: > > Please find below my review comments for patch v17-0002: > > == > > 1. Commit message > > This patch adds a new SUBSCRIPTION parameter "origin". It Specifies whether > the subscription will request the publisher to only send changes that >

Re: pg_rewind: warn when checkpoint hasn't happened after promotion

2022-06-05 Thread Kyotaro Horiguchi
At Sat, 4 Jun 2022 19:09:41 +0530, Bharath Rupireddy wrote in > On Sat, Jun 4, 2022 at 6:29 PM James Coleman wrote: > > > > A few weeks back I sent a bug report [1] directly to the -bugs mailing > > list, and I haven't seen any activity on it (maybe this is because I > > emailed directly instea

Re: bogus: logical replication rows/cols combinations

2022-06-05 Thread Peter Smith
On Thu, Jun 2, 2022 at 9:58 PM Amit Kapila wrote: > > On Fri, May 27, 2022 at 1:04 PM houzj.f...@fujitsu.com > wrote: > > > > On Friday, May 27, 2022 1:54 PM Justin Pryzby wrote: > > > > > > On Fri, May 27, 2022 at 11:17:00AM +0530, Amit Kapila wrote: > > > > On Tue, May 24, 2022 at 11:03 AM hou

Re: Report checkpoint progress with pg_stat_progress_checkpoint (was: Report checkpoint progress in server logs)

2022-06-05 Thread Nitin Jadhav
Hi, Here is the update patch which fixes the previous comments discussed in this thread. I am sorry for the long gap in the discussion. Kindly let me know if I have missed any of the comments or anything new. Thanks & Regards, Nitin Jadhav On Fri, Mar 18, 2022 at 4:52 PM Nitin Jadhav wrote: > >