Re: Hardening PostgreSQL via (optional) ban on local file system access

2022-06-29 Thread Andres Freund
Hi, On 2022-06-29 08:51:10 +0200, Laurenz Albe wrote: > On Tue, 2022-06-28 at 16:27 -0700, Andres Freund wrote: > > > Experience shows that 99% of the time one can run PostgreSQL just fine > > > without a superuser > > > > IME that's not at all true. It might not be needed interactively, but that

Re: Hardening PostgreSQL via (optional) ban on local file system access

2022-06-29 Thread Hannu Krosing
The idea is to allow superuser, but only in case you *already* have access to the file system. You could think of it as a two factor authentication for using superuser. So in the simplest implementation it would be touch $PGDATA/allow_superuser psql hannuk=# CREATE EXTENSION ... rm $PGDATA/all

Re: CREATE INDEX CONCURRENTLY on partitioned index

2022-06-29 Thread Alexander Pyhalov
Justin Pryzby писал 2022-06-28 21:33: Hi, On Thu, Feb 10, 2022 at 06:07:08PM +0300, Alexander Pyhalov wrote: I've rebased patches and tried to fix issues I've seen. I've fixed reference after table_close() in the first patch (can be seen while building with CPPFLAGS='-DRELCACHE_FORCE_RELEASE'

Re: Prevent writes on large objects in read-only transactions

2022-06-29 Thread Yugo NAGATA
Hello Michael-san, Thank you for reviewing the patch. I attached the updated patch. On Thu, 16 Jun 2022 17:31:22 +0900 Michael Paquier wrote: > Looking at the docs of large objects, as of "Client Interfaces", we > mention that any action must take place in a transaction block. > Shouldn't we ad

Re: OpenSSL 3.0.0 compatibility

2022-06-29 Thread Jelte Fennema
On Wed, 29 Jun 2022 at 10:55, Daniel Gustafsson wrote: > These have now been pushed to 14 through to 10 ahead of next week releases I upgraded my OS to Ubuntu 22.04 and it seems that "Define OPENSSL_API_COMPAT" commit was never backported (4d3db13621be64fbac2faf7c01c4879d20885c1b). I now get vari

Re: Lazy JIT IR code generation to increase JIT speed with partitions

2022-06-29 Thread David Geier
Hi Alvaro, That's a very interesting case and might indeed be fixed or at least improved by this patch. I tried to reproduce this, but at least when running a simple, serial query with increasing numbers of functions, the time spent per function is linear or even slightly sub-linear (same as Tom o

Re: Fix proposal for comparaison bugs in PostgreSQL::Version

2022-06-29 Thread Jehan-Guillaume de Rorthais
On Tue, 28 Jun 2022 18:17:40 -0400 Andrew Dunstan wrote: > On 2022-06-28 Tu 16:53, Jehan-Guillaume de Rorthais wrote: > > ... > > A better fix would be to store the version internally as version_num that > > are trivial to compute and compare. Please, find in attachment an > > implementation of t

Re: OpenSSL 3.0.0 compatibility

2022-06-29 Thread Daniel Gustafsson
> On 29 Jun 2022, at 11:02, Jelte Fennema wrote: > > On Wed, 29 Jun 2022 at 10:55, Daniel Gustafsson wrote: >> These have now been pushed to 14 through to 10 ahead of next week releases > > I upgraded my OS to Ubuntu 22.04 and it seems that "Define > OPENSSL_API_COMPAT" commit was never backpor

Re: OpenSSL 3.0.0 compatibility

2022-06-29 Thread Jelte Fennema
> See upthread in ef5c7896-20cb-843f-e91e-0ee5f7fd9...@enterprisedb.com I saw that section, but I thought that only applied before you backpatched the actual fixes to PG13 and below. I mean there's no reason anymore not to compile those older versions with OpenSSL 3.0, right? If so, it seems confu

RE: Support logical replication of DDLs

2022-06-29 Thread houzj.f...@fujitsu.com
On Tuesday, June 28, 2022 11:27 AM Amit Kapila > On Sun, Jun 26, 2022 at 11:47 PM Alvaro Herrera > wrote: > > > > On 2022-Jun-22, vignesh C wrote: > > > > > 1) Creation of temporary table fails infinitely in the subscriber. > > > CREATE TEMPORARY TABLE temp1 (a int primary key); > > > > > > The a

Re: margay fails assertion in stats/dsa/dsm code

2022-06-29 Thread Thomas Munro
On Wed, Jun 29, 2022 at 4:00 PM Thomas Munro wrote: > I suppose this could indicate that the machine and/or RAM disk is > overloaded/swapping and one of those open() or unlink() calls is > taking a really long time, and that could be fixed with some system > tuning. Hmm, I take that bit back. Ev

Re: Support logical replication of DDLs

2022-06-29 Thread Amit Kapila
On Wed, Jun 29, 2022 at 3:24 PM houzj.f...@fujitsu.com wrote: > > On Wednesday, June 29, 2022 11:07 AM Amit Kapila > wrote: > > > > On Tue, Jun 28, 2022 at 5:43 PM Amit Kapila > > wrote: > > > > > > 5. > > > +static ObjTree * > > > +deparse_CreateStmt(Oid objectId, Node *parsetree) > > > { > >

Re: Hardening PostgreSQL via (optional) ban on local file system access

2022-06-29 Thread Laurenz Albe
On Wed, 2022-06-29 at 00:05 -0700, Andres Freund wrote: > On 2022-06-29 08:51:10 +0200, Laurenz Albe wrote: > > On Tue, 2022-06-28 at 16:27 -0700, Andres Freund wrote: > > > > Experience shows that 99% of the time one can run PostgreSQL just fine > > > > without a superuser > > > > > > IME that's

Re: OpenSSL 3.0.0 compatibility

2022-06-29 Thread Daniel Gustafsson
> On 29 Jun 2022, at 11:44, Jelte Fennema wrote: > >> See upthread in ef5c7896-20cb-843f-e91e-0ee5f7fd9...@enterprisedb.com > > I saw that section, but I thought that only applied before you > backpatched the actual fixes to PG13 and below. I mean there's no > reason anymore not to compile those

Re: better error description on logical replication

2022-06-29 Thread Marcos Pegoraro
I´m using 14.4. These are some lines with that error, and context is empty. And yes, if context had this info you wrote would be fine 2022-06-28 08:18:23.600 -03,,,20915,,62b9c77b.51b3,1328,,2022-06-27 12:06:35 -03,4/690182,433844252,ERROR,23505,"duplicate key value violates unique constraint ""pk

Re: better error description on logical replication

2022-06-29 Thread Amit Kapila
On Wed, Jun 29, 2022 at 4:30 PM Marcos Pegoraro wrote: > > I´m using 14.4. > This additional information will be available in 15 as it is committed as part of commit abc0910e. -- With Regards, Amit Kapila.

Re: Implementing Incremental View Maintenance

2022-06-29 Thread huyajun
> 2022年4月22日 下午1:58,Yugo NAGATA 写道: > > On Fri, 22 Apr 2022 11:29:39 +0900 > Yugo NAGATA wrote: > >> Hi, >> >> On Fri, 1 Apr 2022 11:09:16 -0400 >> Greg Stark wrote: >> >>> This patch has bitrotted due to some other patch affecting trigger.c. >>> >>> Could you post a rebase? >>> >>> This

Re: Hardening PostgreSQL via (optional) ban on local file system access

2022-06-29 Thread Hannu Krosing
Ah, I see. My counterclaim was that there are lots of use cases where one would want to be extra sure that *only* they, as the owner of the database, can access the database as a superuser and not someone else. Even if there is some obscure way for that "someone else" to either connect as a superu

Re: doc: BRIN indexes and autosummarize

2022-06-29 Thread Justin Pryzby
On Tue, Jun 28, 2022 at 05:22:34PM -0600, Roberto Mello wrote: > Here's a patch to clarify the BRIN indexes documentation, particularly with > regards to autosummarize, vacuum and autovacuum. It basically breaks down a > big blob of a paragraph into multiple paragraphs for clarity, plus explicitly

Re: Using PQexecQuery in pipeline mode produces unexpected Close messages

2022-06-29 Thread Alvaro Herrera
So I wrote some more test scenarios for this, and as I wrote in some other thread, I realized that there are more problems than just some NOTICE trouble. For instance, if you send a query, then read the result but not the terminating NULL then send another query, everything gets confused; the next

Re: Can we do something to help stop users mistakenly using force_parallel_mode?

2022-06-29 Thread Justin Pryzby
On Wed, Jun 29, 2022 at 03:23:27PM +1200, David Rowley wrote: > Over on [1] I noticed that the user had set force_parallel_mode to > "on" in the hope that would trick the planner into making their query > run more quickly. Of course, that's not what they want since that GUC > is only there to inje

Re: making relfilenodes 56 bits

2022-06-29 Thread Simon Riggs
On Tue, 28 Jun 2022 at 19:18, Matthias van de Meent wrote: > I will be the first to admit that it is quite unlikely to be common > practise, but this workload increases the number of dbOid+spcOid > combinations to 100s (even while using only a single tablespace), Which should still fit nicely in

Re: 13dev failed assert: comparetup_index_btree(): ItemPointer values should never be equal

2022-06-29 Thread Robins Tharakan
> Justin Pryzby writes: > > I have nothing new to add, but wanted to point out this is still an issue. > > This is on the v13 Opened Items list - for lack of anywhere else to put > > them, I > > also added two other, unresolved issues. Two minor things to add: 1. This issue is still reproducible

Re: PostgreSQL 15 beta 2 release announcement draft

2022-06-29 Thread Jonathan S. Katz
On 6/29/22 2:55 AM, Pantelis Theodosiou wrote: Upgrading to PostgreSQL 15 Beta 2 - To upgrade to PostgreSQL 15 Beta 2 from an earlier version of PostgreSQL, you will need to use a strategy similar to upgrading between major versions of PostgreSQL (e.g. `pg_upgrade

Re: PostgreSQL 15 beta 2 release announcement draft

2022-06-29 Thread Jonathan S. Katz
On 6/29/22 2:12 AM, Erik Rijkers wrote: Op 29-06-2022 om 02:04 schreef Jonathan S. Katz: Hi, 'not advise you to run PostgreSQL 15 Beta 1'    should be 'not advise you to run PostgreSQL 15 Beta 2' Thanks; I adjusted the copy. Jonathan OpenPGP_signature Description: OpenPGP digital signatu

Re: JSON/SQL: jsonpath: incomprehensible error message

2022-06-29 Thread Amit Kapila
On Mon, Jun 27, 2022 at 8:46 PM Andrew Dunstan wrote: > > On 2022-06-26 Su 11:44, Erik Rijkers wrote: > > JSON/SQL jsonpath > > > > For example, a jsonpath string with deliberate typo 'like_regexp' > > (instead of 'like_regex'): > > > > select js > > from (values (jsonb '{}')) as f(js) > > where j

Re: Emit extra debug message when executing extension script.

2022-06-29 Thread Peter Eisentraut
On 28.06.22 21:10, Jeff Davis wrote: + ereport(DEBUG1, errmsg("executing extension script: %s", filename)); This should either be elog or use errmsg_internal.

Re: JSON/SQL: jsonpath: incomprehensible error message

2022-06-29 Thread Erik Rijkers
Op 29-06-2022 om 15:00 schreef Amit Kapila: On Mon, Jun 27, 2022 at 8:46 PM Andrew Dunstan wrote: On 2022-06-26 Su 11:44, Erik Rijkers wrote: JSON/SQL jsonpath For example, a jsonpath string with deliberate typo 'like_regexp' (instead of 'like_regex'): select js from (values (jsonb '{}')) a

Re: PostgreSQL 15 beta 2 release announcement draft

2022-06-29 Thread Tom Lane
"Jonathan S. Katz" writes: > On 6/29/22 2:55 AM, Pantelis Theodosiou wrote: >> Is the major version upgrade still needed if they are upgrading from 15 Beta >> 1? > No, but it would be required if you a upgrading from a different > version. The language attempts to be a "catch all" to account fo

Re: [PoC] Let libpq reject unexpected authentication requests

2022-06-29 Thread Peter Eisentraut
On 27.06.22 23:40, Jacob Champion wrote: -HINT: Valid options in this context are: service, passfile, channel_binding, connect_timeout, dbname, host, hostaddr, port, options, application_name, keepalives, keepalives_idle, keepalives_interval, keepalives_count, tcp_user_timeout, sslmode, sslco

Re: Proposal: allow database-specific role memberships

2022-06-29 Thread Antonin Houska
Kenaniah Cerny wrote: > Attached is a newly-rebased patch -- would love to get a review from someone > whenever possible. I've picked this patch for a review. The patch currently does not apply to the master branch, so I could only read the diff. Following are my comments: * I think that roles

Re: [BUG] Panic due to incorrect missingContrecPtr after promotion

2022-06-29 Thread Imseih (AWS), Sami
> Would you mind trying the second attached to abtain detailed log on > your testing environment? With the patch, the modified TAP test yields > the log lines like below. Thanks for this. I will apply this to the testing environment and will share the output. Regards, Sami Imseih Amazon Web Serv

Re: Allowing REINDEX to have an optional name

2022-06-29 Thread Simon Riggs
On Wed, 29 Jun 2022 at 05:35, Michael Paquier wrote: > > On Tue, Jun 28, 2022 at 11:02:25AM +0100, Simon Riggs wrote: > > Attached patch is tested, documented and imho ready to be committed, > > so I will mark it so in CFapp. Thanks for the review Michael. > The behavior introduced by this patch

Re: Export log_line_prefix(); useful for emit_log_hook.

2022-06-29 Thread Alvaro Herrera
On 2022-Jun-28, Jeff Davis wrote: > Patch attached. Some kinds of emit log hooks might find it useful to > also compute the log_line_prefix. Hmm, maybe your hypothetical book would prefer to use a different setting for log line prefix than Log_line_prefix, so it would make sense to pass the forma

Re: JSON/SQL: jsonpath: incomprehensible error message

2022-06-29 Thread Alexander Korotkov
On Wed, Jun 29, 2022 at 4:28 PM Erik Rijkers wrote: > Op 29-06-2022 om 15:00 schreef Amit Kapila: > > On Mon, Jun 27, 2022 at 8:46 PM Andrew Dunstan wrote: > >> > >> On 2022-06-26 Su 11:44, Erik Rijkers wrote: > >>> JSON/SQL jsonpath > >>> > >>> For example, a jsonpath string with deliberate typo

Re: JSON/SQL: jsonpath: incomprehensible error message

2022-06-29 Thread Andrew Dunstan
On 2022-06-29 We 10:58, Alexander Korotkov wrote: > On Wed, Jun 29, 2022 at 4:28 PM Erik Rijkers wrote: >> Op 29-06-2022 om 15:00 schreef Amit Kapila: >>> On Mon, Jun 27, 2022 at 8:46 PM Andrew Dunstan wrote: On 2022-06-26 Su 11:44, Erik Rijkers wrote: > JSON/SQL jsonpath > > F

Re: PostgreSQL 15 beta 2 release announcement draft

2022-06-29 Thread Jonathan S. Katz
On 6/29/22 9:30 AM, Tom Lane wrote: "Jonathan S. Katz" writes: On 6/29/22 2:55 AM, Pantelis Theodosiou wrote: Is the major version upgrade still needed if they are upgrading from 15 Beta 1? No, but it would be required if you a upgrading from a different version. The language attempts to be

Re: pg_upgrade (12->14) fails on aggregate

2022-06-29 Thread Andrey Borodin
> On 28 Jun 2022, at 04:30, Justin Pryzby wrote: > > Nope, it's as I said: this would break pg_upgrade from older versions. As far as I understand 9.5 is not supported. Probably, it makes sense to keep pg_upgrade running against 9.5 clusters, but I'm not sure if we do this routinely. Besid

Re: pg_upgrade (12->14) fails on aggregate

2022-06-29 Thread Justin Pryzby
On Wed, Jun 29, 2022 at 10:58:44PM +0500, Andrey Borodin wrote: > > On 28 Jun 2022, at 04:30, Justin Pryzby wrote: > > > > Nope, it's as I said: this would break pg_upgrade from older versions. > > As far as I understand 9.5 is not supported. Probably, it makes sense to keep > pg_upgrade runnin

Re: pg_upgrade (12->14) fails on aggregate

2022-06-29 Thread Andrey Borodin
> On 29 Jun 2022, at 23:07, Justin Pryzby wrote: > > On Wed, Jun 29, 2022 at 10:58:44PM +0500, Andrey Borodin wrote: >>> On 28 Jun 2022, at 04:30, Justin Pryzby wrote: >>> >>> Nope, it's as I said: this would break pg_upgrade from older versions. >> >> As far as I understand 9.5 is not supp

Re: PostgreSQL 15 beta 2 release announcement draft

2022-06-29 Thread Erik Rijkers
Op 29-06-2022 om 02:04 schreef Jonathan S. Katz: Hi, Attached is a draft of the release announcement for PostgreSQL 15 Beta 2. Please provide feedback on technical accuracy and if there are glaring omissions. Hardly 'glaring' but still: 'Multiples fixes' should be 'Multiple fixes' Pleas

Re: TAP output format in pg_regress

2022-06-29 Thread Daniel Gustafsson
Attached is a new version of this patch, which completes the TAP output format option such that all codepaths emitting output are TAP compliant. The verbose option is fixed to to not output extraneous newlines which the previous PoC did. The output it made to conform to the original TAP spec sinc

Re: Stats collector's idx_blks_hit value is highly misleading in practice

2022-06-29 Thread Sergey Dudoladov
Hello, I would like to get some feedback on that task. > pg_statio_*_tables.idx_blks_hit are highly misleading in practice > because they fail to take account of the difference between internal > pages and leaf pages in B-Tree indexes. I see it is still the case, so the issue is relevant, isn't

Re: Can we do something to help stop users mistakenly using force_parallel_mode?

2022-06-29 Thread David Rowley
On Thu, 30 Jun 2022 at 00:31, Justin Pryzby wrote: > Since the user in this recent thread is running v13.7, I'm *guessing* that > if that had been backpatched, they wouldn't have made this mistake. I wasn't aware of that change. Thanks for highlighting it. Maybe it's worth seeing if fewer mista

Re: Can we do something to help stop users mistakenly using force_parallel_mode?

2022-06-29 Thread David Rowley
On Wed, 29 Jun 2022 at 18:57, Laurenz Albe wrote: > Perhaps some stronger wording in the documetation would be beneficial. > I have little sympathy with people who set unusual parameters without > even glancing at the documentation. My thoughts are that the documentation is ok as is. I have a fee

Re: [PoC/RFC] Multiple passwords, interval expirations

2022-06-29 Thread Jacob Champion
On 4/8/22 10:04, Joshua Brindle wrote: > It's unclear if I will be able to continue working on this featureset, > this email address will be inactive after today. I'm assuming the answer to this was "no". Is there any interest out there to pick this up for the July CF? --Jacob

Re: [PoC/RFC] Multiple passwords, interval expirations

2022-06-29 Thread Stephen Frost
Greetings, On Wed, Jun 29, 2022 at 17:22 Jacob Champion wrote: > On 4/8/22 10:04, Joshua Brindle wrote: > > It's unclear if I will be able to continue working on this featureset, > > this email address will be inactive after today. > > I'm assuming the answer to this was "no". Is there any inter

Re: [PATCH] minor reloption regression tests improvement

2022-06-29 Thread Jacob Champion
This patch is hanging open in the March commitfest. There was a bit of back-and-forth on whether it should be rejected, but no clear statement on the issue, so I'm going to mark it Returned with Feedback. If you still feel strongly about this patch, please feel free to re-register it in the July

Strange failures on chipmunk

2022-06-29 Thread Thomas Munro
Hi, chipmunk (an armv6l-powered original Raspberry Pi model 1?) has failed in a couple of weird ways recently on 14 and master. On 14 I see what appears to be a corrupted log file name: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=chipmunk&dt=2022-06-16%2006%3A48%3A07 cp: cannot stat

Re: making relfilenodes 56 bits

2022-06-29 Thread Matthias van de Meent
On Wed, 29 Jun 2022 at 14:41, Simon Riggs wrote: > > On Tue, 28 Jun 2022 at 19:18, Matthias van de Meent > wrote: > > > I will be the first to admit that it is quite unlikely to be common > > practise, but this workload increases the number of dbOid+spcOid > > combinations to 100s (even while usi

Re: replacing role-level NOINHERIT with a grant-level option

2022-06-29 Thread Nathan Bossart
On Wed, Jun 22, 2022 at 04:30:36PM -0400, Robert Haas wrote: > On Thu, Jun 2, 2022 at 1:17 PM Tom Lane wrote: >> Point 2 would cause every existing pg_dumpall script to fail, which >> seems like kind of a large gotcha. Less unpleasant alternatives >> could include >> >> * Continue to accept the s

Re: minor change for create_list_bounds()

2022-06-29 Thread Nathan Bossart
On Tue, Mar 08, 2022 at 11:05:10AM -0800, Zhihong Yu wrote: > I was looking at commit db632fbca and noticed that, > in create_list_bounds(), if index is added to boundinfo->interleaved_parts > in the first if statement, there is no need to perform the second check > involving call to partition_boun

Re: PostgreSQL 15 beta 2 release announcement draft

2022-06-29 Thread Jonathan S. Katz
On 6/29/22 3:07 PM, Erik Rijkers wrote: Op 29-06-2022 om 02:04 schreef Jonathan S. Katz: Hi, Attached is a draft of the release announcement for PostgreSQL 15 Beta 2. Please provide feedback on technical accuracy and if there are glaring omissions. Hardly 'glaring' but still: 'Multiples fi

Re: enable/disable broken for statement triggers on partitioned tables

2022-06-29 Thread Amit Langote
On Tue, May 24, 2022 at 3:11 PM Amit Langote wrote: > Simon reported $subject off-list. > > For triggers on partitioned tables, various enable/disable trigger > variants recurse to also process partitions' triggers by way of > ATSimpleRecursion() done in the "prep" phase. While that way of > recu

Re: Emit extra debug message when executing extension script.

2022-06-29 Thread Robert Haas
On Wed, Jun 29, 2022 at 9:26 AM Peter Eisentraut wrote: > On 28.06.22 21:10, Jeff Davis wrote: > > + ereport(DEBUG1, errmsg("executing extension script: %s", filename)); > > This should either be elog or use errmsg_internal. Why? -- Robert Haas EDB: http://www.enterprisedb.com

Re: Testing autovacuum wraparound (including failsafe)

2022-06-29 Thread Masahiko Sawada
Hi, On Tue, Feb 1, 2022 at 11:58 AM Masahiko Sawada wrote: > > On Fri, Jun 11, 2021 at 10:19 AM Andres Freund wrote: > > > > Hi, > > > > On 2021-06-10 16:42:01 +0300, Anastasia Lubennikova wrote: > > > Cool. Thank you for working on that! > > > Could you please share a WIP patch for the $subj? I

Add a test for "cannot truncate foreign table"

2022-06-29 Thread Yugo NAGATA
Hello, During checking regression tests of TRUNCATE on foreign tables for other patch [1], I found that there is no test for foreign tables that don't support TRUNCATE. When a foreign table has handler but doesn't support TRUNCATE, an error "cannot truncate foreign table xxx" occurs. So, what ab

Re: Inconvenience of pg_read_binary_file()

2022-06-29 Thread Kyotaro Horiguchi
At Tue, 07 Jun 2022 17:29:31 +0900 (JST), Kyotaro Horiguchi wrote in > pg_read_file(text, bool) makes sense to me, but it doesn't seem like > to be able to share C function with other variations. > pg_read_binary_file() need to accept some out-of-range value for > offset or length to signal that

Re: Add test of pg_prewarm extenion

2022-06-29 Thread Justin Pryzby
On Wed, Jun 29, 2022 at 02:38:12PM +0900, Dong Wook Lee wrote: > Hi hackers, > I wrote a test for pg_prewarm extension. and I wrote it with the aim of > improving test coverage, and feedback is always welcome. The test fails when USE_PREFETCH isn't defined. http://cfbot.cputube.org/dongwook-lee.h

Re: making relfilenodes 56 bits

2022-06-29 Thread Thomas Munro
On Thu, Jun 30, 2022 at 12:41 AM Simon Riggs wrote: > The reason to mention this now is that it would give more space than > 56bit limit being suggested here. Isn't 2^56 enough, though? Remembering that cluster time runs out when we've generated 2^64 bytes of WAL, if you want to run out of 56 bi

Backup command and functions can cause assertion failure and segmentation fault

2022-06-29 Thread Fujii Masao
Hi, I found that the assertion failure and the segmentation fault could happen by running pg_backup_start(), pg_backup_stop() and BASE_BACKUP replication command, in v15 or before. Here is the procedure to reproduce the assertion failure. 1. Connect to the server as the REPLICATION user who is

RE: Handle infinite recursion in logical replication setup

2022-06-29 Thread shiy.f...@fujitsu.com
On Tue, Jun 28, 2022 2:18 PM vignesh C wrote: > > Thanks for the comments, the attached v25 patch has the changes for the > same. > Thanks for updating the patch. Here are some comments. 0002 patch: == 1. +# Test the CREATE SUBSCRIPTION 'origin' parameter and its interaction with

Re: [PATCH] minor reloption regression tests improvement

2022-06-29 Thread Nikolay Shaplov
В письме от четверг, 30 июня 2022 г. 00:38:48 MSK пользователь Jacob Champion написал: > This patch is hanging open in the March commitfest. There was a bit of > back-and-forth on whether it should be rejected, but no clear statement on > the issue, so I'm going to mark it Returned with Feedback.

Re: tuplesort Generation memory contexts don't play nicely with index builds

2022-06-29 Thread David Rowley
On Wed, 29 Jun 2022 at 12:59, David Rowley wrote: > I noticed while doing some memory context related work that since we > now use generation.c memory contexts for tuplesorts (40af10b57) that > tuplesort_putindextuplevalues() causes memory "leaks" in the > generation context due to index_form_tupl

Add index item for MERGE.

2022-06-29 Thread Fujii Masao
Hi, I found that there is no index item for MERGE command, in the docs. Attached is the patch that adds the indexterm for MERGE to merge.sgml. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/doc/src/sgml/ref/mer

Re: [PATCH] minor reloption regression tests improvement

2022-06-29 Thread Nikolay Shaplov
В письме от четверг, 30 июня 2022 г. 06:47:48 MSK пользователь Nikolay Shaplov написал: > Hi! I am surely feel this patch is important. I have bigger patch > https://commitfest.postgresql.org/38/3536/ and this test makes sense as a > part of big work of options refactoring, > > I am also was st

Re: last_archived_wal is not necessary the latest WAL file (was Re: pgsql: Add test case for an archive recovery corner case.)

2022-06-29 Thread Noah Misch
On Mon, Jun 27, 2022 at 07:32:08PM +0900, Michael Paquier wrote: > On Mon, Jun 27, 2022 at 12:04:57AM -0700, Noah Misch wrote: > > One can adapt the test to the server behavior by having the test wait for > > the > > archiver to start, as attached. This is sufficient to make check-world pass > >

Re: First draft of the PG 15 release notes

2022-06-29 Thread Noah Misch
On Tue, Jun 28, 2022 at 04:35:45PM -0400, Bruce Momjian wrote: > On Mon, Jun 27, 2022 at 11:37:19PM -0700, Noah Misch wrote: > > On Tue, May 10, 2022 at 11:44:15AM -0400, Bruce Momjian wrote: > > > I have completed the first draft of the PG 15 release notes > > > > > > > > > > > > > >

Re: doc: pg_prewarm add configuration example

2022-06-29 Thread Dong Wook Lee
On 22/06/29 03:57오후, Jacob Champion wrote: > On 6/18/22 01:55, Dong Wook Lee wrote: > > Hi hackers, > > > > I thought it would be nice to have an configuration example of the > > pg_prewarm extension. > > Therefore, I have written an example of a basic configuration. > > [offlist] > > Hi Don

Re: Support logical replication of DDLs

2022-06-29 Thread Amit Kapila
On Wed, Jun 29, 2022 at 3:17 PM houzj.f...@fujitsu.com wrote: > > On Tuesday, June 28, 2022 11:27 AM Amit Kapila > > On Sun, Jun 26, 2022 at 11:47 PM Alvaro Herrera > > wrote: > > > > > > However, that would still replicate a command that involves a > > > temporary table, which perhaps should no

Re: Strange failures on chipmunk

2022-06-29 Thread Noah Misch
On Thu, Jun 30, 2022 at 10:07:18AM +1200, Thomas Munro wrote: > Then there's this one-off, that smells like WAL corruption: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=chipmunk&dt=2022-06-13%2015%3A12%3A44 > > 2022-06-13 23:02:06.988 EEST [30121:5] LOG: incorrect resource > manag

Re: making relfilenodes 56 bits

2022-06-29 Thread Dilip Kumar
On Tue, Jun 28, 2022 at 5:15 PM Simon Riggs wrote: > > On Sat, 25 Jun 2022 at 02:30, Andres Freund wrote: > > > > And then like this in 0003: > > > > > > typedef struct buftag > > > { > > > Oid spcOid; > > > Oid dbOid; > > > RelFileNumber fileNumber:56; > > > ForkNumber