Re: Order changes in PG16 since ICU introduction

2023-04-28 Thread Jeff Davis
On Thu, 2023-04-27 at 14:23 +0200, Daniel Verite wrote: > This should be pg_strcasecmp(...) == 0 Good catch, thank you! Fixed in updated patches. > postgres=# create database lat9 locale 'fr_FR@euro' encoding LATIN9 > template > 'template0'; > ERROR:  could not convert locale name "fr_FR@euro" to

Re: Postgres Version want to update from 9.2 to 9.5 version in CentOS 7.9

2023-04-28 Thread Roberto Mello
On Fri, Apr 28, 2023 at 12:10 PM Gautham Raj wrote: > Thank you for the quick response. > > Yes, I'm willing to get the latest version. I read some articles CentOS 7 > doesn't support the latest versions. So was trying the old versions. > > I tried the article shared but, got the below error at t

Re: Postgres Version want to update from 9.2 to 9.5 version in CentOS 7.9

2023-04-28 Thread Gautham Raj
Thank you for the quick response. Yes, I'm willing to get the latest version. I read some articles CentOS 7 doesn't support the latest versions. So was trying the old versions. I tried the article shared but, got the below error at the step. [image: image.png] Something is wrong here. Please su

Re: run pgindent on a regular basis / scripted manner

2023-04-28 Thread Bruce Momjian
On Wed, Apr 26, 2023 at 03:44:47PM -0400, Andrew Dunstan wrote: > On 2023-04-26 We 09:27, Tom Lane wrote: > I doubt there's something like that. You can freeze arbitrary blocks of code > like this (from the manual) > > #<<<  format skipping: do not let perltidy change my nice formatting >    

Re: Build problem with square brackets in build path

2023-04-28 Thread Tom Lane
Nikolay Shaplov writes: > If you do > mkdir [source] > git clone git://git.postgresql.org/git/postgresql.git [source] > mkdir build; cd build > ../\[source\]/configure > make > you will get > make[1]: *** No rule to make target 'generated-headers'. Stop. > If there are no "[]" in the path to

Re: Postgres Version want to update from 9.2 to 9.5 version in CentOS 7.9

2023-04-28 Thread Tom Lane
Gautham Raj writes: > *Problem: Having multiple versions of Postgres installed in CentOS 7. I > Want to set the 9.5 version as default. Not able to access Postgres 9.5 > through the terminal as well.* >1. For Command *psql --version* I'm getting 9.5 as the version. >2. For Command *sudo -

Re: Possible regression setting GUCs on \connect

2023-04-28 Thread Pavel Borisov
Hi! On Fri, 28 Apr 2023 at 17:42, Jonathan S. Katz wrote: > > On 4/27/23 8:04 PM, Alexander Korotkov wrote: > > On Fri, Apr 28, 2023 at 2:30 AM Alexander Korotkov > > wrote: > >> Additionally, I think if we start recording role OID, then we need a > >> full set of management clauses for each in

Postgres Version want to update from 9.2 to 9.5 version in CentOS 7.9

2023-04-28 Thread Gautham Raj
Hi, *Problem: Having multiple versions of Postgres installed in CentOS 7. I Want to set the 9.5 version as default. Not able to access Postgres 9.5 through the terminal as well.* 1. For Command *psql --version* I'm getting 9.5 as the version. 2. For Command *sudo -u postgres psql *I'm getti

Re: [PATCH] Support % wildcard in extension upgrade filenames

2023-04-28 Thread Eric Ridge
(I'm the developer of ZomboDB and pgrx, which while not an extension per se, allows others to make extensions that then need upgrade scripts. So this topic is interesting to me.) > On Mar 13, 2023, at 2:48 PM, Regina Obe wrote: > >>> I wonder if a solution to this problem might be to provide

Re: Possible regression setting GUCs on \connect

2023-04-28 Thread Jonathan S. Katz
On 4/27/23 8:04 PM, Alexander Korotkov wrote: On Fri, Apr 28, 2023 at 2:30 AM Alexander Korotkov wrote: Additionally, I think if we start recording role OID, then we need a full set of management clauses for each individual option ownership. Otherwise, we would leave this new role OID without n

RE: [PATCH] Support % wildcard in extension upgrade filenames

2023-04-28 Thread Regina Obe
> > > As for Tom's concern about downgrades, I think it's valid but it's a > > case that is easy to test for in Plpgsql and either handle or error. > > For example, we use semver so testing for a downgrade at the top of > > the upgrade script is trivial. > I was thinking about this more. The ex

Re: Add PQsendSyncMessage() to libpq

2023-04-28 Thread Robert Haas
On Fri, Mar 24, 2023 at 6:39 PM Anton Kirilov wrote: > I have attached a patch that introduces PQsendSyncMessage(), a > function that is equivalent to PQpipelineSync(), except that it does > not flush anything to the server; the user must subsequently call > PQflush() instead. Alternatively, the n

Re: Support logical replication of DDLs

2023-04-28 Thread Amit Kapila
On Tue, Apr 25, 2023 at 9:28 AM Zhijie Hou (Fujitsu) wrote: > I have a few high-level comments on the deparsing approach used in the patch. As per my understanding, we first build an ObjTree from the DDL command, then convert the ObjTree to Jsonb which is then converted to a JSON string. Now, in

Build problem with square brackets in build path

2023-04-28 Thread Nikolay Shaplov
I am not sure it is really a bug, but nevertheless If you do mkdir [source] git clone git://git.postgresql.org/git/postgresql.git [source] mkdir build; cd build ../\[source\]/configure make you will get make[1]: *** No rule to make target 'generated-headers'. Stop. If there are no "[]" in th

Re: Should vacuum process config file reload more often

2023-04-28 Thread Daniel Gustafsson
> On 27 Apr 2023, at 23:25, Daniel Gustafsson wrote: >> On 27 Apr 2023, at 16:53, Melanie Plageman wrote: >> Fix LGTM. > > Thanks for review. I plan to push this in the morning. Done, thanks. -- Daniel Gustafsson

Re: run pgindent on a regular basis / scripted manner

2023-04-28 Thread Alvaro Herrera
On 2023-Feb-05, Andrew Dunstan wrote: > So here's a diff made from running perltidy v20221112 with the additional > setting --valign-exclusion-list=", = => || && if unless" I ran this experimentally with perltidy 20230309, and compared that with the --novalign behavior (not to propose the latter

Re: Perform streaming logical transactions by background workers and parallel apply

2023-04-28 Thread Amit Kapila
On Fri, Apr 28, 2023 at 11:48 AM Masahiko Sawada wrote: > > On Fri, Apr 28, 2023 at 11:51 AM Amit Kapila wrote: > > > > On Wed, Apr 26, 2023 at 4:11 PM Zhijie Hou (Fujitsu) > > wrote: > > > > > > On Wednesday, April 26, 2023 5:00 PM Alexander Lakhin > > > wrote: > > > > > > > > IIUC, that asse

Re: Add two missing tests in 035_standby_logical_decoding.pl

2023-04-28 Thread Drouvot, Bertrand
Hi, On 4/28/23 5:55 AM, Amit Kapila wrote: On Wed, Apr 26, 2023 at 7:53 PM Drouvot, Bertrand wrote: +# Get the restart_lsn from an invalidated slot +my $restart_lsn = $node_standby->safe_psql('postgres', + "SELECT restart_lsn from pg_replication_slots WHERE slot_name = 'vacuum_full_activeslot'

Re: Testing autovacuum wraparound (including failsafe)

2023-04-28 Thread Daniel Gustafsson
> On 28 Apr 2023, at 06:42, Tom Lane wrote: > John Naylor writes: >> If they're that slow, I'd worry more about generating 20GB of xact status >> data. That's why the tests are disabled by default. > > There is exactly zero chance that anyone will accept the introduction > of such an expensive

Re: Logging parallel worker draught

2023-04-28 Thread Benoit Lobréau
On 4/22/23 13:06, Amit Kapila wrote: I don't think introducing a GUC for this is a good idea. We can directly output this message in the server log either at LOG or DEBUG1 level. Hi, Sorry for the delayed answer, I was away from my computer for a few days. I don't mind removing the guc, but I

Re: Add PQsendSyncMessage() to libpq

2023-04-28 Thread Denis Laxalde
Michael Paquier a écrit : On Thu, Apr 27, 2023 at 01:06:27PM +0200, Denis Laxalde wrote: Thank you; this V2 looks good to me. Marking as ready for committer. Please note that we are in a stabilization period for v16 and that the first commit fest of v17 should start in July, so it will perhaps

Re: Initial Schema Sync for Logical Replication

2023-04-28 Thread Masahiko Sawada
On Thu, Apr 27, 2023 at 12:02 PM Wei Wang (Fujitsu) wrote: > > On Fri, Apr 21, 2023 at 16:48 PM Masahiko Sawada > wrote: > > On Thu, Apr 20, 2023 at 8:16 PM Amit Kapila wrote: > > > > > > On Mon, Apr 17, 2023 at 9:12 AM Masahiko Sawada > > wrote: > > > > > > > > On Fri, Apr 7, 2023 at 6:37 PM

Re: Add PQsendSyncMessage() to libpq

2023-04-28 Thread Michael Paquier
On Thu, Apr 27, 2023 at 01:06:27PM +0200, Denis Laxalde wrote: > Thank you; this V2 looks good to me. > Marking as ready for committer. Please note that we are in a stabilization period for v16 and that the first commit fest of v17 should start in July, so it will perhaps take some time before thi