Re: minor replication slot docs edits

On 2024-Jan-16, Bharath Rupireddy wrote: > Thanks for the patch. The wording looks good to me. However, I have > some comments on the placement of the note: > > 1. How about bundling this in a or ? Yeah, I considered this too, but I discarded the idea because my impression of and was that

Re: [17] CREATE COLLATION default provider

On 15.06.23 06:47, Jeff Davis wrote: Currently, CREATE COLLATION always defaults the provider to libc. The attached patch causes it to default to libc if LC_COLLATE/LC_CTYPE are specified, otherwise default to the current database default collation's provider. That way, the provider choice at

Re: Report planning memory in EXPLAIN ANALYZE

On Tue, Jan 16, 2024 at 8:19 PM Ashutosh Bapat wrote: > > Using a boolean return and moving es->indent-- outside of > show_buffer_usage would be less elegant. > I went ahead with this option so as not to break backward compatibility in any manner. Attached patch 0002 has the code and expected

Re: subscription disable_on_error not working after ALTER SUBSCRIPTION set bad conninfo

On Thu, Jan 18, 2024 at 11:15 AM Peter Smith wrote: > > On Thu, Jan 18, 2024 at 12:55 PM Masahiko Sawada > wrote: > > > ... > > > > Although we can improve it to handle this case too, I'm not sure it's > > a bug. The doc says[1]: > > > > Specifies whether the subscription should be

Re: cleanup patches for incremental backup

On Wed, 17 Jan 2024 at 21:10, Robert Haas wrote: > > On Wed, Jan 17, 2024 at 1:42 PM Matthias van de Meent > wrote: > > Sure, added in attached. > > I think this mostly looks good now but I just realized that I think > this needs rephrasing: > > + To restore incremental backups the tool

Re: POC: GROUP BY optimization

On 16/1/2024 22:05, Alexander Korotkov wrote: On Tue, Jan 16, 2024 at 4:48 AM Richard Guo wrote: * When trying to match the ordering of GROUP BY to that of ORDER BY in get_useful_group_keys_orderings, this patch checks against the length of path->pathkeys. This does not make sense. I guess

Re: speed up a logical replica setup

On Tue, Jan 16, 2024 at 11:58 AM Shubham Khanna wrote: > > On Thu, Dec 21, 2023 at 11:47 AM Amit Kapila wrote: > > > > > > 4. Can we see some numbers with various sizes of databases (cluster) > > to see how it impacts the time for small to large-size databases as > > compared to the traditional

Re: speed up a logical replica setup

On Thu, Jan 18, 2024 at 2:49 PM Peter Eisentraut wrote: > > On 11.01.24 23:15, Euler Taveira wrote: > > A new tool called pg_subscriber can convert a physical replica into a > > logical replica. It runs on the target server and should be able to > > connect to the source server (publisher) and

Re: speed up a logical replica setup

On 11.01.24 23:15, Euler Taveira wrote: A new tool called pg_subscriber can convert a physical replica into a logical replica. It runs on the target server and should be able to connect to the source server (publisher) and the target server (subscriber). Can we have a discussion on the name?

Re: Reduce useless changes before reassembly during logical replication

On Thu, Jan 18, 2024 at 12:12 PM Bharath Rupireddy wrote: > > On Wed, Jan 17, 2024 at 11:45 AM li jie wrote: > > > > Hi hackers, > > > > During logical replication, if there is a large write transaction, some > > spill files will be written to disk, depending on the setting of > >

Add \syncpipeline command to pgbench

Hi, PQsendSyncMessage() was added in https://commitfest.postgresql.org/46/4262/. It allows users to add a Sync message without flushing the buffer. As a follow-up, this change adds an additional meta-command to pgbench, \syncpipeline, which will call PQsendSyncMessage(). This will make it

Re: modify first-word capitalisation of some messages

On 17.01.24 23:17, Peter Smith wrote: PSA a small patch to adjust the first-word capitalisation of some errmsg/ errdetail/ errhint so they comply with the guidelines. committed, thanks

Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)

On Thu, Jan 18, 2024 at 4:59 PM Alexander Korotkov wrote: > > On Thu, Jan 18, 2024 at 4:16 AM torikoshia wrote: > > On 2024-01-18 10:10, jian he wrote: > > > On Thu, Jan 18, 2024 at 8:57 AM Masahiko Sawada > > > wrote: > > >> On Thu, Jan 18, 2024 at 6:38 AM Tom Lane wrote: > > >> >

Re: Build versionless .so for Android

On 14.01.24 12:37, Matthias Kuhn wrote: What I try to do is packaging an app with androiddeployqt which fails with an error: The bundled library lib/libpq.so.5 doesn't end with .so. Android only supports versionless libraries ending with the .so suffix. This error was introduced in response

Re: Network failure may prevent promotion

At Sun, 31 Dec 2023 20:07:41 +0900 (JST), Kyotaro Horiguchi wrote in > We've noticed that when walreceiver is waiting for a connection to > complete, standby does not immediately respond to promotion > requests. In PG14, upon receiving a promotion request, walreceiver > terminates instantly,

Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx

> Hmm. So it does not lead to any user-visible changes, right? >From what I can tell, there's no change in the behaviour. All paths would eventually go through HandleSlashCmds's cleaning logic. This is also mentioned in ignore_slash_options's comment. * Read and discard "normal" slash command

Re: add function argument names to regex* functions.

On 10.01.24 15:18, jian he wrote: I put the changes into the new patch. Reading back through the discussion, I wasn't quite able to interpret the resolution regarding Oracle compatibility. From the patch, it looks like you chose not to adopt the parameter names from Oracle. Was that your

Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)

čt 18. 1. 2024 v 8:59 odesílatel Alexander Korotkov napsal: > On Thu, Jan 18, 2024 at 4:16 AM torikoshia > wrote: > > On 2024-01-18 10:10, jian he wrote: > > > On Thu, Jan 18, 2024 at 8:57 AM Masahiko Sawada > > > > wrote: > > >> On Thu, Jan 18, 2024 at 6:38 AM Tom Lane wrote: > > >> >

<    1   2