Re: introduce dynamic shared memory registry

On Sun, Jan 21, 2024 at 04:13:20PM -0600, Nathan Bossart wrote: > Oops. I've attached an attempt at fixing this. I took the opportunity to > clean up the surrounding code a bit. Thanks for the patch. Your proposed attempt looks correct to me with an ERROR when no segments are found.. -- Michael

Re: Synchronizing slots from primary to standby

Hi, On Fri, Jan 19, 2024 at 05:23:53PM +0530, Amit Kapila wrote: > On Wed, Jan 17, 2024 at 4:00 PM shveta malik wrote: > > > > Now, the concerns related to this could be that users would probably > need to change existing mechanisms/tools to update priamry_conninfo Yeah, for the ones that want

Re: Use of backup_label not noted in log

On Fri, Jan 19, 2024 at 09:32:26AM -0400, David Steele wrote: > Any status on this patch? If we do back patch it would be nice to see this > in the upcoming minor releases. I'm in favor of a back patch, as I think > this is minimally invasive and would be very useful for debugging recovery > issues

make dist using git archive

One of the goals is to make the creation of the distribution tarball more directly traceable to the git repository. That is why we removed the "make distprep" step. Here I want to take another step in that direction, by changing "make dist" to directly use "git archive", rather than the custo

Re: [PoC] Improve dead tuple storage for lazy vacuum

On Mon, Jan 22, 2024 at 2:36 PM John Naylor wrote: > > On Mon, Jan 22, 2024 at 10:28 AM Masahiko Sawada > wrote: > > > > On further thought, as you pointed out before, "num_tids" should not > > be in tidstore in terms of integration with tidbitmap.c, because > > tidbitmap.c has "lossy pages". Wi

Re: the s_lock_stuck on perform_spin_delay

Andy Fan writes: > I found a speical case about checking it in errstart. So commit 3 in v7 > is added. > > commit 757c67c1d4895ce6a523bcf5217af8eb2351e2a1 (HEAD -> s_stuck_v3) > Author: yizhi.fzh > Date: Mon Jan 22 07:14:29 2024 +0800 > > Bypass SpinLock checking in SIGQUIT signal hander

Re: Add system identifier to backup manifest

On Mon, Jan 22, 2024 at 10:08 AM Amul Sul wrote: > > > On Fri, Jan 19, 2024 at 10:36 PM Amul Sul wrote: > >> On Wed, Jan 17, 2024 at 8:40 PM Robert Haas >> wrote: >> >>> >>> >> Updated version is attached. >> > > Another updated version attached -- fix missing manifest version check in > pg_ver

Re: index prefetching

On 22/01/2024 1:39 am, Tomas Vondra wrote: Why we can prefer covering index  to compound index? I see only two good reasons: 1. Extra columns type do not  have comparison function need for AM. 2. The extra columns are never used in query predicate. Or maybe you don't want to include the column

RE: speed up a logical replica setup

Dear hackers, > > 15. > I found that subscriptions cannot be started if tuples are inserted on > publisher > after creating temp_replslot. After starting a subscriber, I got below output > on the > log. > > ``` > ERROR: could not receive data from WAL stream: ERROR: publication > "pg_subscri

Re: [PoC] Improve dead tuple storage for lazy vacuum

On Wed, Jan 17, 2024 at 12:32 PM John Naylor wrote: > > I wrote: > > > > Hmm, I wonder if that's a side-effect of the "create" functions doing > > > their own allocations and returning a pointer. Would it be less tricky > > > if the structs were declared where we need them and passed to "init" > >

Re: Synchronizing slots from primary to standby

On Fri, Jan 19, 2024 at 3:55 PM shveta malik wrote: > > On Fri, Jan 19, 2024 at 10:35 AM Masahiko Sawada > wrote: > > > > > > Thank you for updating the patch. I have some comments: > > > > --- > > +latestWalEnd = GetWalRcvLatestWalEnd(); > > +if (remote_slot->confirmed_lsn > lat

Re: Test slots invalidations in 035_standby_logical_decoding.pl only if dead rows are removed

On Fri, Jan 19, 2024 at 09:03:01AM +, Bertrand Drouvot wrote: > On Fri, Jan 19, 2024 at 09:00:01AM +0300, Alexander Lakhin wrote: >> 15.01.2024 12:00, Alexander Lakhin wrote: >>> If this approach looks promising to you, maybe we could add a submodule to >>> perl/PostgreSQL/Test/ and use this fu

Re: speed up a logical replica setup

On 18.01.24 10:37, Amit Kapila wrote: The other option could be pg_createsubscriber on the lines of pg_verifybackup and pg_combinebackup. Yes, that spelling would be more consistent. Yet other options could be pg_buildsubscriber, pg_makesubscriber as 'build' or 'make' in the name sounds like

Re: POC: Extension for adding distributed tracing - pg_tracing

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4456/ [2] https://cirrus-ci.com/task/5581154

Re: Shared detoast Datum proposal

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4759/ [2] https://cirrus-ci.com/github/postg

Re: Things I don't like about \du's "Attributes" column

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4738/ [2] https://cirrus-ci.com/github/postg

Re: index prefetching

On 22/01/2024 1:47 am, Tomas Vondra wrote: h, right. Well, you're right in this case we perhaps could set just one of those flags, but the "purpose" of the two places is quite different. The "prefetch" flag is fully controlled by the prefetcher, and it's up to it to change it (e.g. I can easily

Re: pg_stat_statements and "IN" conditions

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there was a CFbot test failure last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/2837/ [2] https://cirrus-ci.com/task/6688578

Re: Oom on temp (un-analyzed table caused by JIT) V16.1 [Fixed Already]

On Fri, Jan 19, 2024 at 7:03 PM Daniel Gustafsson wrote: > > On 19 Jan 2024, at 23:09, Kirk Wolak wrote: > > > From a FUTURE email, I noticed pg_jit_available() and it's set to f?? > > Right, then this installation does not contain the necessary library to JIT > compile the query. > > > Okay, s

Re: WIP Incremental JSON Parser

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4725/ [2] https://cirrus-ci.com/github/postg

Re: Transaction timeout

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there was a CFbot test failure last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4040/ [2] https://cirrus-ci.com/task/4721191

Re: Row pattern recognition

> Thank you very much for providing the patch for the RPR implementation. > > After applying the v12-patches, I noticed an issue that > the rpr related parts in window clauses were not displayed in the > view definitions (the definition column of pg_views). > > To address this, I have taken the l

Re: remaining sql/json patches

On Mon, Nov 27, 2023 at 9:06 PM Alvaro Herrera wrote: > At this point one thing that IMO we cannot afford to do, is stop feature > progress work on the name of parser speed. I mean, parser speed is > important, and we need to be mindful that what we add is reasonable. > But at some point we'll pr

Re: Moving forward with TDE [PATCH v3]

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/3985/ [2] https://cirrus-ci.com/task/5498215

Re: Add \syncpipeline command to pgbench

On Fri, Jan 19, 2024 at 08:55:31AM +0100, Anthonin Bonnefoy wrote: > I've updated the doc to group the commands. It does look better and > more consistent with similar command groups like \if. I was playing with a few meta command scenarios while looking at this patch, and this sequence generates

Re: remaining sql/json patches

I found two main issues regarding cocece SQL/JSON function output to other data types. * returning typmod influence the returning result of JSON_VALUE | JSON_QUERY. * JSON_VALUE | JSON_QUERY handles returning type domains allowing null and not allowing null inconsistencies. in ExecInitJsonExprCoer

Re: Statistics Import and Export

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4538/ [2] https://cirrus-ci.com/github/postg

Re: Sequence Access Methods, round two

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4677/ [2] https://cirrus-ci.com/task/5576959

Re: Improve heapgetpage() performance, overhead from serializable

On Mon, Jul 17, 2023 at 9:58 PM Andres Freund wrote: > And 397->320ms > for something as core as this, is imo worth considering on its own. Hi Andres, this interesting work seems to have fallen off the radar -- are you still planning to move forward with this for v17?

Re: SQL:2011 application time

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4308/ [2] https://cirrus-ci.com/github/postg

Re: Support "Right Semi Join" plan shapes

Hi vignesh CI saw this path has been passed ( https://cirrus-ci.com/build/6109321080078336),can we push it? Best wish Richard Guo 于2024年1月9日周二 18:49写道： > > On Sun, Jan 7, 2024 at 3:03 PM vignesh C wrote: > >> One of the tests in CFBot has failed at [1] with: >> - Relations: (public.ft1

Re: remaining sql/json patches

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4377/ [2] https://cirrus-ci.com/github/postg

Re: Row pattern recognition

On Sat, 09 Dec 2023 07:22:58 +0900 (JST) Tatsuo Ishii wrote: > > On 04.12.23 12:40, Tatsuo Ishii wrote: > >> diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y > >> index d631ac89a9..5a77fca17f 100644 > >> --- a/src/backend/parser/gram.y > >> +++ b/src/backend/parser/gram.y > >> @

Re: Relation bulk write facility

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there was a CFbot test failure last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4575/ [2] https://cirrus-ci.com/task/4990764

Re: [HACKERS] make async slave to wait for lsn to be replayed

On Wed, Jan 17, 2024 at 1:46 PM Kartyshov Ivan wrote: > > Add some fixes and rebase. > While quickly looking into the patch, I understood the idea of what we are trying to achieve here and I feel that a useful feature. But while looking at both the patches I could not quickly differentiate betwee

Re: Permute underscore separated components of columns before fuzzy matching

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems like there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4282/ [2] https://cirrus-ci.com/github

Re: [PoC] Improve dead tuple storage for lazy vacuum

On Mon, Jan 22, 2024 at 10:28 AM Masahiko Sawada wrote: > > On further thought, as you pointed out before, "num_tids" should not > be in tidstore in terms of integration with tidbitmap.c, because > tidbitmap.c has "lossy pages". With lossy pages, "num_tids" is no > longer accurate and useful. Simi

Re: [PATCH] New [relation] option engine

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4688/ [2] https://cirrus-ci.com/task/5066432

Re: Network failure may prevent promotion

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4748/ [2] https://cirrus-ci.com/github/postg

Re: Move walreceiver state assignment (to WALRCV_STREAMING) in WalReceiverMain()

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4698/ [2] https://cirrus-ci.com/task/5367036

meson: Specify -Wformat as a common warning flag for extensions

Hi, I'm an extension developer. If I use PostgreSQL built with Meson, I get the following warning: cc1: warning: '-Wformat-security' ignored without '-Wformat' [-Wformat-security] Because "pg_config --cflags" includes -Wformat-security but doesn't include -Wformat. Can we specify -Wformat

Re: Make mesage at end-of-recovery less scary.

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/2490/ [2] https://cirrus-ci.com/github/postg

Re: Fix some typos

On Sun, Jan 21, 2024 at 08:22:01PM +0800, Yongtao Huang wrote: > As the title said, just fix some typos. Thanks, applied. -- Michael signature.asc Description: PGP signature

Re: cleanup patches for dshash

On Sun, Jan 21, 2024 at 09:51:18PM -0600, Nathan Bossart wrote: > I did notice a cfbot failure [0]. After a quick glance, I'm assuming this > is caused by the memcpy() in insert_into_bucket(). Even if the string is > short, it will copy the maximum key size, which is bad. So, 0002 is > totally b

Re: [HACKERS] make async slave to wait for lsn to be replayed

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there was a CFbot test failure last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4221/ [2] https://cirrus-ci.com/task/5618308

Re: index prefetching

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems like there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4351/ [2] https://cirrus-ci.com/github

Re: Adding facility for injection points (or probe points?) for more advanced tests

On Mon, Jan 22, 2024 at 10:08 AM Michael Paquier wrote: > > On Thu, Jan 18, 2024 at 10:56:09AM +0530, Ashutosh Bapat wrote: > > There is some overlap between Dtrace functionality and this > > functionality. But I see differences too. E.g. injection points offer > > deeper integration whereas dtrac

Re: Improve eviction algorithm in ReorderBuffer

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems like there was some CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4699/ [2] https://cirrus-ci.com/git

Re: Add system identifier to backup manifest

On Fri, Jan 19, 2024 at 10:36 PM Amul Sul wrote: > On Wed, Jan 17, 2024 at 8:40 PM Robert Haas wrote: > >> >> > Updated version is attached. > Another updated version attached -- fix missing manifest version check in pg_verifybackup before system identifier validation. Regards, Amul From 7ff9e

Re: Adding facility for injection points (or probe points?) for more advanced tests

On Thu, Jan 18, 2024 at 10:56:09AM +0530, Ashutosh Bapat wrote: > There is some overlap between Dtrace functionality and this > functionality. But I see differences too. E.g. injection points offer > deeper integration whereas dtrace provides more information to the > probe like callstack and argum

Re: In-placre persistance change of a relation

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there was a CFbot test failure last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/3461/ [2] https://cirrus-ci.com/task/6050020

Re: Removing const-false IS NULL quals and redundant IS NOT NULL quals

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4459/ [2] https://cirrus-ci.com/github/postg

Re: Why is src/test/modules/committs/t/002_standby.pl flaky?

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems like there were CFbot test failures last time it was run [1]. Please have a look and post an updated version if necessary. == 1[] https://commitfest.postgresql.org/46/3523/ [1] https://cirrus-ci.com/github/

Re: UUID v7

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: tested, passed Spec compliant: not tested Documentation:tested, passed Manually tested uuidv7(), uuid_extract_time() – they work as expected

Re: UUID v7

On Fri, Jan 19, 2024 at 10:07 AM Andrey Borodin wrote: > > > > On 19 Jan 2024, at 13:25, Andrey Borodin wrote: > > > > Also, I've added some documentation on all functions. > > Here's v12. Changes: > 1. Documentation improvements > 2. Code comments > 3. Better commit message and reviews list >

Re: Synchronizing slots from primary to standby

On Fri, Jan 19, 2024 at 5:23 PM Amit Kapila wrote: > > On Wed, Jan 17, 2024 at 4:00 PM shveta malik wrote: > > > > I had some off-list discussions with Sawada-San, Hou-San, and Shveta > on the topic of extending replication commands instead of using the > current model where we fetch the required

Re: Change GUC hashtable to use simplehash?

On Mon, 2024-01-22 at 09:03 +0700, John Naylor wrote: > v15-0004 is a stab at that. As an idea, it also renames zero_bytes_le > to zero_byte_low to reflect the effect better. There might be some > other comment edits needed to explain usage, so I plan to hold on to > this for later. Let me know wha

Re: Avoid computing ORDER BY junk columns unnecessarily

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review", but it seems like there were some CFbot test failures last time it was run [1]. Please have a look and post an updated version if necessary. == [1] https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/46/4717

Re: cleanup patches for dshash

On Mon, Jan 22, 2024 at 10:28:42AM +0800, Andy Fan wrote: > Both LGTM. Thanks for looking. > +dshash_strcmp(const void *a, const void *b, size_t size, void *arg) > +{ > + Assert(strlen((const char *) a) < size); > + Assert(strlen((const char *) b) < size); > + > > Do you think the below

Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review", but it seems like there were some CFbot test failures last time it was run [1]. Please have a look and post an updated version if necessary. == [1] https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/46/4736

Re: [PoC] Improve dead tuple storage for lazy vacuum

On Fri, Jan 19, 2024 at 6:48 PM John Naylor wrote: > > On Fri, Jan 19, 2024 at 2:26 PM Masahiko Sawada wrote: > > > > On Thu, Jan 18, 2024 at 1:30 PM John Naylor wrote: > > > I'm not quite sure what the point of "num_items" is anymore, because > > > it was really tied to the array in VacDeadItem

Re: Add last_commit_lsn to pg_stat_database

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review", but it seems like there was some CFbot test failure last time it was run [1]. Please have a look and post an updated version if necessary. == [1] https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/46/4355

Re: Add code indentation check to cirrus-ci (was Re: Add BF member koel-like indentation checks to SanityCheck CI)

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems like there was some CFbot test failure last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4691/ [2] https://cirrus-ci.com/task

Re: Opportunistically pruning page before update

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems like there was some CFbot test failure last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4384// [2] https://cirrus-ci.com/git

Re: Incremental View Maintenance, take 2

2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems like there was some CFbot test failure last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4337/ [2] https://cirrus-ci.com/task

Re: cleanup patches for dshash

Nathan Bossart writes: > While working on the dynamic shared memory registry, I noticed a couple of > potential improvements for code that uses dshash tables. > > * A couple of dshash_create() callers pass in 0 for the "void *arg" > parameter, which seemed weird. I incorrectly assumed this w

Re: Remove unused fields in ReorderBufferTupleBuf

2024-01 Commitfest. Hi, this patch was marked in CF as "Needs Review" [1], but there has been no activity on this thread for 5+ months. Do you wish to keep this open, or can you post something to elicit more interest in reviews for the latest patch set? Otherwise, if nothing happens then the CF e

Re: ALTER TABLE SET ACCESS METHOD on partitioned tables

2024-01 Commitfest. Hi, this patch was marked in CF as "Needs Review" [1], but there has been no activity on this thread for 6+ months. Is anything else planned, or can you post something to elicit more interest in reviews for the latest patch? Otherwise, if nothing happens then the CF entry will

Re: Volatile write caches on macOS and Windows, redux

2024-01 Commitfest. Hi, this patch was marked in CF as "Needs Review" [1], but there has been no activity on this thread for 6+ months. Is anything else planned, or can you post something to elicit more interest in the patch? Otherwise, if nothing happens then the CF entry will be closed ("Return

Re: MERGE ... WHEN NOT MATCHED BY SOURCE

Hi, this patch was marked in CF as "Needs Review" [1], but there has been no activity on this thread for 6+ months. Is anything else planned? Can you post something to elicit more interest in the latest patch? Otherwise, if nothing happens then the CF entry will be closed ("Returned with feedback"

Re: Support TZ format code in to_timestamp()

Peter Smith writes: > Hi, this patch was marked in CF as "Needs Review" [1], but there has > been no activity on this thread for 7+ months. > If nothing more is planned for this thread then it will be closed > ("Returned with feedback") at the end of this CF. I still think it would be a good idea

Re: Change GUC hashtable to use simplehash?

I wrote: > fasthash_init(&hs, sizeof(Datum), kind); > fasthash_accum(&hs, (char *) &value, sizeof(Datum)); > return fasthash_final32(&hs, 0); It occurred to me that it's strange to have two places that length can be passed. That was a side effect of the original, which used length to both kn

Re: Support TZ format code in to_timestamp()

2024-01 Commitfest. Hi, this patch was marked in CF as "Needs Review" [1], but there has been no activity on this thread for 7+ months. If nothing more is planned for this thread then it will be closed ("Returned with feedback") at the end of this CF. == [1] https://commitfest.postgresql.or

Re: Temporary tables versus wraparound... again

2024-01 Commitfest. Hi, this patch was marked in CF as "Needs Review", but there has been no activity on this thread for 9+ months. Since there seems not much interest, I have changed the status to "Returned with Feedback" [1]. Feel free to propose a stronger use case for the patch and add an ent

Re: WIP: Aggregation push-down - take2

2024-01 Commitfest. Hi, this patch was marked in CF as "Needs Review", but there has been no activity on this thread for 9+ months. Since there seems not much interest, I have changed the status to "Returned with Feedback" [1]. Feel free to propose a stronger use case for the patch and add an ent

Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

2024-01 Commitfest. Hi, this patch was marked in CF as "Needs Review", but there has been no activity on this thread for 14+ months. Since there seems not much interest, I have changed the status to "Returned with Feedback" [1]. Feel free to propose a stronger use case for the patch and add an en

Re: pg_receivewal fail to streams when the partial file to write is not fully initialized present in the wal receiver directory

2024-01 Commitfest. Hi, this patch was marked in CF as "Needs Review", but there has been no activity on this thread for 15+ months. Since there seems not much interest, I have changed the status to "Returned with Feedback" [1]. Feel free to propose a stronger use case for the patch and add an en

Re: generate syscache info automatically

On Fri, Jan 19, 2024 at 9:03 PM Peter Eisentraut wrote: > > The DECLARE_* macros map to actual BKI commands ("declare toast", > "declare index"). So I wanted to use a different verb to distinguish > "generate code for this" from those BKI commands. That makes sense to me.

Re: [PATCH] psql: \dn+ to show size of each schema (and \dA+ for AMs)

2024-01 Commitfest. Hi, This patch had a CF status of "Ready for Committer", but the thread has been inactive for 5+ months. Since the last post from Justin said "hoping to receive some feedback" I have changed the CF status back to "Needs Review" [1]. == [1] https://commitfest.postgresql.or

Re: remaining sql/json patches

based on v35. Now I only applied from 0001 to 0007. For {DEFAULT expression ON EMPTY} | {DEFAULT expression ON ERROR} restrict DEFAULT expression be either Const node or FuncExpr node. so these 3 SQL/JSON functions can be used in the btree expression index. I made some big changes on the doc. (s

Re: Guiding principle for dropping LLVM versions?

2024-01 Commitfest. Hi, This patch has a CF status of "Ready for Committer", but it looks like it failed when the CFbot test for it was last run [1]. Please have a look and post an updated version.. == [1] https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/46/4640 Kind Regar

Re: index prefetching

On 1/21/24 20:56, Konstantin Knizhnik wrote: > > On 19/01/2024 2:35 pm, Tomas Vondra wrote: >> >> On 1/19/24 09:34, Konstantin Knizhnik wrote: >>> On 18/01/2024 6:00 pm, Tomas Vondra wrote: On 1/17/24 09:45, Konstantin Knizhnik wrote: > I have integrated your prefetch patch in Neon and

Re: index prefetching

On 1/21/24 20:50, Konstantin Knizhnik wrote: > > On 20/01/2024 12:14 am, Tomas Vondra wrote: >> Looks like I was not true, even if it is not index-only scan but index >>> condition involves only index attributes, then heap is not accessed >>> until we find tuple satisfying search condition. >>>

Re: pg_rewind WAL segments deletion pitfall

2024-01 Commitfest. Hi, This patch has a CF status of "Ready for Committer", but it is currently failing some CFbot tests [1]. Please have a look and post an updated version.. == [1] https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/46/3874 Kind Regards, Peter Smith.

Re: Evaluate arguments of correlated SubPlans in the referencing ExprState

2024-01 Commitfest. Hi, This patch has a CF status of "Ready for Committer", but it is currently failing some CFbot tests [1]. Please have a look and post an updated version.. == [1] https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/46/4209 Kind Regards, Peter Smith.

Re: the s_lock_stuck on perform_spin_delay

Hi, Andy Fan writes: > Hi, > > v6 attached which addressed all the items Robert suggested except the > following 2 open items. They are handled differently. > >> >> Here is the summary of the open-items, it would be great that Andres and >> Matthias have a look at this when they have time. >> >

Re: introduce dynamic shared memory registry

On Sun, Jan 21, 2024 at 11:21:46AM -0500, Tom Lane wrote: > Coverity complained about this: > > *** CID 1586660: Null pointer dereferences (NULL_RETURNS) > /srv/coverity/git/pgsql-git/postgresql/src/backend/storage/ipc/dsm_registry.c: > 185 in GetNamedDSMSegment() > 179 } > 180

Re: Things I don't like about \du's "Attributes" column

Another approach based on early suggestions. The Attributes column includes only the enabled logical attributes. Regardless of whether the attribute is enabled by default or not. This changes the current behavior, but makes it clearer: everything that is enabled is displayed. This principle is ea

Re: Patch: Improve Boolean Predicate JSON Path Docs

On Jan 21, 2024, at 14:58, David E. Wheeler wrote: > I make this interpretation based on this bit of the docs: Sorry, that’s from my branch. Here it is in master: A path expression can be a Boolean predicate, although the SQL/JSON standard allows predicates only in filters. This is necessa

Re: Patch: Improve Boolean Predicate JSON Path Docs

On Jan 21, 2024, at 14:52, David E. Wheeler wrote: > This is the only way the different behaviors make sense to me. @? expects a > set, not a boolean, sees there is an item in the set, so returns true: I make this interpretation based on this bit of the docs: PostgreSQL's implementation of

Re: index prefetching

On 19/01/2024 2:35 pm, Tomas Vondra wrote: On 1/19/24 09:34, Konstantin Knizhnik wrote: On 18/01/2024 6:00 pm, Tomas Vondra wrote: On 1/17/24 09:45, Konstantin Knizhnik wrote: I have integrated your prefetch patch in Neon and it actually works! Moreover, I combined it with prefetch of leaf

Re: Patch: Improve Boolean Predicate JSON Path Docs

On Jan 21, 2024, at 14:43, Tom Lane wrote: > I don't entirely buy this argument --- if that is the interpretation, > of what use are predicate check expressions? It seems to me that we > have to consider them as being a shorthand notation for filter > expressions, or else they simply do not make

Re: index prefetching

On 20/01/2024 12:14 am, Tomas Vondra wrote: Looks like I was not true, even if it is not index-only scan but index condition involves only index attributes, then heap is not accessed until we find tuple satisfying search condition. Inclusive index case described above (https://commitfest.postgr

Re: Patch: Improve Boolean Predicate JSON Path Docs

"David E. Wheeler" writes: > On Jan 20, 2024, at 12:34, Tom Lane wrote: >> It will take a predicate, but seems to always return true: >> >> regression=# select '{"a":[1,2,3,4,5]}'::jsonb @? '$.a[*] < 5' ; >> ?column? >> -- >> t >> (1 row) >> >> regression=# select '{"a":[1,2,3,4,5]}'::

Re: Patch: Improve Boolean Predicate JSON Path Docs

"David E. Wheeler" writes: > On Jan 20, 2024, at 12:34, Tom Lane wrote: >> Surely we're not helping anybody by leaving that behavior in place. >> Making it do something useful, throwing an error, or returning NULL >> all seem superior to this. I observe that @@ returns NULL for the >> path type

Re: Patch: Improve Boolean Predicate JSON Path Docs

On Jan 20, 2024, at 12:34, Tom Lane wrote: > It will take a predicate, but seems to always return true: > > regression=# select '{"a":[1,2,3,4,5]}'::jsonb @? '$.a[*] < 5' ; > ?column? > -- > t > (1 row) > > regression=# select '{"a":[1,2,3,4,5]}'::jsonb @? '$.a[*] > 5' ; > ?column? >

Re: [17] CREATE COLLATION default provider

On Thu, 2024-01-18 at 11:15 +0100, Peter Eisentraut wrote: > I wonder, however, how useful this would be in practice.  In most > interesting cases, you need to know what the provider is to be able > to > spell out the locale name appropriately.  The cases where some > overlap > exists, like the

Re: Patch: Improve Boolean Predicate JSON Path Docs

On Jan 20, 2024, at 11:45, Tom Lane wrote: > You sure about that? It would surprise me if we could effectively use > a not-equal condition with an index. If it is only == that works, > then the preceding statement seems sufficient. I’m not! I just assumed it in the same way creating an SQL = o

Re: Collation version tracking for macOS

On Sat, 2024-01-20 at 07:40 +0530, vignesh C wrote: > This thread has been idle for a year now, It has stalled after a lot > of discussion. > @Jeff Davis: Do you want to try to restart the discussion by posting > an updated version and see what happens? Thank you for following up. Yes, I'd like to

FEATURE REQUEST: Role vCPU limit/priority

It would be useful to have the ability to define for a role default vCPU affinity limits/thread priority settings so that more active sessions could coexist similar to MySQL resource groups . Best Regards, Yoni Sade

  1   2   >