On 04.06.24 18:41, Tom Lane wrote:
Relevant to this: I wonder what we think the supported macOS versions
are, anyway. AFAICS, the buildfarm only covers current (Sonoma)
and current-1 (Ventura) major versions, and only the latest minor
versions in those OS branches.
For other OS lines I think w
Hi. Here are some minor review comments for the docs patch v4-0001.
==
doc/src/sgml/logical-replication.sgml
1. General
The SGML file wrapping can be fixed to fill up to 80 cols for some of
the paragraphs.
~~~
2.
+ standby is promoted. They can continue subscribing to publications
now on
On 03.06.24 17:28, Nathan Bossart wrote:
I agree, two states should be enough. It could basically just be
pg_fsync(int fd)
{
#if macos
fcntl(fd, F_FULLFSYNC);
#else
fsync(fd);
#endif
}
IIUC with this approach, anyone who is using a file system that fails
fcntl(F_FULLSYNC) with ENOSUP
Hi,
This time at PGconf.dev[1], we had some discussions regarding this
project. The proposed approach is to split the work into two main
components. The first part focuses on conflict detection, which aims to
identify and report conflicts in logical replication. This feature will
enable users to m
On Wed, Jun 5, 2024 at 7:52 AM Zhijie Hou (Fujitsu)
wrote:
>
> Attach the V4 doc patch which addressed Peter and Bertrand's comments.
>
Few comments:
1.
+ On the subscriber node, use the following SQL to identify
+ which slots should be synced to the standby that we plan to promote.
On Tue, Jun 04, 2024 at 09:26:27AM -0400, Robert Haas wrote:
> On Mon, Jun 3, 2024 at 7:11 AM Bertrand Drouvot
> wrote:
> > We’d move the current buffer read and buffer hit counters from the relation
> > stats
> > to the relfilenode stats (while still being able to retrieve them from the
> > pg_s
At Tue, 20 Feb 2024 07:56:28 +0900, Michael Paquier wrote
in
> On Mon, Feb 19, 2024 at 10:26:43AM +0100, Tomas Vondra wrote:
> It just means that I am not much a fan of the signature changes done
> for RecordTransactionCommit() and AtEOXact_PgStat_Database(), adding a
> dependency to a specify L
> 6. Oracle
>
> Oracle PL/SQL allows the use of package variables. PL/SQL is +/- ADA
> language - and package variables are "global" variables. They are not
> directly visible from SQL, but Oracle allows reduced syntax for functions
> without arguments, so you need to write a wrapper
>
> CREATE OR
Bruce Momjian писал(а) 2024-06-04 20:12:
On Mon, May 27, 2024 at 09:30:59PM +,
fujii.y...@df.mitsubishielectric.co.jp wrote:
Hi Mr. Pyhalov.
Sorry for the late reply.
Thank you for your modification and detailed review.
I attach a fixed patch, have been not yet rebased.
I know this patch
On Tue, Jun 04, 2024 at 10:10:06AM -0700, Jacob Champion wrote:
> On Mon, Jun 3, 2024 at 9:32 PM Kyotaro Horiguchi
> wrote:
>> I understand that the part enclosed in parentheses refers to the "if
>> (ptr) pfree(ptr)" structure. I believe we rely on the behavior of
>> free(NULL), which safely does
On Tue, Jun 04, 2024 at 04:16:43PM +0200, Alexander Kukushkin wrote:
> Now that beta1 was released I hope you are not so busy and hence would like
> to follow up on this problem.
I am still working on something for the v18 cycle that I'd like to
present before the beginning of the next commit fest
On Wed, Jun 05, 2024 at 01:12:41PM +0900, Kyotaro Horiguchi wrote:
> At Mon, 27 May 2024 11:31:24 -0300, Ranier Vilela wrote
> in
>> The function *plpgsql_inline_handler* can use uninitialized
>> variable retval, if PG_TRY fails.
>> Fix like function*plpgsql_call_handler* wich declare retval as
On Tue, Jun 04, 2024 at 03:50:51PM -0500, Nathan Bossart wrote:
> Bharath, does the multi-INSERT stuff apply when changing a table to be
> LOGGED? If so, I think it would be interesting to compare it with the FPI
> approach being discussed here.
The answer to this question is yes AFAIK. Look at
At Mon, 27 May 2024 11:31:24 -0300, Ranier Vilela wrote
in
> Hi.
>
> The function *plpgsql_inline_handler* can use uninitialized
> variable retval, if PG_TRY fails.
> Fix like function*plpgsql_call_handler* wich declare retval as
> volatile and initialize to (Datum 0).
If PG_TRY fails, retval
On Mon, Jun 03, 2024 at 03:24:07PM -0700, Andres Freund wrote:
> I'm confused - isn't using common/int.h entirely sufficient for that? Nearly
> all architectures have more efficient ways to check for 64bit overflows than
> doing actual 128 bit math.
One simple way to change the assertion would be
On Tue, Jun 4, 2024 at 8:56 PM Yogesh Sharma
wrote:
>
> On 6/4/24 06:57, Amit Kapila wrote:
>
> > 2. Provide a command say Alter Subscription ... Replicate Sequences
> > (or something like that) which users can perform before shutdown of
> > the publisher node during upgrade. This will allow copy
On Tue, Jun 4, 2024 at 9:37 AM Amit Kapila wrote:
>
> > >
> > > >
> > > > Conflict Resolution
> > > >
> > > > a) latest_timestamp_wins:The change with later commit timestamp
> > > > wins.
> > > > b) earliest_timestamp_wins: The change with earlier commit timestamp
> > > >
On Tue, Jun 4, 2024 at 7:40 PM Ashutosh Bapat
wrote:
>
> On Tue, Jun 4, 2024 at 4:27 PM Amit Kapila wrote:
>>
>>
>> 3. Replicate published sequences via walsender at the time of shutdown
>> or incrementally while decoding checkpoint record. The two ways to
>> achieve this are: (a) WAL log a speci
On Wed, May 15, 2024 at 03:21:36PM -0500, Nathan Bossart wrote:
> Nice! I'll plan on taking a closer look at this one.
LGTM. I've marked the commitfest entry as ready-for-committer.
--
nathan
On Thursday, May 23, 2024 1:34 PM Peter Smith wrote:
Thanks for the comments. I addressed most of the comments except the
following one which I am not sure:
> 5b.
> Patch says "on the subscriber node", but isn't that the simplest case?
> e.g. maybe there are multiple nodes having subscriptions f
On Wednesday, May 8, 2024 5:21 PM Bertrand Drouvot
wrote:
> A few comments:
Thanks for the comments!
> 2 ===
>
> +test_sub=# SELECT
> + array_agg(slotname) AS slots
> + FROM
> + ((
> + SELECT r.srsubid AS subid, CONCAT('pg_', srsubid, '_sync_',
>
On Wed, Jun 5, 2024 at 12:14:45AM +,
fujii.y...@df.mitsubishielectric.co.jp wrote:
> I will add sufficient document and comments to the next patch as Bruce and
> Robert said.
Great, I am available to help improve the documentation.
--
Bruce Momjian https://momjian.us
EDB
Hi. Tender.
Thank you for modification.
> From: Tender Wang
> Sent: Tuesday, June 4, 2024 7:51 PM
> Please add more tests. Especially please add some negative tests;
> current patch checks that it is safe to apply materialization. It would
> be helpful to add tests checking th
On Wed, May 22, 2024 at 2:17 PM Ajin Cherian wrote:
>
> The reason for the crash is that the RelationSyncCache was NULL prior to
> reaching a consistent point.
> Hi li jie, I see that you created a new thread with an updated version of
> this patch [1]. I used that patch and addressed the crash s
On Jun 4, 2024, at 12:28 PM, David G. Johnston
wrote:
> This seems to be working correctly. Lax mode causes the first array level to
> unwrap and produce new context item values. Then the wildcard member
> accessor is applied to each. Numbers don’t have members so no matches exist
> in the
On Mon, Jun 3, 2024 at 9:52 PM Shlok Kyal wrote:
>
> >
> > The attached Patch contains the suggested changes.
> >
>
> Hi,
>
> Currently, COPY command does not work for generated columns and
> therefore, COPY of generated column is not supported during tablesync
> process. So, in patch v4-0001 we a
On Tue, May 21, 2024 at 04:29:54PM +0500, Andrey M. Borodin wrote:
> Currently I'm working on the test using this
> $creator->query_until(qr/start/, q(
> \echo start
> select injection_points_wakeup('');
> select test_create_multixact();
> ));
>
> I'm fine if instead of injection_point
Erik Wienhold writes:
> On 2024-06-03 18:57 +0200, Tom Lane wrote:
>> So your thought that we should just not use throw_tcl_error here
>> was correct, and a minimal fix could look like the attached.
> LGTM.
Pushed, thanks.
regards, tom lane
+Bharath
On Tue, Jun 04, 2024 at 04:00:32PM +0900, Kyotaro Horiguchi wrote:
> At Tue, 4 Jun 2024 09:09:12 +0900, Michael Paquier
> wrote in
>> Another point that Nathan has made is that it may be more appealling
>> to study how this is better than an integration with the multi-INSERT
>> APIs in
Nathan Bossart writes:
> On Tue, Jun 04, 2024 at 02:28:43PM -0400, Tom Lane wrote:
>> Hence, new patch attached, now with docs and tests. Barring
>> objections I'll push this one.
> Should we expand the documentation for SPI_connect_ext() to note that
> SPI_execute_extended()/SPI_execute_plan_ex
On Tue, Jun 04, 2024 at 02:28:43PM -0400, Tom Lane wrote:
> Actually, after poking around some more I found that there *is* a way
> to deal with this within spi.c: we can make _SPI_execute_plan ignore
> options->allow_nonatomic unless the SPI_OPT_NONATOMIC flag was given
> when connecting.
>
> I l
I noticed that the "Restoring database schemas in the new cluster" part of
pg_upgrade can take a while if you have many databases, so I experimented
with a couple different settings to see if there are any easy ways to speed
it up. The FILE_COPY strategy for CREATE DATABASE helped quite
significan
I wrote:
> I poked into this and found that the source of the problem is that
> plpgsql's exec_stmt_call passes allow_nonatomic = true even when
> it's running in an atomic context. So we can fix it with basically
> a one-line change:
> - options.allow_nonatomic = true;
> + options.allow_
On 2024-06-04 13:21 +0200, Dean Rasheed wrote:
> Committed and back-patched to v16. Thanks for the report and patch.
Thanks for the review and push Dean.
--
Erik
On Tue, Jun 4, 2024 at 1:47 AM Alexander Korotkov wrote:
> On Mon, Jun 3, 2024 at 6:55 PM Pavel Borisov wrote:
> > On Sun, 2 Jun 2024 at 17:18, Alexander Korotkov
> > wrote:
> >> On Sun, Jun 2, 2024 at 10:55 AM jian he
> >> wrote:
> >> >
> >> > On Fri, May 31, 2024 at 8:12 AM Alexander Korotk
On Tue, Jun 4, 2024 at 12:56 PM Peter Eisentraut wrote:
> Experimental is probably too harsh a word now.
>
> But it doesn't have feature parity with configure/make yet (for example,
> no .bc files), so I wouldn't recommend it for production or packaging
> builds.
That's unfortunate. :-(
> Then,
On Mon, May 27, 2024 at 09:30:59PM +,
fujii.y...@df.mitsubishielectric.co.jp wrote:
> Hi Mr. Pyhalov.
>
> Sorry for the late reply.
> Thank you for your modification and detailed review.
> I attach a fixed patch, have been not yet rebased.
I know this patch was discussed at the Vancouver con
On Mon, Jun 3, 2024 at 9:32 PM Kyotaro Horiguchi
wrote:
>
> Hi,
Thanks for the review!
> I understand that the part enclosed in parentheses refers to the "if
> (ptr) pfree(ptr)" structure. I believe we rely on the behavior of
> free(NULL), which safely does nothing. (I couldn't find the related
On 04.06.24 17:24, Robert Haas wrote:
On Wed, May 29, 2024 at 2:41 AM Peter Eisentraut wrote:
"Alternatively, PostgreSQL can be built using Meson. This is the only
option for building PostgreSQL in Windows using Visual Something[*].
For other platforms, using Meson is currently experimental."
Peter Eisentraut writes:
> With the native compiler tooling on macOS, it is not safe to assume
> anything, including that the man pages are accurate or that the
> documented options actually work correctly and don't break anything
> else. Unless we have actual testing on all the supported macO
On 04/06/2024 18:28, Dave Page wrote:
I clearly missed the discussion in which it was decided to remove the
old MSVC++ support from the tree (and am disappointed about that as I
would have objected loudly). Having recently started testing Meson on
Windows when I realised that change had been ma
Andres Freund:
Gah. Apples tendency to just break stuff that has worked across *nix-y
platforms for decades is pretty annoying. They could just have made
--export-dynamic an alias for --export_dynamic, but no, everyone needs a
special macos thingy in their build scripts.
Interesting enough my L
On Tuesday, June 4, 2024, David E. Wheeler wrote:
> Hackers,
>
> The behavior of the .* jpiAnyKey jsonpath selector seems incorrect.
>
> ```
> select jsonb_path_query('[1,2,3]', '$.*');
> jsonb_path_query
> --
> (0 rows)
>
> select jsonb_path_query('[1,2,3,{"b": [3,4,5]}]', '$.*')
Hackers,
The behavior of the .* jpiAnyKey jsonpath selector seems incorrect.
```
select jsonb_path_query('[1,2,3]', '$.*');
jsonb_path_query
--
(0 rows)
select jsonb_path_query('[1,2,3,{"b": [3,4,5]}]', '$.*');
jsonb_path_query
--
[3, 4, 5]
```
The first exampl
On 2024-Jun-03, Masahiko Sawada wrote:
> Commit 667e65aac3 changed num_dead_tuples and max_dead_tuples columns
> to dead_tuple_bytes and max_dead_tuple_bytes columns, respectively.
> But at PGConf.dev, I got feedback from multiple people that
> num_dead_tuples information still can provide meaning
On Tue, 4 Jun 2024 at 16:25, Robert Haas wrote:
> On Wed, May 29, 2024 at 2:41 AM Peter Eisentraut
> wrote:
> > "Alternatively, PostgreSQL can be built using Meson. This is the only
> > option for building PostgreSQL in Windows using Visual Something[*].
> > For other platforms, using Meson is
On 6/4/24 06:57, Amit Kapila wrote:
1. Provide a tool to copy all the sequences from publisher to
subscriber. The major drawback is that users need to perform this as
an additional step during the upgrade which would be inconvenient and
probably not as useful as some built-in mechanism.
Agree,
On Wed, May 29, 2024 at 2:41 AM Peter Eisentraut wrote:
> "Alternatively, PostgreSQL can be built using Meson. This is the only
> option for building PostgreSQL in Windows using Visual Something[*].
> For other platforms, using Meson is currently experimental."
Is it, though? I feel like we're b
On Sat, May 25, 2024 at 6:40 AM Jelte Fennema-Nio wrote:
> Of the proposed changes so far on the mailing list the only 2 that
> would fall under 1 imho are:
> 1. The ParameterSet message
> 2. Longer than 32bit secret in BackendKeyData
Yeah. I wonder how Heikki thinks he can do (2) without breakin
On Fri, May 24, 2024 at 6:09 PM Jelte Fennema-Nio wrote:
> Separating it from the GUC infrastructure will mean we need to
> duplicate a lot of the infrastructure. Assuming we don't care about
> SHOW or pg_settings (which I agree are not super important), the
> things that we would want for protoco
Hi Michael and Kyotaro,
Now that beta1 was released I hope you are not so busy and hence would like
to follow up on this problem.
Regards,
--
Alexander Kukushkin
On Fri, May 24, 2024 at 4:00 PM Tom Lane wrote:
> > Oh! That does seem like it would make what I said wrong, but how would
> > it even know who the original owner was? Shouldn't we be recreating
> > the object with the owner it had at dump time?
>
> Keep in mind that the whole point here is for th
Andy Fan wrote:
> Antonin Houska writes:
>
> >> Could you make the reason clearer for adding 'List *opfamily_lists;'
> >> into UniqueKey? You said "This is needed to create ECs in the parent
> >> query if the upper relation represents a subquery." but I didn't get the
> >> it. Since we need to
On Tue, Jun 4, 2024 at 4:27 PM Amit Kapila wrote:
>
> 3. Replicate published sequences via walsender at the time of shutdown
> or incrementally while decoding checkpoint record. The two ways to
> achieve this are: (a) WAL log a special NOOP record just before
> shutting down checkpointer. Then al
On Tue, May 28, 2024 at 9:06 PM Hannu Krosing wrote:
> We should definitely also fix pg_dump, likely just checking that the
> role exists when generating REVOKE commands (may be a good practice
> for other cases too so instead of casting to ::regrole do the actual
> join)
>
> ## here is the fix f
On Mon, Jun 3, 2024 at 7:11 AM Bertrand Drouvot
wrote:
> The main argument is that we currently don’t have writes counters for
> relations.
> The reason is that we don’t have the relation OID when writing buffers out.
OK.
> Second argument is that this is also beneficial for the "Split index an
On Tue, May 21, 2024 at 08:33:51AM -0500, Justin Pryzby wrote:
> It occurred to me that psql \dP+ should show the AM of partitioned
> tables (and other partitioned rels).
ping
On Tue, Jun 4, 2024 at 4:53 PM Bharath Rupireddy
wrote:
>
> On Tue, Jun 4, 2024 at 4:27 PM Amit Kapila wrote:
> >
> > 3. Replicate published sequences via walsender at the time of shutdown
> > or incrementally while decoding checkpoint record. The two ways to
> > achieve this are: (a) WAL log a s
On 2024-06-02 Su 16:00, Alexander Lakhin wrote:
02.06.2024 21:39, Andrew Dunstan wrote:
Maybe uploading this log file too would help to understand what is the
cause of the failure...
Yeah, I'll fix that.
Thank you, Andrew!
Could you also take a look at:
https://buildfarm.postgresql.or
Hi,
On Tue, Jun 4, 2024 at 4:27 PM Amit Kapila wrote:
>
> 3. Replicate published sequences via walsender at the time of shutdown
> or incrementally while decoding checkpoint record. The two ways to
> achieve this are: (a) WAL log a special NOOP record just before
> shutting down checkpointer. The
On Fri, 17 May 2024 at 09:22, Dean Rasheed wrote:
>
> On Wed, 15 May 2024 at 02:14, Erik Wienhold wrote:
> >
> > plpgsql fails to parse 1_000..1_000 as 1000..1000 in FOR loops:
> >
> > Fixed in the attached patch.
> >
>
> Nice catch! The patch looks good to me on a quick read-through.
>
> I'll ta
In the past, we have discussed various approaches to replicate
sequences by decoding the sequence changes from WAL. However, we faced
several challenges to achieve the same, some of which are due to the
non-transactional nature of sequences. The major ones were: (a)
correctness of the decoding part
Tomasz Rybak 于2024年5月31日周五 04:21写道：
> On Tue, 2024-04-23 at 16:59 +0800, Tender Wang wrote:
> >
> [ cut ]
> >
> > I have rebased master and fixed a plan diff case.
>
> We (me, Paul Jungwirth, and Yuki Fujii) reviewed this patch
> at PgConf.dev Patch Review Workshop.
>
Thanks for reviewing this p
On Tue, Jun 4, 2024 at 2:20 AM Tom Lane wrote:
> Peter Eisentraut writes:
> > On 02.06.24 21:46, Tom Lane wrote:
> >> If you don't
> >> like our current behavior, then either you have to say that RETURNING
> >> with a length-limited target type is illegal (which is problematic
> >> for the spec,
Hi Kyotaro,
Thank you for the response.
At 2024-06-04 14:44:09, "Kyotaro Horiguchi" wrote:
>At Tue, 28 May 2024 20:15:59 +0800 (CST), "Long Song"
>wrote in
>>
>> Hi,
>> Actually, I still wonder why only the error message
>> of the last failure to close the file was recorded.
>> For this unu
Hello Andres,
So it looks like the issue resolved, but there is another apparently
performance-related issue: deadlock-parallel test failures.
I reduced test concurrency a bit. I hadn't quite realized how the buildfarm
config and meson test concurrency interact. But there's still something off
Hi,
Here are some review comments for patch v5-0003.
==
0. Whitespace warnings when the patch was applied.
[postgres@CentOS7-x64 oss_postgres_misc]$ git apply
../patches_misc/v5-0003-Support-copy-of-generated-columns-during-tablesyn.patch
../patches_misc/v5-0003-Support-copy-of-generated-col
On Thu, 23 May 2024 at 04:26, David Rowley wrote:
>
> On Sun, 19 May 2024 at 15:20, David Rowley wrote:
> >
> > I noticed that PlannedStmt.hasReturning and hasModifyingCTE have an
> > outdated comment now that MERGE supports RETURNING (per commit
> > c649fa24a)
> >
> > i.e. these two:
> >
> > > b
At Tue, 28 May 2024 20:15:59 +0800 (CST), "Long Song"
wrote in
>
> Hi,
> Actually, I still wonder why only the error message
> of the last failure to close the file was recorded.
> For this unusual situation, it is acceptable to
> record all failure information without causing
> too much loggin
On 03.06.24 17:07, Wolfgang Walther wrote:
I don't mind addressing this in PG18, but I would hesitate with
backpatching. With macOS, it's always hard to figure out whether
these kinds of options work the same way going versions back.
All the versions for ld64 are in [1]. It seems this was int
On 04.06.24 02:11, Laurenz Albe wrote:
On Mon, 2024-06-03 at 15:38 -0400, Tom Lane wrote:
Andres Freund writes:
On 2024-06-03 14:43:17 -0400, David E. Wheeler wrote:
* The ABI is guaranteed to change only in backward compatible ways in minor
releases. If for some reason it doesn’t it’s a bug
On 29.05.24 08:47, Sutou Kouhei wrote:
In <4707d4ed-f268-43c0-b4dd-cdbc7520f...@eisentraut.org>
"Re: meson: Specify -Wformat as a common warning flag for extensions" on
Tue, 28 May 2024 23:31:05 -0700,
Peter Eisentraut wrote:
On 07.04.24 18:01, Sutou Kouhei wrote:
+# We don't have "war
72 matches
Mail list logo
