Re: Proposal to add page headers to SLRU pages

2023-12-18 Thread Bagga, Rishu
On Thu, Dec 8, 2023 at 1:36 AM Li, Yong wrote: >Given so many different approaches were discussed, I have started a >wiki to record and collaborate all efforts towards SLRU >improvements. The wiki provides a concise overview of all the ideas >discussed and can serve as a portal for all

Re: SLRUs in the main buffer pool - Page Header definitions

2023-09-07 Thread Bagga, Rishu
Alekseev, Aleksander (aleksan...@timescale.com) wrote: > It looks like the patch in *this* thread was never registered on the > commitfest and/or tested by CF bot, unless I'm missing something. > Unfortunately it's a bit late to register it for the September CF > especially considering the fact

Shortening the Scope of Critical Section in Creation of New MultiXacts

2022-12-13 Thread Bagga, Rishu
Hi all, I have been going through the multixact code over the last few weeks, and noticed a potential discrepancy between the need for critical sections in the creation of new multixacts and the current code. As per the comment in GetNewMultiXact: /* * Critical section from

Re: SLRUs in the main buffer pool, redux

2022-09-16 Thread Bagga, Rishu
Hi Thomas, While I was working on adding the page headers to SLRU pages on your patch, I came across this code where it seems like "MultiXactIdToMemberPage" is mistakenly being used instead of MultiXactIdToOffsetPage in the TrimMultiXact function. Below is the area of concern in the patch:

Re: SLRUs in the main buffer pool - Page Header definitions

2022-06-23 Thread Bagga, Rishu
Hi, On 2022-06-23 20:25:21 +, Bagga, Rishu wrote: > >> 3. A flag to identify if the page is a relational or BufferedObject > >Why is this needed in the page header? > > Now that we are dealing with two different type of page headers, we need to >

Re: SLRUs in the main buffer pool - Page Header definitions

2022-06-23 Thread Bagga, Rishu
t)) Additionally, we need to account for the size of the page header when reading and writing multixacts in memory based off of the entryno. Rishu Bagga Amazon Web Services (AWS) On 6/22/22, 2:40 PM, "Andres Freund" wrote: Hi, On 2022-06-22 21:06:29 +, Bagga, Rishu wr

SLRUs in the main buffer pool - Page Header definitions

2022-06-22 Thread Bagga, Rishu
Hi all, PostgreSQL currently maintains several data structures in the SLRU cache. The SLRU cache has scaling and sizing challenges because of it’s simple implementation. The goal is to move these caches to the common buffer cache to benefit from the stronger capabilities of the common buffercache