Translatable strings with formatting of 64bit values

2018-04-25 Thread Ildus Kurbangaliev
quot;setval: value %s is out of bounds for sequence \"%\" (%..%)" msgstr "setval передано значение %s вне пределов последовательности \"%s\" (%s..%s)" And still this string will be translatable. I found a bunch of places when PRIx64 macros can simplify the code. -

Re: [HACKERS] Custom compression methods

2018-04-23 Thread Ildus Kurbangaliev
ession could be time series compression described in [1]. [2] contains an example of an extension that adds lz4 compression using this patch. [1] http://www.vldb.org/pvldb/vol8/p1816-teller.pdf [2] https://github.com/zilder/pg_lz4 -- Regards, Ildus Kurbangaliev

Re: [HACKERS] Custom compression methods

2018-04-23 Thread Ildus Kurbangaliev
On Sun, 22 Apr 2018 16:21:31 +0300 Alexander Korotkov <a.korot...@postgrespro.ru> wrote: > On Fri, Apr 20, 2018 at 7:45 PM, Konstantin Knizhnik < > k.knizh...@postgrespro.ru> wrote: > > > On 30.03.2018 19:50, Ildus Kurbangaliev wrote: > > > >> On

Re: Prefix operator for text and spgist support

2018-04-16 Thread Ildus Kurbangaliev
n the documentation too. I was going to add btree support but it would require a new strategy so it will be matter of another patch. I think this operator could be used in LIKE instead of current weird comparison operators. -- --- Ildus Kurbangaliev Postgres Professional: http://www.postgrespro.com Russian Postgres Company

Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors

2018-04-05 Thread Ildus Kurbangaliev
inion Debuglevel should be renamed to DebugLevel that looks nicer, also there DEBUGLEVEl (where last letter is in lower case) which is very confusing. I have checked overall functionality of this patch, but haven't checked any special cases yet. -- --- Ildus Kurbangaliev Postgres Professional: http://www.postgrespro.com Russian Postgres Company

Re: Prefix operator for text and spgist support

2018-03-29 Thread Ildus Kurbangaliev
ry discussion. However, > personally I don't > have better ideas :) Teodor, Alexander, thanks for review. In new version I have added the optimization in spgist using level variable and also got rid of magic numbers. About the operator it's actually ^@ (not @^ :)), I thought about

Re: committing inside cursor loop

2018-03-28 Thread Ildus Kurbangaliev
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed I have checked new version. Although I can miss something,

Re: [PROPOSAL] Shared Ispell dictionaries

2018-03-19 Thread Ildus Kurbangaliev
en mmap approach will possibly require new folder in data directory and management above bunch of new files, with additional issues related with pg_upgrade and etc. Also in dsm approach if someone needs to update dictionaries then he (or his package manager) can just replace files and be done wit

Re: committing inside cursor loop

2018-03-14 Thread Ildus Kurbangaliev
On Tue, 13 Mar 2018 11:08:36 -0400 Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 3/6/18 07:48, Ildus Kurbangaliev wrote: > > Although as was discussed before it seems inconsistent without > > ROLLBACK support. There was a little discussion about it, but

Re: Prefix operator for text and spgist support

2018-03-12 Thread Ildus Kurbangaliev
On Tue, 6 Mar 2018 19:27:21 +0300 Arthur Zakirov <a.zaki...@postgrespro.ru> wrote: > On Mon, Feb 19, 2018 at 05:19:15PM +0300, Ildus Kurbangaliev wrote: > > At brief look at this place seems better to move this block into > > pattern_fixed_prefix function. But there is al

Re: committing inside cursor loop

2018-03-06 Thread Ildus Kurbangaliev
ts are there. Although as was discussed before it seems inconsistent without ROLLBACK support. There was a little discussion about it, but no replies. Maybe the status of the patch should be changed to 'Waiting on author' until the end of discussion. -- --- Ildus Kurbangaliev Postgres Professi

Re: 2018-03 Commitfest Summary (Andres #3)

2018-03-02 Thread Ildus Kurbangaliev
egression tests (becauses it adds new field in \d+) and new tests. -- --- Ildus Kurbangaliev Postgres Professional: http://www.postgrespro.com Russian Postgres Company

Re: autovacuum: change priority of the vacuumed tables

2018-03-02 Thread Ildus Kurbangaliev
> thus isn't v11 material, and should be marked as 'returned with > feedback'? Hi, I agree, this patch definitely needs more thinking. -- --- Ildus Kurbangaliev Postgres Professional: http://www.postgrespro.com Russian Postgres Company

Re: autovacuum: change priority of the vacuumed tables

2018-02-19 Thread Ildus Kurbangaliev
On Fri, 16 Feb 2018 21:48:14 +0900 Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Fri, Feb 16, 2018 at 7:50 PM, Ildus Kurbangaliev > <i.kurbangal...@postgrespro.ru> wrote: > > On Fri, 16 Feb 2018 17:42:34 +0900 > > Masahiko Sawada <sawada.m...@gmail.com&

Re: autovacuum: change priority of the vacuumed tables

2018-02-16 Thread Ildus Kurbangaliev
On Fri, 16 Feb 2018 17:42:34 +0900 Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Thu, Feb 15, 2018 at 10:16 PM, Grigory Smolkin > <g.smol...@postgrespro.ru> wrote: > > On 02/15/2018 09:28 AM, Masahiko Sawada wrote: > > > >> Hi, > >> > >

autovacuum: change priority of the vacuumed tables

2018-02-08 Thread Ildus Kurbangaliev
. -- --- Regards, Ildus Kurbangaliev diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index c45979dee4..b7383a7136 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -6250,6 +6250,21 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv

Prefix operator for text and spgist support

2018-02-02 Thread Ildus Kurbangaliev
of ~>=~ and ~<~ in the future. But it would require new strategy for btree. -- --- Ildus Kurbangaliev Postgres Professional: http://www.postgrespro.com Russian Postgres Company diff --git a/src/backend/access/spgist/spgtextproc.c b/src/backend/access/spgist/spgtextproc.c index f156b2166e..5beb9e33a1

Re: [HACKERS] Custom compression methods

2018-01-29 Thread Ildus Kurbangaliev
pro/jsonbd > Thank you! About cmdrop, I checked that's is called manually, but going to check it thoroughly in my extension. -- --- Ildus Kurbangaliev Postgres Professional: http://www.postgrespro.com Russian Postgres Company

Re: [PROPOSAL] Shared Ispell dictionaries

2018-01-25 Thread Ildus Kurbangaliev
operty of dictionary) or UseSharedMemory, the boolean option called SharedMemory sounds weird. Overall the patches look good, all tests passed. I tried to broke it in few places where I thought it could be unsafe but not succeeded. -- --- Ildus Kurbangaliev Postgres Professional

Re: [HACKERS] Custom compression methods

2017-12-18 Thread Ildus Kurbangaliev
On Thu, 14 Dec 2017 10:29:10 -0500 Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Dec 13, 2017 at 7:18 AM, Ildus Kurbangaliev > <i.kurbangal...@postgrespro.ru> wrote: > > Since we agreed on ALTER syntax, i want to clear things about > > CREATE. Should it b

Re: [HACKERS] Custom compression methods

2017-12-13 Thread Ildus Kurbangaliev
I'd like to keep extra compression options, for example pglz can be configured with them. Syntax would be slightly changed: SET COMPRESSION pglz WITH (min_comp_rate=25) PRESERVE awesome; Setting the same compression method with different options will create new compression options record for f

Re: [HACKERS] Custom compression methods

2017-12-12 Thread Ildus Kurbangaliev
instead provide infrastructure for > doing that in the datatype code directly. > > The other question is if the patch should introduce some > infrastructure for handling the column context (e.g. column > dictionary). Right now, whoever implements the compression has to > implement this bit too. Column specific storage sounds optional to me. For example compressing timestamp[] using some delta compression will not require it. -- Regards, Ildus Kurbangaliev

Re: [HACKERS] Custom compression methods

2017-12-11 Thread Ildus Kurbangaliev
e is current and which ones should be kept. -- Regards, Ildus Kurbangaliev

Re: [HACKERS] Custom compression methods

2017-12-06 Thread Ildus Kurbangaliev
require Oids in tuples), but it could be unusable. -- ---- Regards, Ildus Kurbangaliev

Re: [HACKERS] Custom compression methods

2017-12-01 Thread Ildus Kurbangaliev
on, then it could be nicer than CREATE COMPRESSION METHOD. I just don't know that compression could go as access method or not. Anyway it's easy to change syntax and I don't mind to do it, if it will be neccessary for the patch to be commited. -- Regards, Ildus Kurbangaliev

Re: [HACKERS] Custom compression methods

2017-11-24 Thread Ildus Kurbangaliev
peat(md5(i::text),300) from generate_series(1,10) s(i); \d+ List of relations Schema | Name | Type | Owner | Size | Description +--+---+---+-+- public | t1 | table | ildus | 18 MB | public | t2 | table | ildus | 1

Re: [HACKERS] Custom compression methods

2017-11-20 Thread Ildus Kurbangaliev
table is big, decompression could take an eternity. That's why i decided to only to disable it and the data could be decompressed using compression options. My idea was to keep compression options forever, since there will not be much of them in one database. Still that requires that extension is no

Re: Repetitive code in RI triggers

2017-11-17 Thread Ildus Kurbangaliev
On Fri, 17 Nov 2017 15:05:31 + Ildus Kurbangaliev <i.kurbangal...@gmail.com> wrote: > The following review has been posted through the commitfest > application: make installcheck-world: tested, failed > Implements feature: tested, failed > Spec compliant:

Re: Repetitive code in RI triggers

2017-11-17 Thread Ildus Kurbangaliev
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, failed Spec compliant: tested, failed Documentation:tested, failed The patch looks good. It just removes repetitive code and I