Re: proposal: pg_restore --convert-to-text

2019-03-17 Thread José Arthur Benetasso Villanova
On Sat, 16 Mar 2019, Euler Taveira wrote: I think the former one looks like pretty, but which one is preffered? I don't have a style preference but decided to change to your suggestion. New version attached. Again, the patch compiles and works as expected. -- José Arthur Bene

RE: proposal: pg_restore --convert-to-text

2019-03-06 Thread José Arthur Benetasso Villanova
On Thu, 28 Feb 2019, Imai, Yoshikazu wrote: Is there no need to rewrite the Description in the Doc to state we should specify either -d or -f option? (and also it might be better to write if -l option is given, neither -d nor -f option isn't necessarily needed.) Since the default part of

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

2019-01-13 Thread José Arthur Benetasso Villanova
On Sun, 14 Oct 2018, Matheus de Oliveira wrote: Updated the last patch so it can apply cleanly on HEAD. Hi Matheus. I applied your patch on top of bb874e30fbf9e85bdb117bad34865a5fae29dbf6. It compiled, worked as expected, but some tests broke executing make check: test create_table