Hi again,
> It looks like we can check increments in all fields playing with
transactions in tests.
I've added such tests.
Regards,
Sergey
From 66ac1efe5424aa1385744a60047ffd44d42dd244 Mon Sep 17 00:00:00 2001
From: Sergey Dudoladov
Date: Thu, 1 Feb 2024 16:11:36 +0100
Subject: [PATCH]
r the relevant counters. With that I still would like to maintaint the
focus on committing the "idle in transactions" part of pg_stat_session
first.
Regards,
Sergey
From 05f5117be52b613bb9d4833eec38e152c6f9 Mon Sep 17 00:00:00 2001
From: Sergey Dudoladov
Date: Thu, 1 Feb 2024 16:11
s it should not be empty at the ongoing development stage.
Attached a small modification of the patch with a draft of the docs.
Regards,
Sergey Dudoladov
From d4050be4bfd0a518eba0ff0a7b561f0420be9861 Mon Sep 17 00:00:00 2001
From: Sergey Dudoladov
Date: Wed, 2 Aug 2023 16:47:35 +0200
Subject: [PATCH] B
connection time)
Without pg_stat_session:
latency average = 327.370 ms
tps = 3.054651 (without initial connection time)
Regards,
Sergey
From 329db9a594b96499135bcbfdfad674f6af7ae1dc Mon Sep 17 00:00:00 2001
From: Sergey Dudoladov
Date: Tue, 22 Nov 2022 09:23:32 +0100
Subject: [PATCH] Add
Hello,
I have attached the fourth version of the patch.
Regards,
Sergey.
From 0303df03496ec9aafd6e69fa798177ad06a85bee Mon Sep 17 00:00:00 2001
From: Sergey Dudoladov
Date: Tue, 8 Nov 2022 18:56:26 +0100
Subject: [PATCH] Introduce 'log_connection_messages'
This patch removes 'log_connections
Hello hackers,
I've sketched the first version of a patch to add pg_stat_session.
Please review this early version.
Regards,
Sergey.
From 31f781ecd69fc42aaadd9bcdbebaf8f72449946c Mon Sep 17 00:00:00 2001
From: Sergey Dudoladov
Date: Tue, 22 Nov 2022 09:23:32 +0100
Subject: [PATCH] Add
Hi again,
Justin, thank you for the fast review. The new version is attached.
Regards,
Sergey Dudoladov
From 994a86e6ac3abb647d93bdaf0f42be76f42b83a8 Mon Sep 17 00:00:00 2001
From: Sergey Dudoladov
Date: Tue, 8 Nov 2022 18:56:26 +0100
Subject: [PATCH] Introduce 'log_connection_messages
y properly
in the special case log_connection_messages = 'all'
+ the GUC option is now only GUC_LIST_INPUT
+ typo fixes and line rewrapping in the docs
Regards,
Sergey
From 4bf99bccb4b278188dbc679f00d506cd35b025f5 Mon Sep 17 00:00:00 2001
From: Sergey Dudoladov
Date: Tue, 8 Nov 2022 18:56:26 +01
Hi hackers,
I've sketched an initial patch version; feedback is welcome.
Regards,
Sergey Dudoladov
From be2e6b5c2d6fff1021f52f150b4d849dfbd26ec7 Mon Sep 17 00:00:00 2001
From: Sergey Dudoladov
Date: Tue, 8 Nov 2022 18:56:26 +0100
Subject: [PATCH] Introduce 'log_connection_messages'
This patch
eal for us.
Regards,
Sergey Dudoladov
Hi again,
Having played with the task for a little while, I am no longer sure
it completely justifies the effort involved.
The reason being the task requires modifying the buffer pool in one
way or the other, which implies
(a) significant effort on performance testing and
(b) changes in the
:00:00 2001
From: Sergey Dudoladov
Date: Wed, 20 Apr 2022 23:47:37 +0200
Subject: [PATCH] pg_stat_activity: add 'total_active_time' and
'total_idle_in_transaction_time'
catversion bump because of the change in the contents of pg_stat_activity
Author: Sergey Dudoladov, based on the initial version
Hello,
Thank you for the constructive feedback.
> Your proposal will add more confusion to the already-confused logging-related
> GUCs.
> I wouldn't introduce a new GUC that depends on the stage of other GUC as you
> proposed.
Agreed, coupling a new GUC with "log_connections" is likely to
Hello,
The problem we face is excessive logging of connection information
that clutters the logs and in corner cases with many short-lived
connections leads to disk space exhaustion.
Current connection log lines share significant parts of the
information - host, port, very close timestamps etc.
Hello,
thanks for the helpful review. I have incorporated most of the
suggestions into the patch. I have also rebased and tested the patch
on top of the current master (2cd2569c72b89200).
> + int64 active_time_diff = 0;
> + int64 transaction_idle_time_diff = 0;
>
Hello,
I would like to get some feedback on that task.
> pg_statio_*_tables.idx_blks_hit are highly misleading in practice
> because they fail to take account of the difference between internal
> pages and leaf pages in B-Tree indexes.
I see it is still the case, so the issue is relevant, isn't
Hello,
I've updated the patch in preparation for the upcoming commitfest.
Regards,
Sergey.
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 4549c2560e..cf00685c96 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -979,6 +979,26 @@
Hi,
> > Could you please elaborate on this idea ?
> > So we have pgStatActiveTime and pgStatIdleInTransactionTime ultimately
> > used to report respective metrics in pg_stat_database.
> > Now beentry's st_total_active_time / st_total_transaction_idle_time
> > duplicates this info, so one may get
Hi,
Thank you for the reviews.
> > The write operation to beentry needs to be enclosed by
> > PGSTAT_BEGIN/END_WRITE_ACTIVITY(). In that perspective, it would be
> > better to move that writes to the PGSTAT_WRITE_ACTIVITY section just
> > below.
I have fixed it in the new version.
> >
Hello,
> Without update in the next few
> days this patch will be closed as Returned with Feedback,
Thank you for the reminder, Julien.
Per agreement with Rafia I have reworked the patch in the past days.
The new version 6 is now ready for review.
Regards,
Sergey Dudoladov
diff --git
ove the issue.
[1]
https://github.com/postgres/postgres/blob/410aa248e5a883fde4832999cc9b23c7ace0f2ff/src/include/pg_config_manual.h#L106
[2]
https://github.com/postgres/postgres/blob/410aa248e5a883fde4832999cc9b23c7ace0f2ff/src/interfaces/libpq/fe-exec.c#L1078
[3]
https://github.com/postgres/postgres/blob/27b77ecf9f4d5be211900eda54d8155ada50d696/src/backend/access/transam/xlog.c#L8851-L8859
Regards,
Sergey Dudoladov
21 matches
Mail list logo
