Hi
On Tuesday, March 14, 2023 1:17 PM Ajin Cherian wrote:
> I found out that the option ONLY was not parsed in the "CREATE INDEX"
> command, for eg: CREATE UNIQUE INDEX ... ON ONLY table_name ...
>
> I've fixed this in patch 0002.
FYI, cfbot reports a failure of v80 on linux [1]. Could you
Hi,
On Wednesday, March 15, 2023 2:34 PM Amit Kapila
wrote:
> On Tue, Mar 14, 2023 at 8:50 PM Takamichi Osumi (Fujitsu)
> wrote:
> >
> > On Tuesday, March 14, 2023 8:02 PM Melih Mutlu
> wrote:
> > (3) copy_table()
> >
> > + /*
> > +*
On Tuesday, March 14, 2023 8:02 PM Melih Mutlu wrote:
> Attached v13.
Hi,
Thanks for sharing v13. Few minor review comments.
(1) create_subscription.sgml
+ column types as opposed to text format. Even when this option is
enabled,
+ only data types having binary send and
Hi,
On Friday, March 10, 2023 6:32 PM Wang, Wei/王 威 wrote:
> Attach the new patch set.
Thanks for updating the patch ! One review comment on v7-0005.
stream_start_cb_wrapper and stream_stop_cb_wrapper don't call the pair of
threshold check and UpdateProgressAndKeepalive unlike other write
Hi,
On Wednesday, March 8, 2023 11:54 AM From: wangw.f...@fujitsu.com
wrote:
> Attach the new patch.
Thanks for sharing v6 ! Few minor comments for the same.
(1) commit message
The old function name 'is_skip_threshold_change' is referred currently. We need
to update it to
Hi,
On Monday, February 27, 2023 6:30 PM wangw.f...@fujitsu.com
wrote:
> Attach the new patch.
Thanks for sharing v3. Minor review comments and question.
(1) UpdateDecodingProgressAndKeepalive header comment
The comment should be updated to explain maybe why we reset some other flags as
On Monday, February 20, 2023 8:47 PM Melih Mutlu wrote:
> Thanks for letting me know.
> Attached the fixed version of the patch.
Hi, Melih
Thanks for updating the patch. Minor comments on v9.
(1) commit message
"The patch introduces a new parameter, copy_format, to CREATE SUBSCRIPTION to
Hi, Melih
On Monday, January 30, 2023 7:50 PM Melih Mutlu wrote:
> Thanks for reviewing.
...
> Well, with this patch, it will begin to fail in the table copy phase...
The latest patch doesn't get updated for more than two weeks
after some review comments. If you don't have time,
I would like
Hi, Andres-san
On Tuesday, February 14, 2023 1:47 AM Andres Freund wrote:
> On 2023-02-11 05:44:47 +0000, Takamichi Osumi (Fujitsu) wrote:
> > On Saturday, February 11, 2023 11:10 AM Andres Freund
> wrote:
> > > Has there been any discussion about whether
Hi, Horiguchi-san
On Monday, February 13, 2023 10:26 AM Kyotaro Horiguchi
wrote:
> At Fri, 10 Feb 2023 10:34:49 +0530, Amit Kapila
> wrote in
> > On Fri, Feb 10, 2023 at 10:11 AM Amit Kapila
> wrote:
> > >
> > > On Fri, Feb 10, 2023 at 6:27 AM Kyotaro Horiguchi
> > > wrote:
> > > > We have
Hi
On Saturday, February 11, 2023 11:10 AM Andres Freund
wrote:
> On 2023-02-10 11:26:21 +0000, Takamichi Osumi (Fujitsu) wrote:
> > Subject: [PATCH v34] Time-delayed logical replication subscriber
> >
> > Similar to physical replication, a time-delayed copy of the
Hi,
On Friday, February 10, 2023 2:05 PM Friday, February 10, 2023 2:05 PM wrote:
> On Fri, Feb 10, 2023 at 10:11 AM Amit Kapila
> wrote:
> >
> > On Fri, Feb 10, 2023 at 6:27 AM Kyotaro Horiguchi
> > wrote:
> > >
> > > At Thu, 9 Feb 2023 13:48:52 +0530, Amit Kapila
> > > wrote in
> > > > On
Hi,
On Thursday, February 9, 2023 4:56 PM Amit Kapila
wrote:
> On Thu, Feb 9, 2023 at 12:17 AM Peter Smith
> wrote:
> >
> > On Wed, Feb 8, 2023 at 8:03 PM Hayato Kuroda (Fujitsu)
> > wrote:
> > >
> > ...
> > > > ==
> > > >
> > > > src/backend/replication/logical/worker.c
> > > >
> > > >
On Wednesday, February 8, 2023 6:47 PM Hayato Kuroda (Fujitsu)
wrote:
> PSA rebased patch that supports updated time-delayed patch[1].
Hi,
Thanks for creating the patch ! Minor review comments on v5-0002.
(1)
+ Decides the condition for exiting the walsender process.
+
Hi, Horiguchi-san
Thanks for your review !
On Tuesday, February 7, 2023 1:43 PM From: Kyotaro Horiguchi
wrote:
> At Mon, 6 Feb 2023 13:10:01 +, "Takamichi Osumi (Fujitsu)"
> wrote in
> subscriptioncmds.c
>
> +
Hi,
On Tuesday, February 7, 2023 2:26 PM Amit Kapila
wrote:
> On Tue, Feb 7, 2023 at 10:13 AM Kyotaro Horiguchi
> wrote:
> >
> > At Mon, 6 Feb 2023 13:10:01 +, "Takamichi Osumi (Fujitsu)"
> > wrote in
> > > The attached patch v29 has i
Hi,
On Tuesday, February 7, 2023 6:56 PM Amit Kapila
wrote:
> On Tue, Feb 7, 2023 at 8:22 AM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Thank you for reviewing! PSA new version.
> >
>
> Few comments:
> =
Thanks for your comments !
> 1.
> @@ -74,6 +74,8 @@
Hi,
On Monday, February 6, 2023 8:57 PM Amit Kapila wrote:
> On Tue, Jan 24, 2023 at 5:02 AM Euler Taveira wrote:
> >
> >
> > - elog(DEBUG2, "sending feedback (force %d) to recv %X/%X,
> write %X/%X, flush %X/%X in-delayed: %d",
> > + elog(DEBUG2, "sending feedback (force %d) to recv
On Monday, February 6, 2023 8:51 PM Amit Kapila wrote:
> On Mon, Feb 6, 2023 at 12:36 PM Takamichi Osumi (Fujitsu)
> wrote:
> >
>
> I have made a couple of changes in the attached: (a) changed a few error and
> LOG messages; (a) added/changed comments. See, if t
On Monday, February 6, 2023 12:03 PM Peter Smith wrote:
> On Sat, Feb 4, 2023 at 5:04 PM Takamichi Osumi (Fujitsu)
> wrote:
> >
> ...
> >
> > Kindly have a look at the attached v27.
> >
>
> Here are some review comments for patch v27-0001.
Thanks for check
Hi,
On wangw.f...@fujitsu.com Amit Kapila wrote:
> On Fri, Feb 3, 2023 at 3:12 PM wangw.f...@fujitsu.com
> wrote:
> >
> > Here is a comment:
> >
> > 1. The checks in function AlterSubscription
> > + /*
> > +* The
Hi,
On Friday, February 3, 2023 3:35 PM I wrote:
> On Friday, February 3, 2023 2:21 PM Amit Kapila
> wrote:
> > On Fri, Feb 3, 2023 at 6:41 AM Peter Smith
> wrote:
> > > On Thu, Feb 2, 2023 at 7:21 PM Takamichi Osumi (Fujitsu)
> > > wrote:
> > >
Hi,
On Friday, February 3, 2023 2:21 PM Amit Kapila wrote:
> On Fri, Feb 3, 2023 at 6:41 AM Peter Smith wrote:
> > On Thu, Feb 2, 2023 at 7:21 PM Takamichi Osumi (Fujitsu)
> > wrote:
> > >
> > ...
> > > > Besides, I am not sure it's a stable tes
Hi,
On Wednesday, February 1, 2023 6:41 PM Shi, Yu/侍 雨
wrote:
> On Mon, Jan 30, 2023 6:05 PM Takamichi Osumi (Fujitsu)
> wrote:
> >
> > On Saturday, January 28, 2023 1:28 PM I wrote:
> > > Attached the updated patch v24.
> > Hi,
> >
> >
> &g
Hi,
On Wednesday, February 1, 2023 1:37 PM Peter Smith
wrote:
> Here are my review comments for the patch v25-0001.
Thank you for your review !
> ==
> Commit Message
>
> 1.
> The other possibility is to apply the delay at the end of the parallel apply
> transaction but that would cause
Hi,
On Wednesday, February 1, 2023 5:40 PM Kyotaro Horiguchi
wrote:
> At Wed, 1 Feb 2023 08:38:11 +0530, Amit Kapila
> wrote in
> > On Wed, Feb 1, 2023 at 8:13 AM Kyotaro Horiguchi
> > wrote:
> > >
> > > At Tue, 31 Jan 2023 15:12:14 +0530, Amit Kapila
> > > wrote in
> > > > So, shall we
On Monday, January 30, 2023 7:50 PM Melih Mutlu wrote:
> Thanks for reviewing.
...
> Please see [1] and you'll get the following error in your case:
> "ERROR: incorrect binary data format in logical replication column 1"
Hi, thanks for sharing v7.
(1) general comment
I wondered if the
On Monday, January 30, 2023 7:05 PM I wrote:
> On Saturday, January 28, 2023 1:28 PM I wrote:
> > Attached the updated patch v24.
> I've conducted the rebase affected by the commit(1e8b61735c) by renaming
> the GUC to logical_replication_mode accordingly, because it's utilized in the
> TAP test of
On Monday, January 30, 2023 12:02 PM Kyotaro Horiguchi
wrote:
> At Sat, 28 Jan 2023 04:28:29 +, "Takamichi Osumi (Fujitsu)"
> wrote in
> > On Friday, January 27, 2023 8:00 PM Amit Kapila
> wrote:
> > > So, you have changed min_apply_delay from int
On Saturday, January 28, 2023 1:28 PM I wrote:
> Attached the updated patch v24.
Hi,
I've conducted the rebase affected by the commit(1e8b61735c)
by renaming the GUC to logical_replication_mode accordingly,
because it's utilized in the TAP test of this time-delayed LR feature.
There is no other
Hi,
On Friday, January 27, 2023 8:00 PM Amit Kapila wrote:
> On Fri, Jan 27, 2023 at 1:39 PM Takamichi Osumi (Fujitsu)
> wrote:
> >
> > On Wednesday, January 25, 2023 11:24 PM I wrote:
> > > Attached the updated v22.
> > Hi,
> >
> > During sel
On Wednesday, January 25, 2023 11:24 PM I wrote:
> Attached the updated v22.
Hi,
During self-review, I noticed some changes are
required for some variable types related to 'min_apply_delay' value,
so have conducted the adjustment changes for the same.
Additionally, I made some comments for
On Wednesday, January 25, 2023 3:55 PM Amit Kapila
wrote:
> On Wed, Jan 25, 2023 at 11:23 AM Takamichi Osumi (Fujitsu)
> wrote:
> >
> >
> > Thank you for checking the patch !
> > On Wednesday, January 25, 2023 10:17 AM Kyotaro Horiguchi
> wrote:
> > &
On Wednesday, January 25, 2023 3:27 PM Kyotaro Horiguchi
wrote:
> At Tue, 24 Jan 2023 12:19:04 +, "Takamichi Osumi (Fujitsu)"
> wrote in
> > Attached the patch v20 that has incorporated all comments so far.
>
> Thanks! I looked thourgh the documentation par
Hi, Horiguchi-san
Thank you for checking the patch !
On Wednesday, January 25, 2023 10:17 AM Kyotaro Horiguchi
wrote:
> In short, I'd like to propose renaming the parameter in_delayed_apply of
> send_feedback to "has_unprocessed_change".
>
> At Tue, 24 Jan 2023 12:27:58 +0530, Amit Kapila
>
Hi,
On Wednesday, January 25, 2023 2:02 PM shveta malik
wrote:
> On Tue, Jan 24, 2023 at 5:49 PM Takamichi Osumi (Fujitsu)
> wrote:
> >
> >
> > Attached the patch v20 that has incorporated all comments so far.
> > Kindly have a look at the attached patch.
>
On Tuesday, January 24, 2023 8:32 AM Euler Taveira wrote:
> Good to know that you keep improving this patch. I have a few suggestions that
> were easier to provide a patch on top of your latest patch than to provide an
> inline suggestions.
Thanks for your review ! We basically adopted your
On Monday, January 23, 2023 5:07 PM Peter Smith wrote:
> Here are my review comments for v19-0001.
Thanks for your review !
>
> ==
> Commit message
>
> 1.
> The combination of parallel streaming mode and min_apply_delay is not
> allowed. The subscriber in the parallel streaming mode
On Monday, January 23, 2023 7:45 PM Amit Kapila wrote:
> On Mon, Jan 23, 2023 at 1:36 PM Peter Smith
> wrote:
> >
> > Here are my review comments for v19-0001.
> >
> ...
> >
> > 5. parse_subscription_options
> >
> > + /*
> > + * The combination of parallel streaming mode and min_apply_delay is
>
On Monday, January 23, 2023 9:06 PM Amit Kapila wrote:
> On Sun, Jan 22, 2023 at 6:12 PM Takamichi Osumi (Fujitsu)
> wrote:
> >
> >
> > Attached the updated patch v19.
> >
>
> Few comments:
> =
> 1.
> }
> +
> +
> +/*
>
> O
On Tuesday, January 24, 2023 3:58 PM Amit Kapila
wrote:
> > send_feedback():
> > +* If the subscriber side apply is delayed (because of time-delayed
> > +* replication) then do not tell the publisher that the received
> > latest
> > +* LSN is already applied and flushed,
Hi,
On Tuesday, January 24, 2023 5:52 PM Amit Kapila
wrote:
> On Tue, Jan 24, 2023 at 12:44 PM Peter Smith
> wrote:
> >
> > On Tue, Jan 24, 2023 at 5:58 PM Amit Kapila
> wrote:
> > >
> > > On Tue, Jan 24, 2023 at 8:15 AM Kyotaro Horiguchi
> > > wrote:
> > > >
> > > > > Attached the updated
On Saturday, January 21, 2023 3:36 AM I wrote:
> Kindly have a look at the patch v18.
I've conducted some refactoring for v18.
Now the latest patch should be tidier and
the comments would be clearer and more aligned as a whole.
Attached the updated patch v19.
Best Regards,
Takamichi
Hi,
On Thursday, January 19, 2023 7:55 PM vignesh C wrote:
> On Thu, 19 Jan 2023 at 12:06, Takamichi Osumi (Fujitsu)
> wrote:
> >
> > Updated the comment and the function call.
> >
> > Kindly have a look at the updated patch v17.
>
> Thanks for
Hi,
On Thursday, January 19, 2023 10:17 PM Amit Kapila
wrote:
> On Thu, Jan 19, 2023 at 12:06 PM Takamichi Osumi (Fujitsu)
> wrote:
> >
> > Kindly have a look at the updated patch v17.
> >
>
> Can we try to optimize the test time for this test? On my machine, i
On Friday, January 20, 2023 12:47 PM shveta malik
wrote:
> 1)
> Tried different variations of altering 'min_apply_delay'. All passed except
> one
> below:
>
> postgres=# alter subscription mysubnew set (min_apply_delay = '10.9min
> 1ms'); ALTER SUBSCRIPTION postgres=# alter subscription
On Friday, January 20, 2023 5:54 PM shveta malik wrote:
> On Fri, Jan 20, 2023 at 1:08 PM Peter Smith wrote:
>
> > a) the message should say that this is the *remaining* time to left to wait.
> >
> > b) it might be convenient to know from the log what was the original
> > min_apply_delay value
Hi,
On Friday, January 20, 2023 6:13 PM shveta malik wrote:
> On Fri, Jan 20, 2023 at 2:23 PM shveta malik wrote:
> >
> > On Fri, Jan 20, 2023 at 1:08 PM Peter Smith
> wrote:
> >
> > > a) the message should say that this is the *remaining* time to left to
> > > wait.
> > >
> > > b) it might
On Friday, January 20, 2023 3:56 PM Peter Smith wrote:
> Hi Osumi-san, here are my review comments for the latest patch v17-0001.
Thanks for your review !
> ==
> Commit Message
>
> 1.
> Prohibit the combination of this feature and parallel streaming mode.
>
> SUGGESTION (using the same
Hi, Horiguchi-san and Amit-san
On Wednesday, November 9, 2022 3:41 PM Kyotaro Horiguchi
wrote:
> Using interval is not standard as this kind of parameters but it seems
> convenient. On the other hand, it's not great that the unit month introduces
> some subtle ambiguity. This patch translates
Hi,
On Thursday, January 19, 2023 3:14 PM Michael Paquier
wrote:
> On Wed, Jan 18, 2023 at 02:04:16PM +0530, Bharath Rupireddy wrote:
> > [1]
> > diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index
> > 89d53f2a64..6f9509267c 100644
> > --- a/doc/src/sgml/config.sgml
> > +++
On Thursday, January 19, 2023 10:42 AM Peter Smith
wrote:
> On Wed, Jan 18, 2023 at 6:06 PM Peter Smith
> wrote:
> >
> > Here are my review comments for the latest patch v16-0001. (excluding
> > the test code)
> >
> ...
> >
> > 8. AlterSubscription (general)
> >
> > I observed during testing
On Wednesday, January 18, 2023 4:06 PM Peter Smith
wrote:
> Here are my review comments for the latest patch v16-0001. (excluding the
> test code)
Hi, thank you for your review !
> ==
>
> General
>
> 1.
>
> Since the value of min_apply_delay cannot be < 0, I was thinking probably it
>
On Thursday, January 19, 2023 10:49 AM Peter Smith
wrote:
> On Wed, Jan 18, 2023 at 6:06 PM Peter Smith
> wrote:
> >
> > Here are my review comments for the latest patch v16-0001. (excluding
> > the test code)
> >
>
> And here are some review comments for the v16-0001 test code.
Hi, thanks
On Wednesday, January 18, 2023 4:11 PM Michael Paquier
wrote:
> On Wed, Jan 18, 2023 at 07:00:43AM +0000, Takamichi Osumi (Fujitsu) wrote:
> > The attached patch includes below two changes for the description of
> > Logical Replication "Configuration Settings".
Hi, hackers
The attached patch includes below two changes for the description of
Logical Replication "Configuration Settings".
1. Add one brief description about wal_sender_timeout.
I made it similar to one other sentence for subscriber.
2. Fix a wrong GUC name "wal_receiver_retry_interval".
Hi,
On Wednesday, January 18, 2023 2:19 PM Amit Kapila
wrote:
> On Wed, Jan 18, 2023 at 6:37 AM Takamichi Osumi (Fujitsu)
> wrote:
> >
> > >
> > > Can you please explain a bit more as asked above to understand the
> > > difference?
> > So, the curr
Hi,
On Tuesday, January 17, 2023 9:54 PM Amit Kapila
wrote:
> On Tue, Jan 17, 2023 at 4:30 PM Takamichi Osumi (Fujitsu)
> wrote:
> >
> > On Saturday, January 14, 2023 3:27 PM vignesh C
> wrote:
> >
> > > 2) I'm not sure if this will add any extra
Hi,
On Saturday, January 14, 2023 3:27 PM vignesh C wrote:
> 1) Since the min_apply_delay = 3, but you have specified 2s, there might be a
> possibility that it can log delay as 1000ms due to pub/sub/network delay and
> the test can fail randomly, If we cannot ensure this log file value,
>
Hi,
While working on some logical replication patch,
I've find a typo on HEAD.
Attached the modification patch for this.
Best Regards,
Takamichi Osumi
v1-0001-Fix-a-typo-in-subscription-command-tests.patch
Description: v1-0001-Fix-a-typo-in-subscription-command-tests.patch
Hi, Melih
On Thursday, January 12, 2023 10:12 PM Melih Mutlu
wrote:
> I've a question about 032_apply_delay.pl.
> ...
> I couldn't quite see how these lines test whether ALTER SUBSCRIPTION
> successfully worked.
> Don't we need to check that min_apply_delay really changed as a result?
Yeah,
Hi, Shveta
Thanks for your comments!
On Thursday, January 12, 2023 6:51 PM shveta malik
wrote:
> > Yes, DBAs may set wal_receiver_status_interval to more than
> > wal_sender_timeout by mistake.
> >
> > But to handle the scenario we must compare between min_apply_delay *on
> > subscriber* and
On Thursday, January 12, 2023 12:04 PM Kyotaro Horiguchi
wrote:
> At Wed, 11 Jan 2023 12:46:24 +, "Hayato Kuroda (Fujitsu)"
> wrote in
> > them. Which version is better?
>
>
> Some comments by a quick loock, different from the above.
Horiguchi-san, thanks for your review !
> +
On Wednesday, January 11, 2023 7:45 PM Melih Mutlu
wrote:
> Thanks for your review.
> Done.
Hi, minor comments on v5.
(1) publisher's version check
+ /* If the publisher is v16 or later, copy in binary format.*/
+ server_version = walrcv_server_version(LogRepWorkerWalRcvConn);
+
On Tuesday, January 10, 2023 11:28 AM I wrote:
> On Tuesday, December 27, 2022 6:29 PM Tuesday, December 27, 2022 6:29 PM
> wrote:
> > Thanks for reviewing our patch! PSA new version patch set.
> Now, the patches fails to apply to the HEAD, because of recent commits
> (c6e1f62e2c and 216a784829c)
On Tuesday, January 3, 2023 8:22 PM shveta malik wrote:
> Please find a few minor comments.
Thanks for your review !
> 1.
> + diffms = TimestampDifferenceMilliseconds(GetCurrentTimestamp(),
> +
>
>TimestampTzPlusMilliseconds(ts, MySubscription->minapplydelay)); on
> unix, above code
On Tuesday, January 3, 2023 4:01 PM vignesh C wrote:
Hi, thanks for your review !
> 1) This global variable can be removed as it is used only in send_feedback
> which
> is called from maybe_delay_apply so we could pass it as a function argument:
> + * delay, avoid having positions of the
On Tuesday, December 27, 2022 6:29 PM Tuesday, December 27, 2022 6:29 PM wrote:
> Thanks for reviewing our patch! PSA new version patch set.
Now, the patches fails to apply to the HEAD,
because of recent commits (c6e1f62e2c and 216a784829c) as reported in [1].
I'll rebase the patch with other
On Thursday, December 22, 2022 3:02 PM Takamichi Osumi (Fujitsu)
wrote:
> Attached the updated patch.
> Again, I used one basic patch in another thread to wake up logical replication
> worker shared in [2] for TAP tests.
The v11 caused a cfbot failure in [1]. But, failed tests looked i
On Thursday, December 22, 2022 2:22 AM vignesh C wrote:
> I have handled most of the comments for [1] in the v55 version patch attached.
> I will handle the pending comments in the upcoming version and reply to it.
> [1] -
> https://www.postgresql.org/message-id/20221207122041.hbfj4hen3ibhdzgn%
>
Hi,
On Thursday, December 15, 2022 12:53 PM Amit Kapila
wrote:
> On Thu, Dec 15, 2022 at 7:16 AM Kyotaro Horiguchi
> wrote:
> >
> > At Wed, 14 Dec 2022 10:46:17 +, "Hayato Kuroda (Fujitsu)"
> > wrote in
> > > I have implemented and tested that workers wake up per
> > >
Hi, hackers
I've found two assertion failures on BuildFarm [1][2].
The call stack can be found in [2].
TRAP: failed Assert("dlist_is_empty(blocklist)"), File: "slab.c", Line: 564,
PID: 16148
postgres: publisher: walsender postgres postgres [local]
On Tuesday, December 13, 2022 1:27 PM Kyotaro Horiguchi
wrote:
> At Tue, 13 Dec 2022 02:28:49 +, "Takamichi Osumi (Fujitsu)"
> wrote in
> > On Wednesday, December 7, 2022 12:00 PM Kyotaro Horiguchi
> wrote:
> >
> > We couldn't reproduce this fail
On Wednesday, December 7, 2022 12:00 PM Kyotaro Horiguchi
wrote:
> At Tue, 6 Dec 2022 11:08:43 -0800, Andres Freund wrote
> in
> > Hi,
> >
> > The tests fail on cfbot:
> > https://cirrus-ci.com/task/4533866329800704
> >
> > They only seem to fail on 32bit linux.
> >
> >
Hi,
On Saturday, December 10, 2022 12:08 AM Takamichi Osumi (Fujitsu)
wrote:
> On Friday, December 9, 2022 3:38 PM Kuroda, Hayato/黒田 隼人
> wrote:
> > Thanks for reporting! I have analyzed the problem and found the root cause.
> >
> > This feature seemed no
On Friday, November 25, 2022 5:43 AM Peter Smith wrote:
> On Fri, Nov 25, 2022 at 2:15 AM Takamichi Osumi (Fujitsu)
> wrote:
> >
> > On Wednesday, October 5, 2022 6:42 PM Peter Smith
> wrote:
> ...
> >
> > > ==
> > >
> >
On Tuesday, December 6, 2022 5:00 PM Peter Smith wrote:
> Here are some review comments for patch v9-0001:
Hi, thank you for your reviews !
>
> ==
>
> GENERAL
>
> 1. min_ prefix?
>
> What's the significance of the "min_" prefix for this parameter? I'm guessing
> the
> background is that
On Monday, December 12, 2022 2:54 PM Kyotaro Horiguchi
wrote:
> I asked about unexpected walsender termination caused by this feature but I
> think I didn't received an answer for it and the behavior is still exists.
>
> Specifically, if servers have the following settings, walsender terminates
On Wednesday, December 7, 2022 2:07 PM Amit Kapila
wrote:
> On Tue, Dec 6, 2022 at 5:44 PM Takamichi Osumi (Fujitsu)
> wrote:
> >
> > On Friday, December 2, 2022 4:05 PM Amit Kapila
> wrote:
> > > On Tue, Nov 15, 2022 at 12:33 PM Amit Kapila
> > >
>
Hi,
On Friday, December 9, 2022 3:38 PM Kuroda, Hayato/黒田 隼人
wrote:
> Thanks for reporting! I have analyzed the problem and found the root cause.
>
> This feature seemed not to work on 32-bit OSes. This was because the
> calculation of delay_time was wrong. The first argument of this should
On Wednesday, December 7, 2022 12:00 PM Kyotaro Horiguchi
wrote:
> At Tue, 6 Dec 2022 11:08:43 -0800, Andres Freund wrote
> in
> > Hi,
> >
> > The tests fail on cfbot:
> > https://cirrus-ci.com/task/4533866329800704
> >
> > They only seem to fail on 32bit linux.
> >
> >
On Friday, December 2, 2022 4:05 PM Amit Kapila wrote:
> On Tue, Nov 15, 2022 at 12:33 PM Amit Kapila
> wrote:
> > One more thing I would like you to consider is the point raised by me
> > related to this patch's interaction with the parallel apply feature as
> > mentioned in the email [1]. I am
Hi,
On Thursday, August 11, 2022 7:33 PM Amit Kapila
wrote:
> On Tue, Aug 9, 2022 at 3:52 AM Euler Taveira wrote:
> >
> > On Wed, Aug 3, 2022, at 10:27 AM, Amit Kapila wrote:
> >
> > Your explanation makes sense to me. The other point to consider is
> > that there can be cases where we may
Hi,
On Monday, November 14, 2022 7:15 PM Amit Kapila
wrote:
> On Wed, Nov 9, 2022 at 12:11 PM Kyotaro Horiguchi
> wrote:
> >
> > At Wed, 10 Aug 2022 17:33:00 -0300, "Euler Taveira"
> > wrote in
> > > On Wed, Aug 10, 2022, at 9:39 AM, osumi.takami...@fujitsu.com wrote:
> > > > Minor review
Hi,
On Tuesday, November 22, 2022 6:15 PM vignesh C wrote:
> On Mon, 14 Nov 2022 at 12:14, Amit Kapila wrote:
> >
> > Hi,
> >
> > The thread title doesn't really convey the topic under discussion, so
> > changed it. IIRC, this has been mentioned by others as well in the
> > thread.
> >
> > On
On Wednesday, November 16, 2022 12:58 PM Ian Lawrence Barwick
wrote:
> 2022年11月14日(月) 10:09 Takamichi Osumi (Fujitsu)
> :
> > I've simply rebased the patch to make it applicable on top of HEAD and
> > make the tests pass. Note there are still open pending comments and
>
On Wednesday, October 5, 2022 6:42 PM Peter Smith wrote:
> Hi Euler, a long time ago you ask me a few questions about my previous review
> [1].
>
> Here are my replies, plus a few other review comments for patch v7-0001.
Hi, thank you for your comments.
> ==
>
> 1.
On Tuesday, November 22, 2022 1:39 PM Nathan Bossart
wrote:
> On Tue, Nov 22, 2022 at 03:03:52AM +, Hayato Kuroda (Fujitsu) wrote:
> > Just One comment: IIUC the statement "ALTER SUBSCRIPTION" can be
> > executed inside the transaction. So if two subscriptions are altered
> > in the same
Hi,
On Tuesday, November 15, 2022 10:26 AM Andres Freund wrote:
> On 2022-11-10 16:04:40 +0530, Amit Kapila wrote:
> > I don't have any good ideas on how to proceed with this. Any thoughts
> > on this would be helpful?
>
> One thing worth doing might be to convert the assertion path into an
On Tuesday, November 8, 2022 2:27 PM Kuroda, Hayato/黒田 隼人
wrote:
> If you could not allocate a time to discuss this problem because of other
> important tasks or events, we would like to take over the thread and modify
> your patch.
>
> We've planned that we will start to address comments and
On Monday, October 17, 2022 2:49 PM Wang, Wei/王 威
wrote:
> Attach the new patch set.
Hi, thank you for posting the new patches.
Here are minor comments on the HEAD_v13-0002.
(1) Suggestion for the document description
+
+ If a root partitioned table is published by any
91 matches
Mail list logo
