Re: logical decoding and replication of sequences

On Wed, Jun 23, 2021 at 7:55 PM Tomas Vondra wrote: > > On 6/23/21 4:14 PM, Tomas Vondra wrote: > > A rebased patch, addressing a minor bitrot due to 4daa140a2f5. > > > > Meh, forgot to attach the patch as usual, of course ... The patch does not apply on Head anymore, could you rebase and post a

Re: postgres_fdw - make cached connection functions tests meaningful

On Mon, May 10, 2021 at 6:03 PM Bharath Rupireddy wrote: > > Hi, > > While working on [1], I got to know that there is a new GUC > debug_invalidate_system_caches_always that has been introduced in v14. > It can be used to switch off cache invalidation in > CLOBBER_CACHE_ALWAYS builds which makes

Re: psql - add SHOW_ALL_RESULTS option

On Sat, Jun 12, 2021 at 3:11 PM Fabien COELHO wrote: > > > Hello Peter, > > >> My overly naive trust in non regression test to catch any issues has been > >> largely proven wrong. Three key features do not have a single tests. Sigh. > >> > >> I'll have some time to look at it over next week-end,

Re: Rename of triggers for partitioned tables

On Mon, Jun 28, 2021 at 3:46 PM Arne Roland wrote: > > Hi! > > > From: Zhihong Yu > Sent: Saturday, June 26, 2021 20:32 > Subject: Re: Rename of triggers for partitioned tables > > > Hi, Arne: > > It seems the patch no longer applies cleanly on master branch. > > Do you mind updating the patch ?

Re: Removing unneeded self joins

On Thu, May 27, 2021 at 12:21 PM Andrey V. Lepikhov wrote: > > On 5/8/21 2:00 AM, Hywel Carver wrote: > > On Fri, May 7, 2021 at 8:23 AM Andrey Lepikhov > > mailto:a.lepik...@postgrespro.ru>> wrote: > > Here I didn't work on 'unnecessary IS NOT NULL filter'. > > > > I've tested the new patch,

Re: Remove redundant initializations

On Mon, Jun 28, 2021 at 3:30 PM Peter Eisentraut wrote: > > There are certain parts of code that laboriously initialize every field > of a struct to (some spelling of) zero, even though the whole struct was > just zeroed (by makeNode() or memset()) a few lines earlier. Besides > being redundant,

Re: A qsort template

On Sun, Jul 4, 2021 at 9:58 AM Thomas Munro wrote: > > On Fri, Jul 2, 2021 at 2:32 PM John Naylor > wrote: > > I suspect if we experiment on two extremes of type "heaviness" (accessing > > and comparing trivial or not), such as uint32 and tuplesort, we'll have a > > pretty good idea what the

Re: Enhanced error message to include hint messages for redundant options error

On Thu, Jul 15, 2021 at 1:40 PM Dean Rasheed wrote: > > On Tue, 13 Jul 2021 at 15:30, vignesh C wrote: > > > > On Tue, Jul 13, 2021 at 4:25 PM Dean Rasheed > > wrote: > > > > > > As it stands, the improvements from (3) seem quite worthwhile. Also,

Re: POC: Cleaning up orphaned files using undo logs

On Wed, Jun 30, 2021 at 11:10 PM Antonin Houska wrote: > > Antonin Houska wrote: > > > tsunakawa.ta...@fujitsu.com wrote: > > > > > I'm crawling like a snail to read the patch set. Below are my first set > > > of review comments, which are all minor. > > > > Thanks. > > I've added the patch

Re: VACUUM (DISABLE_PAGE_SKIPPING on)

On Thu, Apr 8, 2021 at 11:40 PM Simon Riggs wrote: > > On Thu, 8 Apr 2021 at 18:15, Alvaro Herrera wrote: > > > > On 2021-Apr-08, Simon Riggs wrote: > > > > > On Thu, 8 Apr 2021 at 16:58, David Steele wrote: > > > > > > It's not clear to me which patch is which, so perhaps move one CF entry > >

Re: storing an explicit nonce

On Sat, Jun 26, 2021 at 2:52 AM Bruce Momjian wrote: > > On Wed, May 26, 2021 at 05:02:01PM -0400, Bruce Momjian wrote: > > For these reasons, if we decide to go in the direction of using a > > non-LSN nonce, I no longer plan to continue working on this feature. I > > would rather work on things

Re: Release SPI plans for referential integrity with DISCARD ALL

On Wed, Mar 10, 2021 at 1:49 PM yuzuko wrote: > > Hello, > > I thought about this suggestion again. > > Amit's patch suggested in the thread [1] can eliminate SPI plans from > INSERT/UPDATE triggers, so our memory pressure issue would be solved. > But as far as I can see that thread, Amit's patch

Re: Reduce the number of special cases to build contrib modules on windows

On Mon, Apr 19, 2021 at 5:18 PM David Rowley wrote: > > On Wed, 3 Mar 2021 at 22:37, David Rowley wrote: > > I've attached a rebased patch. > > I've rebased this again. > > I also moved away from using hash tables for storing references and > libraries. I was having some problems getting psql

Re: [PATCH] New default role allowing to change per-role/database settings

On Wed, Apr 7, 2021 at 5:23 PM Michael Banck wrote: > > Hi, > > Am Dienstag, den 06.04.2021, 15:37 +0200 schrieb Michael Banck: > > Am Montag, den 05.04.2021, 14:33 -0400 schrieb Stephen Frost: > > > Should drop the 'DEFAULT_' to match the others since the rename to > > > 'predefined' roles went

Re: Make Append Cost aware of some run time partition prune case

On Thu, Mar 4, 2021 at 9:51 AM Andy Fan wrote: > > >> >> I have implemented a new one, which only handles 1 level of partitioned >> table, and >> only 1 partition key. and only handle the eq operators like partkey = $1 / >> partkey in ($1, $2) >> / parkey = $1 or partkey = $2; The patch works

Re: Implementing Incremental View Maintenance

On Mon, May 17, 2021 at 10:08 AM Yugo NAGATA wrote: > > On Fri, 7 May 2021 14:14:16 +0900 > Yugo NAGATA wrote: > > > On Mon, 26 Apr 2021 16:03:48 +0900 > > Yugo NAGATA wrote: > > > > > On Mon, 26 Apr 2021 15:46:21 +0900 > > > Yugo NAGATA wrote: > > > > > > > On Tue, 20 Apr 2021 09:51:34 +0900

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

On Tue, Mar 30, 2021 at 2:14 AM Mark Rofail wrote: > > Hey Alvaro > >> Yes, we should do that. > > I have attached v12 with more tests in “ src/test/regress/sql/gin.sql” > > Changelog: > - v12 (compatible with current master 2021/03/29, commit > 6d7a6feac48b1970c4cd127ee65d4c487acbb5e9) > *

Re: DROP INDEX CONCURRENTLY on partitioned index

On Wed, Oct 28, 2020 at 6:14 AM Justin Pryzby wrote: > > Forking this thread, since the existing CFs have been closed. > https://www.postgresql.org/message-id/flat/20200914143102.GX18552%40telsasoft.com#58b1056488451f8594b0f0ba40996afd > > On Mon, Sep 14, 2020 at 09:31:03AM -0500, Justin Pryzby

Re: [PATCH] Allow multiple recursive self-references

On Wed, Mar 31, 2021 at 7:28 PM Denis Hirn wrote: > > Sorry, I didn't append the patch properly. The patch does not apply on Head anymore, could you rebase and post a patch. I'm changing the status to "Waiting for Author". Regards, Vignesh

Re: libpq compression

On Wed, Jul 14, 2021 at 6:31 PM Daniil Zakhlystov wrote: > > **sorry for the noise, but I need to re-send the message because one of the > recipients is blocked on the pgsql-hackers for some reason** > > Hi! > > Done, the patch should apply to the current master now. > > Actually, I have an

Re: ResourceOwner refactoring

On Tue, Mar 9, 2021 at 6:10 PM Heikki Linnakangas wrote: > > On 08/03/2021 18:47, Ibrar Ahmed wrote: > > The patchset does not apply successfully, there are some hunk failures. > > > > http://cfbot.cputube.org/patch_32_2834.log > > > > > >

Re: Polyphase merge is obsolete

On Sat, Jan 23, 2021 at 3:49 AM Heikki Linnakangas wrote: > > On 22/10/2020 14:48, Heikki Linnakangas wrote: > > On 11/09/2017 13:37, Tomas Vondra wrote: > >> I planned to do some benchmarking on this patch, but apparently the > >> patch no longer applies. Rebase please? > > > > Here's a rebase

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

On Sun, Sep 13, 2020 at 9:34 PM Nikolay Shaplov wrote: > > В письме от понедельник, 20 июля 2020 г. 18:36:44 MSK пользователь Georgios > Kokolatos написал: > > Hi! Sorry for really long delay, I was at my summer vacations, and then has > urgent things to finish first. :-( Now I hope we can

Re: Toast compression method options

On Thu, May 6, 2021 at 7:24 PM Dilip Kumar wrote: > > On Mon, May 3, 2021 at 6:27 PM Dilip Kumar wrote: > > > > We have already pushed the configurable lz4 toast compression code[1]. > > In the custom compression thread, we were already having the patch to > > support the compression method

Re: Enhance traceability of wal_level changes for backup management

On Thu, Jan 28, 2021 at 6:14 AM osumi.takami...@fujitsu.com wrote: > > Hello > > > On Thursday, January 21, 2021 11:19 PM I wrote: > > If no one disagree with it, I'll proceed with (1) below. > > > > (1) writing the time or LSN in the control file to indicate when/where > > wal_level > > is

Re: WIP: System Versioned Temporal Table

On Mon, Mar 8, 2021 at 11:04 PM Ibrar Ahmed wrote: > > > > On Thu, Feb 25, 2021 at 3:28 PM Li Japin wrote: >> >> >> On Jan 27, 2021, at 12:39 AM, Surafel Temesgen wrote: >> >> >> >> On Tue, Jan 26, 2021 at 2:33 PM Vik Fearing wrote: >>> >>> I'm still in the weeds of reviewing this patch, but

Re: Write visibility map during CLUSTER/VACUUM FULL

On Mon, Jun 28, 2021 at 1:52 PM Anna Akenteva wrote: > > On 2019-11-29 05:32, Michael Paquier wrote: > > These comments are unanswered for more than 2 months, so I am marking > > this entry as returned with feedback. > > I'd like to revive this patch. To make further work easier, attaching a >

Re: partial heap only tuples

On Tue, Mar 9, 2021 at 12:09 AM Bossart, Nathan wrote: > > On 3/8/21, 10:16 AM, "Ibrar Ahmed" wrote: > > On Wed, Feb 24, 2021 at 3:22 AM Bossart, Nathan wrote: > >> On 2/10/21, 2:43 PM, "Bruce Momjian" wrote: > >>> I wonder if you should create a Postgres wiki page to document all of > >>>

Re: [PATCH] Add extra statistics to explain for Nested Loop

On Wed, Apr 14, 2021 at 4:57 PM wrote: > > Thank you for working on this issue. Your comments helped me make this > patch more correct. > > > Lines with "colon" format shouldn't use equal signs, and should use two > > spaces > > between fields. > Done. Now extra line looks like "Loop min_rows:

Re: Columns correlation and adaptive query optimization

On Fri, Mar 19, 2021 at 10:28 PM Konstantin Knizhnik wrote: > > > > On 19.03.2021 12:17, Yugo NAGATA wrote: > > On Wed, 10 Mar 2021 03:00:25 +0100 > > Tomas Vondra wrote: > > > >> What is being proposed here - an extension suggesting which statistics > >> to create (and possibly creating them

Re: alter table set TABLE ACCESS METHOD

On Thu, Jun 10, 2021 at 1:01 AM Jeff Davis wrote: > > On Wed, 2021-06-09 at 13:47 +0900, Michael Paquier wrote: > > There is a mix of upper and lower-case characters here. It could be > > more consistent. It seems to me that this test should actually check > > that pg_class.relam reflects the

Re: Added schema level support for publication.

On Tue, Jul 13, 2021 at 2:22 PM Greg Nancarrow wrote: > > On Mon, Jul 12, 2021 at 7:24 PM vignesh C wrote: > > > > > > Thanks for reporting this issue. I felt this issue is the same as the issue which Hou San had reported. This issue is fixed in the v10 patch attached

Re: Printing backtrace of postgres processes

On Wed, May 12, 2021 at 2:27 AM Robert Haas wrote: > > On Thu, May 6, 2021 at 3:31 PM Tom Lane wrote: > > Andres Freund writes: > > > On 2021-05-06 14:56:09 -0400, Tom Lane wrote: > > >> If we think it's worth having a predefined role for, OK. However, > > >> I don't like the future I see us

Re: Enhanced error message to include hint messages for redundant options error

On Tue, Jul 13, 2021 at 4:25 PM Dean Rasheed wrote: > > On Mon, 12 Jul 2021 at 17:39, vignesh C wrote: > > > > Thanks for your comments, I have made the changes for the same in the > > V10 patch attached. > > Thoughts? > > > > I'm still not happy about

Re: Add option --drop-cascade for pg_dump/restore

On Fri, Jul 2, 2021 at 12:11 PM Haotian Wu wrote: > > Hi, > > I agree that —drop-cascade does not make sense for pg_dumpall, so I removed > them. > > > are we expecting more things to appear after the semi-colon? > > No, I was just trying to “reuse” original statement as much as possible. >

Re: Failed transaction statistics to measure the logical replication progress

On Thu, Jul 8, 2021 at 12:25 PM osumi.takami...@fujitsu.com wrote: > > Hello, hackers > > > When the current HEAD fails during logical decoding, the failure > increments txns count in pg_stat_replication_slots - [1] and adds > the transaction size to the sum of bytes in the same repeatedly > on

Re: Enhanced error message to include hint messages for redundant options error

On Sun, Jul 11, 2021 at 3:23 PM Dean Rasheed wrote: > > On Sat, 10 Jul 2021 at 18:09, vignesh C wrote: > > > > I'm planning to handle conflicting errors separately after this > > current work is done, once the patch is changed to have just the valid > > scenarios(r

Re: proposal - psql - use pager for \watch command

On Mon, Jul 12, 2021 at 4:29 AM Thomas Munro wrote: > > On Sun, Jul 11, 2021 at 1:18 AM vignesh C wrote: > > On Wed, May 12, 2021 at 5:45 PM Pavel Stehule > > wrote: > > > looks so with your patch psql doesn't work on ms > > Here's a fix for Windows. The pqsi

Re: Added schema level support for publication.

On Fri, Jul 2, 2021 at 10:18 AM tanghy.f...@fujitsu.com wrote: > > On Wednesday, June 30, 2021 7:43 PM vignesh C wrote: > > > > Thanks for reporting this issue, the attached v9 patch fixes this issue. > > This also fixes the other issue you reported at [1]. > > A c

Re: Added schema level support for publication.

On Thu, Jul 8, 2021 at 9:16 AM houzj.f...@fujitsu.com wrote: > > On Wednesday, June 30, 2021 7:43 PM vignesh C wrote: > > Thanks for reporting this issue, the attached v9 patch fixes this issue. > > This also fixes the other issue you reported at [1]. > > Hi, >

Re: Added schema level support for publication.

On Fri, Jul 9, 2021 at 12:12 PM Greg Nancarrow wrote: > > On Fri, Jul 9, 2021 at 1:28 PM houzj.f...@fujitsu.com > wrote: > > > > Currently, postgres caches publication actions info in the > > RelationData::rd_pubactions, but after applying the patch, it seems > > rd_pubactions is not initialized

Re: Enhanced error message to include hint messages for redundant options error

.On Sun, Jul 11, 2021 at 2:57 PM Dean Rasheed wrote: > > On Sat, 10 Jul 2021 at 17:03, vignesh C wrote: > > > > > Also, I don't think this function should be marked inline -- using a > > > normal function ought to help make the compiled code smaller. > &g

Re: psql - factor out echo code

On Sat, Jul 10, 2021 at 10:25 PM Fabien COELHO wrote: > > > Hello Vignesh, > > > I am changing the status to "Needs review" as the review is not > > completed for this patch and also there are some tests failing, that > > need to be fixed: > > test test_extdepend ... FAILED 50

Re: Enhanced error message to include hint messages for redundant options error

On Sat, Jul 10, 2021 at 4:31 PM Dean Rasheed wrote: > > On Sat, 10 Jul 2021 at 11:44, Dean Rasheed wrote: > > > > I'm inclined to think that it isn't worth the effort trying to > > distinguish between conflicting options, options specified more than > > once and faked-up options that weren't

Re: Enhanced error message to include hint messages for redundant options error

On Sat, Jul 10, 2021 at 4:14 PM Dean Rasheed wrote: > > On Thu, 8 Jul 2021 at 14:40, vignesh C wrote: > > > > On Thu, Jul 8, 2021 at 1:52 AM Daniel Gustafsson wrote: > > > > > > I sort of like the visual cue of seeing ereport(ERROR .. since it makes

Re: psql - factor out echo code

On Sat, Jul 3, 2021 at 3:07 AM Fabien COELHO wrote: > > > > "-- # QUERY\n%s\n\n" > > Attached an attempt along those lines. I found another duplicate of the > ascii-art printing in another function. > > Completion queries seems to be out of the echo/echo hidden feature. > > Incredible, there is

Re: proposal - psql - use pager for \watch command

On Wed, May 12, 2021 at 5:45 PM Pavel Stehule wrote: > > > > st 12. 5. 2021 v 12:25 odesílatel Pavel Stehule > napsal: >> >> Hi >> >> st 21. 4. 2021 v 8:52 odesílatel Pavel Stehule >> napsal: >>> >>> >>> >>> st 21. 4. 2021 v 8:49 odesílatel Thomas Munro >>> napsal: On Wed, Apr 21,

Re: Parallel Full Hash Join

On Mon, May 31, 2021 at 10:47 AM Greg Nancarrow wrote: > > On Sat, Mar 6, 2021 at 12:31 PM Thomas Munro wrote: > > > > On Tue, Mar 2, 2021 at 11:27 PM Thomas Munro wrote: > > > On Fri, Feb 12, 2021 at 11:02 AM Melanie Plageman > > > wrote: > > > > I just attached the diff. > > > > > > Squashed

Re: Enhanced error message to include hint messages for redundant options error

On Thu, Jul 8, 2021 at 1:52 AM Daniel Gustafsson wrote: > > > On 6 Jul 2021, at 17:08, vignesh C wrote: > > > The patch was not applying on the head because of the recent commit > > "8aafb02616753f5c6c90bbc567636b73c0cbb9d4", attached patch which is >

Re: [HACKERS] logical decoding of two-phase transactions

On Thu, Jul 8, 2021 at 11:37 AM Amit Kapila wrote: > > On Tue, Jul 6, 2021 at 9:58 AM Peter Smith wrote: > > > > Please find attached the latest patch set v93* > > > > Thanks, I have gone through the 0001 patch and made a number of > changes. (a) Removed some of the code which was leftover from

Re: Enhanced error message to include hint messages for redundant options error

On Wed, Jun 30, 2021 at 7:48 PM vignesh C wrote: > > On Thu, May 13, 2021 at 8:09 PM vignesh C wrote: > > > > On Thu, May 13, 2021 at 4:58 AM Alvaro Herrera > > wrote: > > > > > > > Thanks for the comments, Attached patch has the changes for the sam

Re: Identify missing publications from publisher while create/alter subscription.

On Wed, Jun 30, 2021 at 8:23 PM vignesh C wrote: > > On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote: > > > > On Fri, May 7, 2021 at 6:44 PM vignesh C wrote: > > > > > > Thanks for the comments, the attached patch has the fix for the same. > >

Re: Race condition in InvalidateObsoleteReplicationSlots()

On Mon, Jul 5, 2021 at 10:30 PM Álvaro Herrera wrote: > > On 2021-Jul-05, vignesh C wrote: > > > On Wed, Jun 23, 2021 at 7:32 PM Álvaro Herrera > > wrote: > > > > > > On 2021-Jun-20, Tom Lane wrote: > > > > > > > Actually ... isn't

Re: simplifying foreign key/RI checks

On Sun, Apr 4, 2021 at 1:51 PM Amit Langote wrote: > > On Fri, Apr 2, 2021 at 11:55 PM Zhihong Yu wrote: > > > > Hi, > > > > + skip = !ExecLockTableTuple(erm->relation, , markSlot, > > + estate->es_snapshot, > > estate->es_output_cid, > > +

Re: Pre-allocating WAL files

On Mon, Jun 7, 2021 at 8:48 PM Bossart, Nathan wrote: > > On 12/25/20, 12:09 PM, "Andres Freund" wrote: > > When running write heavy transactional workloads I've many times > > observed that one needs to run the benchmarks for quite a while till > > they get to their steady state performance.

Re: Race condition in InvalidateObsoleteReplicationSlots()

On Wed, Jun 23, 2021 at 7:32 PM Álvaro Herrera wrote: > > On 2021-Jun-20, Tom Lane wrote: > > > Actually ... isn't there a second race, in the opposite direction? > > IIUC, the point of this is that once we force some WAL to be sent > > to the frozen sender/receiver, they'll be killed for failure

Re: Re[3]: On login trigger: take three

On Thu, Jun 3, 2021 at 8:36 AM Greg Nancarrow wrote: > > On Fri, May 21, 2021 at 2:46 PM Greg Nancarrow wrote: > > > > On Thu, May 20, 2021 at 2:45 PM Ivan Panchenko wrote: > > > > > > I have upgraded the patch for the 14th version. > > > > > > > I have some feedback on the patch: > > > > I've

Re: Disable WAL logging to speed up data loading

On Wed, Apr 7, 2021 at 12:13 PM osumi.takami...@fujitsu.com wrote: > > Hi > > > Mainly affected by a commit 9de9294, > I've fixed minor things to rebase the patch. > All modifications I did are cosmetic changes and > a little bit of documentation updates. > Please have a look at attached v09. >

Re: Commit fest manager

On Fri, Jul 2, 2021 at 6:05 PM Ibrar Ahmed wrote: > > > > On Fri, 2 Jul 2021 at 1:47 PM, David Rowley wrote: >> >> On Fri, 2 Jul 2021 at 15:04, vignesh C wrote: >> > I'm interested in assisting Ibrar Ahmed. >> >> It might be worth talking to Ibrar

Re: Added schema level support for publication.

On Fri, Jul 2, 2021 at 10:18 AM tanghy.f...@fujitsu.com wrote: > > On Wednesday, June 30, 2021 7:43 PM vignesh C wrote: > > > > Thanks for reporting this issue, the attached v9 patch fixes this issue. > > This also fixes the other issue you reported at [1]. > > A c

Logical replication - schema change not invalidating the relation cache

Hi, I found a strange behavior when there is an insert after renaming the schema. The test steps for the same are given below, Here after the schema is renamed, the renamed schema table data should not be sent, but the data was being sent. I felt the schema invalidation was not called, attached a

Re: Commit fest manager

On Fri, Jul 2, 2021 at 7:08 AM Michael Paquier wrote: > > On Thu, Jul 01, 2021 at 09:29:01PM -0400, Bruce Momjian wrote: > > Should we reserve the next commit fest for vignesh C? > > If Vignesh is willing to help here, I'd say yes to that. I'm interested in assisting Ibr

Re: Added schema level support for publication.

On Thu, Jul 1, 2021 at 5:43 PM Bharath Rupireddy wrote: > > On Tue, Jun 22, 2021 at 10:11 AM Bharath Rupireddy > wrote: > > > > On Tue, Jun 22, 2021 at 9:45 AM vignesh C wrote: > > > I have removed the skip table patches to keep the focus on the main >

Re: Column Filtering in Logical Replication

On Thu, Jul 1, 2021 at 1:06 AM Rahila Syed wrote: > > Hi, > > Filtering of columns at the publisher node will allow for selective > replication of data between publisher and subscriber. In case the updates on > the publisher are targeted only towards specific columns, the user will have > an

Re: Identify missing publications from publisher while create/alter subscription.

On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote: > > On Fri, May 7, 2021 at 6:44 PM vignesh C wrote: > > > > Thanks for the comments, the attached patch has the fix for the same. > > The patch was not applying on the head, attached patch which is rebased on > HEAD.

Re: Enhanced error message to include hint messages for redundant options error

On Thu, May 13, 2021 at 8:09 PM vignesh C wrote: > > On Thu, May 13, 2021 at 4:58 AM Alvaro Herrera > wrote: > > > > Thanks for the comments, Attached patch has the changes for the same. > The Patch was not applying on Head, the attached patch is rebased on top of Head

Commit fest manager

Hi all, The next commit fest is going to begin soon. I would like to volunteer as commit fest manager for 2021-07 if the role is not filled and there are no objections. Regards, Vignesh

Re: [HACKERS] logical decoding of two-phase transactions

On Tue, Jun 29, 2021 at 12:26 PM Amit Kapila wrote: > > On Wed, Jun 23, 2021 at 4:10 PM Ajin Cherian wrote: > > > > The first two patches look mostly good to me. I have combined them > into one and made some minor changes. (a) Removed opt_two_phase and > related code from repl_gram.y as that is

Re: missing GRANT on pg_subscription columns

On Mon, Jun 7, 2021 at 2:38 PM Amit Kapila wrote: > > On Thu, Jun 3, 2021 at 10:39 PM Tom Lane wrote: > > > > "Euler Taveira" writes: > > > I was checking the GRANT on pg_subscription and noticed that the command > > > is not > > > correct. There is a comment that says "All columns of

Re: alter subscription drop publication fixes

On Fri, Jun 25, 2021 at 1:30 PM Peter Eisentraut wrote: > > On 15.05.21 15:15, vignesh C wrote: > > Thanks Bharath, that looks good. I have added a commitfest entry at [1] > > and marked it to Ready For Committer. > > [1] - https://commitfest.postgresql

Re: Added schema level support for publication.

On Thu, Jun 24, 2021 at 12:10 PM tanghy.f...@fujitsu.com wrote: > > Hi > > I applied your V7* patch and complied it. The following warnings came out, > please take a look. > > >pg_publication.c:688:22: warning: ‘tables’ may be used uninitialized in this > >function [-Wmaybe-uninitialized] > >

Re: Added schema level support for publication.

On Thu, Jun 24, 2021 at 2:12 PM Greg Nancarrow wrote: > > On Thu, Jun 24, 2021 at 4:41 PM tanghy.f...@fujitsu.com > wrote: > > > > I applied your V7* patch and complied it. The following warnings came out, please take a look. > > > > I encountered the following warnings when building with the v7

Re: [HACKERS] logical decoding of two-phase transactions

On Wed, Jun 23, 2021 at 9:10 AM Ajin Cherian wrote: > > On Tue, Jun 22, 2021 at 3:36 PM Greg Nancarrow wrote: > > > Some minor comments: > > > > (1) > > v88-0002 > > > > doc/src/sgml/logicaldecoding.sgml > > > > "examples shows" is not correct. > > I think there is only ONE example being

Re: Added schema level support for publication.

Thanks for the comments. On Fri, Jun 18, 2021 at 5:25 PM Ajin Cherian wrote: > > On Thu, Jun 17, 2021 at 12:41 AM vignesh C wrote: > > > Thanks for reporting it, the attached patch is a rebased version of > > the patch with few review comment fixes, I will reply with

Re: [HACKERS] logical decoding of two-phase transactions

On Thu, Jun 17, 2021 at 7:40 PM Ajin Cherian wrote: > > On Wed, Jun 16, 2021 at 9:08 AM Peter Smith wrote: > > > > On Fri, Jun 11, 2021 at 6:34 PM Peter Smith wrote: > > > > > KNOWN ISSUES: This v85 patch was built and tested using yesterday's > > > master, but due to lots of recent activity in

Re: Added schema level support for publication.

On Wed, Jan 20, 2021 at 6:27 PM Rahila Syed wrote: > > Hi Vignesh, > >> >> I have handled the above scenario(drop schema should automatically >> remove the schema entry from publication schema relation) & addition >> of tests in the new v2 patch attached. >> Thoughts? > > > Please see some

Re: locking [user] catalog tables vs 2pc vs logical rep

On Wed, Jun 16, 2021 at 3:51 PM Amit Kapila wrote: > > On Mon, Jun 14, 2021 at 5:33 PM osumi.takami...@fujitsu.com > wrote: > > > > On Friday, June 11, 2021 2:13 PM vignesh C wrote: > > > > Attached the patch-set that addressed those two comments

Re: Added schema level support for publication.

On Wed, Jun 16, 2021 at 4:59 PM Amit Kapila wrote: > > On Sat, Jan 9, 2021 at 8:08 PM Bharath Rupireddy > wrote: > > > > And, with this feature, since there can be many huge tables inside a > > schema, the initial table sync phase of the replication can take a > > while. > > > > Say a user has

Re: locking [user] catalog tables vs 2pc vs logical rep

On Mon, Jun 14, 2021 at 5:33 PM osumi.takami...@fujitsu.com wrote: > > On Friday, June 11, 2021 2:13 PM vignesh C wrote: > > Thanks for the updated patch: > > Few comments: > > 1) We have used Reordering and Clustering for the same command, we could > > rep

Re: Added missing tab completion for alter subscription set option

On Fri, Jun 11, 2021 at 12:27 PM Michael Paquier wrote: > > On Sun, May 23, 2021 at 04:24:59PM +0530, vignesh C wrote: > > /* Complete "CREATE SUBSCRIPTION ... WITH ( " */ > > else if (HeadMatches("CREATE

Re: locking [user] catalog tables vs 2pc vs logical rep

On Fri, Jun 11, 2021 at 6:57 AM osumi.takami...@fujitsu.com wrote: > > On Thursday, June 10, 2021 1:30 PM I wrote: > > On Thursday, June 10, 2021 1:14 PM vignesh C > > > On Wed, Jun 9, 2021 at 12:03 PM osumi.takami...@fujitsu.com > > > wrote: > > > > &

Re: locking [user] catalog tables vs 2pc vs logical rep

On Wed, Jun 9, 2021 at 12:03 PM osumi.takami...@fujitsu.com wrote: > > On Wednesday, June 9, 2021 12:06 PM Amit Kapila > wrote: > > On Tue, Jun 8, 2021 at 6:24 PM vignesh C wrote: > > > > > > Thanks for the updated patch. > > > > > > I ha

Re: locking [user] catalog tables vs 2pc vs logical rep

On Tue, Jun 8, 2021 at 1:34 PM osumi.takami...@fujitsu.com wrote: > > On Monday, June 7, 2021 6:22 PM Amit Kapila wrote: > > On Mon, Jun 7, 2021 at 10:44 AM Amit Kapila > > wrote: > > > > > > One more comment is that for HEAD, first just create a patch with > > > synchronous replication-related

Re: locking [user] catalog tables vs 2pc vs logical rep

On Mon, Jun 7, 2021 at 4:18 AM osumi.takami...@fujitsu.com wrote: > > On Thursday, June 3, 2021 7:07 PM Amit Kapila wrote: > > On Thu, Jun 3, 2021 at 9:18 AM osumi.takami...@fujitsu.com > > wrote: > > > Thank you for providing the patch. > > > I have updated your patch to include some other

Re: Identify missing publications from publisher while create/alter subscription.

On Fri, May 7, 2021 at 6:44 PM vignesh C wrote: > > On Fri, May 7, 2021 at 5:44 PM Dilip Kumar wrote: > > > > On Fri, May 7, 2021 at 5:38 PM Bharath Rupireddy > > wrote: > > > > > > On Fri, May 7, 2021 at 11:50 AM Dilip Kumar wrote: > > >

Re: locking [user] catalog tables vs 2pc vs logical rep

On Thu, Jun 3, 2021 at 9:18 AM osumi.takami...@fujitsu.com wrote: > > On Tuesday, June 1, 2021 4:33 PM Peter Smith > > To: Andres Freund > > Cc: PostgreSQL-development ; Amit Kapila > > ; Markus Wanner > > > > Subject: Re: locking [user] catalog tables vs 2pc vs logical rep > > > > Hi. > > > >

Re: CREATE COLLATION - check for duplicate options and error out if found one

On Sat, May 29, 2021 at 9:20 PM Bharath Rupireddy wrote: > > On Sat, May 29, 2021 at 9:08 PM vignesh C wrote: > > One minor comment: > > You can remove the brackets around errcode, You could change: > > + if (localeEl) > > + ereport(ERROR, > > + (errcode

Re: Addition of alias types regpublication and regsubscription

On Sat, May 29, 2021 at 9:10 PM Tom Lane wrote: > > vignesh C writes: > > I felt inclusion of alias types regpublication and regsubscription will > > help the logical replication users. > > This doesn't really seem worth the trouble --- how often would you > use th

Re: CREATE COLLATION - check for duplicate options and error out if found one

On Wed, May 26, 2021 at 7:44 PM Bharath Rupireddy wrote: > > On Wed, May 26, 2021 at 7:18 PM vignesh C wrote: > > +1 for fixing this issue, we have handled this error in other places. > > The patch does not apply on head, could you rebase the patch on head > > and post a

Addition of alias types regpublication and regsubscription

Hi, I felt inclusion of alias types regpublication and regsubscription will help the logical replication users. This will also help in [1]. The alias types allow simplified lookup of publication oid values for objects. For example, to examine the pg_publication_rel rows, one could write: SELECT

Re: [HACKERS] logical decoding of two-phase transactions

On Fri, May 28, 2021 at 9:14 AM Ajin Cherian wrote: > > On Wed, May 26, 2021 at 6:53 PM vignesh C wrote: > > > > On Tue, May 25, 2021 at 8:54 AM Ajin Cherian wrote: > > > > > > On Fri, May 21, 2021 at 6:43 PM Peter Smith wrote: > > > > > &g

Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation

On Wed, May 26, 2021 at 7:55 PM Bharath Rupireddy wrote: > > On Wed, May 26, 2021 at 7:38 PM vignesh C wrote: > > > Attaching v5 patch, please have a look. > > > > We get the following error while adding an index: > > create publication mypub for table idx_t1;

Re: CREATE COLLATION - check for duplicate options and error out if found one

On Wed, May 26, 2021 at 7:44 PM Bharath Rupireddy wrote: > > On Wed, May 26, 2021 at 7:18 PM vignesh C wrote: > > +1 for fixing this issue, we have handled this error in other places. > > The patch does not apply on head, could you rebase the patch on head > > and post a

Re: logical replication empty transactions

On Tue, May 25, 2021 at 6:36 PM Ajin Cherian wrote: > > On Tue, Apr 27, 2021 at 1:49 PM Ajin Cherian wrote: > > Rebased the patch as it was no longer applying. Thanks for the updated patch, few comments: 1) I'm not sure if we could add some tests for skip empty transactions, if possible add a

Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation

On Mon, Apr 5, 2021 at 7:19 PM Bharath Rupireddy wrote: > > On Mon, Apr 5, 2021 at 6:41 PM Euler Taveira wrote: > > Here's the v4 patch reabsed on the latest master, please review it further. > > > > /* UNLOGGED and TEMP relations cannot be part of publication. */ > > if

Re: CREATE COLLATION - check for duplicate options and error out if found one

On Tue, Apr 27, 2021 at 3:21 PM Bharath Rupireddy wrote: > > Hi, > > While reviewing [1], I found that the CREATE COLLATION doesn't throw an error > if duplicate options are specified, see [2] for testing a few cases on HEAD. > This may end up accepting some of the weird cases, see [2]. It's

Re: locking [user] catalog tables vs 2pc vs logical rep

On Tue, May 25, 2021 at 12:40 PM Michael Paquier wrote: > > On Mon, May 24, 2021 at 10:03:01AM +0530, Amit Kapila wrote: > > So, this appears to be an existing caveat of synchronous replication. > > If that is the case, I am not sure if it is a good idea to just block > > such ops for the

Re: [HACKERS] logical decoding of two-phase transactions

On Tue, May 25, 2021 at 8:54 AM Ajin Cherian wrote: > > On Fri, May 21, 2021 at 6:43 PM Peter Smith wrote: > > > Fixed in v77-0001, v77-0002 > > Attaching a new patch-set that rebases the patch, addresses review > comments from Peter as well as a test failure reported by Tang. I've > also added

Re: Replication slot stats misgivings

On Mon, May 24, 2021 at 9:38 AM Amit Kapila wrote: > > On Thu, May 13, 2021 at 11:30 AM vignesh C wrote: > > > > Do we want to update the information about pg_stat_replication_slots > at the following place in docs > https://www.postgresql.org/docs/devel/logicaldecoding-

Re: Added missing tab completion for alter subscription set option

On Wed, May 19, 2021 at 2:03 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > > On Tue, May 18, 2021 at 9:21 PM Alvaro Herrera wrote: > > > > On 2021-May-14, vignesh C wrote: > > > > > While I was reviewing one of the logical dec

<    6   7   8   9   10   11   12   13   14   15   >