Re: Support "Right Semi Join" plan shapes

2024-04-28 Thread wenhui qiu
Hi Richard Thank you so much for your tireless work on this,I see the new version of the patch improves some of the comments .I think it can commit in July Thanks On Thu, 25 Apr 2024 at 11:28, Richard Guo wrote: > Here is another rebase with a commit message to help review. I also >

Re: POC: make mxidoff 64 bits

2024-04-23 Thread wenhui qiu
Hi Maxim Orlov Thank you so much for your tireless work on this. Increasing the WAL size by a few bytes should have very little impact with today's disk performance(Logical replication of this feature wal log is also increased a lot, logical replication is a milestone new feature, and the

Re: allow changing autovacuum_max_workers without restarting

2024-04-17 Thread wenhui qiu
Agree +1,From a dba perspective, I would prefer that this parameter can be dynamically modified, rather than adding a new parameter,What is more difficult is how to smoothly reach the target value when the setting is considered to be too large and needs to be lowered. Regards On Tue, 16 Apr

Re: Commitfest Manager for March

2024-03-20 Thread wenhui qiu
Hi Aleksander Alekseev Could you take a look at the patch ( https://commitfest.postgresql.org/47/4284/),How about your opinion Thanks On Tue, 12 Mar 2024 at 21:41, Aleksander Alekseev wrote: > Hi Andrey, > > > > If you need any help please let me know. > > > > Aleksander, I would

Re: Support "Right Semi Join" plan shapes

2024-03-05 Thread wenhui qiu
Hi Alena Rybakina For merge join + /* + * For now we do not support RIGHT_SEMI join in mergejoin. + */ + if (jointype == JOIN_RIGHT_SEMI) + { + *mergejoin_allowed = false; + return NIL; + } + Tanks On Wed, 6 Mar 2024 at 04:10, Alena Rybakina wrote: > To be honest, I didn't see it in the code,

Re: Support "Right Semi Join" plan shapes

2024-03-04 Thread wenhui qiu
Hi Richard Agree +1 ,I think can push now. Richard On Tue, 5 Mar 2024 at 10:44, Richard Guo wrote: > > On Tue, Jan 30, 2024 at 2:51 PM Alena Rybakina > wrote: > >> I have reviewed your patch and I think it is better to add an Assert for >> JOIN_RIGHT_SEMI to the ExecMergeJoin and

Re: Support "Right Semi Join" plan shapes

2024-03-03 Thread wenhui qiu
HI Richard Now it is starting the last commitfest for v17, can you respond to Alena Rybakina points? Regards On Thu, 8 Feb 2024 at 13:50, wenhui qiu wrote: > Hi Alena Rybakina > I saw this code snippet also disable mergejoin ,I think it same effect > + /* > + * F

Re: Thoughts about NUM_BUFFER_PARTITIONS

2024-02-23 Thread wenhui qiu
efault value is 4, which corresponds to 16 partitions, and the maximum is 8. This parameter can only be set in the postgresql.conf file or on the server command line. Best wish On Tue, 20 Feb 2024 at 21:55, Tomas Vondra wrote: > Hi, > > On 2/20/24 03:16, wenhui qiu wrote: > >

Re: Thoughts about NUM_BUFFER_PARTITIONS

2024-02-19 Thread wenhui qiu
. ` wenhui qiu 于2024年2月20日周二 09:36写道: > Hi Japlin Li >Thank you for such important information ! Got it > > Japin Li 于2024年2月19日周一 10:26写道: > >> >> On Mon, 19 Feb 2024 at 00:56, Tomas Vondra >> wrote: >> > On 2/18/24 03:30, Li Jap

Re: Thoughts about NUM_BUFFER_PARTITIONS

2024-02-19 Thread wenhui qiu
Hi Japlin Li Thank you for such important information ! Got it Japin Li 于2024年2月19日周一 10:26写道: > > On Mon, 19 Feb 2024 at 00:56, Tomas Vondra > wrote: > > On 2/18/24 03:30, Li Japin wrote: > >> > >> I find it seems need to change MAX_SIMUL_LWLOCKS if we enlarge the > NUM_BUFFER_PARTITIONS,

Re: Thoughts about NUM_BUFFER_PARTITIONS

2024-02-08 Thread wenhui qiu
, but the result report is in Chinese Best wishes Heikki Linnakangas 于2024年2月8日周四 19:26写道: > On 08/02/2024 12:17, wenhui qiu wrote: > > HI hackers > > When I read this text in this document there is a paragraph in > > it(https://www.interdb.jp/pg/pgsql08/03.html > &

Thoughts about NUM_BUFFER_PARTITIONS

2024-02-08 Thread wenhui qiu
HI hackers When I read this text in this document there is a paragraph in it( https://www.interdb.jp/pg/pgsql08/03.html) /* The BufMappingLock is split into partitions to reduce contention in the buffer table (the default is 128 partitions). Each BufMappingLock partition guards a portion of

Re: Support "Right Semi Join" plan shapes

2024-02-07 Thread wenhui qiu
Hi Alena Rybakina I saw this code snippet also disable mergejoin ,I think it same effect + /* + * For now we do not support RIGHT_SEMI join in mergejoin. + */ + if (jointype == JOIN_RIGHT_SEMI) + { + *mergejoin_allowed = false; + return NIL; + } + Regards Alena Rybakina 于2024年1月30日周二 14:51写道:

Re: Support "Right Semi Join" plan shapes

2024-01-23 Thread wenhui qiu
Hi vignesh C Many thanks, I have marked it to "ready for committer" Best wish vignesh C 于2024年1月23日周二 10:56写道: > On Mon, 22 Jan 2024 at 11:27, wenhui qiu wrote: > > > > Hi vignesh CI saw this path has been passed ( > https://cirrus-ci.com/build/6

Re: Support "Right Semi Join" plan shapes

2024-01-21 Thread wenhui qiu
Hi vignesh CI saw this path has been passed ( https://cirrus-ci.com/build/6109321080078336),can we push it? Best wish Richard Guo 于2024年1月9日周二 18:49写道: > > On Sun, Jan 7, 2024 at 3:03 PM vignesh C wrote: > >> One of the tests in CFBot has failed at [1] with: >> - Relations: (public.ft1

Re: Support "Right Semi Join" plan shapes

2023-12-27 Thread wenhui qiu
AND i4.f1 = a.tenthous; QUERY PLAN Hash Join Hash Cond: (a.tenthous = i4.f1) -> Seq Scan on tenk1 a Filter: (SubPlan 1) SubPlan 1 ->

Re: Transaction timeout

2023-12-20 Thread wenhui qiu
Hi Junwang Zhao Agree +1 Best whish Junwang Zhao 于2023年12月20日周三 10:35写道: > On Wed, Dec 20, 2023 at 9:58 AM Thomas wen > wrote: > > > > Hi Junwang Zhao > > #should we invalidate lock_timeout? Or maybe just document this. > > I think you mean when lock_time is greater than

Re: Add 64-bit XIDs into PostgreSQL 15

2023-12-15 Thread wenhui qiu
Hi Pavel Borisov Many thanks Best whish Pavel Borisov 于2023年12月15日周五 17:13写道: > Hi, Wenhui! > > On Fri, 15 Dec 2023 at 05:52, wenhui qiu wrote: > >> Hi Maxim Orlov >> Good news,xid64 has achieved a successful first phase,I tried to >>

Support "Right Semi Join" plan shapes

2023-12-14 Thread wenhui qiu
Hi Richard Guo I see that the test samples are all (exists) subqueries ,I think semi join should also support ( in) and ( any) subqueries. would you do more test on ( in) and ( any) subqueries? Best whish

Re: Add 64-bit XIDs into PostgreSQL 15

2023-12-14 Thread wenhui qiu
Hi Maxim Orlov Good news,xid64 has achieved a successful first phase,I tried to change the path status (https://commitfest.postgresql.org/43/3594/) ,But it seems incorrect Maxim Orlov 于2023年12月13日周三 20:26写道: > Hi! > > Just to keep this thread up to date, here's a new version after recent >