On Mon, Jun 10, 2024 at 03:10:33PM +0900, Michael Paquier wrote:
> OK, cool. I'll try to get that into the tree once v18 opens up.
And I've spent more time on this one, and applied it to v18 after some
slight tweaks. Please feel free to re-post your tests with
multixacts, Andrey.
--
Michael
Dear Amit,
Sorry, I forgot to say one content.
> > But that is not a good reason for this operation to stop workers
> > first. Instead, we should prohibit this operation if any worker is
> > present. The reason is that there is always a chance that if any
> > worker is alive, it can prepare a
On Fri, Jul 5, 2024 at 11:58 AM Dilip Kumar wrote:
>
> On Thu, Jul 4, 2024 at 5:37 PM Amit Kapila wrote:
> > > So, the situation will be the same. We can even
> > > > decide to spill the data to files if the decision is that we need to
> > > > wait to avoid network buffer-fill situations. But
On Fri, Jul 5, 2024, at 01:18, Michael Paquier wrote:
> I would still stick to only one function, with arguments coming from
> scanning pg_[sh]depend.
>
>> I found some code in aclchk.c on line 4452-4468 that seems useful,
>> but not sure. Maybe there is some other existing code that is better
>>
On 04/07/2024 23:20, Andres Freund wrote:
On 2024-07-04 01:54:18 +0300, Heikki Linnakangas wrote:
I believe that was just an oversight. Trivial patch attached.
Oops. Yes, I clearly should have used dlist_container() here.
Committed, thanks.
--
Heikki Linnakangas
Neon (https://neon.tech)
> On 5 Jul 2024, at 09:12, 杨伯宇(长堂) wrote:
> 1: Skip Compatibility Check In "pg_upgrade"
> =
> Concisely, we've got several databases, each with a million-plus tables.
> Running the compatibility check before pg_dump can eat up like half an hour.
> If I
Here are my review comments for v14-0002.
==
src/backend/replication/logical/tablesync.c
make_copy_attnamelist:
nitpick - remove excessive parentheses in palloc0 call.
nitpick - Code is fine AFAICT except it's not immediately obvious
localgenlist is indexed by the *remote* attribute
On Wed, 3 Jul 2024 at 01:08, Melih Mutlu wrote:
> An example query to get total used bytes including children by using level
> info would look like:
>
> WITH contexts AS (
> SELECT * FROM pg_backend_memory_contexts
> )
> SELECT sum(total_bytes)
> FROM contexts
> WHERE path[( SELECT level+1 FROM
On 2024-07-05 12:59, Fujii Masao wrote:
On 2024/07/04 12:05, torikoshia wrote:
I'm going to update it after discussing the option format as described
below.
Thanks!
I agree that it's possible to use only REJECT_LIMIT without ON_ERROR.
I also think it's easy to understand that REJECT_LIMIT=0
Hello postgres hackers:
I am recently working on speeding up pg_upgrade for database with over a
million tables and would like to share some (maybe) optimizeable or
interesting findings.
1: Skip Compatibility Check In "pg_upgrade"
=
Concisely, we've
On Mon, Jul 1, 2024 at 5:04 AM Peter Smith wrote:
>
> On Fri, Jun 28, 2024 at 4:18 PM Amit Kapila wrote:
> >
> ...
> > Shouldn't the check for flushptr (if (flushptr < targetPagePtr +
> > reqLen)) be moved immediately after the call to WalSndWaitForWal().
> > The comment seems to suggests the
On Thu, Jul 4, 2024 at 5:37 PM Amit Kapila wrote:
> > So, the situation will be the same. We can even
> > > decide to spill the data to files if the decision is that we need to
> > > wait to avoid network buffer-fill situations. But note that the wait
> > > in apply worker has consequences that
On Wed, 3 Jul 2024 at 22:41, David Rowley wrote:
>
> On Wed, 3 Jul 2024 at 00:20, Matthias van de Meent
> > Lastly, I think this would benefit from a test in
> > regress/sql/explain.sql, as the test changes that were included
> > removed the only occurrance of a Materialize node from the
On Fri, Jun 28, 2024 at 6:30 PM Bertrand Drouvot
wrote:
>
> On Fri, Jun 28, 2024 at 03:15:22PM +0530, Amit Kapila wrote:
> > On Fri, Jun 28, 2024 at 12:55 PM Peter Smith wrote:
> > >
> >
> > I don't know whether your assumption is correct. AFAICS, those two
> > lines should be together. Let us
On Fri, Jun 28, 2024 at 06:00:07PM +0530, Ashutosh Bapat wrote:
> Here's a description of patches and some notes
> 0001
> ---
> 1. Per your suggestion the logic to handle dump output differences is
> externalized in PostgreSQL::Test::AdjustDump. Instead of eliminating those
> differences
On Sat, Jun 29, 2024 at 07:12:11PM -0700, Noah Misch wrote:
> Commits 9886744 and b83747a added /D to two %comspec% callers. I gather they
> arose to make particular cmd.exe invocations have just one child. However,
> http://postgr.es/m/20240111.173322.1809044112677090191.horikyota@gmail.com
On Fri, 5 Jul 2024 at 16:00, Alexander Lakhin wrote:
> Please look at a segfault crash introduced with 1eff8279d:
> CREATE TABLE t1(i int);
> CREATE TABLE t2(i int) PARTITION BY RANGE (i);
> CREATE TABLE t2p PARTITION OF t2 FOR VALUES FROM (1) TO (2);
>
> EXPLAIN ANALYZE SELECT * FROM t1 JOIN t2
On Sat, Jun 29, 2024 at 11:13:04PM +0200, Tomas Vondra wrote:
> I think those are two independent issues - knowing that the snapshot is
> from the last checkpoint, and knowing that it's correct (not corrupted).
> And yeah, we should be careful about fsync/durable_rename.
Yeah, that's bugging me
Hi Vignesh.
After applying the v20240703-0003 patch, I was always getting errors
when running the subscription TAP tests.
# +++ tap check in src/test/subscription +++
t/001_rep_changes.pl ... ok
t/002_types.pl . ok
t/003_constraints.pl ... ok
Hi
I think the documentation should be updated and all pre-reqs must be added.
Regards
Kashif Zeeshan
On Thu, Jul 4, 2024 at 11:02 PM Said Assemlal wrote:
> Hi,
>
>
> I just built postgresql on macos sonoma (v14) and I had to install the
> following packages:
>
>- * icu -
Hello David,
03.07.2024 13:41, David Rowley wrote:
Lastly, I think this would benefit from a test in
regress/sql/explain.sql, as the test changes that were included
removed the only occurrance of a Materialize node from the regression
tests' EXPLAIN outputs.
I've modified the tests where the
On 2024/07/04 12:05, torikoshia wrote:
I'm going to update it after discussing the option format as described below.
Thanks!
I agree that it's possible to use only REJECT_LIMIT without ON_ERROR.
I also think it's easy to understand that REJECT_LIMIT=0 is ON_ERROR=stop.
However, expressing
On Tue, Jul 02, 2024 at 12:38:07PM +0200, Joel Jacobson wrote:
> Rebased version.
> Uses ACL acronym added in commit 00d819d46a6f5b7e9d2e02948a1c80d11c4ce260:
> doc: Add ACL acronym for "Access Control List"
Forgot to push the send button for this one yesterday, done now..
While looking at
On Thu, Jul 4, 2024 at 11:18 PM Japin Li wrote:
> On Thu, 04 Jul 2024 at 17:17, Richard Guo wrote:
> > Here is a new rebase.
> >
> > Barring objections, I'm planning to push it soon.
Pushed. Thanks for all the reviews.
> Thanks for updating the patch. It looks good to me, except for a minor
On Thu, Jul 04, 2024 at 11:00:01AM +0300, Alexander Lakhin wrote:
> Could you please share your thoughts regarding other error cases, which is
> not triggered by existing tests, but still can be easily reached by users?
>
> For example:
> SELECT satisfies_hash_partition(1, 1, 0, 0);
>
> ERROR:
On Fri, 5 Jul 2024 at 01:59, David Rowley wrote:
> I also made a pass over the patch, and I also changed:
>
> 1. Fixed up a few outdated comments in execnodes.h.
> 2. Added a comment in ExecEndBitmapHeapScan() to explain why we += the
> stats rather than memcpy the BitmapHeapScanInstrumentation.
On Thu, Jul 04, 2024 at 11:30:17AM +, Bertrand Drouvot wrote:
> On Wed, Jul 03, 2024 at 06:47:15PM +0900, Michael Paquier wrote:
>> among the following lines:
>> - PgStat_ShmemControl holds an array of void* indexed by
>> PGSTAT_NUM_KINDS, pointing to shared memory areas allocated for each
>>
Thomas Munro writes:
> I had been thinking that I should try harder to make the pg_ prefix
> compile-time configurable (imagine some kind of string-pasting macros
> constructing the names), so that TCL and PG could have fewer diffs.
> But we're already not doing that for the function names, so
On Thu, Jul 4, 2024 at 9:12 PM Aleksander Alekseev
wrote:
> I checked against SDK 15 and 14. I also checked that it doesn't break
> something on Linux.
Thanks for testing!
> The patch seems to work. I don't have a Windows machine unfortunately.
Yeah, Windows doesn't have (it has as part of
On Thu, Jul 04, 2024 at 01:56:52PM -0700, Andres Freund wrote:
> On 2024-07-03 18:47:15 +0900, Michael Paquier wrote:
>> - PgStat_ShmemControl holds an array of void* indexed by
>> PGSTAT_NUM_KINDS, pointing to shared memory areas allocated for each
>> fixed-numbered stats. Each entry is
On Thu, Jul 04, 2024 at 02:08:25PM -0700, Andres Freund wrote:
> I forgot to say: In general I am highly supportive of this effort and thankful
> to Michael for tackling it. The above was just about that one aspect.
Thanks. Let's discuss how people want this stuff to be shaped, and
how much we
On Thu, Jul 04, 2024 at 02:00:47PM -0700, Andres Freund wrote:
> On 2024-06-13 16:59:50 +0900, Michael Paquier wrote:
>> * Making custom stats data persistent is an interesting problem, and
>> there are a couple of approaches I've considered:
>> ** Allow custom kinds to define callbacks to read
(Moving to -hackers)
On Thu, Jul 04, 2024 at 10:53:49PM +0200, Joel Jacobson wrote:
> On Thu, Jul 4, 2024, at 17:44, Tom Lane wrote:
>> Uh, why is it defined like that rather than allowing a subobject?
>> This definition is unable to fetch column-specific ACLs.
Yes, I was wondering about that as
On Thu, Jul 04, 2024 at 08:00:00AM +0300, Alexander Lakhin wrote:
> 28.06.2024 08:13, Noah Misch wrote:
> > Pushed. ...
>
> Please look also at another anomaly, I've discovered.
>
> An Assert added with d5f788b41 may be falsified with:
> CREATE TABLE t(a int PRIMARY KEY);
> INSERT INTO t VALUES
On 2024-07-01 16:29:16 +0800, Richard Guo wrote:
> On Mon, Jun 10, 2024 at 5:05 PM Richard Guo wrote:
> > This patchset does not apply any more. Here is a new rebase.
>
> Here is an updated version of this patchset. I've run pgindent for it,
> and also tweaked the commit messages a bit.
>
>
On Wed, Jul 03, 2024 at 02:19:07PM -0700, Jeff Davis wrote:
> * Unless I made a mistake, the last three releases of Unicode (14.0,
> 15.0, and 15.1) all have the exact same behavior for UPPER() and
> LOWER() -- even for unassigned code points. It would be silly to
> promise to stay with 15.1 and
Hi,
On 2024-07-04 14:00:47 -0700, Andres Freund wrote:
> On 2024-06-13 16:59:50 +0900, Michael Paquier wrote:
> > * Making custom stats data persistent is an interesting problem, and
> > there are a couple of approaches I've considered:
> > ** Allow custom kinds to define callbacks to read and
Hi,
On 2024-06-30 16:47:02 +0200, Matthias van de Meent wrote:
> While hooks are generally not installed by default, I would advise
> against marking the hooks as unlikely, as that would unfairly penalize
> the performance of extensions that do utilise this hook (or hooks in
> general when
Hi,
On 2024-07-04 01:54:18 +0300, Heikki Linnakangas wrote:
> pgproc.h has this:
>
> > struct PGPROC
> > {
> > /* proc->links MUST BE FIRST IN STRUCT (see ProcSleep,ProcWakeup,etc) */
> > dlist_node links; /* list link if process is in a
> > list */
> >
Hi,
On 2024-06-13 16:59:50 +0900, Michael Paquier wrote:
> * Making custom stats data persistent is an interesting problem, and
> there are a couple of approaches I've considered:
> ** Allow custom kinds to define callbacks to read and write data from
> a source they'd want, like their own file
Hi,
On 2024-07-03 18:47:15 +0900, Michael Paquier wrote:
> While looking at a different patch from Tristan in this area at [1], I
> still got annoyed that this patch set was not able to support the case
> of custom fixed-numbered stats, so as it is possible to plug in
> pgstats things similar to
Hi,
+1 for this feature.
Replacing Matviews
--
With patch 0001, a matview can be replaced without having to drop it and
its dependent objects. In our use case it is no longer necessary to
define the actual query in a separate view. Replacing a matview works
analogous to
I wrote:
> Pavel Stehule writes:
>> PLpgSQL uses more often function signature
>> (2024-07-04 19:49:20) postgres=# select bx(0);
>> ERROR: division by zero
>> CONTEXT: PL/pgSQL function fx(integer) line 1 at RETURN
>> PL/pgSQL function bx(integer) line 1 at RETURN
> Oh that's a good idea! So
./configure —help
It will show that you can build —without-icu ,
you can also specify a path to pkg-config via PKG_CONFIG=/path/to/pkg-config
side note: I’ve had better experience building with brew on macos, rather than
macports.
> On 4 Jul 2024, at 9:02 PM, Said Assemlal wrote:
>
> Hi,
I wrote:
> I think it might be cleaner to put the new #include and macro hacking
> into regcustom.h, to show that it's our own hack and not part of the
> "official" Spencer code.
Oh, scratch that. I was thinking regex.h included regcustom.h,
but it doesn't, so there's no way that can work.
On Wed, 3 Jul 2024 at 21:45, Joel Jacobson wrote:
>
> > On Wed, Jul 3, 2024, at 20:57, Dean Rasheed wrote:
> >> I wouldn't expect it to ever be off by more than 1
> >
> > OK, so then the cases I found where it was off by 2 for the mul_var_int()
> > patch
> > are unexpected?
>
> Sorry, I meant
Thomas Munro writes:
> On Mon, Jul 1, 2024 at 2:06 PM Tom Lane wrote:
>> Yeah. I'd do pg_regex_t in a minute except that it'd break existing
>> extensions using our facilities. However, your mention of macrology
>> stirred an idea: could we have our regex/regex.h intentionally
>> #include the
Pavel Stehule writes:
> Getting unique name based on suffix _oid looks not too much nice (using
> _increment can be nicer), but it should to work
Hmm, yeah we could do an increment. It'd make the results in cases
of conflict invocation-order-dependent though, which seems like it
might be worse
Hi,
I just built postgresql on macos sonoma (v14) and I had to install the
following packages:
* * icu - https://ports.macports.org/port/icu/
* * pkg - https://ports.macports.org/port/pkgconfig/
I don't see anything related to this on
čt 4. 7. 2024 v 19:36 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > čt 4. 7. 2024 v 17:27 odesílatel Heikki Linnakangas
> > napsal:
> >> What happens if you rename a function? I guess the error context will
> >> still print the old name, but that's pretty harmless.
>
> > The rename
Pavel Stehule writes:
> čt 4. 7. 2024 v 17:27 odesílatel Heikki Linnakangas
> napsal:
>> What happens if you rename a function? I guess the error context will
>> still print the old name, but that's pretty harmless.
> The rename should to generate different tid, so the function will be
>
Hi
> Hmm, could we do something with tcl namespaces to allow having two
> procedures with the same name? E.g. create a separate namespace, based
> on the OID, for each procedure. I wonder how the stack trace would look
> like then.
>
I didn't do full test, but I think so tcl uses for error
čt 4. 7. 2024 v 17:27 odesílatel Heikki Linnakangas
napsal:
> On 05/06/2024 20:42, Tom Lane wrote:
> > While working on commit b631d0149, I got a bee in my bonnet about
> > how unfriendly PL/Tcl's error CONTEXT reports are:
> >
> > * The context reports expose PL/Tcl's internal names for the Tcl
Hello hackers,
03.05.2024 17:36, David Rowley wrote:
I pushed the patch after only adjusting the path in the docs which had
"module" rather than "modules".
Please look at another bunch of inconsistencies/orphaned entities I found
in the tree, with the possible substitutions:
errmsg_buf ->
Hi.
We encountered a problem with excessive logging when transaction is
sampled.
When it is getting sampled every statement is logged, event SELECT. This
can
lead to performance degradation and log polluting.
I have added new setting to filter statements when transaction is
sampled -
On 26/06/2024 21:42, Peter Eisentraut wrote:
Here is a patch for using gmtime_r() and localtime_r() instead of
gmtime() and localtime(), for thread-safety.
There are a few affected calls in libpq and ecpg's libpgtypes, which are
probably effectively bugs, because those libraries already claim
original CopyOneRowTo:
https://git.postgresql.org/cgit/postgresql.git/tree/src/backend/commands/copyto.c#n922
I change it to:
---
if (!cstate->opts.binary)
{
foreach_int(attnum, cstate->attnumlist)
{
Datum value = slot->tts_values[attnum - 1];
bool isnull =
> On 20 Jun 2024, at 17:22, Andreas Karlsson wrote:
>
> On 10/12/23 11:48 AM, Daniel Gustafsson wrote:
>> Thoughts?
>
> I have looked at the patch and it still applies, builds and passes the test
> cases and I personally think these optimizations are pretty much no-brainers
> that we should
Harjyot Bagga writes:
> One such suggestion or rule for example is the Postgres does not support
> Postfix operators. So whenever a new feature is introduced developers make
> sure that they do not add a postfix operators in their grammar. Just like
> that are there any other further rules or
Hi,
However, as you said, for most use cases, pg_stat_statements and
log_statement may be sufficient.
I would like to withdraw this proposal.
Well, they either require extensions or parameters to be set properly.
One advantage I see to store those kind of information is that it can be
Daniel Gustafsson writes:
> Flex/Bison are only required when building from a Git tree, downloading a
> source archive and building from there might be easier to get started.
> https://www.postgresql.org/ftp/source/
That's no longer true I think - as of v17 the source tarballs won't
On 05/06/2024 20:42, Tom Lane wrote:
While working on commit b631d0149, I got a bee in my bonnet about
how unfriendly PL/Tcl's error CONTEXT reports are:
* The context reports expose PL/Tcl's internal names for the Tcl
procedures it creates, which'd be fine if those names were readable.
But
Hi,
With the current file_fdw, if even one line of data conversion fails,
the contents of the file cannot be referenced at all:
=# \! cat data/test.data
1,a
2,b
a,c
=# create foreign table f_fdw_test_1 (i int, t text) server f_fdw
options (filename 'test.data', format 'csv');
On 2024-Jul-04, Mohab Yaser wrote:
> can you send me a link to download this version on windows as I didn't find
> anything other than the one I already have downloaded
Well,
https://packages.msys2.org/package/flex
has 2.6.4. I don't know what GnuWin32 is, but it looks abandoned.
--
Álvaro
On Thu, 04 Jul 2024 at 17:17, Richard Guo wrote:
> On Fri, Jun 28, 2024 at 3:21 PM Richard Guo wrote:
>> On Fri, Jun 28, 2024 at 2:54 PM Richard Guo wrote:
>> > I've refined this test case further to make it more stable by using an
>> > additional filter 'a.tenthous < 5000'. Besides, I noticed
On Jul 4, 2024, at 04:28, jian he wrote:
> Do you need to reset the datestyle?
Wouldn’t hurt but it’s not necessary, no. It’s set only for the execution of
this file, and there are no more calls that rely on it.
> also the above query is time zone sensitive, maybe the time zone is
> set in
On 2024/07/03 23:29, Nathan Bossart wrote:
On Wed, Jul 03, 2024 at 11:08:48PM +0900, Fujii Masao wrote:
+/*
+ * GUC check_hook for summarize_wal
+ */
+bool
+check_summarize_wal(bool *newval, void **extra, GucSource source)
+{
+ if (*newval && wal_level == WAL_LEVEL_MINIMAL)
+ {
+
> On 4 Jul 2024, at 12:34, Aleksander Alekseev wrote:
>>> Sorry, I only have Linux and MacOS. Here are the scripts I use [2].
>>> Maybe someone who develops on Windows will answer your questions.
>>> However IMO your learning curve will be less steep with a Linux
>>> virtual machine.
>>
>>
> On 4 Jul 2024, at 14:13, Dagfinn Ilmari Mannsåker wrote:
>
> Alvaro Herrera writes:
>
>> On 2024-Jul-04, Tom Lane wrote:
>>
>>> "David G. Johnston" writes:
On Wed, Jul 3, 2024 at 8:46 PM Steve Lau wrote:
> While reading the source code, I noticed comments like "-cim 9/10/89".
On Wed, 26 Jun 2024 at 22:22, wrote:
> 1) Unify the print format of leader and worker
>
> In show_tidbitmap_info(), the number of exact/loosy blocks of the leader and
> workers
> are printed. I think the printed format should be same. Currently, the leader
> does not
> print the blocks of
On Thu, 4 Jul 2024 at 14:43, Tomas Vondra wrote:
> I don't have any immediate feedback regarding this patch, but I'm
> wondering about one thing related to cancellations - we talk cancelling
> a query, but we really target a PID (or a particular backend, no matter
> how we identify it).
>
> I
Em qui., 4 de jul. de 2024 às 05:18, Daniel Gustafsson
escreveu:
> > On 3 Jul 2024, at 13:29, Ranier Vilela wrote:
>
> > With the function *getPublications* I think it would be good to free up
> the allocated memory?
> >
> > }
> > + pg_free(pubinfo);
> > +cleanup:
> >
Hi,
I don't have any immediate feedback regarding this patch, but I'm
wondering about one thing related to cancellations - we talk cancelling
a query, but we really target a PID (or a particular backend, no matter
how we identify it).
I occasionally want to only cancel a particular query, but I
On 2024-07-02 16:21 +0200, Tom Lane wrote:
> Erik Wienhold writes:
> > On 2024-07-02 10:45 +0200, Peter Eisentraut wrote:
> >> I had to revert the test case from the 0002 patch. It ended up running
> >> some
> >> build farm machines out of memory.
>
> >> +ERROR: out of memory
> >> +DETAIL:
Hi Marat,
> V4 path with fixed usage PG_GETARG_BYTEA_PP instead of PG_GETARG_TEXT_PP
Thanks for the patch.
Please add it to the nearest open commitfest [1].
```
+select min(v) from bytea_test_table;
+ min
+--
+ \xaa
+(1 row)
+
+select max(v) from bytea_test_table;
+ max
+--
+ \xff
+(1
On Thu, 4 Jul 2024 at 12:32, Heikki Linnakangas wrote:
> We currently don't do any locking on the ProcSignal array. For query
> cancellations, that's good because a query cancel packet is processed
> without having a PGPROC entry, so we cannot take LWLocks. We could use
> spinlocks though. In
Alvaro Herrera writes:
> On 2024-Jul-04, Tom Lane wrote:
>
>> "David G. Johnston" writes:
>> > On Wed, Jul 3, 2024 at 8:46 PM Steve Lau wrote:
>> >> While reading the source code, I noticed comments like "-cim 9/10/89".
>>
>> > It's the initials of the person who, back in 1989, wrote the
Hi Heikki,
> I tried moving it and ran the regression tests. That revealed one place
> where we still don't use dlist_container:
>
> > if (!dlist_is_empty(procgloballist))
> > {
> > MyProc = (PGPROC *) dlist_pop_head_node(procgloballist);
> > ...
>
> I believe that was
On Wed, Jul 3, 2024 at 5:06 PM Dilip Kumar wrote:
>
> On Wed, Jul 3, 2024 at 4:48 PM Amit Kapila wrote:
> >
> > On Wed, Jul 3, 2024 at 4:04 PM Dilip Kumar wrote:
> > >
> > >
> > > What I am saying is that if we are not applying the whole transaction,
> > > it means we are not receiving it
On 2024-Jul-04, Yugo NAGATA wrote:
> On Thu, 4 Jul 2024 11:06:03 +0200
> Jelte Fennema-Nio wrote:
>
> > On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA wrote:
> > > Attached is a small patch to fix a comment on PQcancelErrorMessage.
> >
> > Oops, copy paste mistake on my part I guess. New comment
Okay, so I've pushed the last version after confirming with Alexander
that it works on the Windows x86 machine. I hope nothing breaks now in
the buildfarm.
--
Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/
On 04/07/2024 13:50, Jelte Fennema-Nio wrote:
On Thu, 4 Jul 2024 at 12:35, Heikki Linnakangas wrote:
On 04/07/2024 13:32, Heikki Linnakangas wrote:
Here's a new version of the first patch.
Sorry, forgot attachment.
It seems you undid the following earlier change. Was that on purpose?
If
On Thu, Jul 4, 2024 at 1:34 PM Hayato Kuroda (Fujitsu)
wrote:
>
> > >
> > > It succeeds if force_alter is also expressly set. Prepared transactions
> > > will be
> > > aborted at that time.
> > >
> > > ```
> > > subscriber=# ALTER SUBSCRIPTION sub SET (two_phase = off, force_alter =
> > on);
> >
Hi,
On Wed, Jul 03, 2024 at 06:47:15PM +0900, Michael Paquier wrote:
> While looking at a different patch from Tristan in this area at [1], I
> still got annoyed that this patch set was not able to support the case
> of custom fixed-numbered stats, so as it is possible to plug in
> pgstats things
I'm don't quite understand the problem we're trying to fix:
Currently the launcher's latch is used for the following: a) worker
process attach b) worker process exit and c) subscription creation.
Since this same latch is used for multiple cases, the launcher process
is not able to handle
UPD:
With the proposed changes there is no need to set NO_LOCALE to configure
the test build, so the attached patches remove this option from the
recipes.
From: Aleksei Fakeev
Sent: Tuesday, July 2, 2024 2:39 PM
To: pgsql-hack...@postgresql.org
Subject: Test_extensions installcheck fails
Greetings,
Thank you for your reply. I am aware about these conflicts, but thank you
for the explanation.
My question is specific to Postgres. Do we have a set of guidelines we keep
in mind while writing grammar rules while introducing new features to
postgres?
One such suggestion or rule for
On Thu, 4 Jul 2024 at 12:35, Heikki Linnakangas wrote:
>
> On 04/07/2024 13:32, Heikki Linnakangas wrote:
> > Here's a new version of the first patch.
>
> Sorry, forgot attachment.
It seems you undid the following earlier change. Was that on purpose?
If not, did you undo any other earlier
On Thu, 4 Jul 2024 11:06:03 +0200
Jelte Fennema-Nio wrote:
> On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA wrote:
> > Attached is a small patch to fix a comment on PQcancelErrorMessage.
>
> Oops, copy paste mistake on my part I guess. New comment LGTM
Thank you for your comments.
I made a trivial
On Thu, Jul 4, 2024, at 09:38, Joel Jacobson wrote:
> Summary of benchmark results:
>
> cpu | var1ndigits | winner
> --+-+-
..
>
Hi,
>> > Flex/Bison are only required when building from a Git tree, downloading a
>> > source archive and building from there might be easier to get started.
>> >
>> > https://www.postgresql.org/ftp/source/
>>
>> It could work but personally I wouldn't recommend this path for
>> someone
On 04/07/2024 13:32, Heikki Linnakangas wrote:
Here's a new version of the first patch.
Sorry, forgot attachment.
--
Heikki Linnakangas
Neon (https://neon.tech)
From e9fc1f4365077673c71ba138a0ae7fbcebe16a36 Mon Sep 17 00:00:00 2001
From: Heikki Linnakangas
Date: Thu, 4 Jul 2024 01:03:15
Hi,
> > We don't use top posing in this mailing list [1].
> >
> > Sorry, I only have Linux and MacOS. Here are the scripts I use [2].
> > Maybe someone who develops on Windows will answer your questions.
> > However IMO your learning curve will be less steep with a Linux
> > virtual machine.
>
>
On Wed, 26 Jun 2024 at 08:06, Peter Smith wrote:
>
> Hi Shlok. Here are my review comments for patch v10-0003
>
> ==
> General.
>
> 1.
> The patch has lots of conditions like:
> if (att->attgenerated && (att->attgenerated !=
> ATTRIBUTE_GENERATED_STORED || !include_generated_columns))
>
Here's a new version of the first patch. In the previous version, I
added the pid cancellation key to pmsignal.c, but on second thoughts, I
think procsignal.c is a better place. The ProcSignal array already
contains the pid, we just need to add the cancellation key there.
This first patch
> On 4 Jul 2024, at 12:27, Aleksander Alekseev wrote:
>
> Hi,
>
>>> Flex 2.5.4 is ancient. Version 2.5.39 was released in 2020 and I
>>> didn't look further to figure out the exact release year of 2.5.4
>>>
>>> You need something like flex 2.6.4 and bison >= 2.3. That's what I use.
>>
>> can
On Tue, 25 Jun 2024 at 18:49, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Shlok,
>
> Thanks for updating patches! Below are my comments, maybe only for 0002.
>
> 01. General
>
> IIUC, we are not discussed why ALTER SUBSCRIPTION ... SET
> include_generated_columns
> is prohibit. Previously, it seems
Hi,
>> Flex 2.5.4 is ancient. Version 2.5.39 was released in 2020 and I
>> didn't look further to figure out the exact release year of 2.5.4
>>
>> You need something like flex 2.6.4 and bison >= 2.3. That's what I use.
>
> can you send me a link to download this version on windows as I didn't
can you send me a link to download this version on windows as I didn't find
anything other than the one I already have downloaded
On Thu, Jul 4, 2024 at 1:21 PM Aleksander Alekseev
wrote:
> Hi,
>
> > While I was trying to install PostgreSQL from the git repository to
> start contributing I
Hi,
> While I was trying to install PostgreSQL from the git repository to start
> contributing I faced this issue. When I try to type ./configure it gives me
> this error
>
> checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
> checking for bison... /c/GnuWin32/bin/bison
> configure:
401 - 500 of 171528 matches
Mail list logo