Re: Peter Eisentraut 2019-02-20
<40c5c12f-adad-fc86-7d43-ff7c53535...@2ndquadrant.com>
> > By the same argument, it should always print which variant file was
> > used so determining which _N.out files are still in use is possible.
>
> I would rather not overload the test output even more. A tes
On 2019-02-15 16:05, Christoph Berg wrote:
> Re: Andrew Gierth 2019-02-15 <874l95m8w7@news-spur.riddles.org.uk>
>> Also while we're tweaking regression test output, would it be possible
>> to have some indicator of whether a test passed because a variant file
>> in the resultmap was ignored in
On 2019-01-03 12:16, Peter Eisentraut wrote:
> On 03/01/2019 10:39, Christoph Berg wrote:
>> It will especially say which _alternate.out file was used, which seems
>> like a big win. So +1.
>
> It already shows that in the existing diff output header.
>
> Although if you have a really long absolu
Re: Andrew Gierth 2019-02-15 <874l95m8w7@news-spur.riddles.org.uk>
> Also while we're tweaking regression test output, would it be possible
> to have some indicator of whether a test passed because a variant file
> in the resultmap was ignored in favor of the standard result?
>
> The current s
> "Peter" == Peter Eisentraut writes:
Peter> (This might be one of those rare times where one hopes for a
Peter> buildfarm failure for verification. :-) )
Also while we're tweaking regression test output, would it be possible
to have some indicator of whether a test passed because a varian
On 2019-01-03 11:20, Daniel Gustafsson wrote:
>> On 3 Jan 2019, at 10:39, Christoph Berg wrote:
>>
>> Re: Peter Eisentraut 2019-01-02
>> <70440c81-37bb-76dd-e48b-b5a9550d5...@2ndquadrant.com>
>
>>> While we're considering the pg_regress output, what do you think about
>>> replacing the ==...
On 03/01/2019 10:39, Christoph Berg wrote:
> It will especially say which _alternate.out file was used, which seems
> like a big win. So +1.
It already shows that in the existing diff output header.
Although if you have a really long absolute path, it might be hard to
find it. So perhaps the att
On 02/01/2019 21:44, Tom Lane wrote:
> Peter Eisentraut writes:
>> While we're considering the pg_regress output, what do you think about
>> replacing the ==... separator with a standard diff separator like
>> "diff %s %s %s\n". This would make the file behave more like a proper
>> diff file,
> On 3 Jan 2019, at 10:39, Christoph Berg wrote:
>
> Re: Peter Eisentraut 2019-01-02
> <70440c81-37bb-76dd-e48b-b5a9550d5...@2ndquadrant.com>
>> While we're considering the pg_regress output, what do you think about
>> replacing the ==... separator with a standard diff separator like
>> "di
Re: Peter Eisentraut 2019-01-02
<70440c81-37bb-76dd-e48b-b5a9550d5...@2ndquadrant.com>
> Committed.
\o/
> While we're considering the pg_regress output, what do you think about
> replacing the ==... separator with a standard diff separator like
> "diff %s %s %s\n". This would make the file
Peter Eisentraut writes:
> While we're considering the pg_regress output, what do you think about
> replacing the ==... separator with a standard diff separator like
> "diff %s %s %s\n". This would make the file behave more like a proper
> diff file, for use with other tools. And it shows th
On 22/11/2018 14:10, Christoph Berg wrote:
> It's nice that PG_REGRESS_DIFF_OPTS exists, but the diffs are often
> coming from automated build logs where setting the variable after the
> fact doesn't help.
>
> Please consider the attached patch, extension packagers will thank
> you.
Committed.
W
On Thu, Nov 22, 2018 at 02:10:59PM +0100, Christoph Berg wrote:
> Re: Noah Misch 2017-04-07 <20170407021431.gb2658...@tornado.leadboat.com>
> > > > I personally, and I know of a bunch of other regular contributors, find
> > > > context diffs very hard to read. Besides general dislike, for things
>
Re: Noah Misch 2017-04-07 <20170407021431.gb2658...@tornado.leadboat.com>
> > > I personally, and I know of a bunch of other regular contributors, find
> > > context diffs very hard to read. Besides general dislike, for things
> > > like regression test output context diffs are just not well suite
14 matches
Mail list logo
