Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows

2025-12-12 Thread Nazir Bilal Yavuz
Hi, On Thu, 11 Dec 2025 at 20:49, Andres Freund wrote: > > Hi, > > On 2025-12-11 11:45:01 -0600, Bryan Green wrote: > > On 12/11/2025 10:05 AM, Andres Freund wrote: > > > On 2025-12-11 15:43:36 +0100, Peter Eisentraut wrote: > > >> On 10.12.25 01:45, Bryan Green wrote: > > >>> The attached patch

Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows

2025-12-11 Thread Andres Freund
Hi, On 2025-12-11 11:45:01 -0600, Bryan Green wrote: > On 12/11/2025 10:05 AM, Andres Freund wrote: > > On 2025-12-11 15:43:36 +0100, Peter Eisentraut wrote: > >> On 10.12.25 01:45, Bryan Green wrote: > >>> The attached patch takes a pragmatic approach: for gettext 0.20.1+, we > >>> avoid triggeri

Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows

2025-12-11 Thread Bryan Green
On 12/11/2025 10:05 AM, Andres Freund wrote: > Hi, > > On 2025-12-11 15:43:36 +0100, Peter Eisentraut wrote: >> On 10.12.25 01:45, Bryan Green wrote: >>> The attached patch takes a pragmatic approach: for gettext 0.20.1+, we >>> avoid triggering the bug by using Windows locale format instead of >>

Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows

2025-12-11 Thread Bryan Green
On 12/11/2025 8:43 AM, Peter Eisentraut wrote: > On 10.12.25 01:45, Bryan Green wrote: >> The attached patch takes a pragmatic approach: for gettext 0.20.1+, we >> avoid triggering the bug by using Windows locale format instead of >> calling IsoLocaleName(). This works because gettext 0.20.1+ inter

Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows

2025-12-11 Thread Andres Freund
Hi, On 2025-12-11 15:43:36 +0100, Peter Eisentraut wrote: > On 10.12.25 01:45, Bryan Green wrote: > > The attached patch takes a pragmatic approach: for gettext 0.20.1+, we > > avoid triggering the bug by using Windows locale format instead of > > calling IsoLocaleName(). This works because gettex

Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows

2025-12-11 Thread Peter Eisentraut
On 10.12.25 01:45, Bryan Green wrote: The attached patch takes a pragmatic approach: for gettext 0.20.1+, we avoid triggering the bug by using Windows locale format instead of calling IsoLocaleName(). This works because gettext 0.20.1+ internally converts the Windows format back to POSIX for cata

[PATCH] Fix severe performance regression with gettext 0.20+ on Windows

2025-12-09 Thread Bryan Green
Hello hackers, I've been investigating a performance issue on Windows with recent gettext versions (0.20.1 and later) that causes exception-heavy workloads to run significantly slower than with gettext 0.19.8. Starting with gettext 0.20.1, the library changed its Windows locale handling in a way